+global\CreditNote::state()

Complexity

Conditions	14
Paths	222

Size

Total Lines	120
Code Lines	79

Duplication

Lines	48
Ratio	40 %

Code Coverage

Tests	67
CRAP Score	16.1127

Importance

Changes

0

<?php
    function state($year, $voucher_number, $voucher_date, $translation)
    {
        if (!is_object($year)) {
            throw new Exception('First parameter to state needs to be a Year object!');
            return false;

return false; does not seem to be reachable.

        }

        if (!is_object($translation)) {
            throw new Exception('4th parameter to state needs to be a translation object!');
            return false;

return false; does not seem to be reachable.

        }

        $text = $translation->get('credit note');

        $validator = new Intraface_Validator($this->error);
        if ($validator->isDate($voucher_date, "Ugyldig dato")) {
            $this_date = new Intraface_Date($voucher_date);
            $this_date->convert2db();
        }

        if ($this->error->isError()) {
            return false;
        }

        if (!$this->readyForState($year)) {
            $this->error->set('Kreditnotaen er ikke klar til bogf�ring');
            return false;
        }

        // hente alle produkterne p� debtor
        $this->loadItem();
        $items = $this->item->getList();

        require_once 'Intraface/modules/accounting/Voucher.php';
        require_once 'Intraface/modules/accounting/Account.php';
        $voucher = Voucher::factory($year, $voucher_number);

The method Voucher::factory() has been deprecated.

        $voucher->save(array(
            'voucher_number' => $voucher_number,
            'date' => $voucher_date,
            'text' => 'Kreditnota #' . $this->get('number')
        ));


        $total_with_vat = 0;
        foreach ($items as $item) {
            // produkterne
            // bem�rk at denne g�r ud fra at alt skal overf�res til debtorkontoen som standard
            $product = new Product($this->kernel, $item['product_id']);
            $debet_account = Account::factory($year, $product->get('state_account_id'));

The method Account::factory() has been deprecated.

            $debet_account_number = $debet_account->get('number');
            $credit_account = new Account($year, $year->getSetting('debtor_account_id'));
            $credit_account_number = $credit_account->get('number');
            $voucher = Voucher::factory($year, $voucher_number);

The method Voucher::factory() has been deprecated.

            $amount = $item['quantity'] * $item['price']->getAsIso(2);

            // hvis bel�bet er mindre end nul, skal konti byttes om og bel�bet skal g�res positivt
            if ($amount < 0) {
                $debet_account_number = $credit_account->get('number');
                $credit_account_number = $debet_account->get('number');
                $amount = abs($amount);
            }

            $input_values = array(
                'voucher_number' => $voucher_number,
                'reference' => $this->get('number'),
                'date' => $voucher_date,
                'amount' => number_format($amount, 2, ",", "."),
                'debet_account_number' => $debet_account_number,
                'credit_account_number' => $credit_account_number,
                'vat_off' => 1,
                'text' => $text.' #' . $this->get('number') . ' - ' . $item['name']
            );
            if ($debet_account->get('vat') == 'out') {
                $total_with_vat += $item["quantity"] * $item["price"]->getAsIso(2);
            }

            if (!$voucher->saveInDaybook($input_values, true)) {
                $voucher->error->view();
            }
        }

        // samlet moms p� fakturaen
        if ($total_with_vat != 0) {
            $voucher = Voucher::factory($year, $voucher_number);

The method Voucher::factory() has been deprecated.

            $debet_account = new Account($year, $year->getSetting('vat_out_account_id'));
            $credit_account = new Account($year, $year->getSetting('debtor_account_id'));
            $input_values = array(
                    'voucher_number' => $voucher_number,
                    'reference' => $this->get('number'),
                    'date' => $voucher_date,
                    'amount' => number_format($total_with_vat * $this->kernel->setting->get('intranet', 'vatpercent') / 100, 2, ",", "."), // opm�rksom p� at vat bliver rigtig defineret
                    'debet_account_number' => $debet_account->get('number'),
                    'credit_account_number' => $credit_account->get('number'),
                    'vat_off' => 1,
                    'text' => $text.' #' . $this->get('number') . ' - ' . $debet_account->get('name')
            );
            if (!$voucher->saveInDaybook($input_values, true)) {
                $this->error->merge($voucher->error->getMessage());
            }
        }

        require_once 'Intraface/modules/accounting/VoucherFile.php';
        $voucher_file = new VoucherFile($voucher);
        if (!$voucher_file->save(array('description' => $text.' #' . $this->get('number'), 'belong_to'=>'credit_note','belong_to_id'=>$this->get('id')))) {
            $this->error->merge($voucher_file->error->getMessage());
            $this->error->set('Filen blev ikke overflyttet');
        }

        if ($this->error->isError()) {
            $this->error->set('Der er opst�et en fejl under bogf�ringen af kreditnotaen. Det kan betyde at dele af den er bogf�rt, men ikke det hele. Du bedes manuelt tjekke bilaget');
            // I am not quite sure if the credit note should be set as stated, but it can give trouble to state it again, if some of it was stated...
            $this->setStated($voucher->get('id'), $this_date->get());

The variable $this_date does not seem to be defined for all execution paths leading up to this point.

            return false;
        }

        $this->setStated($voucher->get('id'), $this_date->get());
        $this->load();
        return true;
    }
}