Completed
Pull Request — master (#24)
by Lars
12:05
created
src/Intraface/modules/invoice/Depreciation.php 1 patch
Doc Comments   +4 added lines, -3 removed lines patch added patch discarded remove patch
@@ -39,10 +39,11 @@  discard block
 block discarded – undo
39 39
     /**
40 40
      * States the payment i the given year
41 41
      *
42
-     * @param object $year Accounting Year object
42
+     * @param Year $year Accounting Year object
43 43
      * @param integer $voucher_number
44 44
      * @param string $voucher_date
45 45
      * @param integer $state_account_number
46
+     * @param Stub_Translation $translation
46 47
      *
47 48
      * @return boolean true on succes or false.
48 49
      */
@@ -136,7 +137,7 @@  discard block
 block discarded – undo
136 137
     /**
137 138
      * returns possible payment types
138 139
      *
139
-     * @return array payment types
140
+     * @return string[] payment types
140 141
      *
141 142
      */
142 143
     public static function getTypes()
@@ -149,7 +150,7 @@  discard block
 block discarded – undo
149 150
     /**
150 151
      * returns the possible types payments can be for.
151 152
      *
152
-     * @return array payment for types
153
+     * @return string[] payment for types
153 154
      */
154 155
     private static function getPaymentForTypes()
155 156
     {
Please login to merge, or discard this patch.
src/Intraface/modules/invoice/Invoice.php 1 patch
Doc Comments   +8 added lines, -1 removed lines patch added patch discarded remove patch
@@ -17,6 +17,9 @@  discard block
 block discarded – undo
17 17
         parent::__construct($kernel, 'invoice', $id);
18 18
     }
19 19
 
20
+    /**
21
+     * @param string $status
22
+     */
20 23
     function setStatus($status)
21 24
     {
22 25
         if ($status == 'cancelled') {
@@ -58,7 +61,7 @@  discard block
 block discarded – undo
58 61
     /**
59 62
      * returns DebtorAccount object
60 63
      *
61
-     * @return object DebtorAccount
64
+     * @return DebtorAccount DebtorAccount
62 65
      */
63 66
     public function getDebtorAccount()
64 67
     {
@@ -150,6 +153,10 @@  discard block
 block discarded – undo
150 153
      * @param object year stating year
151 154
      * @param integer voucher_number
152 155
      * @param string voucher_date
156
+     * @param Year $year
157
+     * @param integer $voucher_number
158
+     * @param string $voucher_date
159
+     * @param Stub_Translation $translation
153 160
      * @return boolean true or false
154 161
      */
155 162
     function state($year, $voucher_number, $voucher_date, $translation)
Please login to merge, or discard this patch.
src/Intraface/modules/invoice/PaymentGateway.php 1 patch
Doc Comments   +5 added lines, -2 removed lines patch added patch discarded remove patch
@@ -19,6 +19,9 @@  discard block
 block discarded – undo
19 19
         $this->dbquery = $this->getDBQuery();
20 20
     }
21 21
 
22
+    /**
23
+     * @param string|null $id
24
+     */
22 25
     function findById($id)
23 26
     {
24 27
         $db = new DB_Sql;
@@ -113,7 +116,7 @@  discard block
 block discarded – undo
113 116
     /**
114 117
      * returns possible payment types
115 118
      *
116
-     * @return array payment types
119
+     * @return string[] payment types
117 120
      *
118 121
      */
119 122
     public static function getTypes()
@@ -128,7 +131,7 @@  discard block
 block discarded – undo
128 131
     /**
129 132
      * returns the possible types payments can be for.
130 133
      *
131
-     * @return array payment for types
134
+     * @return string[] payment for types
132 135
      */
133 136
     private static function getPaymentForTypes()
134 137
     {
Please login to merge, or discard this patch.
src/Intraface/modules/invoice/Reminder.php 1 patch
Doc Comments   +13 added lines, -4 removed lines patch added patch discarded remove patch
@@ -36,6 +36,9 @@  discard block
 block discarded – undo
36 36
         return $this->dbquery;
37 37
     }
38 38
 
39
+    /**
40
+     * @param string $type
41
+     */
39 42
     function getItems($type = null)
40 43
     {
41 44
         $this->loadItem();
@@ -297,7 +300,8 @@  discard block
 block discarded – undo
297 300
     /**
298 301
      * Sets status for the reminder
299 302
      *
300
-     * @return true / false
303
+     * @param string $status
304
+     * @return boolean / false
301 305
      */
302 306
     function setStatus($status)
303 307
     {
@@ -356,7 +360,7 @@  discard block
 block discarded – undo
356 360
     /**
357 361
      * returns DebtorAccount object
358 362
      *
359
-     * @return object DebtorAccount
363
+     * @return DebtorAccount DebtorAccount
360 364
      */
361 365
     public function getDebtorAccount()
362 366
     {
@@ -575,6 +579,11 @@  discard block
 block discarded – undo
575 579
      * @param object year stating year
576 580
      * @param integer voucher_number
577 581
      * @param string voucher_date
582
+     * @param Year $year
583
+     * @param integer $voucher_number
584
+     * @param string $voucher_date
585
+     * @param integer $credit_account_number
586
+     * @param Stub_Translation $translation
578 587
      * @return boolean true or false
579 588
      */
580 589
     function state($year, $voucher_number, $voucher_date, $credit_account_number, $translation)
@@ -687,7 +696,7 @@  discard block
 block discarded – undo
687 696
     /**
688 697
      * returns possible status types
689 698
      *
690
-     * @return array possible status types
699
+     * @return string[] possible status types
691 700
      */
692 701
     private static function getStatusTypes()
693 702
     {
@@ -702,7 +711,7 @@  discard block
 block discarded – undo
702 711
     /**
703 712
      * returns possible payment methods
704 713
      *
705
-     * @return array possible payment methods
714
+     * @return string[] possible payment methods
706 715
      */
707 716
     private static function getPaymentMethods()
708 717
     {
Please login to merge, or discard this patch.
src/Intraface/modules/newsletter/ListGateway.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -13,6 +13,9 @@
 block discarded – undo
13 13
         return new NewsletterList($this->kernel, $id);
14 14
     }
15 15
 
16
+    /**
17
+     * @param string $contact_id
18
+     */
16 19
     function findByContactId($contact_id)
17 20
     {
18 21
         $db = new DB_Sql;
Please login to merge, or discard this patch.
src/Intraface/modules/newsletter/NewsletterSubscriber.php 1 patch
Doc Comments   +5 added lines, -2 removed lines patch added patch discarded remove patch
@@ -176,7 +176,7 @@  discard block
 block discarded – undo
176 176
     /**
177 177
      * Adds an existing contact
178 178
      *
179
-     * @param integer $contact_id Contact id
179
+     * @param integer $contact Contact id
180 180
      *
181 181
      * @return integer of the id of the subscriber
182 182
      */
@@ -489,6 +489,9 @@  discard block
 block discarded – undo
489 489
         }
490 490
     }
491 491
 
492
+    /**
493
+     * @param Contact $contact
494
+     */
492 495
     private function getLoginUrl($contact)
493 496
     {
494 497
         if (!$link = $this->list->get('optin_link')) {
@@ -548,7 +551,7 @@  discard block
 block discarded – undo
548 551
     }
549 552
 
550 553
     /**
551
-     * @param object $observer Must implement an update() method
554
+     * @param FakeObserver $observer Must implement an update() method
552 555
      */
553 556
     public function addObserver($observer)
554 557
     {
Please login to merge, or discard this patch.
src/Intraface/modules/newsletter/Observer/OptinMail.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -18,7 +18,7 @@
 block discarded – undo
18 18
     /**
19 19
      * Constructor
20 20
      *
21
-     * @param object $list Newsletter list
21
+     * @param FakeNewsletterList $list Newsletter list
22 22
      *
23 23
      * @return void
24 24
      */
Please login to merge, or discard this patch.
src/Intraface/modules/onlinepayment/OnlinePayment.php 1 patch
Doc Comments   +10 added lines, -3 removed lines patch added patch discarded remove patch
@@ -298,6 +298,10 @@  discard block
 block discarded – undo
298 298
         return $this->id;
299 299
     }
300 300
 
301
+    /**
302
+     * @param string $belong_to
303
+     * @param integer $belong_to_id
304
+     */
301 305
     function changeBelongTo($belong_to, $belong_to_id)
302 306
     {
303 307
         if ($this->id == 0) {
@@ -321,6 +325,9 @@  discard block
 block discarded – undo
321 325
 
322 326
     }
323 327
 
328
+    /**
329
+     * @param string $status
330
+     */
324 331
     function setStatus($status)
325 332
     {
326 333
         if ($this->id == 0) {
@@ -582,7 +589,7 @@  discard block
 block discarded – undo
582 589
     /**
583 590
      * returns the possible status types
584 591
      *
585
-     * @return array with status types
592
+     * @return string[] with status types
586 593
      */
587 594
     static function getStatusTypes()
588 595
     {
@@ -598,7 +605,7 @@  discard block
 block discarded – undo
598 605
     /**
599 606
      * returns possible belong to types
600 607
      *
601
-     * @return array with belong to types
608
+     * @return string[] with belong to types
602 609
      */
603 610
     private function getBelongToTypes()
604 611
     {
@@ -611,7 +618,7 @@  discard block
 block discarded – undo
611 618
     /**
612 619
      * returns the implemented providers
613 620
      *
614
-     * @return array with providers
621
+     * @return string[] with providers
615 622
      */
616 623
     static function getImplementedProviders()
617 624
     {
Please login to merge, or discard this patch.
src/Intraface/modules/procurement/Procurement.php 1 patch
Doc Comments   +10 added lines, -2 removed lines patch added patch discarded remove patch
@@ -280,6 +280,9 @@  discard block
 block discarded – undo
280 280
         return true;
281 281
     }
282 282
 
283
+    /**
284
+     * @param string $dk_paid_date
285
+     */
283 286
     function setPaid($dk_paid_date)
284 287
     {
285 288
         if ($this->get('id') == 0) {
@@ -369,6 +372,11 @@  discard block
 block discarded – undo
369 372
      *
370 373
      * @param object year year object
371 374
      * @param integer voucher_number
375
+     * @param Year $year
376
+     * @param integer $voucher_number
377
+     * @param string $voucher_date
378
+     * @param integer $credit_account_id
379
+     * @param Stub_Translation $translation
372 380
      *
373 381
      * @return boolean
374 382
      */
@@ -685,7 +693,7 @@  discard block
 block discarded – undo
685 693
      *
686 694
      * @todo: duplicate in Procurement class
687 695
      *
688
-     * @return array status types
696
+     * @return string[] status types
689 697
      */
690 698
     private function getStatusTypes()
691 699
     {
@@ -700,7 +708,7 @@  discard block
 block discarded – undo
700 708
      * returns the possible regions where procurement is bought
701 709
      * @todo: duplicate in Procurement class
702 710
      *
703
-     * @return array possible regions
711
+     * @return string[] possible regions
704 712
      */
705 713
     public function getRegionTypes()
706 714
     {
Please login to merge, or discard this patch.