intraface / intraface.dk

src/Intraface/XMLRPC/Newsletter/Server0100.php

Spacing +2 added lines, -2 removed lines

@@ -89,7 +89,7 @@ 
 
         if (!$this->subscriber->unsubscribe($email, $comment)) {
             require_once 'XML/RPC2/Exception.php';
-            throw new XML_RPC2_FaultException('you could not unsubscribe ('. implode(', ', $this->subscriber->error->getMessage()).')', -4);
+            throw new XML_RPC2_FaultException('you could not unsubscribe ('.implode(', ', $this->subscriber->error->getMessage()).')', -4);
         }
 
         return $this->prepareResponseData(true);
@@ -208,7 +208,7 @@ 
         $code = $this->processRequestData($code);
 
         $db = MDB2::singleton(DB_DSN);
-        $result = $db->query('SELECT list_id FROM newsletter_subscriber WHERE code = ' . $db->quote($code, 'text'));
+        $result = $db->query('SELECT list_id FROM newsletter_subscriber WHERE code = '.$db->quote($code, 'text'));
         if ($row = $result->fetchRow(MDB2_FETCHMODE_ASSOC)) {
             return $this->prepareResponseData($row['list_id']);
         }

src/Intraface/Auth/PrivateKeyLogin.php

Spacing +1 added lines, -1 removed lines

@@ -48,7 +48,7 @@
      */
     public function auth()
     {
-        $result = $this->db->query("SELECT id FROM intranet WHERE private_key = " . $this->db->quote($this->key, 'text'));
+        $result = $this->db->query("SELECT id FROM intranet WHERE private_key = ".$this->db->quote($this->key, 'text'));
         if (PEAR::isError($result)) {
             throw new Exception($result->getUserInfo());
         }

src/Intraface/Auth/User.php

Spacing +6 added lines, -6 removed lines

@@ -40,7 +40,7 @@ 
         $result = $this->db->query("SELECT id FROM user WHERE email = ".$this->db->quote($this->email, 'text')." AND password = ".$this->db->quote(md5($this->password), 'text'));
 
         if (PEAR::isError($result)) {
-            throw new Exception('result is an error' . $result->getMessage() . $result->getUserInfo());
+            throw new Exception('result is an error'.$result->getMessage().$result->getUserInfo());
         }
 
         if ($result->numRows() != 1) {
@@ -48,9 +48,9 @@ 
         }
         $row = $result->fetchRow(MDB2_FETCHMODE_ASSOC);
 
-        $result = $this->db->exec("UPDATE user SET lastlogin = NOW(), session_id = ".$this->db->quote($this->session_id, 'text')." WHERE id = ". $this->db->quote($row['id'], 'integer'));
+        $result = $this->db->exec("UPDATE user SET lastlogin = NOW(), session_id = ".$this->db->quote($this->session_id, 'text')." WHERE id = ".$this->db->quote($row['id'], 'integer'));
         if (PEAR::isError($result)) {
-            throw new Exception('could not update user ' . $result->getMessage() . $result->getUserInfo());
+            throw new Exception('could not update user '.$result->getMessage().$result->getUserInfo());
         }
 
         $user = new Intraface_User($row['id']);
@@ -67,7 +67,7 @@ 
     {
         $result = $this->db->query("SELECT id FROM user WHERE session_id = ".$this->db->quote($this->session_id, 'text'));
         if (PEAR::isError($result)) {
-            throw new Exception('could not check if user is logged in ' . $result->getUserInfo());
+            throw new Exception('could not check if user is logged in '.$result->getUserInfo());
         }
 
         if ($result->numRows() == 0) {
@@ -85,10 +85,10 @@ 
      */
     public function logout()
     {
-        $result = $this->db->exec("UPDATE user SET session_id = " . $this->db->quote('', 'text') . " WHERE session_id = " . $this->db->quote($this->session_id, 'text'));
+        $result = $this->db->exec("UPDATE user SET session_id = ".$this->db->quote('', 'text')." WHERE session_id = ".$this->db->quote($this->session_id, 'text'));
 
         if (PEAR::isError($result)) {
-             throw new Exception('could not log user out ' . $result->getUserInfo());
+             throw new Exception('could not log user out '.$result->getUserInfo());
         }
         return true;
     }

Indentation +1 added lines, -1 removed lines

@@ -88,7 +88,7 @@
         $result = $this->db->exec("UPDATE user SET session_id = " . $this->db->quote('', 'text') . " WHERE session_id = " . $this->db->quote($this->session_id, 'text'));
 
         if (PEAR::isError($result)) {
-             throw new Exception('could not log user out ' . $result->getUserInfo());
+                throw new Exception('could not log user out ' . $result->getUserInfo());
         }
         return true;
     }

src/Intraface/Address.php

Indentation +5 added lines, -5 removed lines

@@ -99,11 +99,11 @@
     public static function getBelongToTypes()
     {
         return array(1 => 'intranet',
-                     2 => 'user',
-                     3 => 'contact',
-                     4 => 'contact_delivery',
-                     5 => 'contact_invoice',
-                     6 => 'contactperson');
+                        2 => 'user',
+                        3 => 'contact',
+                        4 => 'contact_delivery',
+                        5 => 'contact_invoice',
+                        6 => 'contactperson');
     }
 
     /**

Doc Comments +3 added lines, -3 removed lines

@@ -83,7 +83,7 @@ 
      * @param string  $belong_to    What the address belongs to, corresponding to the ones in Address::getBelongToTypes()
      * @param integer $belong_to_id From belong_to. NB not id on the address
      *
-     * @return object Address
+     * @return Intraface_Address Address
      */
     function factory($belong_to, $belong_to_id)
     {
@@ -94,7 +94,7 @@ 
     /**
      * Returns possible belong to types
      *
-     * @return array
+     * @return string[]
      */
     public static function getBelongToTypes()
     {
@@ -220,7 +220,7 @@ 
      *
      * @param array $array_var et array med felter med adressen. Se felterne i init funktionen: $this->fields
      *
-     * @return bolean   true or false
+     * @return boolean   true or false
      */
     function save($array_var)
     {

src/Intraface/Fileimport/Controller/Index.php

Spacing +2 added lines, -2 removed lines

@@ -36,7 +36,7 @@ 
             'fileimport' => $this->fileimport
         );
 
-        $tpl = $this->template->create(dirname(__FILE__) . '/templates/index');
+        $tpl = $this->template->create(dirname(__FILE__).'/templates/index');
         return $tpl->render($this, $data);
     }
 
@@ -100,7 +100,7 @@ 
                     $_SESSION['shared_fileimport_data'] = $data;
                     $this->session()->set('fileimport_data', $data);
 
-                    return new k_SeeOther($this->url('../', array('header' => $this->body('header'),'file_id' => $this->filehandler->get('id'), 'fields' => $this->body('fields'))));
+                    return new k_SeeOther($this->url('../', array('header' => $this->body('header'), 'file_id' => $this->filehandler->get('id'), 'fields' => $this->body('fields'))));
 
                     /*
 

src/Intraface/Kernel.php

Spacing +1 added lines, -1 removed lines

@@ -41,7 +41,7 @@
         }
         $this->db = MDB2:: singleton(DB_DSN);
         if (PEAR::isError($this->db)) {
-            throw new Exception($this->db->getMessage() . $this->db->getUserInfo());
+            throw new Exception($this->db->getMessage().$this->db->getUserInfo());
         }
     }
 

Doc Comments +2 added lines, -2 removed lines

@@ -80,7 +80,7 @@ 
      *
      * Used for instance in Page to give the correct submenu.
      *
-     * @return module object or false
+     * @return boolean object or false
      */
     function getPrimaryModule()
     {
@@ -167,7 +167,7 @@ 
      *
      * @param $count (integer) how many characters to return?
      *
-     * @return  random key (string) only letters
+     * @return  string key (string) only letters
      */
     function randomKey($length = 1)
     {

src/Intraface/Doctrine/Template/Listener/Intranet.php

Spacing +5 added lines, -5 removed lines

@@ -8,16 +8,16 @@ 
         $invoker = $event->getInvoker();
         $class   = get_class($invoker);
 
-        $field = $params['alias'] . '.intranet_id';
+        $field = $params['alias'].'.intranet_id';
         $query = $event->getQuery();
 
         // if it is not the class from FROM statement, it is left or inner join.
         // then we add the possibility for IS NULL. Actually it is only relevant in
         // left join, but how do we find out which kind of join it is?
         if ($query->contains('FROM '.$class)) {
-            $query->addWhere($field . '  = ?', array($this->getIntranetId()));
+            $query->addWhere($field.'  = ?', array($this->getIntranetId()));
         } else {
-            $query->addWhere('('.$field.' IS NULL OR '.$field . '  = ?)', array($this->getIntranetId()));
+            $query->addWhere('('.$field.' IS NULL OR '.$field.'  = ?)', array($this->getIntranetId()));
         }
     }
 
@@ -36,9 +36,9 @@ 
     public function preDqlDelete(Doctrine_Event $event)
     {
         $params = $event->getParams();
-        $field = $params['alias'] . '.intranet_id';
+        $field = $params['alias'].'.intranet_id';
         $query = $event->getQuery();
-        $query->addWhere($field . ' = ?', array($this->getIntranetId()));
+        $query->addWhere($field.' = ?', array($this->getIntranetId()));
     }
 
     private function getIntranetId()

src/Intraface/shared/email/EmailGateway.php

Spacing +6 added lines, -6 removed lines

@@ -56,14 +56,14 @@ 
     function findCountByContactId($contact_id)
     {
         $db = new DB_Sql;
-        $db->query('SELECT * FROM email WHERE contact_id = ' . $contact_id);
+        $db->query('SELECT * FROM email WHERE contact_id = '.$contact_id);
         return $db->numRows();
     }
 
     function setNewContactId($old_contact_id, $new_contact_id)
     {
         $db = new DB_Sql;
-        $db->query('UPDATE email SET contact_id = ' . $new_contact_id . ' WHERE contact_id = ' . $old_contact_id);
+        $db->query('UPDATE email SET contact_id = '.$new_contact_id.' WHERE contact_id = '.$old_contact_id);
         return true;
     }
 
@@ -78,7 +78,7 @@ 
     function countQueue()
     {
         $db = new DB_Sql;
-        $db->query("SELECT COUNT(*) AS antal FROM email WHERE status = 2 AND intranet_id = " . $this->kernel->intranet->get('id'));
+        $db->query("SELECT COUNT(*) AS antal FROM email WHERE status = 2 AND intranet_id = ".$this->kernel->intranet->get('id'));
         $this->value['outbox'] = 0;
         if ($db->nextRecord()) {
             $this->value['outbox'] = $db->f('antal');
@@ -99,7 +99,7 @@ 
             $list[$i]['status'] = $this->status[$db->f('status')];
 
             if ($db->f('contact_id') == 0) {
-                $this->error->set('Kan ikke finde #' . $db->f('id') . ' fordi den ikke har noget kontakt_id');
+                $this->error->set('Kan ikke finde #'.$db->f('id').' fordi den ikke har noget kontakt_id');
                 continue;
             }
             $this->kernel->useModule('contact');
@@ -133,13 +133,13 @@ 
     {
         $sent_this_hour = $this->sentThisHour();
 
-        $limit_query = abs($this->allowed_limit-$sent_this_hour-$this->system_buffer);
+        $limit_query = abs($this->allowed_limit - $sent_this_hour - $this->system_buffer);
 
         $sql = "SELECT id
                 FROM email
                 WHERE status = 2
                     AND date_deadline <= NOW()
-                    AND intranet_id = " . $this->kernel->intranet->get('id') . "
+                    AND intranet_id = " . $this->kernel->intranet->get('id')."
                     AND contact_id > 0
                 LIMIT " . $limit_query;
         $db = new DB_Sql;

src/Intraface/ModuleGateway.php

Spacing +1 added lines, -1 removed lines

@@ -16,7 +16,7 @@
 
     public function __construct(MDB2_Driver_Common $db)
     {
-        $this->db =  $db;
+        $this->db = $db;
         $this->error = new Intraface_Error;
     }