UserPreferences::postForm() - Code Metrics - Inspection of "Composer update" - intraface/intraface.dk - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#27)

by Lars

created 2017-03-19 18:07 UTC

UserPreferences::postForm() C

↳ Parent: UserPreferences

Complexity

Conditions	8
Paths	32

Size

Total Lines	52
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	72

Importance

Changes

Metric	Value
cc	8
eloc	13
nc	32
nop	0
dl	0
loc	52
ccs	0
cts	19
cp	0
crap	72
rs	6.8493
c	0
b	0
f	0

How to fix Long Method

<?php
class Intraface_modules_controlpanel_Controller_UserPreferences extends k_Component
{
    protected $error;
    protected $template;

    function __construct(k_TemplateFactory $template)
    {
        $this->template = $template;
    }

    protected function map($name)
    {
        if ($name == 'intranet') {
            return 'Intraface_modules_intranetmaintenance_Controller_Intranet_Index';
        } elseif ($name == 'user') {
            return 'Intraface_modules_intranetmaintenance_Controller_User_Index';
        } elseif ($name == 'preferences') {
            return 'Intraface_modules_controlpanel_Controller_UserPreferences';
        }
    }

    function getValues()
    {
        /*

        $value['rows_pr_page'] = $this->getKernel()->setting->get('user', 'rows_pr_page');
        $value['theme'] = $this->getKernel()->setting->get('user', 'theme');
        $value['ptextsize'] = $this->getKernel()->setting->get('user', 'ptextsize');
        */
        $value['label'] = $this->getKernel()->setting->get('user', 'label');
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        $value['language'] = $this->getKernel()->setting->get('user', 'language');
        //$value['htmleditor'] = $this->getKernel()->setting->get('user', 'htmleditor');

        return $value;
    }

    function renderHtml()
    {
        $smarty = $this->template->create(dirname(__FILE__) . '/templates/userpreferences');
        return $smarty->render($this);
    }

    function postForm()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        /*

        if (!$this->getKernel()->setting->set('user', 'rows_pr_page', $_POST['rows_pr_page'])) {
            $error[] = 'rows_pr_page';
        }
        if (!$this->getKernel()->setting->set('user', 'theme', $_POST['theme'])) {
            $error[] = 'theme';
        }
        if (!$this->getKernel()->setting->set('user', 'ptextsize', $_POST['ptextsize'])) {
            $error[] = 'theme';
        }
        */


        if (isset($_POST['label']) and !isset($labels_standard[$_POST['label']])) {
// Logical operators have lower precedence:
$f = false or true;

// is executed like this:
($f = false) or true;


// Boolean operators have higher precedence:
$f = false || true;

// is executed like this:
$f = (false || true);
            $this->getError()->set('error in label - not allowed');
        }

        if (!$this->getKernel()->setting->set('user', 'label', $_POST['label'])) {
            $this->getError()->set('error in label');
        }

        if (!empty($_POST['language']) and !array_key_exists($_POST['language'], $this->getKernel()->getTranslation()->getLangs())) {
// Logical operators have lower precedence:
$f = false or true;

// is executed like this:
($f = false) or true;


// Boolean operators have higher precedence:
$f = false || true;

// is executed like this:
$f = (false || true);
            $this->getError()->set('error in language - not allowed');
        }

        if (!$this->getKernel()->setting->set('user', 'language', $_POST['language'])) {
            $this->getError()->set('error in language');
        }

        /*

        if ($this->getKernel()->user->hasModuleAccess('cms')) {
            $validator = new Intraface_Validator($error);
            $validator->isString($_POST['htmleditor'], 'error in htmleditor not a string', '');

            if (!array_key_exists($_POST['htmleditor'], $editors)) {
                $error->set('error in htmleditor not allowed');
            }
            if (!$this->getKernel()->setting->set('user', 'htmleditor', $_POST['htmleditor'])) {
                $error->set('error in htmleditor not saved');
            }
        }
        */

        if (!$this->getError()->isError()) {
            return new k_SeeOther($this->url('../'));
        }
        $value = $_POST;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        return $this->render();
    }

    function getLabelStandards()
    {
        return $labels_standard = array(
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            0 => '3x7',
            1 => '2x8'
        );
    }

    function getError()
    {
        if (is_object($this->error)) {
            return $this->error;
        }
        return ($this->error = new Intraface_Error());
    }

    function getKernel()
    {
        return $this->context->getKernel();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
    }

    function getModules()
    {
        return $this->getKernel()->getModules();
    }
}


Pull Request — master (#27)

UserPreferences::postForm() C

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method

Long Method

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

Available Fixes

intraface / intraface.dk

Pull Request — master (#27)

UserPreferences::postForm() C

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method

Long Method

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

Available Fixes

Duplication Side-by-Side

Filter issues like