intraface / intraface.dk

src/Intraface/modules/debtor/DebtorItem.php

Doc Comments +2 added lines, -2 removed lines

@@ -240,7 +240,7 @@ 
     /**
      * Gets the tax percent on the individual product
      *
-     * @return float
+     * @return integer
      */
     public function getTaxPercent()
     {
@@ -570,7 +570,7 @@ 
     /**
      * Returns position object
      *
-     * @return object Ilib_Position
+     * @return Ilib_Position Ilib_Position
      */
     function getPosition($db)
     {

Indentation +3 added lines, -3 removed lines

@@ -282,7 +282,7 @@ 
             $product = new Product($this->debtor->kernel, $input["product_id"], $input['product_detail_id']);
 
             if (!is_object($product) || $product->get('id') == 0) {
-                 $this->error->set("Ugyldigt produkt");
+                    $this->error->set("Ugyldigt produkt");
             } else {
                 $product_detail_id = $product->get("detail_id");
             }
@@ -374,7 +374,7 @@ 
         $product = new Product($this->debtor->kernel, $product_id);
 
         if (!is_object($product) || $product->get('id') == 0) {
-             throw new Excetion('Invalid product id');
+                throw new Excetion('Invalid product id');
         } else {
             $product_detail_id = $product->get("detail_id");
         }
@@ -501,7 +501,7 @@ 
                     $i++;
                 }
             } else {
-                 throw new Exception("Ugyldig produktdetalje i DebtorItem->getList() on ".$db->f('product_id').'/'.$db->f('product_detail_id'));
+                    throw new Exception("Ugyldig produktdetalje i DebtorItem->getList() on ".$db->f('product_id').'/'.$db->f('product_detail_id'));
             }
         }
         unset($db);

Spacing +8 added lines, -8 removed lines

@@ -224,7 +224,7 @@ 
         // TODO how do we handle vat? this should return raw prices
         // and then the tax percent should return the tax to apply
         // the calculator should handle the final price
-        return $this->getProductPrice() * $this->get('quantity');
+        return $this->getProductPrice()*$this->get('quantity');
     }
 
     /**
@@ -234,7 +234,7 @@ 
      */
     public function getWeight()
     {
-        return $this->getProductWeight() * $this->get('quantity');
+        return $this->getProductWeight()*$this->get('quantity');
     }
 
     /**
@@ -471,14 +471,14 @@ 
                     $variation = $product->getVariation($db->f('product_variation_id'));
                     $detail = $variation->getDetail($db->f('product_variation_detail_id'));
                     $item["name"] = $product->get("name").' - '.$variation->getName();
-                    $item["number"]= $product->get("number").'.'.$variation->getNumber();
+                    $item["number"] = $product->get("number").'.'.$variation->getNumber();
                     $item["price"] = $detail->getPrice($product);
                     if ($currency) {
                         $item['price_currency'] = $detail->getPriceInCurrency($currency, $this->debtor->get('currency_product_price_exchange_rate_id'), $product);
                     }
                 } else {
                     $item["name"] = $product->get("name");
-                    $item["number"]= $product->get("number");
+                    $item["number"] = $product->get("number");
                     $item["price"] = $product->getDetails()->getPrice();
                     if ($currency) {
                         $item['price_currency'] = $product->getDetails()->getPriceInCurrency($currency, $this->debtor->get('currency_product_price_exchange_rate_id'));
@@ -487,16 +487,16 @@ 
 
                 if ($product->get("vat") == 0) {
                     $item_no_vat[$j] = $item;
-                    $item_no_vat[$j]["amount"] = new Ilib_Variable_Float($item["quantity"] * $item["price"]->getAsIso(2));
+                    $item_no_vat[$j]["amount"] = new Ilib_Variable_Float($item["quantity"]*$item["price"]->getAsIso(2));
                     if ($currency) {
-                        $item_no_vat[$j]["amount_currency"] = new Ilib_Variable_Float($item["quantity"] * $item["price_currency"]->getAsIso(2), 'iso');
+                        $item_no_vat[$j]["amount_currency"] = new Ilib_Variable_Float($item["quantity"]*$item["price_currency"]->getAsIso(2), 'iso');
                     }
                     $j++;
                 } else {
                     $item_with_vat[$i] = $item;
-                    $item_with_vat[$i]["amount"] = new Ilib_Variable_Float($item["quantity"] * $item["price"]->getAsIso(2) * 1.25);
+                    $item_with_vat[$i]["amount"] = new Ilib_Variable_Float($item["quantity"]*$item["price"]->getAsIso(2)*1.25);
                     if ($currency) {
-                        $item_with_vat[$i]["amount_currency"] = new Ilib_Variable_Float($item["quantity"] * $item["price_currency"]->getAsIso(2) * 1.25, 'iso');
+                        $item_with_vat[$i]["amount_currency"] = new Ilib_Variable_Float($item["quantity"]*$item["price_currency"]->getAsIso(2)*1.25, 'iso');
                     }
                     $i++;
                 }

src/Intraface/modules/filemanager/AppendFile.php

Doc Comments +3 added lines, -2 removed lines

@@ -26,7 +26,7 @@ 
      * @param string  $belong_to    Which type the file belongs to
      * @param integer $belong_to_id The id this appended file belongs to
      *
-     * @return void
+     * @return integer
      */
     public function __construct($kernel, $belong_to, $belong_to_id)
     {
@@ -157,7 +157,7 @@ 
     /**
      * Adds an array with files
      *
-     * @param array $files An array with files
+     * @param FakeAppendFileFile[] $files An array with files
      *
      * @return boolean
      */
@@ -188,6 +188,7 @@ 
     /**
      * Undelete
      *
+     * @param integer $id
      * @return boolean
      */
     public function undelete($id)

Spacing +2 added lines, -2 removed lines

@@ -99,7 +99,7 @@ 
         if ($this->dbquery) {
             return $this->dbquery;
         }
-        $this->dbquery = new Ilib_DBQuery('filehandler_append_file', 'filehandler_append_file.active = 1 AND filehandler_append_file.intranet_id='.$this->kernel->intranet->get('id').' AND filehandler_append_file.belong_to_key = '.$this->belong_to_key.' AND filehandler_append_file.belong_to_id = ' . $this->belong_to_id);
+        $this->dbquery = new Ilib_DBQuery('filehandler_append_file', 'filehandler_append_file.active = 1 AND filehandler_append_file.intranet_id='.$this->kernel->intranet->get('id').' AND filehandler_append_file.belong_to_key = '.$this->belong_to_key.' AND filehandler_append_file.belong_to_id = '.$this->belong_to_id);
         $this->dbquery->createStore($this->kernel->getSessionId(), 'intranet_id = '.intval($this->kernel->intranet->get('id')));
         return $this->dbquery;
     }
@@ -115,7 +115,7 @@ 
     {
         $db = new DB_Sql();
         $db->query("SELECT id FROM filehandler_append_file
-            WHERE intranet_id = " . $this->kernel->intranet->get('id') . "
+            WHERE intranet_id = " . $this->kernel->intranet->get('id')."
                 AND belong_to_key = ".$this->belong_to_key."
                 AND belong_to_id = ".$this->belong_to_id."
                 AND file_handler_id = ".$file_id."

src/Intraface/modules/filemanager/FileHandler.php

Doc Comments +4 added lines, -4 removed lines

@@ -198,7 +198,7 @@ 
     /**
      * Creates a filehandler
      *
-     * @param object $kernel     Kernel object
+     * @param Stub_Kernel $kernel     Kernel object
      * @param string $access_key The accesskey
      *
      * @return object
@@ -359,7 +359,8 @@ 
      * creates and temporary file handler
      *
      * @param string optional file name
-     * @return object temporary file
+     * @param string $file_name
+     * @return TemporaryFile temporary file
      */
     public function createTemporaryFile($file_name = null)
     {
@@ -689,8 +690,7 @@ 
     /**
      * Returns RandomKeyGenerator
      *
-     * @param integer $length the length of the random key
-     * @return object RandomKeyGenerator
+     * @return Ilib_RandomKeyGenerator RandomKeyGenerator
      */
     private function getRandomKeyGenerator()
     {

src/Intraface/modules/filemanager/FileManager.php

Doc Comments +1 added lines, -1 removed lines

@@ -50,7 +50,7 @@
     /**
      * Creates the keywords object
      *
-     * @return object
+     * @return Keyword
      */
     public function getKeywords()
     {

src/Intraface/modules/filemanager/ImageHandler.php

Doc Comments +3 added lines, -3 removed lines

@@ -28,7 +28,7 @@ 
     /**
      * Constructor
      *
-     * @param object $file_handler
+     * @param FileHandler $file_handler
      *
      * @return void
      */
@@ -141,8 +141,8 @@ 
      *
      * @param float  $width  Width
      * @param float  $height Height
-     * @param float $offset_x offset x
-     * @param float $offset_y offset y
+     * @param integer $offset_x offset x
+     * @param integer $offset_y offset y
      *
      * @return string new file name
      */

Indentation +8 added lines, -8 removed lines

@@ -1,12 +1,12 @@
 <?php
- /**
-  * Image handler. Klarer h�ndtering af billeder.
-  *
-  * @package Intraface
-  * @author: Sune
-  * @version: 1.0
-  *
-  */
+    /**
+     * Image handler. Klarer h�ndtering af billeder.
+     *
+     * @package Intraface
+     * @author: Sune
+     * @version: 1.0
+     *
+     */
 
 class ImageHandler extends Intraface_Standard
 {

Spacing +4 added lines, -4 removed lines

@@ -54,7 +54,7 @@ 
         $this->image_library = IMAGE_LIBRARY;
 
         if ($this->file_handler->get('is_image') != 1) {
-            throw new Exception("Filtypen " . $file_handler->get('mime_type') . " er ikke et billede, og kan derfor ikke manipuleres i ImageHandler");
+            throw new Exception("Filtypen ".$file_handler->get('mime_type')." er ikke et billede, og kan derfor ikke manipuleres i ImageHandler");
         }
 
         $this->tempdir_path = $this->file_handler->getTemporaryDirectory();
@@ -80,7 +80,7 @@ 
 
         $image = Image_Transform::factory($this->image_library);
         if (PEAR::isError($image)) {
-            throw new Exception($image->getMessage() . $image->getUserInfo());
+            throw new Exception($image->getMessage().$image->getUserInfo());
         }
 
         if ($this->tmp_file_name != null && file_exists($this->tmp_file_name)) {
@@ -150,7 +150,7 @@ 
     {
         $image = Image_Transform::factory($this->image_library);
         if (PEAR::isError($image)) {
-            throw new Exception($image->getMessage() . $image->getUserInfo());
+            throw new Exception($image->getMessage().$image->getUserInfo());
         }
 
         if ($this->tmp_file_name != null && file_exists($this->tmp_file_name)) {
@@ -168,7 +168,7 @@ 
         $result = $image->crop($width, $height, $offset_x, $offset_y);
 
         if (PEAR::isError($result)) {
-            throw new Exception("Der opstod en fejl under formatering (crop) af billedet i ImageHandler->crop: " . $result->getMessage());
+            throw new Exception("Der opstod en fejl under formatering (crop) af billedet i ImageHandler->crop: ".$result->getMessage());
         }
 
         $file_type = $this->file_handler->get('file_type');

src/Intraface/modules/filemanager/InstanceHandler.php

Doc Comments +4 added lines, -4 removed lines

@@ -34,7 +34,7 @@ 
      * @param object  $file_handler File handler object
      * @param integer $id           Optional id
      *
-     * @return void
+     * @return string
      */
     function __construct($file_handler, $id = 0)
     {
@@ -65,11 +65,11 @@ 
     /**
      * Factory
      *
-     * @param object $file_handler File handler
-     * @param string $type         the instance type
+     * @param FileHandler $file_handler File handler
      * @param array  $param        one or more of crop_width, crop_height, crop_offset_x, crop_offset_y
+     * @param string $type_name
      *
-     * @return object
+     * @return InstanceHandler
      */
     function factory($file_handler, $type_name, $param = array())
     {

Spacing +2 added lines, -2 removed lines

@@ -123,7 +123,7 @@ 
                 type_key = ".$type['type_key'].",
                 file_size = ".(int)$file_size.",
                 width = ".(int)$width.",
-                height = ".(int)$height.", " .
+                height = ".(int)$height.", ".
                 "crop_parameter = \"".safeToDb($crop_param_string)."\"");
 
             $id = $db->insertedId();
@@ -187,7 +187,7 @@ 
         //$this->value['predefined_size'] = $db->f('predefined_size');
         $this->value['server_file_name'] = $db->f('server_file_name');
         $this->value['file_size'] = $db->f('file_size');
-        $this->value['file_path'] = $this->instance_path . $db->f('server_file_name');
+        $this->value['file_path'] = $this->instance_path.$db->f('server_file_name');
 
         $this->value['last_modified'] = filemtime($this->get('file_path'));
         // $this->value['file_uri'] = FILE_VIEWER.'?id='.$this->get('id').'&type='.$this->get('type').'&name=/'.urlencode($this->file_handler->get('file_name'));

src/Intraface/modules/filemanager/UploadHandler.php

Doc Comments +1 added lines, -1 removed lines

@@ -70,7 +70,7 @@
      *       then the filehandler->save method should rather accept some kind of file object which this
      *       object could generate?
      *
-     * @param object $file_handler A filehandler
+     * @param FileHandler $file_handler A filehandler
      *
      * @return void
      */

Spacing +1 added lines, -1 removed lines

@@ -288,7 +288,7 @@
                     continue;
                 }
 
-                $ext = substr($file, strrpos($file, ".")+1);
+                $ext = substr($file, strrpos($file, ".") + 1);
 
                 if (strlen($ext) < 3 || strlen($ext) > 4) {
                     $this->file_handler->error->set("Filen \"".$file."\" har ikke en gyldig endelse, f.eks. .pdf");

src/Intraface/modules/intranetmaintenance/ModuleMaintenance.php

Doc Comments +3 added lines

@@ -85,6 +85,9 @@
         }
     }
 
+    /**
+     * @param string $module_name
+     */
     public function registerModule($module_name)
     {
         $gateway = new Intraface_ModuleGateway(MDB2::singleton(DB_DSN));

src/Intraface/modules/intranetmaintenance/UserMaintenance.php

Doc Comments +1 added lines, -1 removed lines

@@ -95,7 +95,7 @@
      *
      * @param string $action Which action to perform?
      *
-     * @return void
+     * @return boolean
      */
     function transactionAction($action)
     {