Completed
Pull Request — master (#26)
by Lars
14:13
created
src/Intraface/modules/webshop/Webshop.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -186,14 +186,14 @@  discard block
 block discarded – undo
186 186
             if ($value['message'] != '') {
187 187
                 $value['message'] .= "\n\n";
188 188
             }
189
-            $value['message'] .= "Kundekupon:". $input['customer_coupon'];
189
+            $value['message'] .= "Kundekupon:".$input['customer_coupon'];
190 190
         }
191 191
 
192 192
         if (isset($input['customer_comment']) && $input['customer_comment'] != '') {
193 193
             if ($value['message'] != '') {
194 194
                 $value['message'] .= "\n\n";
195 195
             }
196
-            $value['message'] .= "Kommentar:\n". $input['customer_comment'];
196
+            $value['message'] .= "Kommentar:\n".$input['customer_comment'];
197 197
         }
198 198
 
199 199
 
@@ -301,8 +301,8 @@  discard block
 block discarded – undo
301 301
         $email = new Email($this->kernel);
302 302
 
303 303
         if (!$email->save(array('contact_id' => $this->contact->get('id'),
304
-                                'subject' => 'Bekræftelse på bestilling #' . $order_id,
305
-                                'body' => $this->kernel->setting->get('intranet', 'webshop.confirmation_text') . "\n" . $this->contact->getLoginUrl() . "\n\nVenlig hilsen\n" . $this->kernel->intranet->address->get('name'),
304
+                                'subject' => 'Bekræftelse på bestilling #'.$order_id,
305
+                                'body' => $this->kernel->setting->get('intranet', 'webshop.confirmation_text')."\n".$this->contact->getLoginUrl()."\n\nVenlig hilsen\n".$this->kernel->intranet->address->get('name'),
306 306
                                 'from_email' => $this->kernel->intranet->address->get('email'),
307 307
                                 'from_name' => $this->kernel->intranet->address->get('name'),
308 308
                                 'type_id' => 12, // webshop
Please login to merge, or discard this patch.
src/Intraface/modules/webshop/BasketEvaluation.php 1 patch
Spacing   +16 added lines, -16 removed lines patch added patch discarded remove patch
@@ -55,7 +55,7 @@  discard block
 block discarded – undo
55 55
             die($this->db->getMessage());
56 56
         }
57 57
 
58
-        $this->value['settings'] = array (
58
+        $this->value['settings'] = array(
59 59
             'evaluate_target' => array(
60 60
                 0 => 'price',
61 61
                 1 => 'weight',
@@ -94,7 +94,7 @@  discard block
 block discarded – undo
94 94
         $result = $this->db->query("SELECT * FROM webshop_basket_evaluation WHERE active = 1 AND intranet_id = ".$this->db->quote($this->kernel->intranet->get('id'), 'integer')." AND id = ".$this->db->quote($this->id, 'integer'));
95 95
 
96 96
         if (PEAR::isError($result)) {
97
-            throw new Exception($result->getMessage() . $result->getUserInfo());
97
+            throw new Exception($result->getMessage().$result->getUserInfo());
98 98
         }
99 99
 
100 100
         if ($result->numRows() == 0) {
@@ -152,35 +152,35 @@  discard block
 block discarded – undo
152 152
             return false;
153 153
         }
154 154
 
155
-        $sql = "running_index = ".$this->db->quote($input['running_index'], 'integer').", " .
156
-                 "evaluate_target_key = ".$this->db->quote($input['evaluate_target_key'], 'integer').", " .
157
-                 "evaluate_method_key = ".$this->db->quote($input['evaluate_method_key'], 'integer').", " .
158
-                 "evaluate_value = ".$this->db->quote($input['evaluate_value'], 'text').", " .
159
-                 "evaluate_value_case_sensitive = ".$this->db->quote($input['evaluate_value_case_sensitive'], 'integer').", " .
160
-                 "go_to_index_after = ".$this->db->quote($input['go_to_index_after'], 'integer').", " .
161
-                 "action_action_key = ".$this->db->quote($input['action_action_key'], 'integer').", " .
162
-                 "action_value = ".$this->db->quote($input['action_value'], 'text').", " .
163
-                 "action_quantity = ".$this->db->quote($input['action_quantity'], 'integer').", " .
155
+        $sql = "running_index = ".$this->db->quote($input['running_index'], 'integer').", ".
156
+                 "evaluate_target_key = ".$this->db->quote($input['evaluate_target_key'], 'integer').", ".
157
+                 "evaluate_method_key = ".$this->db->quote($input['evaluate_method_key'], 'integer').", ".
158
+                 "evaluate_value = ".$this->db->quote($input['evaluate_value'], 'text').", ".
159
+                 "evaluate_value_case_sensitive = ".$this->db->quote($input['evaluate_value_case_sensitive'], 'integer').", ".
160
+                 "go_to_index_after = ".$this->db->quote($input['go_to_index_after'], 'integer').", ".
161
+                 "action_action_key = ".$this->db->quote($input['action_action_key'], 'integer').", ".
162
+                 "action_value = ".$this->db->quote($input['action_value'], 'text').", ".
163
+                 "action_quantity = ".$this->db->quote($input['action_quantity'], 'integer').", ".
164 164
                  "action_unit_key = ".$this->db->quote($input['action_unit_key'], 'integer');
165 165
 
166 166
         if ($this->id != 0) {
167 167
             $result = $this->db->exec("UPDATE webshop_basket_evaluation SET ".$sql." WHERE intranet_id = ".$this->kernel->intranet->get('id')." AND id = ".$this->id);
168 168
 
169 169
             if (PEAR::isError($result)) {
170
-                throw new Exception($result->getMessage() . $result->getUserInfo());
170
+                throw new Exception($result->getMessage().$result->getUserInfo());
171 171
                 return false;
172 172
             }
173 173
         } else {
174 174
             $result = $this->db->query("INSERT INTO webshop_basket_evaluation SET ".$sql.", intranet_id = ".$this->kernel->intranet->get('id').", id = ".$this->id);
175 175
 
176 176
             if (PEAR::isError($result)) {
177
-                throw new Exception($result->getMessage() . $result->getUserInfo());
177
+                throw new Exception($result->getMessage().$result->getUserInfo());
178 178
                 return false;
179 179
             }
180 180
 
181 181
             $this->id = $this->db->lastInsertID();
182 182
             if (PEAR::isError($this->id)) {
183
-                throw new Exception($result->getMessage() . $result->getUserInfo());
183
+                throw new Exception($result->getMessage().$result->getUserInfo());
184 184
             }
185 185
         }
186 186
 
@@ -196,7 +196,7 @@  discard block
 block discarded – undo
196 196
     {
197 197
         $result = $this->db->exec("UPDATE webshop_basket_evaluation SET active = 0 WHERE intranet_id = ".$this->kernel->intranet->get('id')." AND id = ".$this->id);
198 198
         if (PEAR::isError($result)) {
199
-            throw new Exception($result->getMessage() . $result->getUserInfo());
199
+            throw new Exception($result->getMessage().$result->getUserInfo());
200 200
             return false;
201 201
         }
202 202
         return true;
@@ -212,7 +212,7 @@  discard block
 block discarded – undo
212 212
         $result = $this->db->query("SELECT * FROM webshop_basket_evaluation WHERE active = 1 AND intranet_id = ".$this->kernel->intranet->get('id').' ORDER BY running_index');
213 213
 
214 214
         if (PEAR::isError($this->id)) {
215
-            throw new Exception($result->getMessage() . $result->getUserInfo());
215
+            throw new Exception($result->getMessage().$result->getUserInfo());
216 216
         }
217 217
 
218 218
         $i = 0;
Please login to merge, or discard this patch.
src/Intraface/modules/order/include_front.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -16,7 +16,7 @@
 block discarded – undo
16 16
         );
17 17
     } else {
18 18
         $db = new DB_Sql;
19
-        $db->query("SELECT * FROM debtor WHERE type = 2 AND status = 0 AND active = 1 AND intranet_id = " . $kernel->intranet->get('id'));
19
+        $db->query("SELECT * FROM debtor WHERE type = 2 AND status = 0 AND active = 1 AND intranet_id = ".$kernel->intranet->get('id'));
20 20
         $orders = $db->numRows();
21 21
         if ($orders > 0) {
22 22
             $_attention_needed[] = array(
Please login to merge, or discard this patch.
src/Intraface/modules/currency/Controller/tpl/add.tpl.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -8,7 +8,7 @@
 block discarded – undo
8 8
                 <?php if (!empty($data['selected_type_iso_code']) and $type->getIsoCode() == $data['selected_type_iso_code']) {
9 9
                     echo ' selected="selected"';
10 10
 } ?>
11
-                ><?php e($type->getIsoCode() . ' ' . $type->getDescription()); ?></option>
11
+                ><?php e($type->getIsoCode().' '.$type->getDescription()); ?></option>
12 12
             <?php endforeach; ?>
13 13
             </select>
14 14
         </div>
Please login to merge, or discard this patch.
src/Intraface/modules/todo/TodoList.php 1 patch
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -34,7 +34,7 @@  discard block
 block discarded – undo
34 34
         }
35 35
 
36 36
         $this->kernel = $kernel;
37
-        $this->id = (int) $id;
37
+        $this->id = (int)$id;
38 38
 
39 39
         if ($this->id > 0) {
40 40
             $this->load();
@@ -59,7 +59,7 @@  discard block
 block discarded – undo
59 59
         }
60 60
 
61 61
         $db = new DB_Sql;
62
-        $db->query("SELECT * FROM todo_item WHERE " . $sql_status . " todo_list_id =" . (int)$this->getId() . "  AND active = 1 ORDER BY status ASC, position ASC");
62
+        $db->query("SELECT * FROM todo_item WHERE ".$sql_status." todo_list_id =".(int)$this->getId()."  AND active = 1 ORDER BY status ASC, position ASC");
63 63
         $ids = array();
64 64
         $i = 0;
65 65
         while ($db->nextRecord()) {
@@ -100,7 +100,7 @@  discard block
 block discarded – undo
100 100
     public function setAllItemsUndone()
101 101
     {
102 102
         $db = new DB_Sql;
103
-        $db->query("UPDATE todo_item SET status = 0 WHERE todo_list_id = " . $this->getId());
103
+        $db->query("UPDATE todo_item SET status = 0 WHERE todo_list_id = ".$this->getId());
104 104
         return true;
105 105
     }
106 106
 
@@ -140,7 +140,7 @@  discard block
 block discarded – undo
140 140
     public function deleteAllItems()
141 141
     {
142 142
         $db = new DB_Sql;
143
-        $db->query("DELETE FROM todo_item WHERE todo_list_id = " . $this->id. " AND active = 1 AND status = 0");
143
+        $db->query("DELETE FROM todo_item WHERE todo_list_id = ".$this->id." AND active = 1 AND status = 0");
144 144
         return true;
145 145
     }
146 146
 
@@ -152,7 +152,7 @@  discard block
 block discarded – undo
152 152
     private function load()
153 153
     {
154 154
         $db = new Db_Sql;
155
-        $db->query("SELECT * FROM todo_list WHERE id = " . $this->id . " LIMIT 1");
155
+        $db->query("SELECT * FROM todo_list WHERE id = ".$this->id." LIMIT 1");
156 156
         if ($db->nextRecord()) {
157 157
             $this->value['id'] = $db->f('id');
158 158
             $this->value['list_name'] = $db->f('name');
@@ -218,13 +218,13 @@  discard block
 block discarded – undo
218 218
 
219 219
         if ($this->id == 0) {
220 220
             $sql_type = "INSERT INTO ";
221
-            $sql_end = ", date_created = NOW(), public_key = '" .$this->kernel->randomKey(10) . "'";
221
+            $sql_end = ", date_created = NOW(), public_key = '".$this->kernel->randomKey(10)."'";
222 222
         } else {
223 223
             $sql_type = "UPDATE ";
224
-            $sql_end = " WHERE id = " . $this->id;
224
+            $sql_end = " WHERE id = ".$this->id;
225 225
         }
226 226
         $db = new DB_Sql;
227
-        $db->query($sql_type. " todo_list SET description = '".$var['list_description']."', name = '".$var['list_name']."', date_changed=NOW(),intranet_id = " . $this->kernel->intranet->get('id') . $sql_end);
227
+        $db->query($sql_type." todo_list SET description = '".$var['list_description']."', name = '".$var['list_name']."', date_changed=NOW(),intranet_id = ".$this->kernel->intranet->get('id').$sql_end);
228 228
 
229 229
         if ($this->id == 0) {
230 230
             $this->id = $db->insertedId();
@@ -246,12 +246,12 @@  discard block
 block discarded – undo
246 246
         $db->query("SELECT * FROM todo_list
247 247
             WHERE intranet_id = " . $this->kernel->intranet->get('id'));
248 248
         $ids = array();
249
-        $i=0;
249
+        $i = 0;
250 250
         while ($db->nextRecord()) {
251 251
             $todo = new TodoList($this->kernel, $db->f('id'));
252 252
             if ($type == 'done' and $todo->howManyLeft() > 0) {
253 253
                 continue;
254
-            } elseif ($type != 'done'  and $todo->howManyLeft() == 0) {
254
+            } elseif ($type != 'done' and $todo->howManyLeft() == 0) {
255 255
                 continue;
256 256
             }
257 257
             $ids[$i]['id'] = $db->f('id');
@@ -270,7 +270,7 @@  discard block
 block discarded – undo
270 270
     public function howManyLeft()
271 271
     {
272 272
         $db = new DB_Sql;
273
-        $db->query("SELECT * FROM todo_item WHERE status = 0 AND active = 1 AND todo_list_id = " . $this->id);
273
+        $db->query("SELECT * FROM todo_item WHERE status = 0 AND active = 1 AND todo_list_id = ".$this->id);
274 274
         return $db->numRows();
275 275
     }
276 276
 
@@ -283,11 +283,11 @@  discard block
 block discarded – undo
283 283
     {
284 284
         $id = (int)$id;
285 285
         $db = new DB_Sql;
286
-        $db->query("SELECT * FROM todo_contact WHERE contact_id = " . $id);
286
+        $db->query("SELECT * FROM todo_contact WHERE contact_id = ".$id);
287 287
         if ($db->nextRecord()) {
288 288
             return true;
289 289
         }
290
-        $db->query("INSERT INTO todo_contact SET contact_id = " . $id . ", list_id = ".$this->get('id').", intranet_id = " . $this->kernel->intranet->get('id'));
290
+        $db->query("INSERT INTO todo_contact SET contact_id = ".$id.", list_id = ".$this->get('id').", intranet_id = ".$this->kernel->intranet->get('id'));
291 291
         return true;
292 292
     }
293 293
 
@@ -301,7 +301,7 @@  discard block
 block discarded – undo
301 301
         $db = new DB_Sql;
302 302
         $i = 0;
303 303
         $contacts = array();
304
-        $db->query("SELECT * FROM todo_contact WHERE intranet_id = " . $this->kernel->intranet->get('id'));
304
+        $db->query("SELECT * FROM todo_contact WHERE intranet_id = ".$this->kernel->intranet->get('id'));
305 305
         while ($db->nextRecord()) {
306 306
             $contacts[$i] = $db->f('contact_id');
307 307
             $i++;
Please login to merge, or discard this patch.
src/Intraface/modules/todo/TodoItem.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -29,7 +29,7 @@  discard block
 block discarded – undo
29 29
             throw new Exception('Todo kr�ver Kernel');
30 30
         }
31 31
         $this->todo = $todo;
32
-        $this->id = (int) $id;
32
+        $this->id = (int)$id;
33 33
 
34 34
         if ($this->id > 0) {
35 35
             $this->load();
@@ -44,7 +44,7 @@  discard block
 block discarded – undo
44 44
     private function load()
45 45
     {
46 46
         $db = new Db_Sql;
47
-        $db->query("SELECT * FROM todo_item WHERE id = " . $this->id);
47
+        $db->query("SELECT * FROM todo_item WHERE id = ".$this->id);
48 48
         if ($db->nextRecord()) {
49 49
             $this->value['id'] = $db->f('id');
50 50
             $this->value['item'] = $db->f('item');
@@ -103,20 +103,20 @@  discard block
 block discarded – undo
103 103
         $db = new DB_Sql;
104 104
 
105 105
         if ($this->id == 0) {
106
-            $db->query("SELECT position FROM todo_item WHERE todo_list_id = " . $this->todo->get('id') . " ORDER BY position DESC LIMIT 1");
106
+            $db->query("SELECT position FROM todo_item WHERE todo_list_id = ".$this->todo->get('id')." ORDER BY position DESC LIMIT 1");
107 107
             $db->nextRecord();
108 108
             $new_position = $db->f('position') + 1;
109 109
         }
110 110
 
111 111
         if ($this->id == 0) {
112 112
             $sql_type = "INSERT INTO ";
113
-            $sql_end = ", date_created = NOW(), position = " . $new_position;
113
+            $sql_end = ", date_created = NOW(), position = ".$new_position;
114 114
         } else {
115 115
             $sql_type = "UPDATE ";
116
-            $sql_end = " WHERE id = " . $this->id;
116
+            $sql_end = " WHERE id = ".$this->id;
117 117
         }
118 118
 
119
-        $db->query($sql_type. " todo_item SET intranet_id = ".$this->todo->kernel->intranet->get('id').", item = '".$var."', todo_list_id = ".(int)$this->todo->get('id').", responsible_user_id = " .$user_id. " " . $sql_end);
119
+        $db->query($sql_type." todo_item SET intranet_id = ".$this->todo->kernel->intranet->get('id').", item = '".$var."', todo_list_id = ".(int)$this->todo->get('id').", responsible_user_id = ".$user_id." ".$sql_end);
120 120
 
121 121
         if ($this->id == 0) {
122 122
             $this->id = $db->insertedId();
@@ -135,7 +135,7 @@  discard block
 block discarded – undo
135 135
             return false;
136 136
         }
137 137
         $db = new DB_Sql;
138
-        $db->query("UPDATE todo_item SET status = 1 WHERE id = " . $this->id);
138
+        $db->query("UPDATE todo_item SET status = 1 WHERE id = ".$this->id);
139 139
         return true;
140 140
     }
141 141
 
@@ -150,7 +150,7 @@  discard block
 block discarded – undo
150 150
             return false;
151 151
         }
152 152
         $db = new DB_Sql;
153
-        $db->query("UPDATE todo_item SET active = 0 WHERE id = " . $this->id);
153
+        $db->query("UPDATE todo_item SET active = 0 WHERE id = ".$this->id);
154 154
         return true;
155 155
     }
156 156
 
Please login to merge, or discard this patch.
src/Intraface/modules/todo/Controller/templates/index.tpl.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -1,12 +1,12 @@
 block discarded – undo
1 1
 <h1><?php e(t('Todo')); ?></h1>
2 2
 
3 3
 <ul class="options">
4
-    <li><a href="<?php e(url('create'));?>"><?php e(t('Create list')); ?></a></li>
4
+    <li><a href="<?php e(url('create')); ?>"><?php e(t('Create list')); ?></a></li>
5 5
 </ul>
6 6
 
7 7
 <?php if (count($todo_list) == 0) : ?>
8 8
 
9
-    <p><?php e(t('No lists available'))?>. <a href="<?php e(url('create'));?>"><?php e(t('Create list')); ?></a>.</p>
9
+    <p><?php e(t('No lists available'))?>. <a href="<?php e(url('create')); ?>"><?php e(t('Create list')); ?></a>.</p>
10 10
 
11 11
 <?php else : ?>
12 12
 
Please login to merge, or discard this patch.
src/Intraface/modules/todo/Controller/Email.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -18,7 +18,7 @@  discard block
 block discarded – undo
18 18
         $todo = new TodoList($this->getKernel(), $this->context->name());
19 19
         $value['id'] = $todo->get('id');
20 20
         $value['subject'] = 'Todoliste';
21
-        $value['body'] = $this->getKernel()->setting->get('user', 'todo.email.standardtext') . "\n\nMed venlig hilsen\n".$this->getKernel()->user->getAddress()->get('name') . "\n" . $this->getKernel()->intranet->get('name');
21
+        $value['body'] = $this->getKernel()->setting->get('user', 'todo.email.standardtext')."\n\nMed venlig hilsen\n".$this->getKernel()->user->getAddress()->get('name')."\n".$this->getKernel()->intranet->get('name');
22 22
 
23 23
         $contacts = $todo->getContacts();
24 24
 
@@ -31,7 +31,7 @@  discard block
 block discarded – undo
31 31
             'value' => $value
32 32
         );
33 33
 
34
-        $tpl = $this->template->create(dirname(__FILE__) . '/templates/email');
34
+        $tpl = $this->template->create(dirname(__FILE__).'/templates/email');
35 35
         return $tpl->render($this, $data);
36 36
     }
37 37
 
@@ -54,7 +54,7 @@  discard block
 block discarded – undo
54 54
 
55 55
                 $email = new Email($this->getKernel());
56 56
                 $var = array(
57
-                    'body' => $_POST['body'] . "\n\n" . $contact->getLoginUrl(),
57
+                    'body' => $_POST['body']."\n\n".$contact->getLoginUrl(),
58 58
                     'subject' => $_POST['subject'],
59 59
                     'contact_id' => $contact->get('id'),
60 60
                     'type_id' => 6, // type_id 6 er todo
Please login to merge, or discard this patch.
src/Intraface/modules/todo/Controller/Edit.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -27,7 +27,7 @@  discard block
 block discarded – undo
27 27
             'kernel' => $this->getKernel()
28 28
         );
29 29
 
30
-        $tpl = $this->template->create(dirname(__FILE__) . '/templates/edit');
30
+        $tpl = $this->template->create(dirname(__FILE__).'/templates/edit');
31 31
         return $tpl->render($this, $data);
32 32
     }
33 33
 
@@ -51,7 +51,7 @@  discard block
 block discarded – undo
51 51
                     $item_id = 0;
52 52
                 }
53 53
             }
54
-            return new k_SeeOther($this->url('../' . $todo->get('id')));
54
+            return new k_SeeOther($this->url('../'.$todo->get('id')));
55 55
         }
56 56
         return $this->render();
57 57
     }
Please login to merge, or discard this patch.