Webshop::createOrder() - Code Metrics - intraface/intraface.dk - Measure and Improve Code Quality continuously with Scrutinizer

Webshop::createOrder() F
last analyzed 2017-03-20 12:20 UTC

↳ Parent: Webshop
Complexity

Conditions	26
Paths	1350
Size

Total Lines	104
Code Lines	61
Duplication

Lines	63
Ratio	60.58 %
Code Coverage

Tests	43
CRAP Score	70.1789
Importance

Changes
Metric	Value
cc	26
eloc	61
nc	1350
nop	1
dl	63
loc	104
rs	2
c	0
b	0
f	0
ccs	43
cts	72
cp	0.5971
crap	70.1789
How to fix Long Method Complexity

<?php
/**
 * Webshop s�rger for at holde styr webshoppen.
 *
 * @todo Indstilling af porto - skal det v�re et standardprodukt p� alle ordrer?
 *
 * @todo Standardprodukter p� ordrer.
 *
 * @todo Opf�rsel ift. lager i onlineshoppen.
 *
 * @todo B�r kunne tage h�jde for en tidsangivelse p� produkterne
 *
 * @package Intraface_Shop
 * @author Lars Olesen <[email protected]>
 *
 * @see Basket
 * @see WebshopServer.php / XML-RPC-serveren i xmlrpc biblioteket
 * @see Order
 * @see Contact
 */
class Webshop
{
    /**
     * @var object
     */
    public $kernel;

    /**
     * @var object
     */
    public $basket;

    /**
     * @var object
     */
    private $order;

    /**
     * @var object
     */
    private $contact;

    /**
     * @var object
     */
    public $error;

    /**
     * @var private
     */
    public $session_id;

    /**
     * Construktor
     *
     * @param object $kernel     Kernel object
     * @param string $session_id Unikt session id
     *
     * @return void

     */
    public function __construct($kernel, $session_id)
    {
        if (!is_object($kernel)) {
            throw new Exception('Webshopmodulet har brug for Kernel');
        }

        $this->kernel = $kernel;
        $this->kernel->useModule('debtor');
        $this->kernel->useModule('order');
        $this->kernel->useModule('product');
        $this->kernel->useModule('contact');

        $this->session_id = $session_id;

        $this->basket = $this->createBasket();

        $this->error = new Intraface_Error;
    }

    /**
     * Convenience method to create the basket
     *
     * @return object
     */
    private function createBasket()
    {
        return new Basket($this, $this->session_id);
    }

    /**
     * Gets the basket
     *
     * @return object
     */
    public function getBasket()
    {
        return $this->basket;
    }

    /**
     * Places the order and utilizes basket
     *
     * @param array $input Array with customer data
     *
     * @return integer Order id
     */
    private function createOrder($input)
    {
        if (isset($input['contact_id']) && (int)$input['contact_id'] > 0) {
            $this->contact = new Contact($this->kernel, (int)$input['contact_id']);

            $contact_person_id = 0;
            // It is a company and contactperson is given. We try to see if we can find the contact person.
            if (isset($input['contactperson']) && $input['contactperson'] != '') {
                $input['type'] = 'corporation';

                // If the contact is a company their might already be a contact person.
                if ($this->contact->get('type') == 'company' && isset($this->contact->contactperson)) {
                    $contact_persons = $this->contact->contactperson->getList();
                    foreach ($contact_persons as $contact_person) {
                        // This is only a comparing on name, this might not be enough.
                        if ($contact_person['name'] == $input['contactperson']) {
                            $contact_person_id = $contact_person['id'];
                            break;
                        }
                    }
                }
            }
        } else {
            $this->contact = new Contact($this->kernel);
            $contact_person_id = 0;

            // s�rger for at tjekke om det er et firma
            if (isset($input['contactperson']) && $input['contactperson'] != '') {
                $input['type'] = 'corporation'; // firma
            }

            if (isset($input['customer_ean']) && $input['customer_ean'] != '') {
                // sets preffered invoice to electronic.
                $input['type'] = 'corporation'; // firma
                $input['preferred_invoice'] = 3;
            } else {
                // sets preffered invoice to email. Should be a setting in webshop.
                $input['preferred_invoice'] = 2;
            }
        }

        if (isset($input['customer_ean'])) {
            $input['ean'] = $input['customer_ean'];
        }


        if (!isset($input['contact_id'])) {
            // opdaterer kontakten
            if (!$contact_id = $this->contact->save($input)) {
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
                $this->error->merge($this->contact->getError()->getMessage());
                return false;
            }
        }

        // we update/add the contactperson.
        if (isset($input['type']) && $input['type'] == 'corporation') { // firma
            $this->contact->loadContactPerson($contact_person_id);
            settype($input['contactperson'], 'string');
            settype($input['contactemail'], 'string');
            settype($input['contactphone'], 'string');
            if (!$contact_person_id = $this->contact->contactperson->save(array('name'=>$input['contactperson'], 'email'=>$input['contactemail'], 'phone'=>$input['contactphone']))) {
                $this->error->merge($this->contact->getError()->getMessage());
                return false;
            }
        }

        $value['contact_id'] = $this->contact->get('id');
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        $value['contact_address_id'] = $this->contact->address->get('id');
        $value['contact_person_id'] = $contact_person_id;

        $value['this_date'] = date('d-m-Y');
        $value['due_date'] = date('d-m-Y');
        settype($input['description'], 'string');
        $value['description'] = $input['description'];
        settype($input['internal_note'], 'string');
        $value['internal_note'] = $input['internal_note'];
        settype($input['message'], 'string');
        $value['message'] = $input['message'];

        if (isset($input['customer_coupon']) && $input['customer_coupon'] != '') {
            if ($value['message'] != '') {
                $value['message'] .= "\n\n";
            }
            $value['message'] .= "Kundekupon:". $input['customer_coupon'];
        }

        if (isset($input['customer_comment']) && $input['customer_comment'] != '') {
            if ($value['message'] != '') {
                $value['message'] .= "\n\n";
            }
            $value['message'] .= "Kommentar:\n". $input['customer_comment'];
        }


        $this->order = new Debtor($this->kernel, 'order');
        $order_id = $this->order->update($value, 'webshop');

        if ($order_id == 0) {
            $this->error->merge($this->order->error->message);
            return false;
        }

        return $order_id;
    }

    /**
     * Places the order and utilizes basket
     *
     * @param array $input    Array with customer data
     * @param array $products Array with products
     *
     * @return integer Order id
     */
    public function placeManualOrder($input = array(), $products = array())

    {
        $order_id = $this->createOrder($input);
        if ($order_id == 0) {
            $this->error->set('unable to create the order');
            return false;
        }

        if (!$this->addOrderLines($products)) {
            $this->error->set('unable add products to the order');
            return false;
        }

        if (!$this->sendEmail($order_id)) {
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}
            $this->error->set('unable to send email to the customer');
            return false;
        }

        return $order_id;
    }

    /**
     * Places the order and utilizes basket
     *
     * @param array $input Array with customer data
     *
     * @return integer Order id
     */
    public function placeOrder($input)
    {
        if (!$order_id = $this->createOrder($input)) {
            $this->error->set('unable to create the order');
            return false;
        }

        $products = $this->basket->getItems();

        if (!$this->addOrderLines($products)) {
            $this->error->set('unable add products to the order');
            return false;
        }

        $this->basket->reset();

        if (!$this->sendEmail($order_id)) {
            $this->error->set('unable to send email to the customer');
            return false;
        }

        return $order_id;
    }

    /**
     * Adds the order lines
     *
     * @param array $products
     *
     * @return boolean
     */
    private function addOrderLines($products = array())
    {
        foreach ($products as $product) {
            $this->order->loadItem();
            $value['product_id'] = $product['id'];
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
            $value['quantity'] = $product['quantity'];
            $value['description'] = $product['text'];
            $this->order->item->save($value);
        }

        return true;
    }

    /**
     * Sends the email
     *
     * @param integer $order_id
     *
     * @return boolean
     */
    private function sendEmail($order_id)
    {
        $this->kernel->useShared('email');
        $email = new Email($this->kernel);

        if (!$email->save(array('contact_id' => $this->contact->get('id'),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                                'subject' => 'Bekræftelse på bestilling #' . $order_id,
                                'body' => $this->kernel->setting->get('intranet', 'webshop.confirmation_text') . "\n" . $this->contact->getLoginUrl() . "\n\nVenlig hilsen\n" . $this->kernel->intranet->address->get('name'),
                                'from_email' => $this->kernel->intranet->address->get('email'),
                                'from_name' => $this->kernel->intranet->address->get('name'),
                                'type_id' => 12, // webshop
                                'belong_to' => $order_id))) {
            $this->error->merge($email->error->message);

            return false;
        }

        if (!$email->queue()) {
            $this->error->merge($email->error->message);

            return false;
        }

        return true;
    }

    /**
     * Places the order and utilizes basket
     *
     * @param integer $order_id
     * @param integer $transaction_number
     * @param integer $transaction_status
     * @param float   $transaction_amount
/**
 * @param array $germany
 * @param array $ireland
 */
function finale($germany, $island) {
    return "2:1";
}
     *
     * @return boolean
     */
    public function addOnlinePayment($order_id, $transaction_number, $transaction_status, $amount)
    {
        if ($order_id == 0) {
            return 0;
        }

        if (!$this->kernel->intranet->hasModuleAccess('onlinepayment')) {
            return 0;
        }

        // hvad skal den her sikre?
        if (is_object($this->kernel->user) and $this->kernel->user->hasModuleAccess('onlinepayment')) {
// Logical operators have lower precedence:
$f = false or true;

// is executed like this:
($f = false) or true;


// Boolean operators have higher precedence:
$f = false || true;

// is executed like this:
$f = (false || true);
            return 0;
        }

        $this->kernel->useModule('onlinepayment');
        $onlinepayment = new OnlinePayment($this->kernel);

        $values = array('belong_to'          => 'order',
                        'belong_to_id'       => (int)$order_id,
                        'transaction_number' => $transaction_number,
                        'transaction_status' => $transaction_status,
                        'amount'             => $amount);

        if ($payment_id = $onlinepayment->save($values)) {
            return $payment_id;
        } else {
            $onlinepayment->error->view();
            return 0;
        }
    }

    /**
     * Returns receipt text
     *
     * @todo why return an array
     *
     * @return array with receipt
     */
    public function getReceiptText()
    {
        return array('receipt_text' => $this->kernel->setting->get('intranet', 'webshop.webshop_receipt'));
    }

    /**
     * Sets the order as sent
     *
     * @param integer $order_id
     *
     * @return boolean
     */
    public function setSent($order_id)

    {
        $order_id = (int)$order_id;
        if ($order_id == 0) {
            return 0;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
        }
        $debtor = Debtor::factory($this->kernel, (int)$order_id);
        return $debtor->setSent();
    }
}

intraface / intraface.dk

Webshop::createOrder() F last analyzed 2017-03-20 12:20 UTC

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method Complexity

Long Method

Logical Operators are used for Control-Flow

Duplication Side-by-Side

Filter issues like

Webshop::createOrder() F
last analyzed 2017-03-20 12:20 UTC
