ModuleHandlerTest::testGetModules() - Code Metrics - intraface/intraface.dk - Measure and Improve Code Quality continuously with Scrutinizer

ModuleHandlerTest::testGetModules() A
last analyzed 2017-03-20 12:20 UTC

↳ Parent: ModuleHandlerTest

Complexity

Conditions	2
Paths	2

Size

Total Lines	11
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	7
nc	2
nop	0
dl	0
loc	11
rs	9.4285
c	0
b	0
f	0

<?php
class ModuleHandlerIntranet
{
    function hasModuleAccess()
    {
        return true;
    }
}

class ModuleHandlerTest extends PHPUnit_Framework_TestCase
{
    private $handler;

    function setUp()
    {
        $this->handler = new Intraface_ModuleHandler(new ModuleHandlerIntranet);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    function testUseModuleThrowsAnExceptionIfTheModuleIsNotValid()
    {
        try {
            $this->handler->useModule('invalid module name');
            $this->assertTrue(false, 'Exception should have been thrown');
        } catch (Exception $e) {
            $this->assertTrue(true);
        }
    }

    function testSetPrimaryModuleThrowsAnExceptionWhenNoIntranetIsset()
    {
        try {
            $this->handler->setPrimaryModule('intranetmaintenance');
            $this->assertFalse(true, 'Should have thrown an exception');
        } catch (Exception $e) {
            $this->assertTrue(true);
        }
    }

    function testUseModuleReturnsTheModuleAsAnObjectTrueWhenModuleIsAvailable()
    {
        $this->assertTrue(is_object($module = $this->handler->useModule('intranetmaintenance')));
        $this->assertEquals('intranetmaintenance', $module->getName());
    }

    function testGetModule()
    {
        $this->assertTrue(is_object($this->handler->useModule('intranetmaintenance')));
        $this->assertTrue(is_object($module = $this->handler->getModule('intranetmaintenance')));
        $this->assertEquals('intranetmaintenance', $module->getName());
    }

    function testGetModules()
    {
        $db = MDB2::singleton(DB_DSN);
        $result = $db->query('SELECT * FROM module');
        if (PEAR::isError($result)) {
            die($result->getMessage() . $result->getUserInfo());

        }

        $this->assertTrue(is_array($this->handler->getModules(MDB2::singleton(DB_DSN))));
        $this->assertEquals($result->numRows(), count($this->handler->getModules(MDB2::singleton(DB_DSN))));
    }
}


1			<?php
2			class ModuleHandlerIntranet
3			{
4			function hasModuleAccess()
5			{
6			return true;
7			}
8			}
9
10			class ModuleHandlerTest extends PHPUnit_Framework_TestCase
11			{
12			private $handler;
13
14			function setUp()
15			{
16			$this->handler = new Intraface_ModuleHandler(new ModuleHandlerIntranet);
			0 ignored issues – show Documentation introduced 2016-04-20 09:50 UTC by Report Bug Copy Issue Report `new \ModuleHandlerIntranet()` is of type `object<ModuleHandlerIntranet>`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
17			}
18
19			function testUseModuleThrowsAnExceptionIfTheModuleIsNotValid()
20			{
21			try {
22			$this->handler->useModule('invalid module name');
23			$this->assertTrue(false, 'Exception should have been thrown');
24			} catch (Exception $e) {
25			$this->assertTrue(true);
26			}
27			}
28
29			function testSetPrimaryModuleThrowsAnExceptionWhenNoIntranetIsset()
30			{
31			try {
32			$this->handler->setPrimaryModule('intranetmaintenance');
33			$this->assertFalse(true, 'Should have thrown an exception');
34			} catch (Exception $e) {
35			$this->assertTrue(true);
36			}
37			}
38
39			function testUseModuleReturnsTheModuleAsAnObjectTrueWhenModuleIsAvailable()
40			{
41			$this->assertTrue(is_object($module = $this->handler->useModule('intranetmaintenance')));
42			$this->assertEquals('intranetmaintenance', $module->getName());
43			}
44
45			function testGetModule()
46			{
47			$this->assertTrue(is_object($this->handler->useModule('intranetmaintenance')));
48			$this->assertTrue(is_object($module = $this->handler->getModule('intranetmaintenance')));
49			$this->assertEquals('intranetmaintenance', $module->getName());
50			}
51
52			function testGetModules()
53			{
54			$db = MDB2::singleton(DB_DSN);
55			$result = $db->query('SELECT * FROM module');
56			if (PEAR::isError($result)) {
57			die($result->getMessage() . $result->getUserInfo());
			0 ignored issues – show Coding Style Compatibility introduced 2016-04-20 09:50 UTC by Report Bug Copy Issue Report The method `testGetModules()` contains an exit expression. An exit expression should only be used in rare cases. For example, if you write a short command line script. In most cases however, using an `exit` expression makes the code untestable and often causes incompatibilities with other libraries. Thus, unless you are absolutely sure it is required here, we recommend to refactor your code to avoid its usage. Loading history...
58			}
59
60			$this->assertTrue(is_array($this->handler->getModules(MDB2::singleton(DB_DSN))));
61			$this->assertEquals($result->numRows(), count($this->handler->getModules(MDB2::singleton(DB_DSN))));
62			}
63			}
64

intraface / intraface.dk

ModuleHandlerTest::testGetModules() A last analyzed 2017-03-20 12:20 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

ModuleHandlerTest::testGetModules() A
last analyzed 2017-03-20 12:20 UTC