Intraface_modules_debtor_Controller_Send::renderHtml() - Code Metrics - intraface/intraface.dk - Measure and Improve Code Quality continuously with Scrutinizer

renderHtml() F
last analyzed 2017-03-20 12:20 UTC

↳ Parent: Intraface_modules_debtor_Controller_Send

Complexity

Conditions	27
Paths	582

Size

Total Lines	171
Code Lines	114

Duplication

Lines	44
Ratio	25.73 %

Code Coverage

Tests	0
CRAP Score	756

Importance

Changes

Metric	Value
cc	27
eloc	114
nc	582
nop	0
dl	44
loc	171
rs	2.2958
c	0
b	0
f	0
ccs	0
cts	133
cp	0
crap	756

How to fix Long Method Complexity

<?php
class Intraface_modules_debtor_Controller_Send extends k_Component
{
    function renderHtml()
    {
        $module_debtor = $this->context->getKernel()->getModule('debtor');
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        $this->context->getKernel()->useModule('contact');
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        $this->context->getKernel()->useModule('product');
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        $this->context->getKernel()->useModule('filemanager');
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        $this->context->getKernel()->useShared('email');
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

        $translation = $this->translator();

        // find debtoren
        $debtor = $this->context->getDebtor();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

        switch ($this->query('send')) {
            case 'email':
                $contact = $debtor->getContact();
                if (!$contact->address->get('email')) {
                    throw new Exception('Der er ikke angivet nogen e-mail til kunden');
                }

                if ($debtor->contact->get('preferred_invoice') <> 2) { // email
                    throw new Exception('Kunden foretrækker ikke post på e-mail');
                }

                // vi skal lige have oversat den her rigtigt
                $subject = $translation->get($debtor->get('type')) . ' #' . $debtor->get('number');

                // hvad skal den skrive her?
                if ($debtor->get('type') == 'order') {
                    $body = $this->context->getKernel()->getSetting()->get('intranet', 'debtor.order.email.text');
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
                } elseif ($debtor->get('type') == 'invoice') {
                    $body = $this->context->getKernel()->getSetting()->get('intranet', 'debtor.invoice.email.text');
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
                } elseif ($debtor->get('type') == 'quotation') {
                    $body = $this->context->getKernel()->getSetting()->get('intranet', 'debtor.quotation.email.text');
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
                } else {
                    $body = '';
                }
                break;

            case 'electronic_email':
                // find ud af hvem der er scan in contact
                // måske skal vi lige tjekke om det overhovedet er en faktura
                $scan_in_contact_id = $this->context->getKernel()->getSetting()->get('intranet', 'debtor.scan_in_contact');
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

                $contact = new Contact($this->context->getKernel(), $scan_in_contact_id);
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
                if (!$contact->get('id') > 0) {
                    throw new Exception('Der er ikke angivet nogen kontakt at sende de elektroniske fakturaer til');
                } elseif (!$contact->address->get('email')) {
                    throw new Exception('Der er ikke angivet nogen e-mail til Læs-Ind bureauet');
                }

                if ($debtor->contact->get('preferred_invoice') <> 3) { // elektronisk faktura
                    throw new Exception('Kunden foretrækker ikke elektronisk faktura!');
                } elseif (!$debtor->contact->address->get('ean')) {
                    throw new Exception('EAN-nummeret er ikke sat');
                }

                $subject = 'Elektronisk faktura';
                $body = 'Hermed faktura #' . $debtor->get('number') . ' til at læse ind';

                break;
        }

        if (($debtor->get("type") == "order" || $debtor->get("type") == "invoice") && $this->context->getKernel()->intranet->hasModuleAccess('onlinepayment')) {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            $this->context->getKernel()->useModule('onlinepayment');
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            $onlinepayment = OnlinePayment::factory($this->context->getKernel());
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        } else {
            $onlinepayment = null;
        }

        if ($this->context->getKernel()->intranet->get("pdf_header_file_id") != 0) {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            $file = new FileHandler($this->context->getKernel(), $this->context->getKernel()->intranet->get("pdf_header_file_id"));
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        } else {
            $file = null;
        }

        // gem debtoren som en fil i filsystemet
        $filehandler = new FileHandler($this->context->getKernel());
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        $tmp_file = $filehandler->createTemporaryFile($translation->get($debtor->get("type")).$debtor->get('number').'.pdf');

        // Her gemmes filen
        $report = new Intraface_modules_debtor_Visitor_Pdf($translation, $file);
        $report->visit($debtor, $onlinepayment);
        $report->output('file', $tmp_file->getFilePath());

        // gem filen med filehandleren
        $filehandler = new FileHandler($this->context->getKernel());
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        if (!$file_id = $filehandler->save($tmp_file->getFilePath(), $tmp_file->getFileName(), 'hidden', 'application/pdf')) {
            echo $filehandler->error->view();
            throw new Exception('Filen kunne ikke gemmes');
        }

        $input['accessibility'] = 'intranet';
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        if (!$file_id = $filehandler->update($input)) {
            echo $filehandler->error->view();
            throw new Exception('Oplysninger om filen kunne ikke opdateres');
        }

        switch ($this->context->getKernel()->getSetting()->get('intranet', 'debtor.sender')) {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            case 'intranet':
                $from_email = '';
                $from_name = '';
                break;
            case 'user':
                $from_email = $this->context->getKernel()->user->getAddress()->get('email');
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
                $from_name = $this->context->getKernel()->user->getAddress()->get('name');
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
                break;
            case 'defined':
                $from_email = $this->context->getKernel()->getSetting()->get('intranet', 'debtor.sender.email');
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
                $from_name = $this->context->getKernel()->getSetting()->get('intranet', 'debtor.sender.name');
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
                break;
            default:
                throw new Exception("Invalid sender!");
                exit;
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
        }

        $signature = new Intraface_shared_email_Signature($this->context->getKernel()->user, $this->context->getKernel()->intranet, $this->context->getKernel()->getSetting());
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

        // opret e-mailen
        $email = new Email($this->context->getKernel());
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        if (!$email->save(array(
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                'contact_id' => $contact->get('id'),
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
                'subject' => $subject,
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
                'body' => $body . "\n\n" . $signature->getAsText(),
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
                'from_email' => $from_email,
                'from_name' => $from_name,
                'type_id' => 10, // electronic invoice
                'belong_to' => $debtor->get('id')
            ))) {
            echo $email->error->view();
            throw new Exception('E-mailen kunne ikke gemmes');
        }

        // tilknyt fil
        if (!$email->attachFile($file_id, $filehandler->get('file_name'))) {
            echo $email->error->view();
            throw new Exception('Filen kunne ikke vedhæftes');
        }

        switch ($this->query('send')) {
            case 'email':
                    $redirect = Intraface_Redirect::factory($this->context->getKernel(), 'go');
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
                    $shared_email = $this->context->getKernel()->useModule('email');
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

                    // First vi set the last, because we need this id to the first.
                    $url = $redirect->setDestination($shared_email->getPath().$email->get('id') . '?edit', NET_SCHEME . NET_HOST . $this->url('../'));
                    $redirect->setIdentifier('send_email');
                    $redirect->askParameter('send_email_status');

                return new k_SeeOther($url);
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            case 'electronic_email':
                // Sender e-mailen
                if ($email->queue()) {
                    if ($debtor->get('status') == 'created') {
                        $debtor->setStatus('sent');
                    }
                    return new k_SeeOther($this->url('../'));
                } else {
                    echo $email->error->view();
                    throw new Exception('E-mailen kunne ikke sendes');
                }

                break;
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
            default:
                throw new Exception('not valid send as');
                break;
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
        }
        throw new Exception('Something went wrong');
    }
}


renderHtml() F
last analyzed 2017-03-20 12:20 UTC

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method Complexity

Long Method

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

1			<?php
2			class Intraface_modules_debtor_Controller_Send extends k_Component
3			{
4			function renderHtml()
5			{
6			$module_debtor = $this->context->getKernel()->getModule('debtor');
			0 ignored issues – show Unused Code introduced 2016-04-20 07:43 UTC by Report Bug Copy Issue Report `$module_debtor` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history... Bug introduced 2016-04-20 09:50 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `k_Context` as the method `getKernel()` does only exist in the following implementations of said interface: `Intraface_Controller_Index`, `Intraface_Controller_ModuleGatekeeper`, `Intraface_Controller_ModulePackage_Process`, `Intraface_Controller_Restricted`, `Intraface_Controller_SwitchIntranet`, `Intraface_Filehandler_Controller_Batchedit`, `Intraface_Filehandler_Controller_CKEditor`, `Intraface_Filehandler_Controller_Crop`, `Intraface_Filehandler_Controller_Index`, `Intraface_Filehandler_Controller_SelectFile`, `Intraface_Filehandler_Controller_Show`, `Intraface_Filehandler_Controller_Size`, `Intraface_Filehandler_Controller_Sizes`, `Intraface_Filehandler_Controller_Upload`, `Intraface_Filehandler_Controller_UploadMultiple`, `Intraface_Filehandler_Controller_UploadScript`, `Intraface_Fileimport_Controller_Index`, `Intraface_Keyword_Controller_Connect`, `Intraface_Keyword_Controller_Index`, `Intraface_Keyword_Controller_Show`, `Intraface_modules_accoun...ontroller_Account_Index`, `Intraface_modules_accoun...ontroller_Account_Popup`, `Intraface_modules_accoun...Controller_Account_Show`, `Intraface_modules_accounting_Controller_Daybook`, `Intraface_modules_accounting_Controller_Index`, `Intraface_modules_accounting_Controller_Post_Index`, `Intraface_modules_accounting_Controller_Post_Show`, `Intraface_modules_accounting_Controller_Search`, `Intraface_modules_accounting_Controller_Settings`, `Intraface_modules_accounting_Controller_State`, `Intraface_modules_accoun...roller_State_Creditnote`, `Intraface_modules_accoun...ller_State_Depreciation`, `Intraface_modules_accoun...ontroller_State_Invoice`, `Intraface_modules_accoun...ontroller_State_Payment`, `Intraface_modules_accoun...oller_State_Procurement`, `Intraface_modules_accoun...ntroller_State_Reminder`, `Intraface_modules_accoun...roller_State_SelectYear`, `Intraface_modules_accounting_Controller_Vat_Index`, `Intraface_modules_accounting_Controller_Vat_Show`, `Intraface_modules_accoun...ontroller_Voucher_Index`, `Intraface_modules_accoun...Controller_Voucher_Show`, `Intraface_modules_accounting_Controller_Year_Edit`, `Intraface_modules_accounting_Controller_Year_End`, `Intraface_modules_accounting_Controller_Year_Index`, `Intraface_modules_accoun...troller_Year_Primosaldo`, `Intraface_modules_accounting_Controller_Year_Show`, `Intraface_modules_administration_Controller_Index`, `Intraface_modules_admini...ion_Controller_Intranet`, `Intraface_modules_cms_Controller_Element`, `Intraface_modules_cms_Controller_Elements`, `Intraface_modules_cms_Controller_Index`, `Intraface_modules_cms_Controller_Navigation`, `Intraface_modules_cms_Controller_Page`, `Intraface_modules_cms_Controller_Pages`, `Intraface_modules_cms_Controller_Section`, `Intraface_modules_cms_Controller_Sections`, `Intraface_modules_cms_Controller_Site`, `Intraface_modules_cms_Controller_Stylesheet`, `Intraface_modules_cms_Controller_Template`, `Intraface_modules_cms_Co...ler_TemplateSectionEdit`, `Intraface_modules_cms_Controller_TemplateSections`, `Intraface_modules_cms_Controller_Templates`, `Intraface_modules_contac...troller_BatchNewsletter`, `Intraface_modules_contact_Controller_Choosecontact`, `Intraface_modules_contac...ntroller_Contactpersons`, `Intraface_modules_contact_Controller_Import`, `Intraface_modules_contact_Controller_Index`, `Intraface_modules_contact_Controller_Memos`, `Intraface_modules_contact_Controller_Merge`, `Intraface_modules_contact_Controller_Sendemail`, `Intraface_modules_contact_Controller_Show`, `Intraface_modules_contro...ntroller_ChangePassword`, `Intraface_modules_controlpanel_Controller_Index`, `Intraface_modules_controlpanel_Controller_User`, `Intraface_modules_contro...troller_UserPreferences`, `Intraface_modules_curren...ller_ExchangeRate_Index`, `Intraface_modules_curren...changeRate_ProductPrice`, `Intraface_modules_currency_Controller_Index`, `Intraface_modules_currency_Controller_Show`, `Intraface_modules_debtor_Controller_Collection`, `Intraface_modules_debtor_Controller_Create`, `Intraface_modules_debtor_Controller_Depreciation`, `Intraface_modules_debtor_Controller_Depreciations`, `Intraface_modules_debtor_Controller_Index`, `Intraface_modules_debtor_Controller_Item`, `Intraface_modules_debtor_Controller_Items`, `Intraface_modules_debtor_Controller_Payment`, `Intraface_modules_debtor_Controller_Payments`, `Intraface_modules_debtor_Controller_Reminder`, `Intraface_modules_debtor_Controller_Reminders`, `Intraface_modules_debtor_Controller_Settings`, `Intraface_modules_debtor_Controller_Show`, `Intraface_modules_debtor_Controller_Typenegotiator`, `Intraface_modules_email_Controller_Email`, `Intraface_modules_email_Controller_Index`, `Intraface_modules_fileimport_Controller_Index`, `Intraface_modules_filemanager_Controller_Index`, `Intraface_modules_intran...enance_Controller_Index`, `Intraface_modules_intran...ntroller_Intranet_Index`, `Intraface_modules_intran...Controller_Intranet_Key`, `Intraface_modules_intran...ler_Intranet_Permission`, `Intraface_modules_intran...ontroller_Intranet_Show`, `Intraface_modules_intran...ance_Controller_Modules`, `Intraface_modules_intran...e_Controller_User_Index`, `Intraface_modules_intran...troller_User_Permission`, `Intraface_modules_intran...ce_Controller_User_Show`, `Intraface_modules_module...e_Controller_AddPackage`, `Intraface_modules_modulepackage_Controller_Index`, `Intraface_modules_modulepackage_Controller_Package`, `Intraface_modules_modulepackage_Controller_Payment`, `Intraface_modules_module...age_Controller_PostForm`, `Intraface_modules_modulepackage_Controller_Process`, `Intraface_modules_newsletter_Controller_Index`, `Intraface_modules_newsletter_Controller_Letter`, `Intraface_modules_newsletter_Controller_Letters`, `Intraface_modules_newsletter_Controller_List`, `Intraface_modules_newsletter_Controller_Lists`, `Intraface_modules_newsletter_Controller_Log`, `Intraface_modules_newsletter_Controller_Send`, `Intraface_modules_newsle..._Controller_Subscribers`, `Intraface_modules_onlinepayment_Controller_Index`, `Intraface_modules_online...ent_Controller_Settings`, `Intraface_modules_payment_Controller_Index`, `Intraface_modules_payment_Controller_Show`, `Intraface_modules_procurement_Controller_Index`, `Intraface_modules_procurement_Controller_Item`, `Intraface_modules_procurement_Controller_Items`, `Intraface_modules_procur...ontroller_PurchasePrice`, `Intraface_modules_procurement_Controller_Show`, `Intraface_modules_produc...troller_AttributeGroups`, `Intraface_modules_produc...tributeGroups_Attribute`, `Intraface_modules_produc...er_AttributeGroups_Show`, `Intraface_modules_product_Controller_BatchEdit`, `Intraface_modules_produc...oller_BatchPriceChanger`, `Intraface_modules_product_Controller_Index`, `Intraface_modules_produc...r_Productattributegroup`, `Intraface_modules_product_Controller_Related`, `Intraface_modules_product_Controller_Selectproduct`, `Intraface_modules_produc..._Selectproductvariation`, `Intraface_modules_product_Controller_Show`, `Intraface_modules_produc...ntroller_Show_PlainText`, `Intraface_modules_produc...troller_Show_Variations`, `Intraface_modules_produc...s_SelectAttributeGroups`, `Intraface_modules_product_Controller_Variation`, `Intraface_modules_shop_C...r_BasketEvaluation_Edit`, `Intraface_modules_shop_C..._BasketEvaluation_Index`, `Intraface_modules_shop_C...r_BasketEvaluation_Show`, `Intraface_modules_shop_Controller_Categories`, `Intraface_modules_shop_C...oller_Categories_Create`, `Intraface_modules_shop_Controller_Categories_Show`, `Intraface_modules_shop_C...oller_DiscountCampaigns`, `Intraface_modules_shop_Controller_FeaturedProducts`, `Intraface_modules_shop_Controller_Index`, `Intraface_modules_shop_Controller_Show`, `Intraface_modules_stock_Controller_Index`, `Intraface_modules_stock_Controller_Product`, `Intraface_modules_stock_Controller_Variations`, `Intraface_modules_todo_Controller_Edit`, `Intraface_modules_todo_Controller_Index`, `Intraface_modules_todo_Controller_Todo`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
7
8			$this->context->getKernel()->useModule('contact');
			0 ignored issues – show Bug introduced 2016-04-20 09:50 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `k_Context` as the method `getKernel()` does only exist in the following implementations of said interface: `Intraface_Controller_Index`, `Intraface_Controller_ModuleGatekeeper`, `Intraface_Controller_ModulePackage_Process`, `Intraface_Controller_Restricted`, `Intraface_Controller_SwitchIntranet`, `Intraface_Filehandler_Controller_Batchedit`, `Intraface_Filehandler_Controller_CKEditor`, `Intraface_Filehandler_Controller_Crop`, `Intraface_Filehandler_Controller_Index`, `Intraface_Filehandler_Controller_SelectFile`, `Intraface_Filehandler_Controller_Show`, `Intraface_Filehandler_Controller_Size`, `Intraface_Filehandler_Controller_Sizes`, `Intraface_Filehandler_Controller_Upload`, `Intraface_Filehandler_Controller_UploadMultiple`, `Intraface_Filehandler_Controller_UploadScript`, `Intraface_Fileimport_Controller_Index`, `Intraface_Keyword_Controller_Connect`, `Intraface_Keyword_Controller_Index`, `Intraface_Keyword_Controller_Show`, `Intraface_modules_accoun...ontroller_Account_Index`, `Intraface_modules_accoun...ontroller_Account_Popup`, `Intraface_modules_accoun...Controller_Account_Show`, `Intraface_modules_accounting_Controller_Daybook`, `Intraface_modules_accounting_Controller_Index`, `Intraface_modules_accounting_Controller_Post_Index`, `Intraface_modules_accounting_Controller_Post_Show`, `Intraface_modules_accounting_Controller_Search`, `Intraface_modules_accounting_Controller_Settings`, `Intraface_modules_accounting_Controller_State`, `Intraface_modules_accoun...roller_State_Creditnote`, `Intraface_modules_accoun...ller_State_Depreciation`, `Intraface_modules_accoun...ontroller_State_Invoice`, `Intraface_modules_accoun...ontroller_State_Payment`, `Intraface_modules_accoun...oller_State_Procurement`, `Intraface_modules_accoun...ntroller_State_Reminder`, `Intraface_modules_accoun...roller_State_SelectYear`, `Intraface_modules_accounting_Controller_Vat_Index`, `Intraface_modules_accounting_Controller_Vat_Show`, `Intraface_modules_accoun...ontroller_Voucher_Index`, `Intraface_modules_accoun...Controller_Voucher_Show`, `Intraface_modules_accounting_Controller_Year_Edit`, `Intraface_modules_accounting_Controller_Year_End`, `Intraface_modules_accounting_Controller_Year_Index`, `Intraface_modules_accoun...troller_Year_Primosaldo`, `Intraface_modules_accounting_Controller_Year_Show`, `Intraface_modules_administration_Controller_Index`, `Intraface_modules_admini...ion_Controller_Intranet`, `Intraface_modules_cms_Controller_Element`, `Intraface_modules_cms_Controller_Elements`, `Intraface_modules_cms_Controller_Index`, `Intraface_modules_cms_Controller_Navigation`, `Intraface_modules_cms_Controller_Page`, `Intraface_modules_cms_Controller_Pages`, `Intraface_modules_cms_Controller_Section`, `Intraface_modules_cms_Controller_Sections`, `Intraface_modules_cms_Controller_Site`, `Intraface_modules_cms_Controller_Stylesheet`, `Intraface_modules_cms_Controller_Template`, `Intraface_modules_cms_Co...ler_TemplateSectionEdit`, `Intraface_modules_cms_Controller_TemplateSections`, `Intraface_modules_cms_Controller_Templates`, `Intraface_modules_contac...troller_BatchNewsletter`, `Intraface_modules_contact_Controller_Choosecontact`, `Intraface_modules_contac...ntroller_Contactpersons`, `Intraface_modules_contact_Controller_Import`, `Intraface_modules_contact_Controller_Index`, `Intraface_modules_contact_Controller_Memos`, `Intraface_modules_contact_Controller_Merge`, `Intraface_modules_contact_Controller_Sendemail`, `Intraface_modules_contact_Controller_Show`, `Intraface_modules_contro...ntroller_ChangePassword`, `Intraface_modules_controlpanel_Controller_Index`, `Intraface_modules_controlpanel_Controller_User`, `Intraface_modules_contro...troller_UserPreferences`, `Intraface_modules_curren...ller_ExchangeRate_Index`, `Intraface_modules_curren...changeRate_ProductPrice`, `Intraface_modules_currency_Controller_Index`, `Intraface_modules_currency_Controller_Show`, `Intraface_modules_debtor_Controller_Collection`, `Intraface_modules_debtor_Controller_Create`, `Intraface_modules_debtor_Controller_Depreciation`, `Intraface_modules_debtor_Controller_Depreciations`, `Intraface_modules_debtor_Controller_Index`, `Intraface_modules_debtor_Controller_Item`, `Intraface_modules_debtor_Controller_Items`, `Intraface_modules_debtor_Controller_Payment`, `Intraface_modules_debtor_Controller_Payments`, `Intraface_modules_debtor_Controller_Reminder`, `Intraface_modules_debtor_Controller_Reminders`, `Intraface_modules_debtor_Controller_Settings`, `Intraface_modules_debtor_Controller_Show`, `Intraface_modules_debtor_Controller_Typenegotiator`, `Intraface_modules_email_Controller_Email`, `Intraface_modules_email_Controller_Index`, `Intraface_modules_fileimport_Controller_Index`, `Intraface_modules_filemanager_Controller_Index`, `Intraface_modules_intran...enance_Controller_Index`, `Intraface_modules_intran...ntroller_Intranet_Index`, `Intraface_modules_intran...Controller_Intranet_Key`, `Intraface_modules_intran...ler_Intranet_Permission`, `Intraface_modules_intran...ontroller_Intranet_Show`, `Intraface_modules_intran...ance_Controller_Modules`, `Intraface_modules_intran...e_Controller_User_Index`, `Intraface_modules_intran...troller_User_Permission`, `Intraface_modules_intran...ce_Controller_User_Show`, `Intraface_modules_module...e_Controller_AddPackage`, `Intraface_modules_modulepackage_Controller_Index`, `Intraface_modules_modulepackage_Controller_Package`, `Intraface_modules_modulepackage_Controller_Payment`, `Intraface_modules_module...age_Controller_PostForm`, `Intraface_modules_modulepackage_Controller_Process`, `Intraface_modules_newsletter_Controller_Index`, `Intraface_modules_newsletter_Controller_Letter`, `Intraface_modules_newsletter_Controller_Letters`, `Intraface_modules_newsletter_Controller_List`, `Intraface_modules_newsletter_Controller_Lists`, `Intraface_modules_newsletter_Controller_Log`, `Intraface_modules_newsletter_Controller_Send`, `Intraface_modules_newsle..._Controller_Subscribers`, `Intraface_modules_onlinepayment_Controller_Index`, `Intraface_modules_online...ent_Controller_Settings`, `Intraface_modules_payment_Controller_Index`, `Intraface_modules_payment_Controller_Show`, `Intraface_modules_procurement_Controller_Index`, `Intraface_modules_procurement_Controller_Item`, `Intraface_modules_procurement_Controller_Items`, `Intraface_modules_procur...ontroller_PurchasePrice`, `Intraface_modules_procurement_Controller_Show`, `Intraface_modules_produc...troller_AttributeGroups`, `Intraface_modules_produc...tributeGroups_Attribute`, `Intraface_modules_produc...er_AttributeGroups_Show`, `Intraface_modules_product_Controller_BatchEdit`, `Intraface_modules_produc...oller_BatchPriceChanger`, `Intraface_modules_product_Controller_Index`, `Intraface_modules_produc...r_Productattributegroup`, `Intraface_modules_product_Controller_Related`, `Intraface_modules_product_Controller_Selectproduct`, `Intraface_modules_produc..._Selectproductvariation`, `Intraface_modules_product_Controller_Show`, `Intraface_modules_produc...ntroller_Show_PlainText`, `Intraface_modules_produc...troller_Show_Variations`, `Intraface_modules_produc...s_SelectAttributeGroups`, `Intraface_modules_product_Controller_Variation`, `Intraface_modules_shop_C...r_BasketEvaluation_Edit`, `Intraface_modules_shop_C..._BasketEvaluation_Index`, `Intraface_modules_shop_C...r_BasketEvaluation_Show`, `Intraface_modules_shop_Controller_Categories`, `Intraface_modules_shop_C...oller_Categories_Create`, `Intraface_modules_shop_Controller_Categories_Show`, `Intraface_modules_shop_C...oller_DiscountCampaigns`, `Intraface_modules_shop_Controller_FeaturedProducts`, `Intraface_modules_shop_Controller_Index`, `Intraface_modules_shop_Controller_Show`, `Intraface_modules_stock_Controller_Index`, `Intraface_modules_stock_Controller_Product`, `Intraface_modules_stock_Controller_Variations`, `Intraface_modules_todo_Controller_Edit`, `Intraface_modules_todo_Controller_Index`, `Intraface_modules_todo_Controller_Todo`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
9			$this->context->getKernel()->useModule('product');
			0 ignored issues – show Bug introduced 2016-04-20 09:50 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `k_Context` as the method `getKernel()` does only exist in the following implementations of said interface: `Intraface_Controller_Index`, `Intraface_Controller_ModuleGatekeeper`, `Intraface_Controller_ModulePackage_Process`, `Intraface_Controller_Restricted`, `Intraface_Controller_SwitchIntranet`, `Intraface_Filehandler_Controller_Batchedit`, `Intraface_Filehandler_Controller_CKEditor`, `Intraface_Filehandler_Controller_Crop`, `Intraface_Filehandler_Controller_Index`, `Intraface_Filehandler_Controller_SelectFile`, `Intraface_Filehandler_Controller_Show`, `Intraface_Filehandler_Controller_Size`, `Intraface_Filehandler_Controller_Sizes`, `Intraface_Filehandler_Controller_Upload`, `Intraface_Filehandler_Controller_UploadMultiple`, `Intraface_Filehandler_Controller_UploadScript`, `Intraface_Fileimport_Controller_Index`, `Intraface_Keyword_Controller_Connect`, `Intraface_Keyword_Controller_Index`, `Intraface_Keyword_Controller_Show`, `Intraface_modules_accoun...ontroller_Account_Index`, `Intraface_modules_accoun...ontroller_Account_Popup`, `Intraface_modules_accoun...Controller_Account_Show`, `Intraface_modules_accounting_Controller_Daybook`, `Intraface_modules_accounting_Controller_Index`, `Intraface_modules_accounting_Controller_Post_Index`, `Intraface_modules_accounting_Controller_Post_Show`, `Intraface_modules_accounting_Controller_Search`, `Intraface_modules_accounting_Controller_Settings`, `Intraface_modules_accounting_Controller_State`, `Intraface_modules_accoun...roller_State_Creditnote`, `Intraface_modules_accoun...ller_State_Depreciation`, `Intraface_modules_accoun...ontroller_State_Invoice`, `Intraface_modules_accoun...ontroller_State_Payment`, `Intraface_modules_accoun...oller_State_Procurement`, `Intraface_modules_accoun...ntroller_State_Reminder`, `Intraface_modules_accoun...roller_State_SelectYear`, `Intraface_modules_accounting_Controller_Vat_Index`, `Intraface_modules_accounting_Controller_Vat_Show`, `Intraface_modules_accoun...ontroller_Voucher_Index`, `Intraface_modules_accoun...Controller_Voucher_Show`, `Intraface_modules_accounting_Controller_Year_Edit`, `Intraface_modules_accounting_Controller_Year_End`, `Intraface_modules_accounting_Controller_Year_Index`, `Intraface_modules_accoun...troller_Year_Primosaldo`, `Intraface_modules_accounting_Controller_Year_Show`, `Intraface_modules_administration_Controller_Index`, `Intraface_modules_admini...ion_Controller_Intranet`, `Intraface_modules_cms_Controller_Element`, `Intraface_modules_cms_Controller_Elements`, `Intraface_modules_cms_Controller_Index`, `Intraface_modules_cms_Controller_Navigation`, `Intraface_modules_cms_Controller_Page`, `Intraface_modules_cms_Controller_Pages`, `Intraface_modules_cms_Controller_Section`, `Intraface_modules_cms_Controller_Sections`, `Intraface_modules_cms_Controller_Site`, `Intraface_modules_cms_Controller_Stylesheet`, `Intraface_modules_cms_Controller_Template`, `Intraface_modules_cms_Co...ler_TemplateSectionEdit`, `Intraface_modules_cms_Controller_TemplateSections`, `Intraface_modules_cms_Controller_Templates`, `Intraface_modules_contac...troller_BatchNewsletter`, `Intraface_modules_contact_Controller_Choosecontact`, `Intraface_modules_contac...ntroller_Contactpersons`, `Intraface_modules_contact_Controller_Import`, `Intraface_modules_contact_Controller_Index`, `Intraface_modules_contact_Controller_Memos`, `Intraface_modules_contact_Controller_Merge`, `Intraface_modules_contact_Controller_Sendemail`, `Intraface_modules_contact_Controller_Show`, `Intraface_modules_contro...ntroller_ChangePassword`, `Intraface_modules_controlpanel_Controller_Index`, `Intraface_modules_controlpanel_Controller_User`, `Intraface_modules_contro...troller_UserPreferences`, `Intraface_modules_curren...ller_ExchangeRate_Index`, `Intraface_modules_curren...changeRate_ProductPrice`, `Intraface_modules_currency_Controller_Index`, `Intraface_modules_currency_Controller_Show`, `Intraface_modules_debtor_Controller_Collection`, `Intraface_modules_debtor_Controller_Create`, `Intraface_modules_debtor_Controller_Depreciation`, `Intraface_modules_debtor_Controller_Depreciations`, `Intraface_modules_debtor_Controller_Index`, `Intraface_modules_debtor_Controller_Item`, `Intraface_modules_debtor_Controller_Items`, `Intraface_modules_debtor_Controller_Payment`, `Intraface_modules_debtor_Controller_Payments`, `Intraface_modules_debtor_Controller_Reminder`, `Intraface_modules_debtor_Controller_Reminders`, `Intraface_modules_debtor_Controller_Settings`, `Intraface_modules_debtor_Controller_Show`, `Intraface_modules_debtor_Controller_Typenegotiator`, `Intraface_modules_email_Controller_Email`, `Intraface_modules_email_Controller_Index`, `Intraface_modules_fileimport_Controller_Index`, `Intraface_modules_filemanager_Controller_Index`, `Intraface_modules_intran...enance_Controller_Index`, `Intraface_modules_intran...ntroller_Intranet_Index`, `Intraface_modules_intran...Controller_Intranet_Key`, `Intraface_modules_intran...ler_Intranet_Permission`, `Intraface_modules_intran...ontroller_Intranet_Show`, `Intraface_modules_intran...ance_Controller_Modules`, `Intraface_modules_intran...e_Controller_User_Index`, `Intraface_modules_intran...troller_User_Permission`, `Intraface_modules_intran...ce_Controller_User_Show`, `Intraface_modules_module...e_Controller_AddPackage`, `Intraface_modules_modulepackage_Controller_Index`, `Intraface_modules_modulepackage_Controller_Package`, `Intraface_modules_modulepackage_Controller_Payment`, `Intraface_modules_module...age_Controller_PostForm`, `Intraface_modules_modulepackage_Controller_Process`, `Intraface_modules_newsletter_Controller_Index`, `Intraface_modules_newsletter_Controller_Letter`, `Intraface_modules_newsletter_Controller_Letters`, `Intraface_modules_newsletter_Controller_List`, `Intraface_modules_newsletter_Controller_Lists`, `Intraface_modules_newsletter_Controller_Log`, `Intraface_modules_newsletter_Controller_Send`, `Intraface_modules_newsle..._Controller_Subscribers`, `Intraface_modules_onlinepayment_Controller_Index`, `Intraface_modules_online...ent_Controller_Settings`, `Intraface_modules_payment_Controller_Index`, `Intraface_modules_payment_Controller_Show`, `Intraface_modules_procurement_Controller_Index`, `Intraface_modules_procurement_Controller_Item`, `Intraface_modules_procurement_Controller_Items`, `Intraface_modules_procur...ontroller_PurchasePrice`, `Intraface_modules_procurement_Controller_Show`, `Intraface_modules_produc...troller_AttributeGroups`, `Intraface_modules_produc...tributeGroups_Attribute`, `Intraface_modules_produc...er_AttributeGroups_Show`, `Intraface_modules_product_Controller_BatchEdit`, `Intraface_modules_produc...oller_BatchPriceChanger`, `Intraface_modules_product_Controller_Index`, `Intraface_modules_produc...r_Productattributegroup`, `Intraface_modules_product_Controller_Related`, `Intraface_modules_product_Controller_Selectproduct`, `Intraface_modules_produc..._Selectproductvariation`, `Intraface_modules_product_Controller_Show`, `Intraface_modules_produc...ntroller_Show_PlainText`, `Intraface_modules_produc...troller_Show_Variations`, `Intraface_modules_produc...s_SelectAttributeGroups`, `Intraface_modules_product_Controller_Variation`, `Intraface_modules_shop_C...r_BasketEvaluation_Edit`, `Intraface_modules_shop_C..._BasketEvaluation_Index`, `Intraface_modules_shop_C...r_BasketEvaluation_Show`, `Intraface_modules_shop_Controller_Categories`, `Intraface_modules_shop_C...oller_Categories_Create`, `Intraface_modules_shop_Controller_Categories_Show`, `Intraface_modules_shop_C...oller_DiscountCampaigns`, `Intraface_modules_shop_Controller_FeaturedProducts`, `Intraface_modules_shop_Controller_Index`, `Intraface_modules_shop_Controller_Show`, `Intraface_modules_stock_Controller_Index`, `Intraface_modules_stock_Controller_Product`, `Intraface_modules_stock_Controller_Variations`, `Intraface_modules_todo_Controller_Edit`, `Intraface_modules_todo_Controller_Index`, `Intraface_modules_todo_Controller_Todo`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
10			$this->context->getKernel()->useModule('filemanager');
			0 ignored issues – show Bug introduced 2016-04-20 09:50 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `k_Context` as the method `getKernel()` does only exist in the following implementations of said interface: `Intraface_Controller_Index`, `Intraface_Controller_ModuleGatekeeper`, `Intraface_Controller_ModulePackage_Process`, `Intraface_Controller_Restricted`, `Intraface_Controller_SwitchIntranet`, `Intraface_Filehandler_Controller_Batchedit`, `Intraface_Filehandler_Controller_CKEditor`, `Intraface_Filehandler_Controller_Crop`, `Intraface_Filehandler_Controller_Index`, `Intraface_Filehandler_Controller_SelectFile`, `Intraface_Filehandler_Controller_Show`, `Intraface_Filehandler_Controller_Size`, `Intraface_Filehandler_Controller_Sizes`, `Intraface_Filehandler_Controller_Upload`, `Intraface_Filehandler_Controller_UploadMultiple`, `Intraface_Filehandler_Controller_UploadScript`, `Intraface_Fileimport_Controller_Index`, `Intraface_Keyword_Controller_Connect`, `Intraface_Keyword_Controller_Index`, `Intraface_Keyword_Controller_Show`, `Intraface_modules_accoun...ontroller_Account_Index`, `Intraface_modules_accoun...ontroller_Account_Popup`, `Intraface_modules_accoun...Controller_Account_Show`, `Intraface_modules_accounting_Controller_Daybook`, `Intraface_modules_accounting_Controller_Index`, `Intraface_modules_accounting_Controller_Post_Index`, `Intraface_modules_accounting_Controller_Post_Show`, `Intraface_modules_accounting_Controller_Search`, `Intraface_modules_accounting_Controller_Settings`, `Intraface_modules_accounting_Controller_State`, `Intraface_modules_accoun...roller_State_Creditnote`, `Intraface_modules_accoun...ller_State_Depreciation`, `Intraface_modules_accoun...ontroller_State_Invoice`, `Intraface_modules_accoun...ontroller_State_Payment`, `Intraface_modules_accoun...oller_State_Procurement`, `Intraface_modules_accoun...ntroller_State_Reminder`, `Intraface_modules_accoun...roller_State_SelectYear`, `Intraface_modules_accounting_Controller_Vat_Index`, `Intraface_modules_accounting_Controller_Vat_Show`, `Intraface_modules_accoun...ontroller_Voucher_Index`, `Intraface_modules_accoun...Controller_Voucher_Show`, `Intraface_modules_accounting_Controller_Year_Edit`, `Intraface_modules_accounting_Controller_Year_End`, `Intraface_modules_accounting_Controller_Year_Index`, `Intraface_modules_accoun...troller_Year_Primosaldo`, `Intraface_modules_accounting_Controller_Year_Show`, `Intraface_modules_administration_Controller_Index`, `Intraface_modules_admini...ion_Controller_Intranet`, `Intraface_modules_cms_Controller_Element`, `Intraface_modules_cms_Controller_Elements`, `Intraface_modules_cms_Controller_Index`, `Intraface_modules_cms_Controller_Navigation`, `Intraface_modules_cms_Controller_Page`, `Intraface_modules_cms_Controller_Pages`, `Intraface_modules_cms_Controller_Section`, `Intraface_modules_cms_Controller_Sections`, `Intraface_modules_cms_Controller_Site`, `Intraface_modules_cms_Controller_Stylesheet`, `Intraface_modules_cms_Controller_Template`, `Intraface_modules_cms_Co...ler_TemplateSectionEdit`, `Intraface_modules_cms_Controller_TemplateSections`, `Intraface_modules_cms_Controller_Templates`, `Intraface_modules_contac...troller_BatchNewsletter`, `Intraface_modules_contact_Controller_Choosecontact`, `Intraface_modules_contac...ntroller_Contactpersons`, `Intraface_modules_contact_Controller_Import`, `Intraface_modules_contact_Controller_Index`, `Intraface_modules_contact_Controller_Memos`, `Intraface_modules_contact_Controller_Merge`, `Intraface_modules_contact_Controller_Sendemail`, `Intraface_modules_contact_Controller_Show`, `Intraface_modules_contro...ntroller_ChangePassword`, `Intraface_modules_controlpanel_Controller_Index`, `Intraface_modules_controlpanel_Controller_User`, `Intraface_modules_contro...troller_UserPreferences`, `Intraface_modules_curren...ller_ExchangeRate_Index`, `Intraface_modules_curren...changeRate_ProductPrice`, `Intraface_modules_currency_Controller_Index`, `Intraface_modules_currency_Controller_Show`, `Intraface_modules_debtor_Controller_Collection`, `Intraface_modules_debtor_Controller_Create`, `Intraface_modules_debtor_Controller_Depreciation`, `Intraface_modules_debtor_Controller_Depreciations`, `Intraface_modules_debtor_Controller_Index`, `Intraface_modules_debtor_Controller_Item`, `Intraface_modules_debtor_Controller_Items`, `Intraface_modules_debtor_Controller_Payment`, `Intraface_modules_debtor_Controller_Payments`, `Intraface_modules_debtor_Controller_Reminder`, `Intraface_modules_debtor_Controller_Reminders`, `Intraface_modules_debtor_Controller_Settings`, `Intraface_modules_debtor_Controller_Show`, `Intraface_modules_debtor_Controller_Typenegotiator`, `Intraface_modules_email_Controller_Email`, `Intraface_modules_email_Controller_Index`, `Intraface_modules_fileimport_Controller_Index`, `Intraface_modules_filemanager_Controller_Index`, `Intraface_modules_intran...enance_Controller_Index`, `Intraface_modules_intran...ntroller_Intranet_Index`, `Intraface_modules_intran...Controller_Intranet_Key`, `Intraface_modules_intran...ler_Intranet_Permission`, `Intraface_modules_intran...ontroller_Intranet_Show`, `Intraface_modules_intran...ance_Controller_Modules`, `Intraface_modules_intran...e_Controller_User_Index`, `Intraface_modules_intran...troller_User_Permission`, `Intraface_modules_intran...ce_Controller_User_Show`, `Intraface_modules_module...e_Controller_AddPackage`, `Intraface_modules_modulepackage_Controller_Index`, `Intraface_modules_modulepackage_Controller_Package`, `Intraface_modules_modulepackage_Controller_Payment`, `Intraface_modules_module...age_Controller_PostForm`, `Intraface_modules_modulepackage_Controller_Process`, `Intraface_modules_newsletter_Controller_Index`, `Intraface_modules_newsletter_Controller_Letter`, `Intraface_modules_newsletter_Controller_Letters`, `Intraface_modules_newsletter_Controller_List`, `Intraface_modules_newsletter_Controller_Lists`, `Intraface_modules_newsletter_Controller_Log`, `Intraface_modules_newsletter_Controller_Send`, `Intraface_modules_newsle..._Controller_Subscribers`, `Intraface_modules_onlinepayment_Controller_Index`, `Intraface_modules_online...ent_Controller_Settings`, `Intraface_modules_payment_Controller_Index`, `Intraface_modules_payment_Controller_Show`, `Intraface_modules_procurement_Controller_Index`, `Intraface_modules_procurement_Controller_Item`, `Intraface_modules_procurement_Controller_Items`, `Intraface_modules_procur...ontroller_PurchasePrice`, `Intraface_modules_procurement_Controller_Show`, `Intraface_modules_produc...troller_AttributeGroups`, `Intraface_modules_produc...tributeGroups_Attribute`, `Intraface_modules_produc...er_AttributeGroups_Show`, `Intraface_modules_product_Controller_BatchEdit`, `Intraface_modules_produc...oller_BatchPriceChanger`, `Intraface_modules_product_Controller_Index`, `Intraface_modules_produc...r_Productattributegroup`, `Intraface_modules_product_Controller_Related`, `Intraface_modules_product_Controller_Selectproduct`, `Intraface_modules_produc..._Selectproductvariation`, `Intraface_modules_product_Controller_Show`, `Intraface_modules_produc...ntroller_Show_PlainText`, `Intraface_modules_produc...troller_Show_Variations`, `Intraface_modules_produc...s_SelectAttributeGroups`, `Intraface_modules_product_Controller_Variation`, `Intraface_modules_shop_C...r_BasketEvaluation_Edit`, `Intraface_modules_shop_C..._BasketEvaluation_Index`, `Intraface_modules_shop_C...r_BasketEvaluation_Show`, `Intraface_modules_shop_Controller_Categories`, `Intraface_modules_shop_C...oller_Categories_Create`, `Intraface_modules_shop_Controller_Categories_Show`, `Intraface_modules_shop_C...oller_DiscountCampaigns`, `Intraface_modules_shop_Controller_FeaturedProducts`, `Intraface_modules_shop_Controller_Index`, `Intraface_modules_shop_Controller_Show`, `Intraface_modules_stock_Controller_Index`, `Intraface_modules_stock_Controller_Product`, `Intraface_modules_stock_Controller_Variations`, `Intraface_modules_todo_Controller_Edit`, `Intraface_modules_todo_Controller_Index`, `Intraface_modules_todo_Controller_Todo`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
11			$this->context->getKernel()->useShared('email');
			0 ignored issues – show Bug introduced 2016-04-20 09:50 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `k_Context` as the method `getKernel()` does only exist in the following implementations of said interface: `Intraface_Controller_Index`, `Intraface_Controller_ModuleGatekeeper`, `Intraface_Controller_ModulePackage_Process`, `Intraface_Controller_Restricted`, `Intraface_Controller_SwitchIntranet`, `Intraface_Filehandler_Controller_Batchedit`, `Intraface_Filehandler_Controller_CKEditor`, `Intraface_Filehandler_Controller_Crop`, `Intraface_Filehandler_Controller_Index`, `Intraface_Filehandler_Controller_SelectFile`, `Intraface_Filehandler_Controller_Show`, `Intraface_Filehandler_Controller_Size`, `Intraface_Filehandler_Controller_Sizes`, `Intraface_Filehandler_Controller_Upload`, `Intraface_Filehandler_Controller_UploadMultiple`, `Intraface_Filehandler_Controller_UploadScript`, `Intraface_Fileimport_Controller_Index`, `Intraface_Keyword_Controller_Connect`, `Intraface_Keyword_Controller_Index`, `Intraface_Keyword_Controller_Show`, `Intraface_modules_accoun...ontroller_Account_Index`, `Intraface_modules_accoun...ontroller_Account_Popup`, `Intraface_modules_accoun...Controller_Account_Show`, `Intraface_modules_accounting_Controller_Daybook`, `Intraface_modules_accounting_Controller_Index`, `Intraface_modules_accounting_Controller_Post_Index`, `Intraface_modules_accounting_Controller_Post_Show`, `Intraface_modules_accounting_Controller_Search`, `Intraface_modules_accounting_Controller_Settings`, `Intraface_modules_accounting_Controller_State`, `Intraface_modules_accoun...roller_State_Creditnote`, `Intraface_modules_accoun...ller_State_Depreciation`, `Intraface_modules_accoun...ontroller_State_Invoice`, `Intraface_modules_accoun...ontroller_State_Payment`, `Intraface_modules_accoun...oller_State_Procurement`, `Intraface_modules_accoun...ntroller_State_Reminder`, `Intraface_modules_accoun...roller_State_SelectYear`, `Intraface_modules_accounting_Controller_Vat_Index`, `Intraface_modules_accounting_Controller_Vat_Show`, `Intraface_modules_accoun...ontroller_Voucher_Index`, `Intraface_modules_accoun...Controller_Voucher_Show`, `Intraface_modules_accounting_Controller_Year_Edit`, `Intraface_modules_accounting_Controller_Year_End`, `Intraface_modules_accounting_Controller_Year_Index`, `Intraface_modules_accoun...troller_Year_Primosaldo`, `Intraface_modules_accounting_Controller_Year_Show`, `Intraface_modules_administration_Controller_Index`, `Intraface_modules_admini...ion_Controller_Intranet`, `Intraface_modules_cms_Controller_Element`, `Intraface_modules_cms_Controller_Elements`, `Intraface_modules_cms_Controller_Index`, `Intraface_modules_cms_Controller_Navigation`, `Intraface_modules_cms_Controller_Page`, `Intraface_modules_cms_Controller_Pages`, `Intraface_modules_cms_Controller_Section`, `Intraface_modules_cms_Controller_Sections`, `Intraface_modules_cms_Controller_Site`, `Intraface_modules_cms_Controller_Stylesheet`, `Intraface_modules_cms_Controller_Template`, `Intraface_modules_cms_Co...ler_TemplateSectionEdit`, `Intraface_modules_cms_Controller_TemplateSections`, `Intraface_modules_cms_Controller_Templates`, `Intraface_modules_contac...troller_BatchNewsletter`, `Intraface_modules_contact_Controller_Choosecontact`, `Intraface_modules_contac...ntroller_Contactpersons`, `Intraface_modules_contact_Controller_Import`, `Intraface_modules_contact_Controller_Index`, `Intraface_modules_contact_Controller_Memos`, `Intraface_modules_contact_Controller_Merge`, `Intraface_modules_contact_Controller_Sendemail`, `Intraface_modules_contact_Controller_Show`, `Intraface_modules_contro...ntroller_ChangePassword`, `Intraface_modules_controlpanel_Controller_Index`, `Intraface_modules_controlpanel_Controller_User`, `Intraface_modules_contro...troller_UserPreferences`, `Intraface_modules_curren...ller_ExchangeRate_Index`, `Intraface_modules_curren...changeRate_ProductPrice`, `Intraface_modules_currency_Controller_Index`, `Intraface_modules_currency_Controller_Show`, `Intraface_modules_debtor_Controller_Collection`, `Intraface_modules_debtor_Controller_Create`, `Intraface_modules_debtor_Controller_Depreciation`, `Intraface_modules_debtor_Controller_Depreciations`, `Intraface_modules_debtor_Controller_Index`, `Intraface_modules_debtor_Controller_Item`, `Intraface_modules_debtor_Controller_Items`, `Intraface_modules_debtor_Controller_Payment`, `Intraface_modules_debtor_Controller_Payments`, `Intraface_modules_debtor_Controller_Reminder`, `Intraface_modules_debtor_Controller_Reminders`, `Intraface_modules_debtor_Controller_Settings`, `Intraface_modules_debtor_Controller_Show`, `Intraface_modules_debtor_Controller_Typenegotiator`, `Intraface_modules_email_Controller_Email`, `Intraface_modules_email_Controller_Index`, `Intraface_modules_fileimport_Controller_Index`, `Intraface_modules_filemanager_Controller_Index`, `Intraface_modules_intran...enance_Controller_Index`, `Intraface_modules_intran...ntroller_Intranet_Index`, `Intraface_modules_intran...Controller_Intranet_Key`, `Intraface_modules_intran...ler_Intranet_Permission`, `Intraface_modules_intran...ontroller_Intranet_Show`, `Intraface_modules_intran...ance_Controller_Modules`, `Intraface_modules_intran...e_Controller_User_Index`, `Intraface_modules_intran...troller_User_Permission`, `Intraface_modules_intran...ce_Controller_User_Show`, `Intraface_modules_module...e_Controller_AddPackage`, `Intraface_modules_modulepackage_Controller_Index`, `Intraface_modules_modulepackage_Controller_Package`, `Intraface_modules_modulepackage_Controller_Payment`, `Intraface_modules_module...age_Controller_PostForm`, `Intraface_modules_modulepackage_Controller_Process`, `Intraface_modules_newsletter_Controller_Index`, `Intraface_modules_newsletter_Controller_Letter`, `Intraface_modules_newsletter_Controller_Letters`, `Intraface_modules_newsletter_Controller_List`, `Intraface_modules_newsletter_Controller_Lists`, `Intraface_modules_newsletter_Controller_Log`, `Intraface_modules_newsletter_Controller_Send`, `Intraface_modules_newsle..._Controller_Subscribers`, `Intraface_modules_onlinepayment_Controller_Index`, `Intraface_modules_online...ent_Controller_Settings`, `Intraface_modules_payment_Controller_Index`, `Intraface_modules_payment_Controller_Show`, `Intraface_modules_procurement_Controller_Index`, `Intraface_modules_procurement_Controller_Item`, `Intraface_modules_procurement_Controller_Items`, `Intraface_modules_procur...ontroller_PurchasePrice`, `Intraface_modules_procurement_Controller_Show`, `Intraface_modules_produc...troller_AttributeGroups`, `Intraface_modules_produc...tributeGroups_Attribute`, `Intraface_modules_produc...er_AttributeGroups_Show`, `Intraface_modules_product_Controller_BatchEdit`, `Intraface_modules_produc...oller_BatchPriceChanger`, `Intraface_modules_product_Controller_Index`, `Intraface_modules_produc...r_Productattributegroup`, `Intraface_modules_product_Controller_Related`, `Intraface_modules_product_Controller_Selectproduct`, `Intraface_modules_produc..._Selectproductvariation`, `Intraface_modules_product_Controller_Show`, `Intraface_modules_produc...ntroller_Show_PlainText`, `Intraface_modules_produc...troller_Show_Variations`, `Intraface_modules_produc...s_SelectAttributeGroups`, `Intraface_modules_product_Controller_Variation`, `Intraface_modules_shop_C...r_BasketEvaluation_Edit`, `Intraface_modules_shop_C..._BasketEvaluation_Index`, `Intraface_modules_shop_C...r_BasketEvaluation_Show`, `Intraface_modules_shop_Controller_Categories`, `Intraface_modules_shop_C...oller_Categories_Create`, `Intraface_modules_shop_Controller_Categories_Show`, `Intraface_modules_shop_C...oller_DiscountCampaigns`, `Intraface_modules_shop_Controller_FeaturedProducts`, `Intraface_modules_shop_Controller_Index`, `Intraface_modules_shop_Controller_Show`, `Intraface_modules_stock_Controller_Index`, `Intraface_modules_stock_Controller_Product`, `Intraface_modules_stock_Controller_Variations`, `Intraface_modules_todo_Controller_Edit`, `Intraface_modules_todo_Controller_Index`, `Intraface_modules_todo_Controller_Todo`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
12
13			$translation = $this->translator();
14
15			// find debtoren
16			$debtor = $this->context->getDebtor();
			0 ignored issues – show Bug introduced 2016-04-20 09:50 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `k_Context` as the method `getDebtor()` does only exist in the following implementations of said interface: `Intraface_modules_accoun...ller_State_Depreciation`, `Intraface_modules_accoun...ontroller_State_Invoice`, `Intraface_modules_debtor_Controller_Create`, `Intraface_modules_debtor_Controller_Depreciation`, `Intraface_modules_debtor_Controller_Depreciations`, `Intraface_modules_debtor_Controller_Item`, `Intraface_modules_debtor_Controller_Items`, `Intraface_modules_debtor_Controller_Payment`, `Intraface_modules_debtor_Controller_Show`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
17
18			switch ($this->query('send')) {
19			case 'email':
20			$contact = $debtor->getContact();
21			if (!$contact->address->get('email')) {
22			throw new Exception('Der er ikke angivet nogen e-mail til kunden');
23			}
24
25			if ($debtor->contact->get('preferred_invoice') <> 2) { // email
26			throw new Exception('Kunden foretrækker ikke post på e-mail');
27			}
28
29			// vi skal lige have oversat den her rigtigt
30			$subject = $translation->get($debtor->get('type')) . ' #' . $debtor->get('number');
31
32			// hvad skal den skrive her?
33			if ($debtor->get('type') == 'order') {
34			$body = $this->context->getKernel()->getSetting()->get('intranet', 'debtor.order.email.text');

intraface / intraface.dk

renderHtml() F last analyzed 2017-03-20 12:20 UTC

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method Complexity

Long Method

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

renderHtml() F
last analyzed 2017-03-20 12:20 UTC