+global\Intraface_modules_cms_PageGateway::findAllBySite()

Complexity

Conditions	27
Paths	8162

Size

Total Lines	160
Code Lines	88

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	67
CRAP Score	50.0688

Importance

Changes

0

<?php
    function findAllBySite($site, $page = null)
    {
        $this->cmssite = $site;
        $pages = array();

$pages is not used, you could remove the assignment.

        if ($this->getDBQuery()->checkFilter('type') && $this->getDBQuery()->getFilter('page') == 'all') {

This if statement is empty and can be removed.

            // no condition isset
            // $sql_type = "";

43% of this comment could be valid code. Did you maybe forget this after debugging?

        } else {
            // with int it will never be a fake searcy
            $type = $this->getDBQuery()->getFilter('type');
            if ($type == '') {
                $type = 'page'; // Standard
            }

            if ($type != 'all') {
                $type_key = array_search($type, $this->getTypes());
                if ($type_key === false) {
                    throw new Exception("Invalid type '".$type."' set with CMS_PAGE::dbquery::setFilter('type') in CMS_Page::getList");
                }

                $this->getDBQuery()->setCondition("type_key = ".$type_key);
            }
        }


        // hvis en henter siderne uden for systemet
        $sql_expire = '';

$sql_expire is not used, you could remove the assignment.

        $sql_publish = '';

$sql_publish is not used, you could remove the assignment.

        // @todo This need to be corrected
        if (!is_object($this->kernel->user)) {
            $this->getDBQuery()->setCondition("(date_expire > NOW() OR date_expire = '0000-00-00 00:00:00') AND (date_publish < NOW() AND status_key > 0 AND hidden = 0)");
        }

        switch ($this->getDBQuery()->getFilter('type')) {
            case 'page':
                $this->getDBQuery()->setSorting("position ASC");
                break;
            case 'news':
                $this->getDBQuery()->setSorting("date_publish DESC");
                break;
            case 'article':
                $this->getDBQuery()->setSorting("position, date_publish DESC");
                break;
            default:
                $this->getDBQuery()->setSorting("date_publish DESC");
                break;
        }

        // rekursiv funktion til at vise siderne
        $pages = array();
        $go = true;

$go is not used, you could remove the assignment.

        $n = 0; // level
        // $o = 0; //

38% of this comment could be valid code. Did you maybe forget this after debugging?

        $i = 0; // page counter
        // $level = 1;

43% of this comment could be valid code. Did you maybe forget this after debugging?

        $cmspage = array();
        $cmspage[0] = new DB_Sql;

        // Benyttes til undersider.
        $dbquery_original = clone $this->getDBQuery();
        $dbquery_original->storeResult('', '', 'toplevel'); // sikre at der ikke bliver gemt ved undermenuer.


        $keywords = $this->getDBQuery()->getKeyword();
        if (isset($keywords) && is_array($keywords) && count($keywords) > 0 && $type == 'page') {

This if statement is empty and can be removed.

            // If we are looking for pages, and there is keywords, we probaly want from more than one level
            // So we add nothing about level to condition.
        } elseif ($this->getDBQuery()->checkFilter('level') && $type == 'page') { // $level == 'sublevel' &&

The variable $type does not seem to be defined for all execution paths leading up to this point.

38% of this comment could be valid code. Did you maybe forget this after debugging?

            // Til at finde hele menuen p� valgt level.
            $page_tree = $page->get('page_tree');
            $level = (int)$this->getDBQuery()->getFilter('level');
            if (isset($page_tree[$level - 1]) && is_array($page_tree[$level - 1])) {
                $child_of_id = $page_tree[$level - 1]['id'];
            } else {
                $child_of_id = 0;
            }

            $this->getDBQuery()->setCondition('child_of_id = '.$child_of_id);
            // $cmspage[0]->query("SELECT *, DATE_FORMAT(date_publish, '%d-%m-%Y') AS date_publish_dk FROM cms_page WHERE active=1 AND child_of_id = ".$this->id. $sql_expire . $sql_publish . " ORDER BY id");

54% of this comment could be valid code. Did you maybe forget this after debugging?

        } else {
            $this->getDBQuery()->setCondition('child_of_id = 0');
            // $cmspage[0]->query("SELECT *, DATE_FORMAT(date_publish, '%d-%m-%Y') AS date_publish_dk FROM cms_page WHERE ".$sql_type." site_id = " . $this->cmssite->get('id') . " AND child_of_id = 0 AND active = 1 " . $sql_expire . $sql_publish . $sql_order);

50% of this comment could be valid code. Did you maybe forget this after debugging?

        }

        $cmspage[0] = $this->getDBQuery()->getRecordset("cms_page.id, title, identifier, status_key, navigation_name, date_publish, child_of_id, pic_id, description, DATE_FORMAT(date_publish, '%d-%m-%Y') AS date_publish_dk", '', false); //

        while (true) {
            while ($cmspage[$n]->nextRecord()) {
                $pages[$i]['id'] = $cmspage[$n]->f('id');

                $pages[$i]['title'] = $cmspage[$n]->f('title');
                $pages[$i]['identifier'] = $cmspage[$n]->f('identifier');
                $pages[$i]['navigation_name'] = $cmspage[$n]->f('navigation_name');
                $pages[$i]['date_publish_dk'] = $cmspage[$n]->f('date_publish_dk');
                $pages[$i]['date_publish'] = $cmspage[$n]->f('date_publish');
                $pages[$i]['child_of_id'] = $cmspage[$n]->f('child_of_id');
                $pages[$i]['level'] = $n;

                if (empty($pages[$i]['identifier'])) {
                    $pages[$i]['identifier'] = $pages[$i]['id'];
                }
                if (empty($pages[$i]['navigation_name'])) {
                    $pages[$i]['navigation_name'] = $pages[$i]['title'];
                }

                $pages[$i]['status'] = $this->status_types[$cmspage[$n]->f('status_key')];

                // @todo hvad er det her til
                $pages[$i]['new_status'] = 'published';
                if ($pages[$i]['status'] == 'published') {
                    $pages[$i]['new_status'] = 'draft';
                }
                // hertil slut

                // denne b�r laves om til picture - og s� f�r man alle nyttige oplysninger ud
                $pages[$i]['pic_id'] = $cmspage[$n]->f('pic_id');
                $pages[$i]['picture'] = $this->getPicture($cmspage[$n]->f('pic_id'));

                //$pages[$i]['picture'] = $cmspage[$n]->f('pic_id');

80% of this comment could be valid code. Did you maybe forget this after debugging?

                $pages[$i]['description'] = $cmspage[$n]->f('description');

                // til google sitemaps
                // sp�rgsm�let er om vi ikke skal starte et objekt op for hver pages

                $pages[$i]['url'] = $this->cmssite->get('url') . $pages[$i]['identifier'] . '/';
                $pages[$i]['url_self'] = $pages[$i]['identifier'] . '/';
                $pages[$i]['changefreq'] = 'weekly';
                $pages[$i]['priority'] = 0.5;

                $i++;
                // $o = $n + 1;

37% of this comment could be valid code. Did you maybe forget this after debugging?

                if ($this->getDBQuery()->getFilter('type') == 'page' and $this->getDBQuery()->getFilter('level') == 'alllevels') {

Using logical operators such as and instead of && is generally not recommended.

                    $dbquery[$n + 1] = clone $dbquery_original;

$dbquery was never initialized. Although not strictly required by PHP, it is generally a good practice to add $dbquery = array(); before regardless.

                    $dbquery[$n + 1]->setCondition("child_of_id = ".$cmspage[$n]->f("id"));

The variable $dbquery does not seem to be defined for all execution paths leading up to this point.

                    $cmspage[$n + 1] = $dbquery[$n + 1]->getRecordset("id, title, identifier, navigation_name, date_publish, child_of_id, pic_id, status_key, description, DATE_FORMAT(date_publish, '%d-%m-%Y') AS date_publish_dk", '', false);

                    // if (!array_key_exists($n + 1, $cmspage) OR !is_object($cmspage[$n + 1])) {

59% of this comment could be valid code. Did you maybe forget this after debugging?

                    //	$cmspage[$n + 1] = new DB_Sql;

44% of this comment could be valid code. Did you maybe forget this after debugging?

                    //}
                    // $cmspage[$n + 1]->query("SELECT *, DATE_FORMAT(date_publish, '%d-%m-%Y') AS date_publish_dk FROM cms_page WHERE active=1 AND child_of_id = ".$cmspage[$n]->f("id"). $sql_expire . $sql_publish . " ORDER BY id");

59% of this comment could be valid code. Did you maybe forget this after debugging?

                    if ($cmspage[$n + 1]->numRows() != 0) {
                        $n++;
                        continue;
                    }
                }
            }

            if ($n == 0) {
                break;
            }

            $n--;
        }

        return $pages;
    }