Intraface_Doctrine_Intranet::singleton() - Code Metrics - intraface/intraface.dk - Measure and Improve Code Quality continuously with Scrutinizer

Intraface_Doctrine_Intranet::singleton() A
last analyzed 2017-03-20 12:20 UTC

↳ Parent: Intraface_Doctrine_Intranet

Complexity

Conditions	3
Paths	4

Size

Total Lines	10
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	3.0261

Importance

Changes

Metric	Value
cc	3
eloc	6
nc	4
nop	1
dl	0
loc	10
rs	9.4285
c	0
b	0
f	0
ccs	6
cts	7
cp	0.8571
crap	3.0261

<?php
class Intraface_Doctrine_Intranet
{
    private $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

    public static function singleton($id = null)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        if ($id != null) {
            $GLOBALS['intraface_doctrine_intranet_id'] = intval($id);
        }
        if (empty($GLOBALS['intraface_doctrine_intranet_id'])) {
            throw new Exception('An intranet id was not set!');
        }
        return new Intraface_Doctrine_Intranet($GLOBALS['intraface_doctrine_intranet_id']);
    }

    public function getId()
    {
        return $this->id;
    }
}


1		<?php
2		class Intraface_Doctrine_Intranet
3		{
4		private $id;
5
6	47	public function __construct($id)
7		{
8	47	$this->id = $id;
9	47	}
10
11	47	public static function singleton($id = null)
		0 ignored issues – show Coding Style introduced 2016-04-20 09:50 UTC by Report Bug Copy Issue Report `singleton` uses the super-global variable `$GLOBALS` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
12		{
13	47	if ($id != null) {
14	4	$GLOBALS['intraface_doctrine_intranet_id'] = intval($id);
15	4	}
16	47	if (empty($GLOBALS['intraface_doctrine_intranet_id'])) {
17		throw new Exception('An intranet id was not set!');
18		}
19	47	return new Intraface_Doctrine_Intranet($GLOBALS['intraface_doctrine_intranet_id']);
20		}
21
22	47	public function getId()
23		{
24	47	return $this->id;
25		}
26		}
27

intraface / intraface.dk

Intraface_Doctrine_Intranet::singleton() A last analyzed 2017-03-20 12:20 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

Intraface_Doctrine_Intranet::singleton() A
last analyzed 2017-03-20 12:20 UTC