Intraface_Controller_Payment::renderHtml() - Code Metrics - intraface/intraface.dk - Measure and Improve Code Quality continuously with Scrutinizer

Intraface_Controller_Payment::renderHtml() A
last analyzed 2017-03-20 12:20 UTC

↳ Parent: Intraface_Controller_Payment

Complexity

Conditions	2
Paths	2

Size

Total Lines	20
Code Lines	15

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
cc	2
eloc	15
nc	2
nop	0
dl	0
loc	20
rs	9.4285
c	0
b	0
f	0
ccs	0
cts	18
cp	0
crap	6

<?php
class Intraface_Controller_Payment extends k_Component
{
    protected $template;

    function __construct(k_TemplateFactory $template)
    {
        $this->template = $template;
    }

    function renderHtml()
    {
        if ($this->query('language') == 'da') {
            $text[0] = 'Intraface Betaling';
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
            $text[1] = 'Du er nu ved at betale for ordre nummer';
            $text[2] = 'I alt hæves %s på fra dit kort';
            $text[3] = 'Betalingen foretages over Quickpay\'s sikker betalingsserver.';
        } else {
            $text[0] = 'Intraface Payment';
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
            $text[1] = 'You are now about to pay for order number';
            $text[2] = '%s is withdrawed from your card';
            $text[3] = 'The payment is carried out via Quickpay\'s secure server.';
        }

        $this->document->setTitle('Payment');

        $tpl = $this->template->create(dirname(__FILE__) . '/templates/payment');
        $content = $tpl-render($this, array('text' => $text));
        return new k_HtmlResponse($content);
    }
}


1			<?php
2			class Intraface_Controller_Payment extends k_Component
3			{
4			protected $template;
5
6			function __construct(k_TemplateFactory $template)
7			{
8			$this->template = $template;
9			}
10
11			function renderHtml()
12			{
13			if ($this->query('language') == 'da') {
14			$text[0] = 'Intraface Betaling';
			0 ignored issues – show Coding Style Comprehensibility introduced 2016-04-20 07:43 UTC by Report Bug Copy Issue Report `$text` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$text = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
15			$text[1] = 'Du er nu ved at betale for ordre nummer';
16			$text[2] = 'I alt hæves %s på fra dit kort';
17			$text[3] = 'Betalingen foretages over Quickpay\'s sikker betalingsserver.';
18			} else {
19			$text[0] = 'Intraface Payment';
			0 ignored issues – show Coding Style Comprehensibility introduced 2016-04-20 07:43 UTC by Report Bug Copy Issue Report `$text` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$text = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
20			$text[1] = 'You are now about to pay for order number';
21			$text[2] = '%s is withdrawed from your card';
22			$text[3] = 'The payment is carried out via Quickpay\'s secure server.';
23			}
24
25			$this->document->setTitle('Payment');
26
27			$tpl = $this->template->create(dirname(__FILE__) . '/templates/payment');
28			$content = $tpl-render($this, array('text' => $text));
29			return new k_HtmlResponse($content);
30			}
31			}
32

intraface / intraface.dk

Intraface_Controller_Payment::renderHtml() A last analyzed 2017-03-20 12:20 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

Intraface_Controller_Payment::renderHtml() A
last analyzed 2017-03-20 12:20 UTC