| Conditions | 1 |
| Paths | 1 |
| Total Lines | 9 |
| Code Lines | 5 |
| Lines | 0 |
| Ratio | 0 % |
| Tests | 0 |
| CRAP Score | 2 |
| Changes | 0 | ||
| 1 | <?php |
||
| 28 | function renderHtml() |
||
| 29 | { |
||
| 30 | $this->document->setTitle('Module gatekeeper'); |
||
| 31 | |||
| 32 | require_once 'Intraface/modules/intranetmaintenance/ModuleMaintenance.php'; |
||
| 33 | |||
| 34 | $smarty = $this->template->create(dirname(__FILE__) . '/templates/modulegatekeeper'); |
||
| 35 | return $smarty->render($this); |
||
| 36 | } |
||
| 37 | |||
| 56 |
Let’s take a look at an example:
In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break.
Available Fixes
Change the type-hint for the parameter:
Add an additional type-check:
Add the method to the interface: