Install_Helper_Email::create() - Code Metrics - intraface/intraface.dk - Measure and Improve Code Quality continuously with Scrutinizer

Install_Helper_Email::create() A
last analyzed 2017-03-20 12:20 UTC

↳ Parent: Install_Helper_Email

Complexity

Conditions	1
Paths	1

Size

Total Lines	11
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	7
nc	1
nop	0
dl	0
loc	11
rs	9.4285
c	0
b	0
f	0

<?php
class Install_Helper_Email {

    private $kernel;
    private $db;

    public function __construct($kernel, $db)
    {
        $this->kernel = $kernel;
        $this->db = $db;
    }

    public function create()
    {
        require_once dirname(__FILE__) . '/Contact.php';
        $contact = new Install_Helper_Contact($this->kernel, $this->db);
        $contact_id = $contact->create();
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();

        require_once 'Intraface/shared/email/Email.php';
        $email = new Email($this->kernel);

        $email->save(array('belong_to' => 1, 'type_id' => 2, 'contact_id' => $contact_id, 'subject' => 'test', 'body' => 'new test!'));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }
}



1			<?php
2			class Install_Helper_Email {
3
4			private $kernel;
5			private $db;
6
7			public function __construct($kernel, $db)
8			{
9			$this->kernel = $kernel;
10			$this->db = $db;
11			}
12
13			public function create()
14			{
15			require_once dirname(__FILE__) . '/Contact.php';
16			$contact = new Install_Helper_Contact($this->kernel, $this->db);
17			$contact_id = $contact->create();
			0 ignored issues – show Bug introduced 2016-04-20 07:43 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$contact_id` is correct as `$contact->create()` (which targets `Install_Helper_Contact::create()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
18
19			require_once 'Intraface/shared/email/Email.php';
20			$email = new Email($this->kernel);
21
22			$email->save(array('belong_to' => 1, 'type_id' => 2, 'contact_id' => $contact_id, 'subject' => 'test', 'body' => 'new test!'));
			0 ignored issues – show Documentation introduced 2016-04-20 09:50 UTC by Report Bug Copy Issue Report `array('belong_to' => 1, ... 'body' => 'new test!')` is of type `array<string,integer\|nul...ring","body":"string"}>`, but the function expects a `object<Struct>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
23			}
24			}
25
26

intraface / intraface.dk

Install_Helper_Email::create() A last analyzed 2017-03-20 12:20 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

Install_Helper_Email::create() A
last analyzed 2017-03-20 12:20 UTC