DebtorItem::save() - Code Metrics - intraface/intraface.dk - Measure and Improve Code Quality continuously with Scrutinizer

DebtorItem::save() F
last analyzed 2017-03-20 12:20 UTC

↳ Parent: DebtorItem
Complexity

Conditions	19
Paths	2921
Size

Total Lines	95
Code Lines	62
Duplication

Lines	40
Ratio	42.11 %
Code Coverage

Tests	48
CRAP Score	31.267
Importance

Changes
Metric	Value
cc	19
eloc	62
nc	2921
nop	1
dl	40
loc	95
rs	2
c	0
b	0
f	0
ccs	48
cts	71
cp	0.6761
crap	31.267
How to fix Long Method Complexity

<?php
/**
 * Handles items to debtor (quotation, order, invoice, credit note)
 *
 * @package Intraface_Debtor
 * @author Sune Jensen <[email protected]>
 * @author Lars Olesen <[email protected]>
 */

/**
 * Handles items to debtor (quotation, order, invoice, credit note)
 *
 * @package Intraface_Debtor
 * @author Sune Jensen <[email protected]>
 * @author Lars Olesen <[email protected]>
 */
class DebtorItem extends Intraface_Standard
{
    /**
     * @var array
     */
    public $value;

    /**
     * @var integer
     */
    private $id;

    /**
     * @var object
     */
    private $invoice;


    /**
     * @var object
     */
    private $db;

    /**
     * @var object
     */
    private $product;

    /**
     * @var object Intraface_modules_product_Variation
     */
    private $product_variation;

    /**
     * @var object Intraface_modules_product_Variation_Detail
     */
    private $product_variation_detail;

    /**
     * @var integer
     */
    private $product_id;


    /**
     * @var object
     */
    public $error;

    /**
     * Constructor
     *
     * @param object  $debtor Debtor object
     * @param integer $id     If a special item id is needed
     *
     * @return void

     */
    public function __construct($debtor, $id = 0)

    {
        $this->debtor = $debtor;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->db = new DB_Sql;
        $this->error = new Intraface_Error;
        $this->id = (int)$id;

        if ($this->id > 0) {
            $this->load();
        }
    }

    /**
     * Loads data
     *
     * @return void
     */
    private function load()
    {
        if ($this->id == 0) {
            return;
        }
        $this->db->query("SELECT id, product_id, product_detail_id, product_variation_id, product_variation_detail_id, description, quantity FROM debtor_item WHERE id = ".$this->id." AND intranet_id = ".$this->debtor->kernel->intranet->get("id"));
        if ($this->db->nextRecord()) {
            $this->value["id"] = $this->db->f("id");
            $this->value["product_id"] = $this->db->f("product_id");
            $this->value["product_detail_id"] = $this->db->f("product_detail_id");
            $this->value["product_variation_id"] = $this->db->f("product_variation_id");
            $this->value["product_variation_detail_id"] = $this->db->f("product_variation_detail_id");
            $this->value["description"] = $this->db->f("description");
            $this->value["quantity"] = $this->db->f("quantity");
        }
    }

    /**
     * returns product object with loaded from item
     *
     * @return object Product
     */
    private function getProduct()

    {
        if (!$this->product) {
            if ($this->get('product_id') == '' || $this->get('product_detail_id') == '') {
                throw new Exception('The item is not loaded');
            }
            $this->product = new Product($this->debtor->kernel, $this->get('product_id'), $this->get('product_detail_id'));
        }
        return $this->product;
    }

    /**
     * Returns Product variation loaded from item
     *
     * @return object Intraface_modules_product_Variation
     */
    private function getProductVariation()

    {
        if (!$this->getProduct()->get('has_variation')) {
            throw new Exception('The product must have variation to request variations');
        }
        if (!$this->product_variation) {
            if (intval($this->get('product_variation_id')) == 0) {
                throw new Exception('The product variation id is not valid on item '.$this->get('id'));
            }
            $this->product_variation = $this->product->getVariation($this->get('product_variation_id'));
        }
        return $this->product_variation;
    }

    /**
     * Returns product variation detail loaded from item
     *
     * @return object Intraface_modules_product_Variation_Detail
     */
    private function getProductVariationDetail()

    {
        if (!$this->getProduct()->get('has_variation')) {
            throw new Exception('The product must have variation to request variations');
        }
        if (!$this->product_variation_detail) {
            if (intval($this->get('product_variation_detail_id')) == 0) {
                throw new Exception('The product variation detail id is not valid on item '.$this->get('id'));
            }
            $this->product_variation_detail = $this->getProductVariation()->getDetail($this->get('product_variation_detail_id'));
        }
        return $this->product_variation_detail;
    }

    /**
     * Returns price of product without vat
     *
     * @return float price of product
     */
    public function getProductPrice()

    {
        if ($this->getProduct()->get('has_variation')) {
            return $this->getProductVariationDetail()->getPrice($this->getProduct());
        } else {
            return $this->getProduct()->getDetails()->getPrice();
        }
    }

    /**
     * Returns weight of product without vat
     *
     * @return integer weight of product
     */
    public function getProductWeight()
    {
        if ($this->getProduct()->get('has_variation')) {
            return $this->getProduct()->get("weight") + $this->getProductVariationDetail()->getWeightDifference();
        } else {
            return $this->getProduct()->get("weight");
        }
    }

    /**
     * Returns number of product
     *
     * @return string product number
     */
    public function getProductNumber()

    {
        if ($this->getProduct()->get('has_variation')) {
            return $this->getProduct()->get("number").'.'.$this->getProductVariation()->getNumber();
        } else {
            return $this->getProduct()->get("number");
        }
    }

    /**
     * Returns name of product
     *
     * @return string name of product
     */
    public function getProductName()

    {
        if ($this->getProduct()->get('has_variation')) {
            return $this->getProduct()->get("name").' - '.$this->getProductVariation()->getName();
        } else {
            return $this->getProduct()->get("name");
        }
    }


    /**
     * Gets price without taxes
     *
     * @return float
     */
    public function getPrice()
    {
        // TODO how do we handle vat? this should return raw prices
        // and then the tax percent should return the tax to apply
        // the calculator should handle the final price
        return $this->getProductPrice() * $this->get('quantity');
    }

    /**
     * Gets weight
     *
     * @return float
     */
    public function getWeight()
    {
        return $this->getProductWeight() * $this->get('quantity');
    }

    /**
     * Gets the tax percent on the individual product
     *
     * @return float
     */
    public function getTaxPercent()
    {
        if ($this->getProduct()->get('vat')) {
            return 25;
        } else {
            return 0;
        }
    }

    /**
     * Saves data
     *
     * @TODO: Should have product object instead of product id in the param array.
     *
     * @param array $input Values to save
     *
     * @return integer
     */
    public function save($input)
    {
        if ($this->debtor->get("locked") == 1) {
            $this->error->set('Posten er l�st er l�st og der kan ikke opdateres varer p� den');
            return 0;
        }

        $input = safeToDb($input);

        $validator = new Intraface_Validator($this->error);

        settype($input["product_id"], 'integer');
        if ($validator->isNumeric($input["product_id"], "Du skal v�lge et produkt", "greater_than_zero")) {
            if (!isset($input['product_detail_id'])) {
                $input['product_detail_id'] = 0;
            }

            require_once 'Intraface/modules/product/Product.php';
            $product = new Product($this->debtor->kernel, $input["product_id"], $input['product_detail_id']);

            if (!is_object($product) || $product->get('id') == 0) {
                 $this->error->set("Ugyldigt produkt");
            } else {
                $product_detail_id = $product->get("detail_id");
            }

            if (!isset($input['product_variation_id'])) {
                $input['product_variation_id'] = 0;
            }
            if (intval($input['product_variation_id']) != 0) {
                $variation = $product->getVariation(intval($input['product_variation_id']));
                if (!$variation->getId()) {
                    $this->error->set("Invalid product variation");
                }

                if (!isset($input['product_variation_detail_id'])) {
                    $input['product_variation_detail_id'] = 0;
                }
                $detail = $variation->getDetail(intval($input['product_variation_detail_id']));
                if (!$detail->getId()) {
                    $this->error->set("Invalid product variation detail");
                }

                $variation_id = $variation->getId();
                $variation_detail_id = $detail->getId();
            } else {
                $variation_id = 0;
                $variation_detail_id = 0;
            }
        }

        if (!isset($input["quantity"])) {
            $input["quantity"] = 0;
        }
        $validator->isDouble($input["quantity"], "Du skal angive et antal", "");
        $quantity = new Intraface_Amount($input["quantity"]);
        if ($quantity->convert2db()) {
            $input["quantity"] = $quantity->get();
        } else {
            $this->error->set("Ugyligt antal");
        }
        if (!isset($input['description'])) {
            $input['description'] = '';
        }
        $validator->isString($input["description"], "Fejl i beskrivelse", "<b><i>", "allow_empty");

        if ($this->error->isError()) {
            return(false);
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
        }

        $sql = "product_id = ".$input["product_id"].",
            product_detail_id = ".$product_detail_id.",
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
            product_variation_id = ".$variation_id.",
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
            product_variation_detail_id = ".$variation_detail_id.",
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
            quantity = ".$input["quantity"].",
            description = '".$input["description"]."'";

        if ($this->id == 0) {
            $position = $this->getPosition(MDB2::singleton(DB_DSN))->getMaxPosition() + 1;
            $sql = $sql.', position = '.$position;

            $this->db->query("INSERT INTO debtor_item SET ".$sql.", intranet_id = ".$this->debtor->kernel->intranet->get("id").", debtor_id = ".$this->debtor->get("id").", active = 1");
            $this->id = $this->db->InsertedId();
        } else {
            $this->db->query("UPDATE debtor_item SET ".$sql." WHERE id = ".$this->id." and debtor_id = ".$this->debtor->get("id"));
        }

        // hvis det er et kreditnota, skal fakturastatus opdateres
        if ($this->debtor->get("type") == "credit_note" && $this->debtor->get("where_from") == "invoice" && $this->debtor->get("where_from_id") != 0) {
            $invoice = Debtor::factory($this->debtor->kernel, (int)$this->debtor->get("where_from_id"));
            $invoice->updateStatus();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        }

        return $this->id;
    }

    /**
     * Changes the product assigned to the item
     *
     * @param integer $product_id
     * @param integer $product_variation_id
     * @return boolean true on success
     */
    public function changeProduct($product_id, $product_variation_id = 0)
    {
        if (!$this->id) {
            throw new Exception('You cannot change product when not saved');
        }

        require_once 'Intraface/modules/product/Product.php';
        $product = new Product($this->debtor->kernel, $product_id);

        if (!is_object($product) || $product->get('id') == 0) {
             throw new Excetion('Invalid product id');
        } else {
            $product_detail_id = $product->get("detail_id");
        }

        if (intval($product_variation_id) != 0) {
            $variation = $product->getVariation(intval($product_variation_id));
            if (!$variation->getId()) {
                throw new Exception('Invalid product variation id');
            }

            $detail = $variation->getDetail();
            if (!$detail->getId()) {
                throw new Exception("Invalid product variation detail");
            }

            $variation_id = $variation->getId();
            $variation_detail_id = $detail->getId();
        } else {
            $variation_id = 0;
            $variation_detail_id = 0;
        }

        $sql = "product_id = ".$product->getId().",
            product_detail_id = ".$product_detail_id.",
            product_variation_id = ".$variation_id.",
            product_variation_detail_id = ".$variation_detail_id;

        $this->db->query("UPDATE debtor_item SET ".$sql." WHERE id = ".$this->id." and debtor_id = ".$this->debtor->get("id"));
        return true;
    }

    /**
     * Deletes a product
     *
     * @return boolean
     */
    public function delete()
    {
        if ($this->debtor->get("locked") == true) {
            $this->error->set('Du kan ikke slette vare til en l�st post');
            return false;
        }
        $this->db->query("UPDATE debtor_item SET active = 0 WHERE id = ".$this->id." AND debtor_id = ".$this->debtor->get("id"));
        $this->id = 0;

        if ($this->debtor->get("type") == "credit_note" && $this->debtor->get("where_from") == "invoice" && $this->debtor->get("where_from_id") != 0) {
            $invoice = Debtor::factory($this->debtor->kernel, intval($this->debtor->get("where_from_id")));
            $invoice->updateStatus();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        }

        return true;
    }

    /**
     * Get a list with Debtor items
     *
     * @return array
     */
    public function getList()
    {
        $db = new DB_Sql;
        $db2 = new DB_Sql;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        $db->query("SELECT id, product_id, product_detail_id, product_variation_id, product_variation_detail_id, quantity, description FROM debtor_item WHERE active = 1 AND intranet_id = ".$this->debtor->kernel->intranet->get("id")." AND debtor_id = ".$this->debtor->get("id")." ORDER BY position ASC, id ASC");
        $i = 0;
        $j = 0;
        $item_no_vat = array();
        $item_with_vat = array();

        require_once 'Intraface/modules/product/Product.php';

        $currency = $this->debtor->getCurrency();

        while ($db->nextRecord()) {
            $product = new Product($this->debtor->kernel, $db->f('product_id'), $db->f('product_detail_id'));

            if ($product->getId() != 0 && $product->get('detail_id') != 0) {
                $item = array();
                $item["description"] = $db->f("description");
                $item["quantity"] = $db->f("quantity");
                $item["id"] = $db->f("id");

                $item["vat"] = $product->get("vat");
                $item["product_id"] = $product->getId();
                $item["product_detail_id"] = $product->get("detail_id");
                $unit = $product->get('unit');
                if ($db->f("quantity") == 1) {
                    $item["unit"] = $unit['singular'];
                } else {
                    $item["unit"] = $unit['plural'];
                }

                if ($product->get('has_variation')) {
                    $variation = $product->getVariation($db->f('product_variation_id'));
                    $detail = $variation->getDetail($db->f('product_variation_detail_id'));
                    $item["name"] = $product->get("name").' - '.$variation->getName();
                    $item["number"]= $product->get("number").'.'.$variation->getNumber();
                    $item["price"] = $detail->getPrice($product);
                    if ($currency) {
                        $item['price_currency'] = $detail->getPriceInCurrency($currency, $this->debtor->get('currency_product_price_exchange_rate_id'), $product);
                    }
                } else {
                    $item["name"] = $product->get("name");
                    $item["number"]= $product->get("number");
                    $item["price"] = $product->getDetails()->getPrice();
                    if ($currency) {
                        $item['price_currency'] = $product->getDetails()->getPriceInCurrency($currency, $this->debtor->get('currency_product_price_exchange_rate_id'));
                    }
                }

                if ($product->get("vat") == 0) {
                    $item_no_vat[$j] = $item;
                    $item_no_vat[$j]["amount"] = new Ilib_Variable_Float($item["quantity"] * $item["price"]->getAsIso(2));
                    if ($currency) {
                        $item_no_vat[$j]["amount_currency"] = new Ilib_Variable_Float($item["quantity"] * $item["price_currency"]->getAsIso(2), 'iso');
                    }
                    $j++;
                } else {
                    $item_with_vat[$i] = $item;
                    $item_with_vat[$i]["amount"] = new Ilib_Variable_Float($item["quantity"] * $item["price"]->getAsIso(2) * 1.25);
                    if ($currency) {
                        $item_with_vat[$i]["amount_currency"] = new Ilib_Variable_Float($item["quantity"] * $item["price_currency"]->getAsIso(2) * 1.25, 'iso');
                    }
                    $i++;
                }
            } else {
                 throw new Exception("Ugyldig produktdetalje i DebtorItem->getList() on ".$db->f('product_id').'/'.$db->f('product_detail_id'));
            }
        }
        unset($db);
        return(array_merge($item_with_vat, $item_no_vat));
    }

    /**
     * Method to get quantity of each product
     *
     * TODO This should not be in this class
     *
     * @param integer $product_id Product id
     * @param string  $from_date  Which date to start the quantity from
     * @param string  $sent       TODO WHAT IS THIS
     *
     * @return integer
     */
    public function getQuantity($product_id, $product_variation_id, $from_date, $sent = "")
    {

        /*

        0=>'created',
            1=>'sent',
            2=>'executed',
            3=>'cancelled'
        */

        if (!in_array($sent, array("", "not_sent"))) {
            throw new Exception("Ugyldig værdi i 3. parameter til debtor->item->getQuantity()");
        }

        if ($this->debtor->get('type') == "quotation") {
            $status_sql = "debtor.status = 0 OR debtor.status = 1"; // tilbud der er oprettet eller sent.
            $date_sql = "";
        } elseif ($this->debtor->get('type') == "order") {
            $status_sql = "debtor.status = 0 OR debtor.status = 1"; // ordre der er oprettet eller sent.
            $date_sql = "";
        } elseif ($this->debtor->get('type') == "invoice" && $sent == "") {
            $status_sql = "debtor.status = 1 OR debtor.status = 2"; // fakturaer der er sent eller f�rdigbehandlet
            $date_sql = "AND debtor.date_sent > \"".$from_date."\"";
        } elseif ($this->debtor->get('type') == "invoice" && $sent == "not_sent") {
            $status_sql = "debtor.status = 0"; // fakturaer der er oprettet.
            $date_sql = "";
        } elseif ($this->debtor->get('type') == "credit_note") {
            $status_sql = "debtor.status = 2"; // kredit notaer der er f�rdigbehandlet
            $date_sql = "AND debtor.date_executed > \"".$from_date."\"";
        } else {
            throw new Exception("Der er opstået en fejl i Debtor->item->getQuantity()");
        }

        $db = new DB_sql;

        $sql = "SELECT SUM(quantity) AS sum_quantity
            FROM debtor_item INNER JOIN debtor
                ON debtor_item.debtor_id = debtor.id
            WHERE debtor_item.active = 1 AND debtor.active = 1
                AND debtor_item.intranet_id = ".$this->debtor->kernel->intranet->get("id")." AND debtor.intranet_id = ".$this->debtor->kernel->intranet->get("id")."
                AND debtor.type = ".$this->debtor->get('type_key')." AND (".$status_sql.")
                AND debtor_item.product_id = ".intval($product_id)."
                AND debtor_item.product_variation_id = ".intval($product_variation_id)." ".$date_sql;
        $db->query($sql);
        $db->nextRecord(); // Der vil altid v�re en post
        return intval($db->f("sum_quantity"));
    }

    /**
     * Returns position object
     *
     * @return object Ilib_Position
     */
    function getPosition($db)
    {
        return new Ilib_Position($db, "debtor_item", $this->id, "intranet_id=".$this->debtor->kernel->intranet->get('id')." AND debtor_id=".$this->debtor->get('id')." AND active = 1", "position", "id");
    }
}

DebtorItem::save() F
last analyzed 2017-03-20 12:20 UTC

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method Complexity

Long Method

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

1			<?php
2			/**
3			* Handles items to debtor (quotation, order, invoice, credit note)
4			*
5			* @package Intraface_Debtor
6			* @author Sune Jensen <[email protected]>
7			* @author Lars Olesen <[email protected]>
8			*/
9
10			/**
11			* Handles items to debtor (quotation, order, invoice, credit note)
12			*
13			* @package Intraface_Debtor
14			* @author Sune Jensen <[email protected]>
15			* @author Lars Olesen <[email protected]>
16			*/
17			class DebtorItem extends Intraface_Standard
18			{
19			/**
20			* @var array
21			*/
22			public $value;
23
24			/**
25			* @var integer
26			*/
27			private $id;
28
29			/**
30			* @var object
31			*/
32			private $invoice;
			0 ignored issues – show Unused Code introduced 2016-04-20 07:43 UTC by Report Bug Copy Issue Report The property `$invoice` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
33
34			/**
35			* @var object
36			*/
37			private $db;
38
39			/**
intraface / intraface.dk

DebtorItem::save() F last analyzed 2017-03-20 12:20 UTC

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method Complexity

Long Method

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

DebtorItem::save() F
last analyzed 2017-03-20 12:20 UTC
