DBQueryTest::testUseStoreOnSublevelNotChangingToplevel() - Code Metrics - intraface/intraface.dk - Measure and Improve Code Quality continuously with Scrutinizer

testUseStoreOnSublevelNotChangingToplevel() B
last analyzed 2017-03-20 12:20 UTC

↳ Parent: DBQueryTest

Complexity

Conditions	2
Paths	2

Size

Total Lines	26
Code Lines	18

Duplication

Lines	26
Ratio	100 %

Importance

Changes

Metric	Value
cc	2
eloc	18
nc	2
nop	0
dl	26
loc	26
rs	8.8571
c	0
b	0
f	0

<?php
/**
 * Notice this should only be tests to ensure that the extend from Ilib_DBQuery works
 * The actual tests of DBQuery should be in Intraface_3Party
 */
class DBQueryTest extends PHPUnit_Framework_TestCase
{
    private $db;
    private $table = 'dbquery_test';

    function setUp()
    {
        $this->db = MDB2::singleton(DB_DSN);
        if (PEAR::isError($this->db)) {
            die($this->db->getUserInfo());

        }

        $result = $this->db->exec('TRUNCATE TABLE dbquery_result');
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        $result = $this->db->exec('DROP TABLE ' . $this->table);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        /*

         TODO: DROP THE TABLE IF IT EXISTS

        $result = $this->db->exec('DROP TABLE ' . $this->table);

        if (PEAR::isError($result)) {
            die($result->getUserInfo());
        }
        */

        $result = $this->db->exec('CREATE TABLE ' . $this->table . '(
            id int(11) NOT NULL auto_increment, name varchar(255) NOT NULL, PRIMARY KEY  (id))');

        if (PEAR::isError($result)) {
            die($result->getUserInfo());

        }

        $this->insertPosts();
    }

    function createDBQuery($session_id = '')
    {
        $kernel = new Stub_Kernel($session_id);
        return new Intraface_DBQuery($kernel, $this->table);
    }

    function insertPosts()
    {
        $data = array('one', 'two', 'three', 'four', 'five', 'six', 'seven', 'eight', 'nine', 'ten', 'eleven', 'twelve', 'thirteen', 'fourteen', 'fifteen', 'sixteen', 'seventeen', 'eighteen', 'nineteen', 'twenty', 'twentyone');
        foreach ($data as $d) {
            $this->createPost($d);
        }
    }

    function createPost($post)
    {
        $result = $this->db->exec('INSERT INTO ' . $this->table . ' (name) VALUES ('.$this->db->quote($post, 'text').')');
        if (PEAR::isError($result)) {
            die($result->getUserInfo());

        }
    }

    function tearDown()
    {
        $result = $this->db->exec('DROP TABLE ' . $this->table);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
    }

    ///////////////////////////////////////////////////////////////////////////

    function testConstructor()
    {
        $dbquery = $this->createDBQuery();
        $this->assertTrue(is_object($dbquery));
        $this->assertEquals($this->table, $dbquery->getTableName());
    }

    function testRequiredConditions()
    {
        $condition = 'name = 1';
        $kernel = new Stub_Kernel;
        $dbquery = new Intraface_DBQuery($kernel, $this->table, $condition);
        $this->assertEquals($condition, $dbquery->required_conditions);

    }

    function testGetCharacters()
    {
        $dbquery = $this->createDBQuery();
        $db = $dbquery->getRecordset('*', '', false);
        $this->assertEquals(21, $db->numRows());
        $dbquery->useCharacter();
        $dbquery->defineCharacter('t', 'name');
        $this->assertTrue($dbquery->getUseCharacter());
        $characters = $dbquery->getCharacters();
        $this->assertEquals(6, count($characters));
    }

    function testPaging()
    {
        $dbquery = $this->createDBQuery();
        $paging_name = 'paging';
        $rows_pr_page = 2;
        $dbquery->usePaging($paging_name, $rows_pr_page);
        $db = $dbquery->getRecordset('*', '', false);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        $this->assertEquals($paging_name, $dbquery->getPagingVarName());

        $paging = $dbquery->getPaging();
        $expected_offset = array(1=>0, 2=>2, 3=>4, 4=>6, 5=>8, 6=>10, 7=>12, 8=>14, 9=>16,10=>18,11=>20);
        $this->assertEquals($expected_offset, $paging['offset']);
        $this->assertEquals(0, $paging['previous']);
        $this->assertEquals(2, $paging['next']);
    }

    function testGetRecordset()
    {
        $dbquery = $this->createDBQuery();

        $dbquery->setCondition('id > 2');

        $db = $dbquery->getRecordset('id, name');
        $i = 0;
        while($db->nextRecord()) {
            $result[$i]['id'] = $db->f('id');
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
            $result[$i]['name'] = $db->f('name');
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
            $i++;
        }

        $this->assertEquals(19, count($result));
    }

    function testUseStoreOnTopLevel()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $dbquery = $this->createDBQuery();
        $dbquery->setCondition('id > 10');
        $dbquery->storeResult("use_stored", 'unittest', "toplevel");
        $db = $dbquery->getRecordset('id, name');
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}


        $dbquery = $this->createDBQuery();
        $_GET['use_stored'] = 'true';
        $dbquery->storeResult("use_stored", 'unittest', "toplevel");
        $db = $dbquery->getRecordset('id, name');
        $i = 0;
        while($db->nextRecord()) {
            $result[$i]['id'] = $db->f('id');
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
            $result[$i]['name'] = $db->f('name');
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
            $i++;
        }
        $this->assertEquals(11, count($result));
    }

    function testUseStoreOnTopLevelWithAnotherOneInBetween()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        // the first page
        $dbquery = $this->createDBQuery();
        $dbquery->setCondition('id > 10');
        $dbquery->storeResult("use_stored", 'unittest', "toplevel");
        $db = $dbquery->getRecordset('id, name');
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        // another page also with toplevel - overrides the first one saved
        $dbquery = $this->createDBQuery();
        $dbquery->storeResult("use_stored", 'unittest-on-another-page', "toplevel");
        $db = $dbquery->getRecordset('id, name');
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        // then back to the first page again - the result should not be saved
        $dbquery = $this->createDBQuery();
        $_GET['use_stored'] = 'true';
        $dbquery->storeResult("use_stored", 'unittest', "toplevel");
        $db = $dbquery->getRecordset('id, name');
        $i = 0;
        while($db->nextRecord()) {
            $result[$i]['id'] = $db->f('id');
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
            $result[$i]['name'] = $db->f('name');
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
            $i++;
        }
        $this->assertEquals(21, count($result));
    }

    function testUseStoreOnSublevelNotChangingToplevel()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        // the first page
        $dbquery = $this->createDBQuery();
        $dbquery->setCondition('id > 10');
        $dbquery->storeResult("use_stored", 'unittest', "toplevel");
        $db = $dbquery->getRecordset('id, name');
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        // another page with sublevel - does not override the first one saved
        $dbquery = $this->createDBQuery();
        $dbquery->storeResult("use_stored", 'unittest-on-another-page', "sublevel");
        $db = $dbquery->getRecordset('id, name');
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        // then back to the first page again - the result should be saved
        $dbquery = $this->createDBQuery();
        $_GET['use_stored'] = 'true';
        $dbquery->storeResult("use_stored", 'unittest', "toplevel");
        $db = $dbquery->getRecordset('id, name');
        $i = 0;
        while($db->nextRecord()) {
            $result[$i]['id'] = $db->f('id');
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
            $result[$i]['name'] = $db->f('name');
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
            $i++;
        }
        $this->assertEquals(11, count($result));
    }

    function testUseStoreWithTwoDifferentUsers()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        // the first page
        $dbquery = $this->createDBQuery();
        $dbquery->setCondition('id > 10');
        $dbquery->storeResult("use_stored", 'unittest', "toplevel");
        $db = $dbquery->getRecordset('id, name');
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        // another user on the same page
        $dbquery = $this->createDBQuery('another-session-id-passed-to-kernel-and-then-to-dbquery');
        $dbquery->storeResult("use_stored", 'unittest', "toplevel");
        $db = $dbquery->getRecordset('id, name');
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        // then back to the first page again - the result should be saved
        $dbquery = $this->createDBQuery();
        $_GET['use_stored'] = 'true';
        $dbquery->storeResult("use_stored", 'unittest', "toplevel");
        $db = $dbquery->getRecordset('id, name');
        $i = 0;
        while($db->nextRecord()) {
            $result[$i]['id'] = $db->f('id');
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
            $result[$i]['name'] = $db->f('name');
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
            $i++;
        }
        $this->assertEquals(11, count($result));
    }
}


testUseStoreOnSublevelNotChangingToplevel() B
last analyzed 2017-03-20 12:20 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

1			<?php
2			/**
3			* Notice this should only be tests to ensure that the extend from Ilib_DBQuery works
4			* The actual tests of DBQuery should be in Intraface_3Party
5			*/
6			class DBQueryTest extends PHPUnit_Framework_TestCase
7			{
8			private $db;
9			private $table = 'dbquery_test';
10
11			function setUp()
12			{
13			$this->db = MDB2::singleton(DB_DSN);
14			if (PEAR::isError($this->db)) {
15			die($this->db->getUserInfo());
			0 ignored issues – show Coding Style Compatibility introduced 2016-04-20 09:50 UTC by Report Bug Copy Issue Report The method `setUp()` contains an exit expression. An exit expression should only be used in rare cases. For example, if you write a short command line script. In most cases however, using an `exit` expression makes the code untestable and often causes incompatibilities with other libraries. Thus, unless you are absolutely sure it is required here, we recommend to refactor your code to avoid its usage. Loading history...
16			}
17
18			$result = $this->db->exec('TRUNCATE TABLE dbquery_result');
			0 ignored issues – show Unused Code introduced 2016-04-20 09:50 UTC by Report Bug Copy Issue Report `$result` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
19
20			$result = $this->db->exec('DROP TABLE ' . $this->table);
			0 ignored issues – show Unused Code introduced 2016-04-20 09:50 UTC by Report Bug Copy Issue Report `$result` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
21			/*
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-04-20 09:50 UTC by Report Bug Copy Issue Report `46%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
22			TODO: DROP THE TABLE IF IT EXISTS
23
24			$result = $this->db->exec('DROP TABLE ' . $this->table);
25
26			if (PEAR::isError($result)) {
27			die($result->getUserInfo());
28			}
29			*/
30
31			$result = $this->db->exec('CREATE TABLE ' . $this->table . '(
32			id int(11) NOT NULL auto_increment, name varchar(255) NOT NULL, PRIMARY KEY (id))');
33
34			if (PEAR::isError($result)) {
35			die($result->getUserInfo());
			0 ignored issues – show Coding Style Compatibility introduced 2016-04-20 09:50 UTC by Report Bug Copy Issue Report The method `setUp()` contains an exit expression. An exit expression should only be used in rare cases. For example, if you write a short command line script. In most cases however, using an `exit` expression makes the code untestable and often causes incompatibilities with other libraries. Thus, unless you are absolutely sure it is required here, we recommend to refactor your code to avoid its usage. Loading history...

intraface / intraface.dk

testUseStoreOnSublevelNotChangingToplevel() B last analyzed 2017-03-20 12:20 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

testUseStoreOnSublevelNotChangingToplevel() B
last analyzed 2017-03-20 12:20 UTC