Year

Complexity

Total Complexity

133

Size/Duplication

Total Lines	869
Duplicated Lines	7.25 %

Coupling/Cohesion

Components	1
Dependencies	8

Test Coverage

Coverage

60.12%

Importance

Changes

0

31 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	14	4
A	setYear()	0	11	2
A	loadActiveYear()	0	5	1
A	getActiveYear()	0	4	1
A	checkYear()	0	17	4
A	isYearSet()	0	10	2
A	reset()	0	5	1
B	load()	0	37	3
A	validate()	0	16	2
B	save()	0	48	5
A	isValid()	0	4	1
A	_isValid()	16	16	2
B	vatAccountIsSet()	0	10	5
A	isYearOpen()	11	11	3
B	isDateInYear()	0	17	5
B	readyForState()	0	21	5
B	getList()	0	27	1
B	getBalanceAccounts()	0	43	6
A	setSetting()	0	4	1
A	getSetting()	0	4	1
F	createAccounts()	24	171	35
F	setSettings()	0	93	19
B	getSettings()	0	28	2
B	isSettingsSet()	0	7	6
B	isBalanced()	12	37	4
B	isStated()	0	25	4
A	isPaymentsStated()	0	13	2
A	isProcurementsStated()	0	14	2
A	lock()	0	6	1
A	getId()	0	4	1
A	transferAccountSetting()	0	9	2

<?php
/**
 * Year
 *
 * @package Intraface_Accounting
 * @author  Lars Olesen
 * @since   1.0
 * @version     1.0
 */
require_once 'Intraface/modules/accounting/Account.php';

class Year extends Intraface_Standard
{
    public $id; // årsid
    public $kernel; // object
    public $value; // array
    public $error; // error object

    /**
     * Constructor
     *
     * @param object  $kernel
     * @param integer $year_id
     * @param boolean $load_active used when a new year is created
     *
     * @return void

Adding a @return annotation to constructors is generally not recommended as a constructor does not have a meaningful return value.

     */
    function __construct($kernel, $year_id = 0, $load_active = true)
    {
        $this->error  = new Intraface_Error;
        $this->kernel = $kernel;
        $this->id     = (int)$year_id;

        if ($this->id > 0) {
            $this->load();
        } elseif ($load_active) {
            if ($this->loadActiveyear() > 0) {
                $this->load();
            }
        }
    }

    /**
     * Funktion til at sætte et regnskabsår, som brugeren redigerer i.
     *
     * @return true
     */
    function setYear()
    {
        if ($this->id == 0) {
            return false;
        }
        $this->reset();

        $this->kernel->getSetting()->set('user', 'accounting.active_year', $this->id);

        return true;
    }

    /**
     * Finder det aktive år.
     *
     * @todo should be deprecated in favor of getActiveYear
     *
     * @return year / false
     */
    public function loadActiveYear()
    {
        $this->id = $this->kernel->getSetting()->get('user', 'accounting.active_year');
        return $this->id;
    }

    /**
     * Finds the ative year
     *
     * @return integer
     */
    function getActiveYear()
    {
        return $this->kernel->getSetting()->get('user', 'accounting.active_year');
    }

    /**
     * Checks whether a year isset.
     *
     * @param boolean $redirect Set to true if a redirect should occur if no year isset
     *
     * @return boolean
     */
    function checkYear($redirect = true)
    {
        // hvis ikke der er sat noget aktivt år, skal det sættes
        $active_year = $this->getActiveYear();
        if (!$this->_isValid()) {
            $active_year = 0;
        }

        if (!$active_year) {
            if ($redirect) {
                header('Location: years.php');
                exit;

The method checkYear() contains an exit expression.

            }
            return false;
        }
        return true;
    }

    function isYearSet()
    {
        // if no active year isset, it has to be done
        $active_year = $this->loadActiveYear();

$active_year is not used, you could remove the assignment.

        if (!$this->_isValid()) {
            return false;
        }

        return true;
    }

    /**
     * Resets active year
     *
     * @return boolean
     */
    private function reset()
    {
        $this->kernel->getSetting()->set('user', 'accounting.active_year', 0);
        return true;
    }

    /*******************************************************************************
        OPDATERING OG LOAD
    *******************************************************************************/

    private function load()
    {
        if ($this->id == 0) {
            $this->value['id'] = 0;
            return;
        }

        $sql = "SELECT id,
                DATE_FORMAT(from_date, '%Y') AS year,
                DATE_FORMAT(from_date, '%d-%m-%Y') AS from_date_dk,
                DATE_FORMAT(to_date, '%d-%m-%Y') AS to_date_dk,
                last_year_id, from_date, to_date, locked, label, vat
            FROM accounting_year
            WHERE id = '" . $this->id . "'
                AND intranet_id = ".$this->kernel->intranet->get('id')."
            LIMIT 1";

        $db = new DB_Sql;
        $db->query($sql);

        if ($db->nextRecord()) {
            $this->id = $db->f('id');
            $this->value['id'] = $db->f('id');
            $this->value['year'] = $db->f('year');
            $this->value['label'] = $db->f('label');
            $this->value['last_year_id'] = $db->f('last_year_id');
            $this->value['from_date'] = $db->f('from_date');
            $this->value['from_date_dk'] = $db->f('from_date_dk');
            $this->value['to_date'] = $db->f('to_date');
            $this->value['to_date_dk'] = $db->f('to_date_dk');
            $this->value['locked'] = $db->f('locked');
            $this->value['vat'] = $db->f('vat');
        } else {
            $this->id = 0;
            $this->value['id'] = 0;
        }
    }

    private function validate(&$var)
    {
        $validator = new Intraface_Validator($this->error);
        // I could not find any use of the following, so i commented it out /SJ (22-01-2007)
        // $validator->isNumeric($var['year'], "year", "allow_empty");

77% of this comment could be valid code. Did you maybe forget this after debugging?

        $validator->isNumeric($var['last_year_id'], "last_year_id", "allow_empty");
        $validator->isString($var['label'], "Du skal skrive et navn til året");
        $validator->isNumeric($var['locked'], "locked");
        settype($var['vat'], 'integer');
        $validator->isNumeric($var['vat'], "vat", 'allow_empty');

        if ($this->error->isError()) {
            return false;
        }
        return true;
    }

    /**
     * Updates year
     *
     * @param array $var Information about the year
     *
     * @return integer
     */
    public function save($var)
    {
        $var = safeToDb($var);

        $post_date_from = new Intraface_Date($var['from_date']);
        $post_date_from->convert2db();

        $post_date_to = new Intraface_Date($var['to_date']);
        $post_date_to->convert2db();

        if (!isset($var['last_year_id'])) {
            $var['last_year_id'] = 0;
        }

        if (!$this->validate($var)) {
            return false;

The return type of return false; (false) is incompatible with the return type documented by Year::save of type integer.

        }

        if ($this->id > 0) {
            $sql="UPDATE accounting_year ";
            $sql_after=" WHERE id='".$this->id."' AND intranet_id = ".$this->kernel->intranet->get('id')."";
        } else {
            $sql="INSERT INTO accounting_year ";
            $sql_after = ', date_created = NOW()';
        }
        $sql.=" SET
            intranet_id='".$this->kernel->intranet->get('id')."',
            user_id='".$this->kernel->user->get('id')."',
            last_year_id='".$var['last_year_id']."',
            label='".$var['label']."',
            from_date='".$post_date_from->get()."',
            to_date = '".$post_date_to->get()."',
            locked='".$var['locked']."',
            date_changed = NOW(),
            vat = '".(int)$var['vat']."'
            $sql_after";

        $db = new DB_Sql;
        $db->query($sql);

        if ($this->id == 0) {
            $this->id = $db->insertedId();
        }

        $this->load();

        return $this->id;
    }

    /****************************************************************************
    VALIDERINGSFUNKTIONER
    ****************************************************************************/
    public function isValid()
    {
        return $this->_isValid();
    }

    /**
     * Checks whether year is valid
     *
     * @return 1 = year set; 0 = year NOT set

The doc-type 1 could not be parsed: Unknown type name "1" at position 0. (view supported doc-types)

     */
    private function _isValid()

This method seems to be duplicated in your project.

    {
        $sql = "SELECT id FROM accounting_year
            WHERE id = ".$this->id."
                AND intranet_id = ". $this->kernel->intranet->get('id') . " AND active = 1";

        $db = new DB_Sql;
        $db->query($sql);


        if (!$db->nextRecord()) {
            return false;
        }

        return true;
    }

    function vatAccountIsSet()
    {
        if ($this->get('vat') == 0) {
            return true; // pretend it is set, when no vat on the year
        }
        if ($this->getSetting('vat_in_account_id') > 0 and $this->getSetting('vat_out_account_id') > 0 and $this->getSetting('vat_balance_account_id') > 0) {

Using logical operators such as and instead of && is generally not recommended.

            return true;
        }
        return false;
    }

    /**
     * Checks whether the year is open for stating
     *
     * @return boolean
     */
    public function isYearOpen()

This method seems to be duplicated in your project.

    {
        $db = new Db_Sql;
        $db->query("SELECT locked FROM accounting_year WHERE id = " . $this->id . " AND intranet_id = ".$this->kernel->intranet->get('id'));
        if ($db->nextRecord()) {
            if ($db->f('locked') == 1) {
                return false;
            }
        }
        return true;
    }

    /**
     * is the date in the current year
     *
     * @param date $date Format: 0000-00-00
     *
     * @return boolean
     */
    public function isDateInYear($date)
    {
        if ($this->getId() == 0) {
            throw new Exception('Year has not been loaded yet - maybe not saved');
        }

        $date = safeToDb($date);

        $db = new Db_Sql;
        $db->query("SELECT from_date, to_date FROM accounting_year WHERE id= " . $this->id . " AND intranet_id = " . $this->kernel->intranet->get('id') . " LIMIT 1");
        if ($db->nextRecord()) {
            if ($db->f('from_date') <= $date and $date <= $db->f('to_date')) {

Using logical operators such as and instead of && is generally not recommended.

                return true;
            }
        }
        return false;
    }

    /**
     * Checks whether the year is ready to use for stating
     *
     * @return boolean
     */
    public function readyForState($date = null)
    {
        if ($date === null) {
            $date = date('Y-m-d');
        }

        $return = true;

        if (!$this->get('id')) {
            $this->error->set('Der er ikke sat noget år.');
            $return = false;
        } elseif (!$this->isDateInYear($date)) {
            $this->error->set('Datoen er ikke i det år, der er sat i regnskabsmodulet.');
            $return = false;
        } elseif ($this->get('locked') == 1) {
            $this->error->set('Året er ikke åbent for bogføring.');
            $return = false;
        }

        return $return;
    }

    /**************************************************************************
        �VRIGE METODER
    **************************************************************************/


    /**
     * Gets a list
     *
     * @return array
     */
    function getList()
    {
        $gateway = new Intraface_modules_accounting_YearGateway($this->kernel);
        return $gateway->getList();
        /*

62% of this comment could be valid code. Did you maybe forget this after debugging?

        if (!is_object($this->kernel)) {
            throw new Exception('Du kan ikke k�re Year::getList() uden at have instatieret klassen', FATAL);
        }
        $sql = "SELECT id, label FROM accounting_year
            WHERE intranet_id = ".$this->kernel->intranet->get('id')."
            ORDER BY from_date ASC";

        $db = new DB_Sql;
        $db->query($sql);

        if ($db->numRows() == 0) {
            return array();
        }

        while ($db->nextRecord()) {
            $account_years[$db->f("id")]['id'] = $db->f("id");
            $account_years[$db->f("id")]['label'] = $db->f("label");
        }

        return $account_years;
        */
    }

    function getBalanceAccounts()
    {
        // afstemningskonti
        $balance_accounts = unserialize($this->getSetting('balance_accounts'));

        if (!is_array($balance_accounts)) {
            throw new Exception('Balance accounts are not an array');
        }

        $sql_where = "";

        if (!empty($balance_accounts) and count($balance_accounts) > 0) {

Using logical operators such as and instead of && is generally not recommended.

            foreach ($balance_accounts as $account) {
                $sql_where .= "id = " . $account . " OR ";
            }
        }
        // hvis der ikke er nogen balance_accounts skal den ikke v�lge nogen poster
        $sql_where .= "id=0";

        $db = new DB_Sql;
        $db->query("SELECT id FROM accounting_account
            WHERE (".$sql_where.")
            	AND intranet_id = " . $this->kernel->intranet->get('id') . "
            	AND year_id = " . $this->get('id'));

        $accounts = array(); // afstemningskonti
        $i = 0;
        while ($db->nextRecord()) {
            $oAccount = new Account($this, $db->f('id'));
            $oAccount->getSaldo('stated');
            $saldo = $oAccount->get('saldo');
            $oAccount->getSaldo('draft'); // f�r et array

            $accounts[$i]['id'] = $oAccount->get('id');
            $accounts[$i]['name'] = $oAccount->get('name');
            $accounts[$i]['number'] = $oAccount->get('number');
            $accounts[$i]['saldo_primo'] = $saldo;
            $accounts[$i]['saldo_draft'] = (float)$oAccount->get('saldo_draft');
            $accounts[$i]['saldo_ultimo'] = $saldo + $oAccount->get('saldo_draft');
            $i++;
        }
        return $accounts;
    }

    function setSetting($setting, $value)
    {
        return $this->kernel->getSetting()->set('intranet', 'accounting.'.$setting, $value, $this->get('id'));
    }

    function getSetting($setting)
    {
        return $this->kernel->getSetting()->get('intranet', 'accounting.' . $setting, $this->get('id'));
    }

    function createAccounts($type, $last_year_id = 0)
    {
        if ($this->getId() == 0) {
            throw new Exception('Year has no id');
        }

        $last_year_id = (int)$last_year_id;
        switch ($type) {
            case 'standard':
                    $standardaccounts = array();
                    /*

49% of this comment could be valid code. Did you maybe forget this after debugging?

                    // HACK
                    include(ROOT_PATH . 'intraface_modules/accounting/standardaccounts.php');
                    // HACK

                    if (empty($standardaccounts)) {
                        return 0;
                    }
                    */

                    // $module_accounting = $this->kernel->useModule('accounting');

58% of this comment could be valid code. Did you maybe forget this after debugging?

                    // $module_accounting->includeFile('standardaccounts.php');

75% of this comment could be valid code. Did you maybe forget this after debugging?

                    // HACK
                    // include($module_accounting->includeFile('standardaccounts.php')); // 'intraface_modules/accounting/standardaccounts.php');

75% of this comment could be valid code. Did you maybe forget this after debugging?

                    // HACK

                    include('Intraface/modules/accounting/standardaccounts.php');

                if (empty($standardaccounts)) {
                    return false;
                }

                    $balance_accounts = array();
                    $buy_abroad = array();
                    $buy_eu = array();

                foreach ($standardaccounts as $input) {
                    require_once 'Intraface/modules/accounting/Account.php';
                    $account = new Account($this);
                    $input['vat_percent'] = $this->kernel->getSetting()->get('intranet', 'vatpercent');
                    $id = $account->save($input);

                    // settings
                    if (!empty($input['setting'])) {
                        $this->setSetting($input['setting'] . '_account_id', $id);
                    }
                    if (!empty($input['balance_account']) and $input['balance_account'] == 1) {

Using logical operators such as and instead of && is generally not recommended.

                        $balance_accounts[] = $id;
                    }
                    if (!empty($input['result_account_id_start']) and $input['result_account_id_start']) {

Using logical operators such as and instead of && is generally not recommended.

                        $this->setSetting('result_account_id_start', $id);
                    }

                    if (!empty($input['result_account_id_end']) and $input['result_account_id_end']) {

Using logical operators such as and instead of && is generally not recommended.

                        $this->setSetting('result_account_id_end', $id);
                    }

                    if (!empty($input['balance_account_id_start']) and $input['balance_account_id_start']) {

Using logical operators such as and instead of && is generally not recommended.

                        $this->setSetting('balance_account_id_start', $id);
                    }
                    if (!empty($input['capital_account']) and $input['capital_account']) {

Using logical operators such as and instead of && is generally not recommended.

                        $this->setSetting('capital_account_id', $id);
                    }
                    if (!empty($input['balance_account_id_end']) and $input['balance_account_id_end']) {

Using logical operators such as and instead of && is generally not recommended.

                        $this->setSetting('balance_account_id_end', $id);
                    }

                    if (!empty($input['buy_eu']) and $input['buy_eu'] == 1) {

Using logical operators such as and instead of && is generally not recommended.

                        $buy_eu[] = $id;
                    }
                    if (!empty($input['buy_abroad']) and $input['buy_abroad'] == 1) {

Using logical operators such as and instead of && is generally not recommended.

                        $buy_abroad[] = $id;
                    }
                }

                    $this->setSetting('balance_accounts', serialize($balance_accounts));
                    $this->setSetting('buy_abroad_accounts', serialize($buy_abroad));
                    $this->setSetting('buy_eu_accounts', serialize($buy_eu));

                break;
            case 'transfer_from_last_year':
                    // oprette konti
                if ($last_year_id == 0) {
                    return false;
                }
                    $last_year = new Year($this->kernel, $last_year_id);
                    $account = new Account($last_year);
                    $accounts = $account->getList();

                foreach ($accounts as $a) {
                    $old_account = new Account($last_year, $a['id']);
                    $input = $old_account->get();
                    $input['created_from_id'] = $old_account->get('id');
                    $new_account = new Account($this);
                    $new_account->save($input);
                }
                    // transfer setttings
                    // old account id will be connected to the new account
                if ($this->get('vat') > 0) {
                    $this->transferAccountSetting($last_year, 'vat_in_account_id');
                    $this->transferAccountSetting($last_year, 'vat_abroad_account_id');
                    $this->transferAccountSetting($last_year, 'vat_out_account_id');
                    $this->transferAccountSetting($last_year, 'vat_balance_account_id');
                    $this->transferAccountSetting($last_year, 'vat_free_account_id');
                    $this->transferAccountSetting($last_year, 'eu_sale_account_id');
                    //$this->transferAccountSetting($last_year, 'eu_buy_account_id');

80% of this comment could be valid code. Did you maybe forget this after debugging?

                    //$this->transferAccountSetting($last_year, 'abroad_buy_account_id');

80% of this comment could be valid code. Did you maybe forget this after debugging?

                }
                    $this->transferAccountSetting($last_year, 'result_account_id');
                    $this->transferAccountSetting($last_year, 'debtor_account_id');
                    $this->transferAccountSetting($last_year, 'credit_account_id');

                    $this->transferAccountSetting($last_year, 'result_account_id_start');
                    $this->transferAccountSetting($last_year, 'result_account_id_end');
                    $this->transferAccountSetting($last_year, 'balance_account_id_start');
                    $this->transferAccountSetting($last_year, 'balance_account_id_end');
                    $this->transferAccountSetting($last_year, 'capital_account_id');

                    $balance_accounts = unserialize($last_year->getSetting('balance_accounts'));

                    $db = new DB_Sql;
                    $new_balance_accounts = array();

                if (is_array($balance_accounts)) {
                    foreach ($balance_accounts as $key => $id) {
                        $db->query("SELECT id FROM accounting_account WHERE year_id = ".$this->get('id')." AND intranet_id = ".$this->kernel->intranet->get('id')." AND created_from_id = " . (int)$id);
                        while ($db->nextRecord()) {
                            $new_balance_accounts[] = $db->f('id');
                        }
                    }
                }
                    $this->setSetting('balance_accounts', serialize($new_balance_accounts));

                    $buy_eu_accounts = unserialize($last_year->getSetting('buy_eu_accounts'));

                    $db = new DB_Sql;
                    $new_buy_eu_accounts = array();

                if (is_array($buy_eu_accounts)) {
                    foreach ($buy_eu_accounts as $key => $id) {
                        $db->query("SELECT id FROM accounting_account WHERE year_id = ".$this->get('id')." AND intranet_id = ".$this->kernel->intranet->get('id')." AND created_from_id = " . (int)$id);
                        while ($db->nextRecord()) {
                            $new_buy_eu_accounts[] = $db->f('id');
                        }
                    }
                }
                    $this->setSetting('buy_eu_accounts', serialize($new_buy_eu_accounts));

                    $buy_abroad_accounts = unserialize($last_year->getSetting('buy_abroad_accounts'));

                    $db = new DB_Sql;
                    $new_buy_abroad_accounts = array();

                if (is_array($buy_abroad_accounts)) {
                    foreach ($buy_abroad_accounts as $key => $id) {
                        $db->query("SELECT id FROM accounting_account WHERE year_id = ".$this->get('id')." AND intranet_id = ".$this->kernel->intranet->get('id')." AND created_from_id = " . (int)$id);
                        while ($db->nextRecord()) {
                            $new_buy_abroad_accounts[] = $db->f('id');
                        }
                    }
                }
                    $this->setSetting('buy_abroad_accounts', serialize($new_buy_abroad_accounts));


                break;
            default:
                throw new Exception('A method to create the accounts must be chosen');
                break;

break; does not seem to be reachable.

        }
        return true;
    }

    function setSettings($input)
    {
        if ($this->get('vat') > 0) {
            if (empty($input['vat_in_account_id'])) {
                $input['vat_in_account_id'] = 0;
            }
            $this->setSetting('vat_in_account_id', (int)$input['vat_in_account_id']);

            if (empty($input['vat_out_account_id'])) {
                $input['vat_out_account_id'] = 0;
            }
            $this->setSetting('vat_out_account_id', (int)$input['vat_out_account_id']);

            if (empty($input['vat_abroad_account_id'])) {
                $input['vat_abroad_account_id'] = 0;
            }
            $this->setSetting('vat_abroad_account_id', (int)$input['vat_abroad_account_id']);

            if (empty($input['vat_balance_account_id'])) {
                $input['vat_balance_account_id'] = 0;
            }
            $this->setSetting('vat_balance_account_id', (int)$input['vat_balance_account_id']);

            if (empty($input['vat_free_account_id'])) {
                $input['vat_free_account_id'] = 0;
            }
            $this->setSetting('vat_free_account_id', (int)$input['vat_free_account_id']);

            if (empty($input['eu_sale_account_id'])) {
                $input['eu_sale_account_id'] = 0;
            }
            $this->setSetting('eu_sale_account_id', (int)$input['eu_sale_account_id']);
            //$this->setSetting('eu_buy_account_id', (int)$input['eu_buy_account_id']);

86% of this comment could be valid code. Did you maybe forget this after debugging?

            //$this->setSetting('abroad_buy_account_id', (int)$input['abroad_buy_account_id']);

86% of this comment could be valid code. Did you maybe forget this after debugging?

        }
        if (empty($input['result_account_id'])) {
            $input['result_account_id'] = 0;
        }
        $this->setSetting('result_account_id', (int)$input['result_account_id']);

        if (empty($input['debtor_account_id'])) {
            $input['debtor_account_id'] = 0;
        }
        $this->setSetting('debtor_account_id', (int)$input['debtor_account_id']);

        if (empty($input['credit_account_id'])) {
            $input['credit_account_id'] = 0;
        }
        $this->setSetting('credit_account_id', (int)$input['credit_account_id']);

        if (empty($input['balance_accounts'])) {
            $input['balance_accounts'] = array();
        }
        $this->setSetting('balance_accounts', serialize($input['balance_accounts']));

        if (empty($input['buy_abroad_accounts'])) {
            $input['buy_abroad_accounts'] = array();
        }
        $this->setSetting('buy_abroad_accounts', serialize($input['buy_abroad_accounts']));

        if (empty($input['buy_eu_accounts'])) {
            $input['buy_eu_accounts'] = array();
        }
        $this->setSetting('buy_eu_accounts', serialize($input['buy_eu_accounts']));


        if (empty($input['result_account_id_start'])) {
            $input['result_account_id_start'] = 0;
        }
        $this->setSetting('result_account_id_start', $input['result_account_id_start']);

        if (empty($input['result_account_id_end'])) {
            $input['result_account_id_end'] = 0;
        }
        $this->setSetting('result_account_id_end', $input['result_account_id_end']);

        if (empty($input['balance_account_id_start'])) {
            $input['balance_account_id_start'] = 0;
        }
        $this->setSetting('balance_account_id_start', $input['balance_account_id_start']);

        if (empty($input['balance_account_id_end'])) {
            $input['balance_account_id_end'] = 0;
        }
        $this->setSetting('balance_account_id_end', $input['balance_account_id_end']);

        if (empty($input['capital_account_id'])) {
            $input['capital_account_id'] = 0;
        }
        $this->setSetting('capital_account_id', $input['capital_account_id']);

        return true;
    }

    function getSettings()
    {
        if ($this->get('vat') > 0) {
            $setting['vat_in_account_id'] = $this->getSetting('vat_in_account_id');

$setting was never initialized. Although not strictly required by PHP, it is generally a good practice to add $setting = array(); before regardless.

            $setting['vat_out_account_id'] = $this->getSetting('vat_out_account_id');
            $setting['vat_abroad_account_id'] = $this->getSetting('vat_abroad_account_id');
            $setting['vat_balance_account_id'] = $this->getSetting('vat_balance_account_id');
            $setting['vat_free_account_id'] = $this->getSetting('vat_free_account_id');
            $setting['eu_sale_account_id'] = $this->getSetting('eu_sale_account_id');
            //$setting['eu_buy_account_id'] = $this->getSetting('eu_buy_account_id');

72% of this comment could be valid code. Did you maybe forget this after debugging?

            //$setting['abroad_buy_account_id'] = $this->getSetting('abroad_buy_account_id');

72% of this comment could be valid code. Did you maybe forget this after debugging?

        }
        $setting['result_account_id'] = $this->getSetting('result_account_id');

The variable $setting does not seem to be defined for all execution paths leading up to this point.

        $setting['debtor_account_id'] = $this->getSetting('debtor_account_id');
        $setting['credit_account_id'] = $this->getSetting('credit_account_id');
        $setting['balance_accounts'] = unserialize($this->getSetting('balance_accounts'));
        $setting['buy_eu_accounts'] = unserialize($this->getSetting('buy_eu_accounts'));
        $setting['buy_abroad_accounts'] = unserialize($this->getSetting('buy_abroad_accounts'));

        $setting['result_account_id_start'] = $this->getSetting('result_account_id_start');
        $setting['result_account_id_end'] = $this->getSetting('result_account_id_end');
        $setting['balance_account_id_start'] = $this->getSetting('balance_account_id_start');
        $setting['balance_account_id_end'] = $this->getSetting('balance_account_id_end');

        $setting['capital_account_id'] = $this->getSetting('capital_account_id');

        return $setting;
    }

    /**
     * @param $from->year (object)
     * @param $setting (string)
     */
    function transferAccountSetting($from_year, $setting)
    {
        $account_id = $from_year->getSetting($setting);
        $db = new DB_Sql;
        $db->query("SELECT id FROM accounting_account WHERE year_id = ".$this->get('id')." AND intranet_id = ".$this->kernel->intranet->get('id')." AND created_from_id = " . $account_id);
        if ($db->nextRecord()) {
            $this->setSetting($setting, $db->f('id'));
        }
    }

    function isSettingsSet()
    {
        if (!$this->getSetting('result_account_id_start') or !$this->getSetting('result_account_id_end') or !$this->getSetting('balance_account_id_start') or !$this->getSetting('balance_account_id_end') or !$this->getSetting('capital_account_id')) {

Using logical operators such as or instead of || is generally not recommended.

            return false;
        }
        return true;
    }

    /**
     *
     */
    function isBalanced()
    {
        $this->value['year_saldo'] = 0;

        $db = new DB_Sql;
        $db2 = new Db_Sql;

$db2 is not used, you could remove the assignment.

        $db->query("SELECT distinct(account.id)
            FROM accounting_account account
            LEFT JOIN accounting_post post
                ON account.id = post.account_id
            WHERE
                account.intranet_id = ".$this->kernel->intranet->get('id')."
                AND account.active = 1
                AND account.year_id = ".$this->get('id')."
            ORDER BY account.number ASC");
        $i = 0;
        while ($db->nextRecord()) {
            $account = new Account($this, $db->f('id'));

            # ikke sum konti
            if ($account->get('type_key') == array_search('sum', $account->types)) {
                continue;
            }

            $account->getSaldo();

            $i++;
        }

        // HACK midlertidigt hack round() indtil alle beløb er integers i stedet for floats
        if (round($this->value['year_saldo']) == 0) {
            return true;
        } else {
            return false;
        }
    }

    /**************************************************************************
     * VALIDATE FUNCTIONS - IKKE EGENTLIG ÅRSRELATEREDE
     **************************************************************************/

    /**
     * Bruges i momsafregning og Årsafslutning
     *
     * @return boolean
     */
    function isStated($type, $date_start, $date_end)
    {
        if (!$this->kernel->user->hasModuleAccess('debtor')) {
            return true;
        }

        require_once 'Intraface/modules/debtor/Debtor.php';
        $types = Debtor::getDebtorTypes();
        $type_key = array_search($type, $types);
        if (empty($type_key)) {
            throw new Exception('Ugyldig type');
        }
        $db = new DB_Sql;
        $sql = "SELECT id FROM debtor
            WHERE type= " . $type_key . "
                AND intranet_id = " .$this->kernel->intranet->get('id') . "
                AND (this_date BETWEEN '" . $date_start . "' AND '" .$date_end . "')
                AND voucher_id = 0
                AND active = 1";
        $db->query($sql);
        if ($db->numRows() == 0) {
            return true;
        }
        return false;
    }
    
    function isPaymentsStated($date_start, $date_end)
    {
        $db = new DB_Sql;
        $sql = "SELECT id FROM invoice_payment
            WHERE intranet_id = " .$this->kernel->intranet->get('id') . "
                AND (payment_date BETWEEN '" . $date_start . "' AND '" .$date_end . "')
                AND voucher_id = 0";
        $db->query($sql);
        if ($db->numRows() == 0) {
            return true;
        }
        return false;
    }
    
    function isProcurementsStated($date_start, $date_end)
    {
        $db = new DB_Sql;
        $sql = "SELECT id FROM procurement
            WHERE intranet_id = " .$this->kernel->intranet->get('id') . "
                AND (invoice_date BETWEEN '" . $date_start . "' AND '" .$date_end . "')
                AND voucher_id = 0
                AND active = 1";
        $db->query($sql);
        if ($db->numRows() == 0) {
            return true;
        }
        return false;
    }

    function lock()
    {
        $db = new DB_Sql;
        $db->query("UPDATE accounting_year SET locked = 1 WHERE id = " . $this->id);
        return true;
    }

    public function getId()
    {
        return $this->get('id');
    }
}