UserTest

Complexity

Total Complexity

18

Size/Duplication

Total Lines	166
Duplicated Lines	12.65 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes

0

18 Methods

Rating	Name	Duplication	Size	Complexity
A	setUp()	0	20	1
A	tearDown()	0	4	1
A	testConstructionOfUser()	0	4	1
A	testIntranetAccessReturnsTrueWhenTheUserHasIntranetAccessAndFalseIfNot()	0	8	1
A	testUserModuleAccessOnlyWorksWhenTheUserHasAnActiveIntranetId()	0	13	1
A	testSubAccessReturnsFalseOnANotInitializedSubAccess()	0	6	1
A	testSetActiveIntranetReturnsAValueLargerThanZero()	0	7	1
A	testGetPermissionsReturnsAnArray()	0	4	1
A	testHasModuleAccessReturnsTrueOnAccess()	0	8	1
A	testHasModuleAccessReturnsFalseIfAccessIsNotGranted()	0	7	1
A	testClearCachedPermissionsEmptiesPermissionArrayAndSetsPermissionLoadedToFalse()	0	9	1
A	testGetAddressReturnsObject()	0	4	1
A	testGetActiveIntranetIdReturnsCorrectIntranetIdEvenBeforeItIsSpecificallySetBySetActiveIntranetId()	0	6	1
A	testGetActiveIntranetIdReturnsActiveIdWhenFirstSetBySetActiveIntranetId()	0	8	1
A	testIsFilledInReturnsFalseWhenNothingHasBeenDoneToSetupTheUser()	0	6	1
A	testUpdatePasswordReturnsTrue()	10	10	1
A	testUpdatePasswordReturnsFalseIfNewPasswordsDoNotMatch()	11	11	1
A	testGetIdReturnsTheIdOfTheUSer()	0	4	1

<?php
require_once 'Intraface/User.php';
require_once 'Intraface/modules/intranetmaintenance/ModuleMaintenance.php';
require_once 'Intraface/modules/intranetmaintenance/UserMaintenance.php';
require_once 'Intraface/modules/intranetmaintenance/IntranetMaintenance.php';
require_once 'Intraface/Validator.php';

class UserTest extends PHPUnit_Framework_TestCase
{
    private $user;

    function setUp()
    {
        $db = MDB2::singleton(DB_DSN);
        $db->exec('TRUNCATE user');
        $db->exec('TRUNCATE intranet');
        $db->exec('TRUNCATE modules');
        $db->exec('TRUNCATE permission');

        // @todo this has the notion with the standard database setup
        $u = new UserMaintenance();
        $u->update(array('email' => 'start@intraface.dk', 'password' => '123456', 'confirm_password' => '123456', 'disabled' => 0));

        $i = new IntranetMaintenance();
        $i->save(array('name' => 'intraface', 'identifier' => 'intraface'));

        $m = new ModuleMaintenance();
        $result = $m->register();

$result is not used, you could remove the assignment.

        $this->user = new Intraface_User(1);
    }

    function tearDown()
    {
        $this->user = null;
    }

    ////////////////////////////////////////////////////////////////////////////

    function testConstructionOfUser()
    {
        $this->assertTrue(is_object($this->user));
    }

    function testIntranetAccessReturnsTrueWhenTheUserHasIntranetAccessAndFalseIfNot()
    {
        $u = new UserMaintenance(1);
        $u->setIntranetAccess(1);

        $this->assertTrue($this->user->hasIntranetAccess(1));
        $this->assertFalse($this->user->hasIntranetAccess(2));
    }

    function testUserModuleAccessOnlyWorksWhenTheUserHasAnActiveIntranetId()
    {
        $u = new UserMaintenance(1);
        $u->setModuleAccess('intranetmaintenance', 1);

        // TODO how should we handle unknown modules
        // TODO and setup modules we can count on for the test
        $this->assertFalse($this->user->hasModuleAccess('intranetmaintenance'));
        $this->assertFalse($this->user->hasModuleAccess('todo'));
        $this->user->setIntranetId(1); // sp�rgsm�let er om man bare skal have en init i stedet?
        $this->assertTrue($this->user->hasModuleAccess('intranetmaintenance'));
        $this->assertFalse($this->user->hasModuleAccess('todo'));
    }

    function testSubAccessReturnsFalseOnANotInitializedSubAccess()
    {
        $u = new UserMaintenance(1);
        $u->setIntranetAccess(1);
        $this->assertFalse($this->user->hasSubAccess(1, 1));
    }

    function testSetActiveIntranetReturnsAValueLargerThanZero()
    {
        $u = new UserMaintenance(1);
        $u->setModuleAccess('intranetmaintenance', 1);

        $this->assertTrue($this->user->setActiveIntranetId(1) > 0);
    }

    function testGetPermissionsReturnsAnArray()
    {
        $this->assertTrue(is_array($this->user->getPermissions()));
    }

    function testHasModuleAccessReturnsTrueOnAccess()
    {
        $u = new UserMaintenance(1);
        $u->setModuleAccess('intranetmaintenance', 1);

        $this->user->setIntranetId(1);
        $this->assertTrue($this->user->hasModuleAccess('intranetmaintenance'));
    }

    function testHasModuleAccessReturnsFalseIfAccessIsNotGranted()
    {
        $u = new UserMaintenance(1);
        $u->setIntranetAccess(1);
        $this->user->setIntranetId(1);
        $this->assertFalse($this->user->hasModuleAccess('todo'));
    }

    function testClearCachedPermissionsEmptiesPermissionArrayAndSetsPermissionLoadedToFalse()
    {
        $u = new UserMaintenance(1);
        $u->setIntranetAccess(1);

        $this->user->setIntranetId(1);
        $this->user->clearCachedPermission();
        $this->assertEquals(0, count($this->user->getPermissions()));
    }

    function testGetAddressReturnsObject()
    {
        $this->assertTrue(is_object($this->user->getAddress()));
    }

    /**
     * @todo Is this correct?
     */
    function testGetActiveIntranetIdReturnsCorrectIntranetIdEvenBeforeItIsSpecificallySetBySetActiveIntranetId()
    {
        $u = new UserMaintenance(1);
        $u->setIntranetAccess(1);
        $this->assertEquals(1, $this->user->getActiveIntranetId());
    }

    function testGetActiveIntranetIdReturnsActiveIdWhenFirstSetBySetActiveIntranetId()
    {
        $u = new UserMaintenance(1);
        $u->setIntranetAccess(1);

        $this->user->setActiveIntranetId(1);
        $this->assertEquals(1, $this->user->getActiveIntranetId());
    }

    function testIsFilledInReturnsFalseWhenNothingHasBeenDoneToSetupTheUser()
    {
        $u = new UserMaintenance(1);
        $u->setIntranetAccess(1);
        $this->assertFalse($this->user->isFilledIn());
    }

    function testUpdatePasswordReturnsTrue()

This method seems to be duplicated in your project.

    {
        $u = new UserMaintenance(1);
        $u->setIntranetAccess(1);

        $old = '123456';
        $new = 'newpass';

        $this->assertTrue($this->user->updatePassword($old, $new, $new));
    }

    function testUpdatePasswordReturnsFalseIfNewPasswordsDoNotMatch()

This method seems to be duplicated in your project.

    {
        $u = new UserMaintenance(1);
        $u->setIntranetAccess(1);

        $old = '123456';
        $new = 'newpass';
        $new1 = 'nomatch';

        $this->assertFalse($this->user->updatePassword($old, $new, $new1));
    }

    function testGetIdReturnsTheIdOfTheUSer()
    {
        $this->assertEquals(1, $this->user->getId());
    }
}