Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
6 | class TemplateSectionTest extends PHPUnit_Framework_TestCase |
||
7 | { |
||
8 | |||
9 | function setUp() |
||
13 | |||
14 | function createKernel() |
||
20 | |||
21 | function createTemplate() |
||
25 | |||
26 | function createSite() |
||
30 | |||
31 | function testConstruction() |
||
36 | |||
37 | View Code Duplication | function testSaveReturnsInteger() |
|
44 | |||
45 | function testAddParameterReturnsTrue() |
||
53 | |||
54 | View Code Duplication | function testDelete() |
|
61 | } |
||
62 |
In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code:
Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: