ProductDoctrineTest - Code Metrics - intraface/intraface.dk - Measure and Improve Code Quality continuously with Scrutinizer

ProductDoctrineTest B
last analyzed 2017-03-20 12:20 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	629
Duplicated Lines	3.82 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes

Metric	Value
dl	24
loc	629
rs	8.3999
c	0
b	0
f	0
wmc	38
lcom	1
cbo	5

20 Methods

Rating	Name	Duplication	Size	Complexity
A	setUp()	0	16	1
A	createProductObject()	0	10	2
A	createNewProduct()	13	13	1
A	createNewProductWithVariations()	0	10	1
A	testSaveProductReturnsIdOfProductOnSuccess()	0	21	2
A	testSaveThrowsExceptionOnEmptyProduct()	0	7	1
A	testSaveThrowsExceptionOnEmptyProductDetails()	0	8	1
A	testSaveThrowsExceptionOnEmptyName()	0	7	1
A	testSaveThrowsExceptionOnNoNameButFilledInPrice()	0	7	1
B	testSaveIncreasesNumberOnNewProduct()	0	40	3
B	testSavePersistsItselfAndCanSaveAgainStillHavingTheSameNumber()	0	29	3
B	testSaveStateAccountIdInProductDetailsDoesntChangeOtherValues()	0	35	2
B	testChangeProductNameSavesAsNewDetail()	0	28	3
B	testChangeProductPriceSavesAsNewDetail()	0	28	3
B	testDetailsIsNotUpdatedWhenErrorInTranslation()	0	30	3
B	testLoadEarlierDetails()	0	27	3
A	testShowInShop()	0	19	3
A	testSetAttributeGroupThrowsExceptionOnWhenNotSavedWithVariations()	0	16	2
A	testSetAttributeGroup()	11	11	1
B	testGetAttributeGroups()	0	43	1

How to fix Duplicated Code

<?php
Intraface_Doctrine_Intranet::singleton(1);

class ProductDoctrineTest extends PHPUnit_Framework_TestCase
{

    function setUp()
    {
        $connection = Doctrine_Manager::connection();
        // $query = $connection->getQuery();

        $connection->exec('TRUNCATE product');
        $connection->exec('TRUNCATE product_attribute');
        $connection->exec('TRUNCATE product_attribute_group');
        $connection->exec('TRUNCATE product_detail');
        $connection->exec('TRUNCATE product_detail_translation');
        $connection->exec('TRUNCATE product_variation');
        $connection->exec('TRUNCATE product_variation_detail');
        $connection->exec('TRUNCATE product_variation_x_attribute');
        $connection->exec('TRUNCATE product_x_attribute_group');

        $connection->clear();
    }

    function createProductObject($id = 0)
    {
        if ($id != 0) {
            $connection = Doctrine_Manager::connection();
            $connection->clear(); // clear repo, so that we are sure data are loaded again.
            $gateway = new Intraface_modules_product_ProductDoctrineGateway($connection, null);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            return $gateway->findById($id);
        }
        return new Intraface_modules_product_ProductDoctrine;
    }

    function createNewProduct()

    {
        $product = $this->createProductObject();
        $product->getDetails()->Translation['da']->name = 'Test';
        $product->getDetails()->Translation['da']->description = '';
        $product->getDetails()->price = new Ilib_Variable_Float(20);
        $product->getDetails()->unit = 1;
        $product->save();
        $product->refresh(true);
        return $product;
        // $product->save(array('name' => 'Test', 'price' => 20, 'unit' => 1));

        // return $product;
    }

    function createNewProductWithVariations()
    {
        $product = $this->createNewProduct();
        $product->has_variation = 1;
        $product->save();
        $product->refresh(true);
        return $product;
        // $product->save(array('name' => 'Test', 'price' => 20, 'unit' => 1, 'has_variation' => true));

        // return $product;
    }

    ////////////////////////////////////////////////////////////////////////////

    function testSaveProductReturnsIdOfProductOnSuccess()
    {
        $product = $this->createProductObject();
        $name = 'Test';
        $price = 20;
        $product->getDetails()->Translation['da']->name = 'Test';
        $product->getDetails()->Translation['da']->description = '';
        $product->getDetails()->price = new Ilib_Variable_Float(20);

        try {
            $product->save();
        } catch (Exception $e) {
            $this->fail($e);
        }

        $product->refresh(true);

        $this->assertEquals(1, $product->getDetails()->getNumber());
        $this->assertEquals($name, $product->getDetails()->getTranslation('da')->name);
        $this->assertEquals($price, $product->getDetails()->getPrice()->getAsIso());
    }

    function testSaveThrowsExceptionOnEmptyProduct()
    {
        $product = $this->createProductObject();
        
        $this->setExpectedException('Exception');
        $product->save();
    }
    
    function testSaveThrowsExceptionOnEmptyProductDetails()
    {
        $product = $this->createProductObject();
        $product->getDetails();
        
        $this->setExpectedException('Exception');
        $product->save();
    }

    function testSaveThrowsExceptionOnEmptyName()
    {
        $product = $this->createProductObject();
        $product->getDetails()->Translation['da']->name = '';
        $this->setExpectedException('Doctrine_Validator_Exception');
        $product->save();
    }

    function testSaveThrowsExceptionOnNoNameButFilledInPrice()
    {
        $product = $this->createProductObject();
        $product->getDetails()->price = new Ilib_Variable_Float(20);
        $this->setExpectedException('Exception');
        $product->save();
    }

    function testSaveIncreasesNumberOnNewProduct()
    {
        $product = $this->createProductObject();
        $name = 'Test';
        $price = 20;
        $product->getDetails()->Translation['da']->name = $name;
        $product->getDetails()->Translation['da']->description = '';
        $product->getDetails()->price = new Ilib_Variable_Float($price);

        try {
            $product->save();
        } catch (Exception $e) {
            $this->fail('Exception thrown '.$e->__toString());
        }

        $product->refresh(true);

        $this->assertEquals(1, $product->getDetails()->getNumber());
        $this->assertEquals($name, $product->getDetails()->getTranslation('da')->name);
        $this->assertEquals($price, $product->getDetails()->getPrice()->getAsIso());

        $product = $this->createProductObject();
        $name = 'Test 3';
        $price = 30;
        $product->getDetails()->Translation['da']->name = $name;
        $product->getDetails()->Translation['da']->description = '';
        $product->getDetails()->price = new Ilib_Variable_Float($price);

        try {
            $product->save();
        } catch (Exception $e) {
            $this->fail('Exception thrown '.$e->__toString());
        }

        $product->refresh(true);

        $this->assertEquals(2, $product->getDetails()->getNumber());
        $this->assertEquals($name, $product->getDetails()->getTranslation('da')->name);
        $this->assertEquals($price, $product->getDetails()->getPrice()->getAsIso());
    }

    function testSavePersistsItselfAndCanSaveAgainStillHavingTheSameNumber()
    {
        $product = $this->createProductObject();
        $name = 'Test';
        $price = 20;
        $product->getDetails()->Translation['da']->name = $name;
        $product->getDetails()->Translation['da']->description = '';
        $product->getDetails()->price = new Ilib_Variable_Float($price);

        try {
            $product->save();
        } catch (Exception $e) {
            $this->fail('Exception thrown '.$e->__toString());
        }
        $product->refresh(true);

        $name = 'Test 2';
        $product->getDetails()->Translation['da']->name = $name;
        try {
                $product->save();
        } catch (Exception $e) {
            $this->fail('Exception thrown '.$e->__toString());
        }
        $product->refresh(true);

        $this->assertEquals(1, $product->getDetails()->getNumber());
        $this->assertEquals($name, $product->getDetails()->getTranslation('da')->name);
        $this->assertEquals($price, $product->getDetails()->getPrice()->getAsIso());
    }


    function testSaveStateAccountIdInProductDetailsDoesntChangeOtherValues()
    {
        $product = $this->createProductObject();
        $name = 'Test';
        $price = 20;
        $product->getDetails()->Translation['da']->name = 'Test';
        $product->getDetails()->Translation['da']->description = '';
        $product->getDetails()->price = new Ilib_Variable_Float(20);
        $product->getDetails()->state_account_id = 10;

        try {
            $product->save();
        } catch (Exception $e) {
            $this->fail('Exception thrown '.$e->__toString());
        }

        $product->refresh(true);

        $id = $product->getId();
        $this->assertEquals(1, $product->getDetails()->getNumber());
        $this->assertEquals($name, $product->getDetails()->getTranslation('da')->name);
        $this->assertEquals($price, $product->getDetails()->getPrice()->getAsIso());
        $this->assertEquals(10, $product->getDetails()->getStateAccountId());


        $product = $this->createProductObject($id);
        $this->assertEquals($id, $product->getId());
        $this->assertTrue($product->getDetails()->setStateAccountId(20));

        $product->refresh(true);

        $this->assertEquals(1, $product->getDetails()->getNumber());
        $this->assertEquals($name, $product->getDetails()->getTranslation('da')->name);
        $this->assertEquals(20, $product->getDetails()->getStateAccountId());
    }

    function testChangeProductNameSavesAsNewDetail()
    {
        $product = $this->createProductObject();
        $product->getDetails()->Translation['da']->name = 'Test';
        $product->getDetails()->price = new Ilib_Variable_Float(20);

        try {
            $product->save();
        } catch (Exception $e) {
            $this->fail('Exception thrown '.$e->__toString());
        }

        $product->refresh(true);
        $this->assertEquals(1, $product->getDetails()->getId());
        $this->assertEquals('Test', $product->getDetails()->getTranslation('da')->name);

        $product->getDetails()->Translation['da']->name = 'Test 2';
        try {
            $product->save();
        } catch (Exception $e) {
            $this->fail('Exception thrown '.$e->__toString());
        }
        $product->refresh(true);
        // $product = $this->createProductObject($product->get('id'));


        $this->assertEquals(2, $product->getDetails()->getId());
        $this->assertEquals('Test 2', $product->getDetails()->getTranslation('da')->name);
    }

    function testChangeProductPriceSavesAsNewDetail()
    {
        $product = $this->createProductObject();
        $product->getDetails()->Translation['da']->name = 'Test';
        $product->getDetails()->price = new Ilib_Variable_Float(20);

        try {
            $product->save();
        } catch (Exception $e) {
            $this->fail('Exception thrown '.$e->__toString());
        }

        $product->refresh(true);
        $this->assertEquals(1, $product->getDetails()->getId());
        $this->assertEquals(20, $product->getDetails()->getPrice()->getAsIso());

        $product->getDetails()->price = new Ilib_Variable_Float(30);
        try {
            $product->save();
        } catch (Exception $e) {
            $this->fail('Exception thrown '.$e->__toString());
        }
        $product->refresh(true);
        // $product = $this->createProductObject($product->get('id'));


        $this->assertEquals(2, $product->getDetails()->getId());
        $this->assertEquals(30, $product->getDetails()->getPrice()->getAsIso());
    }
    
    function testDetailsIsNotUpdatedWhenErrorInTranslation()
    {
        $product = $this->createProductObject();
        $product->getDetails()->Translation['da']->name = 'Test';
        $product->getDetails()->price = new Ilib_Variable_Float(20);

        try {
            $product->save();
        } catch (Exception $e) {
            $this->fail('Exception thrown '.$e->__toString());
        }
        
        $product->refresh(true);
        $this->assertEquals(1, $product->getDetails()->getId());
        $this->assertEquals(20, $product->getDetails()->getPrice()->getAsIso());

        $product->getDetails()->Translation['da']->name = '';
        $product->getDetails()->price = new Ilib_Variable_Float(30);
        try {
            $product->save();
        } catch (Exception $e) {
            // we excpect error.
            // $this->fail('Exception thrown '.$e->__toString());

        }
        $product->refresh(true);
        // $product = $this->createProductObject($product->get('id'));


        $this->assertEquals(1, $product->getDetails()->getId());
        $this->assertEquals(20, $product->getDetails()->getPrice()->getAsIso());
    }

    public function testLoadEarlierDetails()
    {
        $product = $this->createProductObject();
        $product->getDetails()->Translation['da']->name = 'Test';
        $product->getDetails()->price = new Ilib_Variable_Float(20);

        try {
            $product->save();
        } catch (Exception $e) {
            $this->fail('Exception thrown '.$e->__toString());
        }

        $product->refresh(true);
        $this->assertEquals(1, $product->getDetails()->getId());
        $this->assertEquals('Test', $product->getDetails()->getTranslation('da')->name);

        $product->getDetails()->Translation['da']->name = 'Test 2';
        try {
            $product->save();
        } catch (Exception $e) {
            $this->fail('Exception thrown '.$e->__toString());
        }
        // $product->refresh(true);

        $product = $this->createProductObject(1);
        $this->assertEquals(1, $product->getDetails(1)->getId());
        $this->assertEquals('Test', $product->getDetails(1)->getTranslation('da')->name);
    }

    public function testShowInShop()
    {
        $product = $this->createProductObject();
        $product->getDetails()->Translation['da']->name = 'Test';
        $product->getDetails()->Translation['da']->description = '';
        $product->getDetails()->price = new Ilib_Variable_Float(20);
        $product->do_show = 1;
        try {
            $product->save();
        } catch (Exception $e) {
            foreach ($product->getErrorStack() as $field => $error) {
                echo $field;
                var_dump($error);

            }
        }

        $product = $this->createProductObject(1);
        $this->assertEquals(1, $product->showInShop());
    }
    
    function testSetAttributeGroupThrowsExceptionOnWhenNotSavedWithVariations()
    {
        $product = $this->createNewProduct();
        
        $group = new Intraface_modules_product_Attribute_Group;
        $group->name = 'Test1';
        $group->save();
        $group->load();
        
        try {
            $product->setAttributeGroup($group);
            $this->assertTrue(false, 'An excpetion is not thrown');
        } catch(Exception $e) {
            $this->assertEquals('You can not set attribute group for a product without variations!', $e->getMessage());
        }
    }

    function testSetAttributeGroup()

    {
        $product = $this->createNewProductWithVariations();
        
        $group = new Intraface_modules_product_Attribute_Group;
        $group->name = 'Test1';
        $group->save();
        $group->load();
        
        $this->assertTrue($product->setAttributeGroup($group));
    }
    
    function testGetAttributeGroups()
    {
        $product = $this->createNewProductWithVariations();

        $group = new Intraface_modules_product_Attribute_Group;
        $group->name = 'Test1';
        $group->save();
        $group->load();
        $product->setAttributeGroup($group);

        $group = new Intraface_modules_product_Attribute_Group;
        $group->name = 'Test2';
        $group->save();
        $group->load();
        $product->setAttributeGroup($group);

        $group = new Intraface_modules_product_Attribute_Group;
        $group->name = 'Test3';
        $group->save();
        $group->load();
        

        $expected = array(
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            0 => array(
                'id' => 1,
                'intranet_id' => 1,
                'name' => 'Test1',
                '_old_deleted' => 0,
                'deleted_at' => null
            ),
            1 => array(
                'id' => 2,
                'intranet_id' => 1,
                'name' => 'Test2',
                '_old_deleted' => 0,
                'deleted_at' => null
            )
        );
        
        $groups = $product->getAttributeGroups();
        
        $this->assertEquals(2, $groups->count());
    }

    /*

    function testMaxNumberIncrementsOnePrProductAdded()
    {
        $product = $this->createProductObject();
        $this->assertEquals(0, $product->getMaxNumber());
        $product = $this->createNewProduct();
        $this->assertEquals(1, $product->getMaxNumber());
    }

    function testProductCanGetNumberIfOtherProductDontNeedItAnymore()
    {
        $product = new Product($this->kernel);

        $number = $product->getMaxNumber() + 1;

        $new_number = $number + 1;
        if (!$product->save(array('number' => $number, 'name' => 'Test', 'price' => 20, 'unit' => 1))) {
            $product->error->view();
        }

        if (!$product->save(array('number' => $new_number, 'name' => 'Test', 'price' => 20, 'unit' => 1))) {
            $product->error->view();
        }

        $new_product = new Product($this->kernel);
        $array = array('number' => $number, 'name' => 'Test overtager nummer', 'price' => 20, 'unit' => 1);
        if (!$new_product->save($array)) {
            $new_product->error->view();
        }

        $this->assertEquals($number, $new_product->get('number'));
    }

    function testDeleteAProduct()
    {
        $product = $this->createNewProduct();
        $this->assertTrue($product->delete());
        $this->assertFalse($product->isActive());
    }

    function testUnDeleteAProduct()
    {
        $product = $this->createNewProduct();
        $product->delete();
        $this->assertFalse($product->isActive());
        $this->assertTrue($product->undelete());
        $this->assertTrue($product->isActive());
    }

    function testAProductCanStillBeLoadedEvenIfDeleted()
    {
        $product = $this->createNewProduct();
        $product_id = $product->get('id');
        $product->delete();

        $deletedproduct = $this->createProductObject($product_id);

        $this->assertEquals($product->get('id'), $deletedproduct->get('id'));
        $this->assertEquals($product->get('name'), $deletedproduct->get('name'));
        $this->assertEquals($product->get('price'), $deletedproduct->get('price'));
    }

    function testCopyProduct()
    {
        $product = $this->createNewProduct();
        $new_id = $product->copy();

        $newproduct = $this->createProductObject($new_id);

        $this->assertEquals(2, $newproduct->get('number'));
        $this->assertEquals('Test (kopi)', $newproduct->get('name'));
    }

    function testIsFilledInReturnsZeroWhenNoProductsHasBeenCreated()
    {
        $product = $this->createProductObject();
        $this->assertEquals(0, $product->isFilledIn());
    }

    function testSetRelatedProductReturnsTrueOnSuccessAndOneProductIsReturned()
    {
        $product = $this->createNewProduct();
        $product_to_relate = $this->createNewProduct();

        $this->assertTrue($product->setRelatedProduct($product_to_relate->getId()));

        $this->assertEquals(1, count($product->getRelatedProducts()));
    }

    

    function testRemoveAttributeGroup()
    {
        $product = $this->createNewProductWithVariations();
        $product->setAttributeGroup(1);
        $this->assertTrue($product->removeAttributeGroup(1));
    }

    

    function testGetVariationThrowsExceptionWhenNoGroupsAdded()
    {
        $product = $this->createNewProductWithVariations();
        try {
            $product->getVariation();
            $this->assertTrue(false, 'No exception thrown');
        }
        catch (Exception $e) {
            $this->assertTrue(true);
        }

    }

    function testGetVariation()
    {
        $product = $this->createNewProductWithVariations();
        $group = new Intraface_modules_product_Attribute_Group;
        $group->name = 'Test1';
        $group->save();
        $group->load();
        $product->setAttributeGroup($group->getId());

        $this->assertTrue(is_object($product->getVariation()));


    }

    function testGetVariations()
    {
        $product = $this->createNewProductWithVariations();
        $group = new Intraface_modules_product_Attribute_Group;
        $group->name = 'color';
        $group->attribute[0]->name = 'red';
        $group->attribute[1]->name = 'blue';
        $group->save();
        $product->setAttributeGroup($group->getId());


        $group = new Intraface_modules_product_Attribute_Group;
        $group->name = 'size';
        $group->attribute[0]->name = 'small';
        $group->attribute[1]->name = 'medium';
        $group->save();
        $product->setAttributeGroup($group->getId());

        $variation = $product->getVariation();
        $variation->product_id = 1;
        $variation->setAttributesFromArray(array('attribute1' => 1, 'attribute2' => 3));
        $variation->save();
        $detail = $variation->getDetail();
        $detail->price_difference = 0;
        $detail->weight_difference = 0;
        $detail->save();

        $variation = $product->getVariation();
        $variation->product_id = 1;
        $variation->setAttributesFromArray(array('attribute1' => 2, 'attribute2' => 4));
        $variation->save();
        $detail = $variation->getDetail();
        $detail->price_difference = 0;
        $detail->weight_difference = 0;
        $detail->save();


        $variations = $product->getVariations();

        $this->assertEquals(2, $variations->count());
        $variation = $variations->getFirst();
        $this->assertEquals(1, $variation->getId());
        $this->assertEquals('red', $variation->attribute1->attribute->getName());
        $this->assertEquals('color', $variation->attribute1->attribute->group->getName());

        $this->assertEquals('small', $variation->attribute2->attribute->getName());
        $this->assertEquals('size', $variation->attribute2->attribute->group->getName());

    }

    function testGetPriceInCurrency()
    {
        require_once 'tests/unit/stubs/Fake/Intraface/modules/currency/Currency.php';
        $currency = new Fake_Intraface_modules_currency_Currency;
        require_once 'tests/unit/stubs/Fake/Intraface/modules/currency/Currency/ExchangeRate.php';
        $currency->product_price_exchange_rate = new Fake_Intraface_modules_currency_Currency_ExchangeRate;
        require_once 'tests/unit/stubs/Fake/Ilib/Variable/Float.php';
        $currency->product_price_exchange_rate->rate = new Fake_Ilib_Variable_Float;
        $currency->product_price_exchange_rate->rate->iso = 745.23;

        $product = new Product($this->kernel);
        $product->save(array('name' => 'test', 'price' => 200, 'unit' => 1));
        $product->load();

        $this->assertEquals(26.84, $product->getDetails()->getPriceInCurrency($currency)->getAsIso());



    }
    */
}


1		<?php
2		Intraface_Doctrine_Intranet::singleton(1);
3
4		class ProductDoctrineTest extends PHPUnit_Framework_TestCase
5		{
6
7		function setUp()
8		{
9		$connection = Doctrine_Manager::connection();
10		// $query = $connection->getQuery();
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-04-20 09:50 UTC by Report Bug Copy Issue Report `55%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
11		$connection->exec('TRUNCATE product');
12		$connection->exec('TRUNCATE product_attribute');
13		$connection->exec('TRUNCATE product_attribute_group');
14		$connection->exec('TRUNCATE product_detail');
15		$connection->exec('TRUNCATE product_detail_translation');
16		$connection->exec('TRUNCATE product_variation');
17		$connection->exec('TRUNCATE product_variation_detail');
18		$connection->exec('TRUNCATE product_variation_x_attribute');
19		$connection->exec('TRUNCATE product_x_attribute_group');
20
21		$connection->clear();
22		}
23
24		function createProductObject($id = 0)
25		{
26		if ($id != 0) {
27		$connection = Doctrine_Manager::connection();
28		$connection->clear(); // clear repo, so that we are sure data are loaded again.
29		$gateway = new Intraface_modules_product_ProductDoctrineGateway($connection, null);
		0 ignored issues – show Documentation introduced 2016-04-20 09:50 UTC by Report Bug Copy Issue Report `null` is of type `null`, but the function expects a `object`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
30		return $gateway->findById($id);
31		}
32		return new Intraface_modules_product_ProductDoctrine;
33		}
34
35	View Code Duplication	function createNewProduct()
		0 ignored issues – show Duplication introduced 2016-04-20 09:50 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
36		{
37		$product = $this->createProductObject();

intraface / intraface.dk

ProductDoctrineTest B last analyzed 2017-03-20 12:20 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

20 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like

ProductDoctrineTest B
last analyzed 2017-03-20 12:20 UTC