Intraface_modules_debtor_Visitor_Pdf - Code Metrics - intraface/intraface.dk - Measure and Improve Code Quality continuously with Scrutinizer

Intraface_modules_debtor_Visitor_Pdf C
last analyzed 2017-03-20 12:20 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	334
Duplicated Lines	21.86 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

1.24%

Importance

Changes

Metric	Value
dl	73
loc	334
rs	6.1904
c	0
b	0
f	0
ccs	3
cts	241
cp	0.0124
wmc	59
lcom	1
cbo	2

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
F	visit()	73	311	58

How to fix Duplicated Code Complexity

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

If you have the same expression in different places: Extract expression to a method
If you have the same method in different sub-classes: Extract method, and pull up field to the parent class
If you have the same code in unrelated classes: Consider extracting the code to a new class, and injecting that class

Complex Class

Tip: Before tackling complexity, make sure that you eliminate any duplication first. This often can reduce the size of classes significantly.

Complex classes like Intraface_modules_debtor_Visitor_Pdf often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

While breaking up the class, it is a good idea to analyze how other classes use Intraface_modules_debtor_Visitor_Pdf, and based on these observations, apply Extract Interface, too.

<?php
/**
 * Creates a pdf of a debtor. The class implements the visitor pattern.
 *
 * The debtor must comply with a certain interface.
 *
 * PHP version 5
 *
 * TODO Put in the doc instead of having it started up.
 *
 * <code>
 * $file = new FileHandler($file_id);
 * $report = new Debtor_Report_Pdf($file);
 * $report->visit($debtor);
 * </code>
 *
 * @package Intraface_Debtor
 * @author Lars Olesen <[email protected]>
 * @author Sune Jensen <[email protected]>
 */
class Intraface_modules_debtor_Visitor_Pdf extends Intraface_modules_debtor_Pdf
{
    /**
     * Constructor
     *
     * @param object $translation Used to do the translation in the class
     * @param object $file        File to use for the header
     *
     * @return void

     */
    function __construct($translation, $file = null)
    {
        parent::__construct($translation, $file);
    }

    /**
     * Visitor for the debtor
     *
     * @param object $debtor The debtor to be written
     *
     * @return void
     */
    function visit($debtor, $onlinepayment = null)
    {
        $this->doc = $this->getDocument();

        if (!empty($this->file) and $this->file->get('id') > 0) {
// Logical operators have lower precedence:
$f = false or true;

// is executed like this:
($f = false) or true;


// Boolean operators have higher precedence:
$f = false || true;

// is executed like this:
$f = (false || true);
            $this->doc->addHeader($this->file->get('file_uri_pdf'));
        }

        $this->doc->setY('-5');

        $contact = $debtor->contact->address->get();
        if (is_object($debtor->contact_person)) {
            $contact["attention_to"] = $debtor->contact_person->get("name");
        }
        $contact['number'] = $debtor->contact->get('number');

        $intranet_address = $debtor->getIntranetAddress();
        $intranet = $intranet_address->get();

        $intranet = array_merge($intranet, $debtor->getContactInformation());

        $this->docinfo[0]["label"] = $this->translation->get($debtor->get('type').' number').":";
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->docinfo[0]["value"] = $debtor->get("number");
        $this->docinfo[1]["label"] = "Dato:";
        $this->docinfo[1]["value"] = $debtor->get("dk_this_date");
        if ($debtor->get("type") != "credit_note" && $debtor->get("due_date") != "0000-00-00") {
            $this->docinfo[2]["label"] = $this->translation->get($debtor->get('type').' due date').":";
            $this->docinfo[2]["value"] = $debtor->get("dk_due_date");
        }

        $this->addRecieverAndSender($contact, $intranet, $this->translation->get($debtor->get('type')), $this->docinfo);

        $this->doc->setY('-'.$this->doc->get("font_spacing"));

        if ($this->doc->get('y') < $this->doc->get("margin_bottom") + $this->doc->get("font_spacing") * 2) {
            $this->doc->nextPage(true);
        }

        if ($debtor->get('message')) {
            $text = explode("\r\n", $debtor->get('message'));
            foreach ($text as $line) {
                if ($line == "") {
                    $this->doc->setY('-'.$this->doc->get("font_spacing"));
                    if ($this->doc->get('y') < $this->doc->get("margin_bottom") + $this->doc->get("font_spacing") * 2) {
                        $this->doc->nextPage(true);
                    }
                } else {
                    while ($line != "") {
                        $this->doc->setY('-'.($this->doc->get("font_padding_top") + $this->doc->get("font_size")));
                        $line = $this->doc->addTextWrap($this->doc->get('margin_left'), $this->doc->get('y'), $this->doc->get('content_width'), $this->doc->get("font_size"), $line);
                        $this->doc->setY('-'.$this->doc->get("font_padding_bottom"));
                        if ($this->doc->get('y') < $this->doc->get("margin_bottom") + $this->doc->get("font_spacing") * 2) {
                            $this->doc->nextPage(true);
                        }
                    }
                }
            }
        }

        // Headlines for the products
        $this->doc->setY('-40'); // space to the product list

        $apointX["varenr"] = 80;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        $apointX["tekst"] = 90;
        $apointX["antal"] = $this->doc->get("right_margin_position") - 150;
        $apointX["enhed"] = $this->doc->get('right_margin_position') - 145;
        $apointX["pris"] = $this->doc->get('right_margin_position') - 60;
        $apointX["beloeb"] = $this->doc->get('right_margin_position');
        $apointX["tekst_width"] = $this->doc->get('right_margin_position') - $this->doc->get("margin_left") - $apointX["tekst"] - 60;
        $apointX["tekst_width_small"] = $apointX["antal"] - $this->doc->get("margin_left") - $apointX["tekst"];


        $this->doc->addText($apointX["varenr"] - $this->doc->getTextWidth($this->doc->get("font_size"), "Varenr."), $this->doc->get('y'), $this->doc->get("font_size"), "Varenr.");
        $this->doc->addText($apointX["tekst"], $this->doc->get('y'), $this->doc->get("font_size"), "Tekst");
        $this->doc->addText($apointX["antal"] - $this->doc->getTextWidth($this->doc->get("font_size"), "Antal"), $this->doc->get('y'), $this->doc->get("font_size"), "Antal");
        $this->doc->addText($apointX["pris"] - $this->doc->getTextWidth($this->doc->get("font_size"), "Pris"), $this->doc->get('y'), $this->doc->get("font_size"), "Pris");
        $this->doc->addText($apointX["beloeb"] - $this->doc->getTextWidth($this->doc->get("font_size"), "Beløb") -3, $this->doc->get('y'), $this->doc->get("font_size"), "Beløb");

        $this->doc->setY('-'.($this->doc->get("font_spacing") - $this->doc->get("font_size")));

        $this->doc->line($this->doc->get("margin_left"), $this->doc->get('y'), $this->doc->get('right_margin_position'), $this->doc->get('y'));

        // products
        $items = $debtor->getItems();

        $total = 0;
        if ($debtor->getCurrency()) {
            $total_currency = 0;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        }

        if (isset($items[0]["vat"])) {
            $vat = $items[0]["vat"];
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        } else {
            $vat = 0;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        }

        $bg_color = 0;

        for ($i = 0, $max = count($items); $i <  $max; $i++) {
            $vat = $items[$i]["vat"];

            if ($bg_color == 1) {
                $this->doc->setColor(0.8, 0.8, 0.8);
                $this->doc->filledRectangle($this->doc->get("margin_left"), $this->doc->get('y') - $this->doc->get("font_spacing"), $this->doc->get('right_margin_position') - $this->doc->get("margin_left"), $this->doc->get("font_spacing"));
                $this->doc->setColor(0, 0, 0);
            }

            $this->doc->setY('-'.($this->doc->get("font_padding_top") + $this->doc->get("font_size")));
            $this->doc->addText($apointX["varenr"] - $this->doc->getTextWidth($this->doc->get("font_size"), $items[$i]["number"]), $this->doc->get('y'), $this->doc->get("font_size"), $items[$i]["number"]);

            if ($items[$i]["unit"] != "") {
                $this->doc->addText($apointX["antal"] - $this->doc->getTextWidth($this->doc->get("font_size"), number_format($items[$i]["quantity"], 2, ",", ".")), $this->doc->get('y'), $this->doc->get("font_size"), number_format($items[$i]["quantity"], 2, ",", "."));
                $this->doc->addText($apointX["enhed"], $this->doc->get('y'), $this->doc->get("font_size"), $this->translation->get($items[$i]["unit"], 'product'));
                if ($debtor->getCurrency()) {
                    $this->doc->addText($apointX["pris"] - $this->doc->getTextWidth($this->doc->get("font_size"), $items[$i]["price_currency"]->getAsLocale('da_dk', 2)), $this->doc->get('y'), $this->doc->get("font_size"), $items[$i]["price_currency"]->getAsLocale('da_dk', 2));
                } else {
                    $this->doc->addText($apointX["pris"] - $this->doc->getTextWidth($this->doc->get("font_size"), $items[$i]["price"]->getAsLocale('da_dk', 2)), $this->doc->get('y'), $this->doc->get("font_size"), $items[$i]["price"]->getAsLocale('da_dk', 2));
                }
            }
            
            if ($debtor->getCurrency()) {
                $amount =  $items[$i]["quantity"] * $items[$i]["price_currency"]->getAsIso(2);
            } else {
                $amount =  $items[$i]["quantity"] * $items[$i]["price"]->getAsIso(2);
            }
            $total += $amount;

            $this->doc->addText($apointX["beloeb"] - $this->doc->getTextWidth($this->doc->get("font_size"), number_format($amount, 2, ",", ".")), $this->doc->get('y'), $this->doc->get("font_size"), number_format($amount, 2, ",", "."));

            $tekst = $items[$i]["name"];
            $first = true;

            while ($tekst != "") {
                if (!$first) {
                    // first line has already got coloured
                    if ($bg_color == 1) {
                        $this->doc->setColor(0.8, 0.8, 0.8);
                        $this->doc->filledRectangle($this->doc->get("margin_left"), $this->doc->get('y') - $this->doc->get("font_spacing"), $this->doc->get('right_margin_position') - $this->doc->get("margin_left"), $this->doc->get("font_spacing"));
                        $this->doc->setColor(0, 0, 0);
                    }
                    $this->doc->setY('-'.($this->doc->get("font_padding_top") + $this->doc->get("font_size")));
                }
                $first = false;


                $tekst = $this->doc->addTextWrap($apointX["tekst"], $this->doc->get('y'), $apointX["tekst_width_small"], $this->doc->get("font_size"), $tekst);
                $this->doc->setY('-'.$this->doc->get("font_padding_bottom"));
                if ($this->doc->get('y') < $this->doc->get("margin_bottom") + $this->doc->get("font_spacing") * 2) {
                    $this->doc->nextPage(true);
                }
            }

            if ($items[$i]["description"] != "") {
                // space to the text
                $this->doc->setY('-'.($this->doc->get("font_spacing")/2));
                if ($bg_color == 1) {
                    $this->doc->setColor(0.8, 0.8, 0.8);
                    $this->doc->filledRectangle($this->doc->get("margin_left"), $this->doc->get('y'), $this->doc->get('right_margin_position') - $this->doc->get("margin_left"), $this->doc->get("font_spacing")/2);
                    $this->doc->setColor(0, 0, 0);
                }

                $desc_line = explode("\r\n", $items[$i]["description"]);
                foreach ($desc_line as $line) {
                    if ($line == "") {
                        if ($bg_color == 1) {
                            $this->doc->setColor(0.8, 0.8, 0.8);
                            $this->doc->filledRectangle($this->doc->get("margin_left"), $this->doc->get('y') - $this->doc->get("font_spacing"), $this->doc->get('right_margin_position') - $this->doc->get("margin_left"), $this->doc->get("font_spacing"));
                            $this->doc->setColor(0, 0, 0);
                        }
                        $this->doc->setY('-'.$this->doc->get("font_spacing"));
                        if ($this->doc->get('y') < $this->doc->get("margin_bottom") + $this->doc->get("font_spacing") * 2) {
                            $this->doc->nextPage(true);
                        }
                    } else {
                        while ($line != "") {
                            if ($bg_color == 1) {
                                $this->doc->setColor(0.8, 0.8, 0.8);
                                $this->doc->filledRectangle($this->doc->get("margin_left"), $this->doc->get('y') - $this->doc->get("font_spacing"), $this->doc->get('right_margin_position') - $this->doc->get("margin_left"), $this->doc->get("font_spacing"));
                                $this->doc->setColor(0, 0, 0);
                            }

                            $this->doc->setY('-'.($this->doc->get("font_padding_top") + $this->doc->get("font_size")));
                            $line = $this->doc->addTextWrap($apointX["tekst"], $this->doc->get('y') + 1, $apointX["tekst_width"], $this->doc->get("font_size"), $line); // Ups Ups, hvor kommer '+ 1' fra - jo ser du, ellers kappes det nederste af teksten!
                            $this->doc->setY('-'.$this->doc->get("font_padding_bottom"));

                            if ($this->doc->get('y') < $this->doc->get("margin_bottom") + $this->doc->get("font_spacing") * 2) {
                                $this->doc->nextPage(true);
                            }
                        }
                    }
                }
            }

            if ($this->doc->get('y') < $this->doc->get("margin_bottom") + $this->doc->get("font_spacing") * 2) {
                $this->doc->nextPage(true);
            }

            // If products with VAT and next post is without we add VAT.
            if (($vat == 1 && isset($items[$i+1]["vat"]) && $items[$i+1]["vat"] == 0) || ($vat == 1 && $i+1 >= $max)) {
                // If VAT on current product, but next has no VAT OR if VAT and last product

                ($bg_color == 1) ? $bg_color = 0 : $bg_color = 1;

                if ($bg_color == 1) {
                    $this->doc->setColor(0.8, 0.8, 0.8);
                    $this->doc->filledRectangle($this->doc->get("margin_left"), $this->doc->get('y') - $this->doc->get("font_spacing"), $this->doc->get('right_margin_position') - $this->doc->get("margin_left"), $this->doc->get("font_spacing"));
                    $this->doc->setColor(0, 0, 0);
                }

                $this->doc->setLineStyle(0.5);
                $this->doc->line($this->doc->get("margin_left"), $this->doc->get('y'), $this->doc->get('right_margin_position'), $this->doc->get('y'));
                $this->doc->setY('-'.($this->doc->get("font_size") + $this->doc->get("font_padding_top")));
                $this->doc->addText($apointX["tekst"], $this->doc->get('y'), $this->doc->get("font_size"), "<b>25% moms af ".number_format($total, 2, ",", ".")."</b>");
                $this->doc->addText($apointX["beloeb"] - $this->doc->getTextWidth($this->doc->get("font_size"), "<b>".number_format($total * 0.25, 2, ",", ".")."</b>"), $this->doc->get('y'), $this->doc->get("font_size"), "<b>".number_format($total * 0.25, 2, ",", ".")."</b>");
                $total = $total * 1.25;
                $this->doc->setY('-'.$this->doc->get("font_padding_bottom"));
                $this->doc->line($this->doc->get("margin_left"), $this->doc->get('y'), $this->doc->get('right_margin_position'), $this->doc->get('y'));
                $this->doc->setLineStyle(1);
                $this->doc->setY('-1');
            }

            ($bg_color == 1) ? $bg_color = 0 : $bg_color = 1;
        }


        if ($this->doc->get('y') < $this->doc->get("margin_bottom") + $this->doc->get("font_spacing") * 2) {
            $this->doc->nextPage();
        }

        $this->doc->setLineStyle(1);
        $this->doc->line($this->doc->get("margin_left"), $this->doc->get('y'), $this->doc->get('right_margin_position'), $this->doc->get('y'));
        if ($debtor->getCurrency()) {
            $currency_iso_code = $debtor->getCurrency()->getType()->getIsoCode();
            $debtor_total = $debtor->get("total_currency");
        } else {
            $currency_iso_code = 'DKK';
            $debtor_total = $debtor->get("total");
        }

        if ($debtor->get("round_off") == 1 && $debtor->get("type") == "invoice" && $total != $debtor_total) {
            $this->doc->setY('-'.($this->doc->get("font_size") + $this->doc->get("font_padding_top")));
            $this->doc->addText($apointX["enhed"], $this->doc->get('y'), $this->doc->get("font_size"), "I alt:");
            $this->doc->addText($apointX["beloeb"] - $this->doc->getTextWidth($this->doc->get("font_size"), number_format($total, 2, ",", ".")), $this->doc->get('y'), $this->doc->get("font_size"), number_format($total, 2, ",", "."));
            $this->doc->setY('-'.$this->doc->get("font_padding_bottom"));

            $total_text = "Total afrundet ".$currency_iso_code.":";
        } else {
            $total_text = "Total ".$currency_iso_code.":";
        }

        if ($this->doc->get('y') < $this->doc->get("margin_bottom") + $this->doc->get("font_spacing") * 2) {
            $this->doc->nextPage(true);
        }

        $this->doc->setY('-'.($this->doc->get("font_size") + $this->doc->get("font_padding_top")));
        $this->doc->addText($apointX["enhed"], $this->doc->get('y'), $this->doc->get("font_size"), "<b>".$total_text."</b>");
        $this->doc->addText($apointX["beloeb"] - $this->doc->getTextWidth($this->doc->get("font_size"), "<b>".number_format($debtor_total, 2, ",", ".")."</b>"), $this->doc->get('y'), $this->doc->get("font_size"), "<b>".number_format($debtor_total, 2, ",", ".")."</b>");
        $this->doc->setY('-'.$this->doc->get("font_padding_bottom"));
        $this->doc->line($apointX["enhed"], $this->doc->get('y'), $this->doc->get('right_margin_position'), $this->doc->get('y'));

        // payment condition
        if ($debtor->get("type") == "invoice" || $debtor->get("type") == "order") {
            $parameter = array(
                "contact" => $debtor->contact,
                "payment_text" => ucfirst($this->translation->get($debtor->get('type')))." ".$debtor->get("number"),
                "amount" => $debtor->get("total"),
                "payment" => $debtor->get('payment_total'),
                "payment_online" => 0,
                "due_date" => $debtor->get("dk_due_date"),
                "girocode" => $debtor->get("girocode"));

            if (is_object($onlinepayment)) {
                $onlinepayment->getDBQuery()->setFilter('belong_to', $debtor->get("type"));
                $onlinepayment->getDBQuery()->setFilter('belong_to_id', $debtor->get('id'));
                $onlinepayment->getDBQuery()->setFilter('status', 2);

                foreach ($onlinepayment->getlist() as $p) {
                    $parameter['payment_online'] += $p["amount"];
                }
            }


            $this->addPaymentCondition($debtor->get("payment_method"), $parameter, $debtor->getPaymentInformation());

            $this->doc->setY('-'.$this->doc->get("font_spacing"));

            if ($this->doc->get('y') < $this->doc->get("margin_bottom") + $this->doc->get("font_spacing") * 2) {
                $this->doc->nextPage(true);
            }

            $text = explode("\r\n", $debtor->getInvoiceText());
            foreach ($text as $line) {
                if ($line == "") {
                    $this->doc->setY('-'.$this->doc->get("font_spacing"));
                    if ($this->doc->get('y') < $this->doc->get("margin_bottom") + $this->doc->get("font_spacing") * 2) {
                        $this->doc->nextPage(true);
                    }
                } else {
                    while ($line != "") {
                        $this->doc->setY('-'.($this->doc->get("font_padding_top") + $this->doc->get("font_size")));
                        $line = $this->doc->addTextWrap($this->doc->get('margin_left'), $this->doc->get('y'), $this->doc->get('content_width'), $this->doc->get("font_size"), $line);
                        $this->doc->setY('-'.$this->doc->get("font_padding_bottom"));

                        if ($this->doc->get('y') < $this->doc->get("margin_bottom") + $this->doc->get("font_spacing") * 2) {
                            $this->doc->nextPage(true);
                        }
                    }
                }
            }
        }
    }
}


intraface / intraface.dk

Intraface_modules_debtor_Visitor_Pdf C last analyzed 2017-03-20 12:20 UTC