Intraface_XMLRPC_Server0100

Complexity

Total Complexity

18

Size/Duplication

Total Lines	136
Duplicated Lines	100 %

Coupling/Cohesion

Components	1
Dependencies	6

Test Coverage

Coverage

0%

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	7	7	2
B	checkCredentials()	35	35	5
A	prepareResponseData()	10	10	2
A	processRequestData()	11	11	2
A	handleNull()	7	7	2
B	recursiveMap()	15	15	5

<?php
/**
 * Main XMLRPC server class to extend all other Serves from
 *
 * This version 1.0.0 supports utf8 backend.
 *
 * Gives ability to encode and decode data correct.
 * @category XMLRPC_Server
 * @package  Intraface_XMLRPC
 * @author   Sune Jensen <sj@sunet.dk>
 * @author   Lars Olesen <lars@legestue.net>
 * @version  @package-version@
 */

/**
 * Main XMLRPC server class to extend all other Serves from
 *
 * This version 1.0.0 supports utf8 backend.
 *
 * Gives ability to encode and decode data correct.
 * @category XMLRPC_Server
 * @package  Intraface_XMLRPC
 * @author   Sune Jensen <sj@sunet.dk>
 * @author   Lars Olesen <lars@legestue.net>
 * @version  @package-version@
 */
class Intraface_XMLRPC_Server0100

This class seems to be duplicated in your project.

{
    /**
     * @var struct $credentials
     */
    protected $credentials;

    /**
     * @var object $kernel intraface kernel
     */
    protected $kernel;

    /**
     * @var array with valid encodings
     */
    protected $valid_encodings = array('utf-8', 'iso-8859-1');

    /**
     * Constructor
     *
     * @param string  $encoding The encoding wich the server recieves and returns data in
     *
     * @return void

Adding a @return annotation to constructors is generally not recommended as a constructor does not have a meaningful return value.

     */
    public function __construct($encoding = 'utf-8')
    {
        if (!in_array($encoding, $this->valid_encodings)) {
            throw new Exception('Invalid encoding: '.$encoding.'. Should either be utf-8 or iso-8859');
        }
        $this->encoding = $encoding;

The property encoding does not seem to exist. Did you mean valid_encodings?

    }

    /**
     * Checks credentials
     *
     * @param struct $credentials Credentials to use the server
     *
     * @return array
     */
    protected function checkCredentials($credentials)
    {
        $this->credentials = $credentials;

        if (count($credentials) != 2) { // -4
            require_once 'XML/RPC2/Exception.php';
            throw new XML_RPC2_FaultException('wrong argument count in $credentials - got ' . count($credentials) . ' arguments - need 2', -4);
        }
        if (empty($credentials['private_key'])) { // -5
            require_once 'XML/RPC2/Exception.php';
            throw new XML_RPC2_FaultException('supply a private_key', -5);
        }
        if (empty($credentials['session_id'])) { // -5
            require_once 'XML/RPC2/Exception.php';
            throw new XML_RPC2_FaultException('supply a session_id', -5);
        }

        $auth_adapter = new Intraface_Auth_PrivateKeyLogin(MDB2::singleton(DB_DSN), $credentials['session_id'], $credentials['private_key']);
        $weblogin = $auth_adapter->auth();

        if (!$weblogin) {
            require_once 'XML/RPC2/Exception.php';
            throw new XML_RPC2_FaultException('access to intranet denied', -2);
        }

        $this->kernel = new Intraface_Kernel($credentials['session_id']);
        $this->kernel->weblogin = $weblogin;

The property weblogin does not seem to exist in Intraface_Kernel.

        $this->kernel->intranet = new Intraface_Intranet($weblogin->getActiveIntranetId());
        $this->kernel->setting = new Intraface_Setting($this->kernel->intranet->get('id'));

        // makes intranet_id accessable in Doctrine
        Intraface_Doctrine_Intranet::singleton($this->kernel->intranet->getId());

        return true;
    }

    /**
     * Prepares response to be sent with the correct UTF-8 encoding.
     *
     * @param mixed $values Array or string to decode
     *
     * @return mixed UTF8 decoded request
     */
    protected function prepareResponseData($values)
    {
        $values = $this->recursiveMap(array($this, 'handleNull'), $values);

        if ($this->encoding == 'iso-8859-1') {

The property encoding does not seem to exist. Did you mean valid_encodings?

            return $this->recursiveMap('utf8_decode', $values);
        }

        return $values;
    }

    /**
     * Process data from client, so that data is returned with the correct encoding.
     *
     * @param mixed $values Array or string to decode
     *
     * @return mixed correct encoded response
     */
    protected function processRequestData($values)
    {
        // @todo When sending from utf8-backend from outside to xmlrpcext
        //       the encoding will think it is iso-8859-1, but acutally it is utf8.
        //       So it seems that it is encoded twice.
        if ($this->encoding == 'iso-8859-1') {

The property encoding does not seem to exist. Did you mean valid_encodings?

            return $this->recursiveMap('utf8_encode', $values);
        }

        return $values;
    }

    function handleNull($value)
    {
        if (is_null($value)) {
            return '';
        }
        return $value;
    }

    protected function recursiveMap($function, $values)
    {
        if (is_string($values)) {
            return call_user_func($function, $values);
        } elseif (is_null($values)) {
            return call_user_func($function, $values);
        } elseif (is_array($values)) {
            foreach ($values as $key => $value) {
                $values[$key] = $this->recursiveMap($function, $value);
            }
            return $values;
        } else {
            return $values;
        }
    }
}