Contact - Code Metrics - intraface/intraface.dk - Measure and Improve Code Quality continuously with Scrutinizer

Contact D
last analyzed 2017-03-20 12:20 UTC

↳ Parent: Project
Complexity

Total Complexity
107
Size/Duplication

Total Lines	867
Duplicated Lines	15.69 %
Coupling/Cohesion

Components	3
Dependencies	10
Test Coverage

Coverage
55.32%
Importance

Changes
Metric	Value
dl	136
loc	867
rs	4.4444
c	0
b	0
f	0
ccs	182
cts	329
cp	0.5532
wmc	107
lcom	3
cbo	10
33 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	15	2
A	identify()	0	4	1
A	getKernel()	0	4	1
A	getError()	0	4	1
A	getDBQuery()	11	11	2
B	factory()	0	53	6
B	load()	5	43	4
A	getAddress()	0	7	2
A	getLoginUrl()	0	6	1
F	validate()	0	101	27
F	save()	0	91	19
A	delete()	14	14	3
A	undelete()	15	15	3
A	isNumberFree()	0	17	2
A	getMaxNumber()	9	9	2
B	getList()	40	40	4
A	hasSimilarContacts()	0	5	1
B	getSimilarContacts()	0	38	4
A	merge()	0	4	1
A	getKeywords()	0	4	1
A	getKeyword()	0	4	1
A	getKeywordAppender()	0	4	1
A	loadMessage()	0	4	1
A	loadContactPerson()	0	4	1
A	isFilledIn()	9	9	2
A	generateCode()	10	10	2
A	generatePassword()	10	10	2
A	getNewsletterSubscriptions()	0	10	2
A	needNewsletterOptin()	13	13	2
A	canBeDeleted()	0	9	2
A	canLogin()	0	7	2
A	getId()	0	4	1
A	getType()	0	4	1
How to fix Duplicated Code Complexity

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
If you have the same expression in different places: Extract expression to a method
If you have the same method in different sub-classes: Extract method, and pull up field to the parent class
If you have the same code in unrelated classes: Consider extracting the code to a new class, and injecting that class
Complex Class

Tip: Before tackling complexity, make sure that you eliminate any duplication first. This often can reduce the size of classes significantly.
Complex classes like Contact often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Contact, and based on these observations, apply Extract Interface, too.
<?php
/**
 * Handles a contact
 *
 * I think we should distinguish between company and contact
 *

 // www, email, cvr, ean hoerer ikke hertil
 abstract class Address
 {
 private $types;

 // istedet for belong_to og belong_to_id
 // skal vaere den samme maade som tags

 public function __construct($data) {
 $this->init();
 // data is put into variables
 // this can be done either from a database or from some form input (remember to validate from forminput)
 }

 function registerType($id, $type)
 {
 // some rules for id and type
 $this->types[$id] = $type;
 }

 function getTypes()
 {
 return $this->types;
 }

 abstract function init();

 }

 // this is the one we use for our application
 class MyAddress extends Address
 {
 function init()
 {
 $this->registerType(1, 'intranet');
 }
 }

 class Contact
 {
 public $name;
 public $occupation:
 public $birthday;

 // et eller andet med et keyword
 // work, home, delivery, billing etc.
 function addAddress() {}

 function setPrimaryAddress() {}

 function getPrimaryAddress() {}

 function getAddresses() {}

 ////////////////////////////

 function addEmail() {}

 function getEmails() {}

 function setPrimaryEmail() {}

 function getPrimaryEmail() {}

 ////////////////////////////

 function getBirthday() { // return date object }

 /////////////////////////////

 function addPicture() {}

 function setPrimaryPicture() {}

 function getPictures() {}

 ///////////////////////////////

 function addWebsite() {}

 function getWebsites() {}

 ////////////////////////////////

 // maaske med mobile eller landline, work
 function addPhone() {}

 function getPhones() {}

 }

 class Company extends Contact
 {
 public $ean;
 public $cvr;

 function addContact() {}

 function getContacts()
 }



 *
 * @package Intraface_Contact
 * @author  Lars Olesen <[email protected]>
 * @author  Sune Jensen <[email protected]>
 * @copyright   Lars Olesen
 */
require_once dirname(__FILE__) . '/ContactPerson.php';
require_once 'Intraface/functions.php';

class Contact extends Intraface_Standard
{
    /**
     * @var object
     */
    public $kernel;

    /**
     * @var integer
     */
    protected $id;

    /**
     * @var array
     */
    public $value;

    /**
     * @var object
     */
    public $address;

    /**
     * @var object
     */
    public $delivery_address;

    /**
     * @var object
     */
    public $error;

    /**
     * @var object
     */
    public $contactperson;

    /**
     * @var object
     */
    protected $message;

    /**
     * @var object
     */
    public $keywords;

    /**
     * @var object
     */
    protected $lock;

    /**
     * @var array
     */
    protected $addresses = array(
        0 => 'standard',
        1 => 'delivery',
        2 => 'invoice');

    /**
     * @var array
     */
    protected $types = array(
        0 => 'private',
        1 => 'corporation');

    /**
     * @todo has to be made private
     */
    public $dbquery;

    /**
     * Constructor
     *
     * @param object  $kernel
     * @param integer $id     Contact id
     *
     * @return  void

     */
    public function __construct($kernel, $id = 0)
    {
        $this->kernel = $kernel;
        //$contact_module = $this->kernel->getModule('contact');

        //$this->types = $contact_module->getSetting('type');


        $this->error = new Intraface_Error;
        $this->id = (int)$id;

        $this->fields = array('type_key', 'paymentcondition', 'number', 'preferred_invoice', 'openid_url', 'username', 'code');
class MyClass { }

$x = new MyClass();
$x->foo = true;

        if ($this->id > 0) {
            $this->load();
        }
    }

    /**
     * Used by Keyword
     *
     * @see Keyword
     *
     * @return string
     */
    function identify()
    {
        return 'contact';
    }

    function getKernel()
    {
        return $this->kernel;
    }

    function getError()
    {
        return $this->error;
    }

    public function getDBQuery()

    {
        if ($this->dbquery) {
            return $this->dbquery;
        }
        $this->dbquery = new Intraface_DBQuery($this->kernel, "contact", "contact.active = 1 AND contact.intranet_id = ".$this->kernel->intranet->get("id"));
        $this->dbquery->setJoin("LEFT", "address", "address.belong_to_id = contact.id", "address.active = 1 AND address.type = 3");
        $this->dbquery->useErrorObject($this->error);

        return $this->dbquery;
    }

    /**
     * Constructor
     *
     * @param object $kernel
     * @param string $type   What should the contact object be created from
     * @param string $id     The value which corresponds to the type
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     *
     * @return  object
     */
    public function factory($kernel, $type, $value)
    {
        // Husk noget validering af de forskellige values og typer
        $gateway = new Intraface_modules_contact_ContactGateway($kernel, new DB_Sql);
        try {
            switch ($type) {
                case 'email':
                    $emails = $gateway->findByEmail($value);
                    return $emails[0];
                case 'code':
                    return $gateway->findByCode($value);
                case 'username':
                    return $gateway->findByUsername($value);
                case 'openid_url':
                    return $gateway->findByOpenId($value);
                    // Her b�r vel v�re et tjek p� hvor mange - og hvis mange give en fejl
                    break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
                default:
                    throw new Exception('Contact::factory() skal bruge en type');
                    break;
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
            }
        } catch (Exception $e) {
            return $contact = new Contact($kernel);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        }

        /*

         $db = new DB_Sql;
         switch($type) {
         case 'email':
         $db->query("SELECT address.belong_to_id AS id FROM contact INNER JOIN address ON address.belong_to_id = contact.id WHERE address.email = '".$value."' AND contact.intranet_id = " . $kernel->intranet->get('id') . " AND address.active = 1 AND contact.active = 1");
         break;
         case 'code':
         $db->query("SELECT id FROM contact WHERE code  = '".$value."' AND contact.intranet_id = " . $kernel->intranet->get('id'));
         break;
         case 'username':
         $db->query("SELECT id FROM contact WHERE username  = '".$value['username']."' AND password  = '".$value['password']."' AND contact.intranet_id = " . $kernel->intranet->get('id'));
         break;
         case 'openid_url':
         $db->query("SELECT id FROM contact WHERE openid_url  = '".$value."' AND contact.intranet_id = " . $kernel->intranet->get('id'));
         // Her b�r vel v�re et tjek p� hvor mange - og hvis mange give en fejl
         break;
         default:
         throw new Exception('Contact::factory() skal bruge en type');
         break;
         }
         if (!$db->nextRecord()) {
         return $contact = new Contact($kernel);
         }
         $id = $db->f('id');

         return ($contact = new Contact($kernel, $id));
         */
    }

    /**
     * Loads values for the contact into an array
     *
     * @return true on success
     */
    private function load()
    {
        $db = new DB_Sql;
        $this->value = array();

        $db->query("SELECT id, ".implode(',', $this->fields).", password
            FROM contact
            WHERE contact.id=".$this->id."
                AND intranet_id =".$this->kernel->intranet->get('id'));

        if (!$db->nextRecord()) {
            $this->id = 0;
            $this->value['id'] = 0;
            return false;
        }

        $this->value['id'] = $db->f('id');

        foreach ($this->fields as $field) {
            $this->value[$field] = $db->f($field);
        }
        $this->value['type_key'] = $db->f('type_key');
        $this->value['type'] = $this->getType();
        $this->value['password'] = $db->f('password');
        $this->value['username'] = $db->f('username');
        $this->value['number'] = $db->f('number');
        $this->value['code'] = $db->f('code');

        if ($this->get('type') == 'corporation') {
            $this->contactperson = new ContactPerson($this);
        }

        $this->address = Intraface_Address::factory('contact', $db->f('id'));

        $this->delivery_address = Intraface_Address::factory('contact_delivery', $db->f('id'));


        // name m� ikke fjernes - bruges af keywords
        $this->value['name'] = $this->address->get('name');
        $this->value['openid_url'] = $this->get('openid_url');

        $this->value['id'] = $db->f('id'); // m� ikke fjernes

        return true;
    }

    /**
     * Gets the address
     *
     * @return object
     */
    public function getAddress()
    {
        if (!is_object($this->address)) {
            $this->address = Intraface_Address::factory('contact', $this->id);

        }
        return $this->address;
    }

    /**
     * Gets the login url for the contact
     *
     * @return string
     */
    public function getLoginUrl()
    {
        // HACK NECCESSARY FOR THE NEWSLETTERSUBSCRIBER
        $this->kernel->useModule('contact');
        return ($this->value['login_url'] = 'http://' . $this->kernel->getSetting()->get('intranet', 'contact.login_url') . '/' .$this->kernel->intranet->get('identifier') . '/login?code='. $this->get('code'));
    }

    /**
     * Validates values
     *
     * @param array $var Values to validate
     *
     * @return true on success
     */
    public function validate($var)
    {
        $var = $var;


        if (array_key_exists('number', $var) and !$this->isNumberFree($var['number'])) {
// Logical operators have lower precedence:
$f = false or true;

// is executed like this:
($f = false) or true;


// Boolean operators have higher precedence:
$f = false || true;

// is executed like this:
$f = (false || true);
            $this->error->set('Kundenummeret er ikke frit');
        }

        $validator = new Intraface_Validator($this->error);
        if (!empty($var['type_key'])) {
            $validator->isNumeric($var['type_key'], 'Fejl i typen', 'allow_empty');
        }
        if (!empty($var['openid_url'])) {
            $validator->isUrl($var['openid_url'], 'Openid_url', 'allow_empty');
        }

        // address
        $validator->isString($var['name'], 'Navnet er ikke en gyldig streng');
        if (!empty($var['address'])) {
            $validator->isString($var['address'], 'Adressen er ikke en streng', '', 'allow_empty');
        }
        if (!empty($var['postcode'])) {
            $validator->isString($var['postcode'], 'Postkoden er ikke gyldig', '', 'allow_empty');
        }
        if (!empty($var['city'])) {
            $validator->isString($var['city'], 'Byen er ikke en by', '', 'allow_empty');
        }
        if (!empty($var['country'])) {
            $validator->isString($var['country'], 'Der er fejl i landet', '', 'allow_empty');
        }
        if (!empty($var['phone'])) {
            $validator->isString($var['phone'], 'Telefonnummeret et ikke rigtigt.', '', 'allow_empty');
        }
        if (!empty($var['email'])) {
            $validator->isEmail($var['email'], 'E-mailen er ikke en rigtig e-mail', 'allow_empty');
        }
        if (!empty($var['website'])) {
            $validator->isUrl($var['website'], 'Der er fejl i urlen', 'allow_empty');
        }
        if (!empty($var['cvr'])) {
            $validator->isNumeric($var['cvr'], 'Fejl i cvr-nummeret', 'allow_empty');
        }
        settype($var['ean'], 'string');
        if (!empty($var['ean'])) {
            $validator->isNumeric($var['ean'], 'Fejl i ean-nummeret', 'allow_empty');
        }

        if (!empty($var['ean']) and strlen($var['ean']) != 13) {
// Logical operators have lower precedence:
$f = false or true;

// is executed like this:
($f = false) or true;


// Boolean operators have higher precedence:
$f = false || true;

// is executed like this:
$f = (false || true);
            $this->error->set('EAN-nummeret skal pr�cis v�re 13 tal');
        }

        //deliveryaddress
        if (!empty($var['delivery_name'])) {
            $validator->isString($var['delivery_name'], 'Leveringsadressen forkert', '', 'allow_empty');
        }
        if (!empty($var['delivery_address'])) {
            $validator->isString($var['delivery_address'], 'Leveringsadressen forkert', '', 'allow_empty');
        }
        if (!empty($var['delivery_postcode'])) {
            $validator->isString($var['delivery_postcode'], 'Leveringsadressens postnummer', '', 'allow_empty');
        }
        if (!empty($var['delivery_city'])) {
            $validator->isString($var['delivery_city'], 'Leveringsadressens by', '', 'allow_empty');
        }
        if (!empty($var['delivery_country'])) {
            $validator->isString($var['delivery_country'], 'Leveringsadressens land', '', 'allow_empty');
        }

        // other
        if (!empty($var['paymentcondition'])) {
            $var['paymentcondition'] = 0;
        }
        settype($var['paymentcondition'], 'integer');
        $validator->isNumeric($var['paymentcondition'], 'Betalingsbetingelserne er ikke sat', 'allow_empty');
        if (empty($var['paymentcondition'])) {
            //$var['paymentcondition'] = $this->kernel->setting->get('intranet', 'contact.standard_paymentcondition');

            $var['paymentcondition'] = 8;
        }

        if (empty($var['preferred_invoice'])) {
            $var['preferred_invoice'] = 0;
        }
        settype($var['preferred_invoice'], 'integer');
        $validator->isNumeric($var['preferred_invoice'], 'Fejl i preferred_invoice', 'allow_empty');
        /*

         if ($var['preferred_invoice'] == 3 AND empty($var['ean'])) {
         // @todo this creates problems from the shop when EAN has been chosen
         $this->error->set('Du skal udfylde EAN-nummeret, hvis du v�lger en elektronisk faktura');
         }
         */

        if ($var['preferred_invoice'] == 2 and empty($var['email'])) {
// Logical operators have lower precedence:
$f = false or true;

// is executed like this:
($f = false) or true;


// Boolean operators have higher precedence:
$f = false || true;

// is executed like this:
$f = (false || true);
            $this->error->set('E-mailen skal udfyldes, hvis kontakten foretr�kker e-mail.');
        }

        if ($this->error->isError()) {
            //$this->error->view();

            return false;
        }
        return true;
    }


    /**
     * Saves the contact
     *
     * @param   int $var['id']  Kundeid
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @param   string $var['company']
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @param   string $var['address']
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @param   string $var['postalcode']
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @param   string $var['town']
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @param   string $var['country']
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @param   string $var['email']
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @param   string $var['website']
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @param   string $var['phone']
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @param   string $var['deliveryaddress']
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @param   string $var['deliverypostalcode']
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @param   string $var['deliverytown']
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @param   string $var['deliverycountry']
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @param   string $var['paymentcondition']
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     *
     * @return void
     */
    public function save($var)
    {
        // safeToDb must not be run on all the values, as it is run
        // again in Address. Make sure to run it on the fields being saved here.

        $sql_items = '';

        if ($this->id == 0 and empty($var['number'])) {
// Logical operators have lower precedence:
$f = false or true;

// is executed like this:
($f = false) or true;


// Boolean operators have higher precedence:
$f = false || true;

// is executed like this:
$f = (false || true);
            $var['number'] = $this->getMaxNumber() + 1;

        }

        if (isset($var['type'])) {
            $type_key = array_search($var['type'], $this->types);
            if ($type_key === false) {
                $this->error->set('invalid type for the contact');
            } else {
                $var['type_key'] = $type_key;
            }
        }

        if (!$this->validate($var)) {
            return 0;
        }

        // skrive sql
        foreach ($this->fields as $field) {
            if (!array_key_exists($field, $var)) {
                continue;
            }
            if (isset($var[$field])) {
                $sql_items .= $field." = '".safeToDb($var[$field])."', ";
            }
        }


        // prepare sql to update or insert
        if ($this->id > 0) {
            $sql="UPDATE contact ";
            $sql_after=" WHERE id='".$this->id."'";
            $sql_create = "";
        } else {
            $sql="INSERT INTO contact ";
            $sql_after = ", code='".safeToDb(md5(date('Y-m-d H:i:s') . $sql_items))."'";
            $sql_create = "date_created = NOW(),";
        }

        $sql .= " SET	".$sql_create. "
            intranet_id = '". $this->kernel->intranet->get('id')."',"
            .$sql_items.
            "date_changed = NOW()
            $sql_after";

            $db = new DB_Sql;
            $db->query($sql);
        if ($this->id == 0) {
            $this->id = $db->insertedId();
        }

            // Standardadresse
            $address_object = Intraface_Address::factory('contact', $this->id);

            $address_fields = $address_object->fields;

        foreach ($address_fields as $key => $value) {
            if (array_key_exists($value, $var)) {
                $standard_address_to_save[$value] = $var[$value];
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
            }
        }
        if (!empty($standard_address_to_save)) {
            if (!$address_object->save($standard_address_to_save)) {
                return 0;
            }
        }

            // Delivery Address
        foreach ($address_fields as $key => $value) {
            if (array_key_exists('delivery_'.$value, $var)) {
                $delivery_address_to_save[$value] = $var['delivery_' . $value];
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
            }
        }

            $delivery_address_object = Intraface_Address::factory('contact_delivery', $this->id);


        if (!empty($delivery_address_to_save)) {
            if (!$delivery_address_object->save($delivery_address_to_save)) {
                return 0;
            }
        }
            $this->load();

            return $this->id;
    }

    /**
     * Deletes a contact
     *
     * Never delete a contact entirely. Should only be deactivated.
     *
     * @return integer  0 = false eller 1 = true
     */
    public function delete()

    {
        if ($this->get('locked') == 1) {
            $this->error->set('Posten er l�st og kan ikke slettes');
            return false;
        }
        if ($this->id == 0) {
            $this->error->set('Kender ikke id, s� kan ikke slette kunden');
            return false;
        }
        $db = new DB_Sql;
        $db->query("UPDATE contact SET active = 0, date_changed = NOW() WHERE intranet_id = " . $this->kernel->intranet->get("id") . " AND id = " . $this->id);
        return true;
    }

    /**
     * Undelete
     *
     * @return boolean
     */
    public function undelete()

    {
        if ($this->get('locked') == 1) {
            $this->error->set('Posten er l�st og kan ikke slettes');
            return false;
        }
        if ($this->id == 0) {
            $this->error->set('Kender ikke id, s� kan ikke slette kunden');
            return false;
        }
        $db = new DB_Sql;
        $db->query("UPDATE contact SET active = 1, date_changed = NOW() WHERE intranet_id = " . $this->kernel->intranet->get("id") . " AND id = " . $this->id);

        return true;
    }

    /**
     * Tjekke om kundenummeret er frit
     *
     * @param string $number
     *
     * @return true hvis det er frit
     */
    public function isNumberFree($number)
    {
        $number = (int)$number;
        $db = new DB_Sql();
        $sql = "SELECT id
            FROM contact
            WHERE intranet_id = " . $this->kernel->intranet->get("id") . "
                AND number = " . (int)$number . "
                AND id <> " . $this->id . "
                AND active = 1
            LIMIT 1";
        $db->query($sql);
        if ($db->numRows() == 0) {
            return true;
        }
        return false;
    }

    /**
     * Hente det maksimale kundenummer
     *
     * @deprecated moved to gateway
     *
     * @return integer
     */
    public function getMaxNumber()

    {
        $db = new DB_Sql();
        $db->query("SELECT number FROM contact WHERE intranet_id = " . $this->kernel->intranet->get("id") . " ORDER BY number DESC");
        if (!$db->nextRecord()) {
            return 0;
        }
        return $db->f("number");
    }

    /**
     * Public: Finde data til en liste
     *
     * @deprecated moved to gateway
     *
     * @param string $parameter hvad er det?
     *
     * @return array indeholdende kundedata til liste
     */
    public function getList($parameter = "")

    {
        if ($this->getDBQuery()->checkFilter("search")) {
            $search = $this->getDBQuery()->getFilter("search");
            $this->getDBQuery()->setCondition("
                contact.number = '".$search."' OR
                address.name LIKE '%".$search."%' OR
                address.address LIKE '%".$search."%' OR
                address.email LIKE '%".$search."%' OR
                address.phone = '".$search."'");
        }

        $this->getDBQuery()->setSorting("address.name");

        $i = 0; // til at give arrayet en key

        $db = $this->getDBQuery()->getRecordset("contact.id, contact.number, contact.paymentcondition, address.name, address.email, address.phone, address.address, address.postcode, address.city", "", false);

        $contacts = array();
        while ($db->nextRecord()) {
            //
            $contacts[$i]['id'] = $db->f("id");
            $contacts[$i]['number'] = $db->f("number");
            $contacts[$i]['paymentcondition'] = $db->f("paymentcondition");
            $contacts[$i]['name'] = $db->f("name");
            $contacts[$i]['address'] = $db->f("address");
            $contacts[$i]['postcode'] = $db->f("postcode");
            $contacts[$i]['city'] = $db->f("city");
            $contacts[$i]['phone'] = $db->f("phone");
            $contacts[$i]['email'] = $db->f("email");

            if ($parameter == "use_address") {
                $address = Intraface_Address::factory("contact", $db->f("id"));

                $contacts[$i]['address'] = $address->get();
            }

            $i++;
        }
        return $contacts;
    }

    /**
     * has contact any similar contacts based on phonenumber and email
     *
     * @return boolean
     */
    public function hasSimilarContacts()
    {
        $contacts = $this->getSimilarContacts();
        return (count($contacts) > 0);
    }

    /**
     * Return an array with similar contacts
     *
     * @return array
     */
    public function getSimilarContacts()
    {
        $this->address = $this->getAddress();

        $similar_contacts = array();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        if ($this->id == 0) {
            return array();
        }

        $this->load();

        $db = MDB2::singleton(DB_DSN);
        $sql = "SELECT DISTINCT(contact.id), contact.number, address.name, address.id AS address_id, address.address, address.postcode, address.phone, address.email, address.city FROM contact
                INNER JOIN address
                    ON contact.id = address.belong_to_id
                WHERE address.type=3
                    AND contact.active = 1
                    AND address.active = 1
                    AND contact.intranet_id = " . $db->quote($this->kernel->intranet->get('id'), 'integer') . "
                    AND contact.id != " . $db->quote($this->id, 'integer') . "
                    AND (
                        (address.email = " . $db->quote($this->address->get('email'), 'text') . " AND address.email != '')
                        OR (address.phone = " . $db->quote($this->address->get('phone'), 'text') . " AND address.phone != ''))

                    ";

        $result = $db->query($sql);
        if (PEAR::isError($result)) {
            throw new Exception($result->getMessage().' '.$result->getUserInfo());
        }

        if ($result->numRows() == 0) {
            return array();
        }

        return $result->fetchAll();
    }

    /**
     * Merges a contact to one contact
     *
     * - debtor
     * - newsletter
     * - procurement
     * - intranet
     *
     * These needs to implement a common function changeContact($old, $new)
     */
    function merge()
    {
        die('Contact::merge(): Ikke implementeret');

    }

    /**
     * Start keywordmodulet op
     * Denne metode kr�ves af keyword
     *
     * TODO M�ske burde denne metode hedde loadKeywords()?
     *
     * @return object
     */
    function getKeywords()
    {
        return $this->keywords = new Keyword($this);
    }

    function getKeyword()
    {
        return $this->getKeywords();
    }

    function getKeywordAppender()
    {
        return new Intraface_Keyword_Appender($this);
    }

    /**
     * Start message op
     *
     * @deprecated
     *
     * @param integer $id Optional id for the message
     *
     * @return object
     */
    private function loadMessage($id = 0)

    {
        return $this->message = new ContactMessage($this, (int)$id);
    }

    /**
     * Hvis kontakten er et firma, skal den loade og inkludere kontaktpersonerne
     *
     * @param integer $id Optional id of the contact person
     *
     * @return object
     */
    function loadContactPerson($id = 0)
    {
        return ($this->contactperson = new ContactPerson($this, (int)$id));
    }

    /**
     * Funktionen skal tjekke om der er tastet nogen kontaktpersoner ind overhovedet.
     * Funktionen er tilt�nkt et tjek, s� man hurtigt kan tjekke om brugeren har nogen.
     *
     * @return integer
     */
    function isFilledIn()

    {
        $db = new DB_Sql;
        $db->query("SELECT count(*) AS antal FROM contact WHERE intranet_id = " . $this->kernel->intranet->get('id'));
        if ($db->nextRecord()) {
            return $db->f('antal');
        }
        return 0;
    }

    /**
     * Generates a password for the contact
     *
     * @return boolean
     */
    function generateCode()

    {
        if ($this->id == 0) {
            return false;
        }
        $db = new DB_Sql;
        $db->query("UPDATE contact SET code = '".md5($this->id . date('Y-m-d H:i:s') . $this->kernel->intranet->get('id'))."' WHERE id = " . $this->id);
        $this->load();
        return true;
    }


    /**
     * Generates a password for the contact
     *
     * @return boolean
     */
    function generatePassword()

    {
        if ($this->id == 0) {
            return false;
        }
        $db = new DB_Sql;
        $db->query("UPDATE contact SET password = '".md5($this->id . date('Y-m-d H:i:s') . $this->kernel->intranet->get('id'))."' WHERE id = " . $this->id);
        $this->load();
        return true;
    }

    /**
     * Gets the contacts newsletter subscriptions
     *
     * @return array
     */
    function getNewsletterSubscriptions()
    {
        $db = new DB_Sql;
        $db->query("SELECT * FROM newsletter_subscriber WHERE optin = 1 AND active = 1 AND contact_id = " . $this->id . " AND intranet_id =" . $this->kernel->intranet->get('id'));
        $lists = array();
        while ($db->nextRecord()) {
            $lists[] = $db->f('list_id');
        }
        return $lists;
    }

    /**
     * Checks whether the contact needs to accept subscriptions
     *
     * @return array
     */
    function needNewsletterOptin()

    {
        $db = new DB_Sql;
        $db->query("SELECT list_id, code FROM newsletter_subscriber WHERE optin = 0 AND contact_id = " . $this->id . " AND intranet_id =" . $this->kernel->intranet->get('id'));
        $lists = array();
        $i = 0;
        while ($db->nextRecord()) {
            $lists[$i]['list_id'] = $db->f('list_id');
            $lists[$i]['code'] = $db->f('code');
            $i++;
        }
        return $lists;
    }

    /**
     * Kontakten kan slettes, hvis man kun er indskrevet i nyhedsbrevet.
     * Der b�r sikkert ogs� v�re en indstilling som ejeren af intranettet kan s�tte
     * efter al sandsynlighed skal denne v�re med som tjek i delete
     *
     * @return boolean
     */
    function canBeDeleted()
    {
        $db = new DB_Sql;
        $db->query("SELECT * FROM debtor WHERE contact_id = " . $this->id . " AND intranet_id = " . $this->kernel->intranet->get('id'));
        if (!$db->nextRecord()) {
            return true;
        }
        return false;
    }

    /**
     * skal tage h�jde for om intranettet tillader kundelogin
     *
     * @return boolean
     */
    function canLogin()
    {
        if ($this->get('active') == 0) {
            return false;
        }
        return true;
    }

    function getId()
    {
        return $this->id;
    }

    function getType()
    {
        return $this->types[$this->value['type_key']];
    }
}

Contact D
last analyzed 2017-03-20 12:20 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

33 Methods

How to fix Duplicated Code Complexity

Duplicated Code

Complex Class

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

intraface / intraface.dk

Contact D last analyzed 2017-03-20 12:20 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

33 Methods

How to fix Duplicated Code Complexity

Duplicated Code

Complex Class

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

Logical Operators are used for Control-Flow

Duplication Side-by-Side

Filter issues like

Contact D
last analyzed 2017-03-20 12:20 UTC
