CMS.check_paths() - Code Metrics - Inspection of "[GUI][0.5.8.7] Удаление логирования в TextBox" - intervisionlord/CarMusicSorter - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — dev ( 3dc5ca...6e7e16 )

by Andreas

created 2022-01-14 23:02 UTC

CMS.check_paths() B

↳ Parent: CMS

Complexity

Conditions

Size

Total Lines	19
Code Lines	16

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	72

Importance

Changes

Metric	Value
eloc	16
dl	0
loc	19
ccs	0
cts	13
cp	0
rs	7.3333
c	0
b	0
f	0
cc	8
nop	0
crap	72

"""Car Music Sorter."""
import gettext
import os
import re
import shutil
import w_settings

from sys import exit
from tkinter import Tk, PhotoImage, Menu, LabelFrame
from tkinter import Toplevel
from tkinter.ttk import Button, Label, Progressbar
from pathlib import Path
from f_getconfig import getconfig
from f_logging import writelog

import tkinter.filedialog as fd
input_dir = ''
output_dir = ''
source_file = []


# BEGIN FUNCTIONS #
# FIXME: Вынести по возможности в отдельные файлы
# Определение исходной и целевой директорий
def workdirs(param):
    """Открывает диалог выбора директории."""
    if param == 'indir':
        global input_dir
        input_dir = fd.askdirectory(title = _('Open source directory'))

        if input_dir != '':
            source_label.config(text = f'...{path_short(input_dir, 2)}')
            writelog(_('Input DIR set to: ') + input_dir)
        else:
            input_dir = ''
    elif param == 'outdir':
        global output_dir
        output_dir = fd.askdirectory(title = _('Set destination directory'))
        if output_dir != '':
            dest_label.config(text = f'...{path_short(output_dir, 2)}')
            writelog(_('Output DIR set to: ') + output_dir)
        else:
            output_dir = ''
    elif param == 'clear':
        source_label.config(text = _('Input DIR not defined'))
        dest_label.config(text = _('Output DIR not defined'))
        main_progressbar['value'] = 0
        input_dir = output_dir = ''


def path_short(path_string, len):
    """Сокращает путь для корректного отображения в лейбле."""
    return Path(*Path(path_string).parts[-len:])


# Вызов "О программе"
def popup_about(vers):
    """Открывает окно 'О программе'."""
# Центровка окна
    main_width = 400
    main_height = 150
    center_x_pos = int(window.winfo_screenwidth() / 2) - main_width
    center_y_pos = int(window.winfo_screenheight() / 2) - main_height

    popup = Toplevel()
    popup.geometry(f'{main_width}x{main_height}+{center_x_pos}+{center_y_pos}')
    popup.title(_('About'))

    imagepath = 'data/imgs/main.png'
    img = PhotoImage(file = imagepath)
    poplabel1 = Label(popup, image = img)
    poplabel1.grid(sticky = 'W', column = 0, row = 0, rowspan = 2)

    name_vers_str = 'Car Music Sorter\n\n' + _('Version: ') + vers
    author_github = 'https://github.com/intervisionlord'
    prog_author = _('\nAuthor: ') + 'Intervision\nGithub: ' + author_github
    poplabel_maindesc = Label(popup,
                              text = name_vers_str + prog_author,
                              justify = 'left')
    poplabel_maindesc.grid(sticky = 'W', column = 1, row = 0)
# Автор иконок
    icons_author = _('Icons: ') + 'icon king1 ' + _('on') + ' freeicons.io'
    poplabel_icons = Label(popup, text = icons_author, justify = 'left')
    poplabel_icons.grid(sticky = 'W', column = 1, row = 1)

    popup.grab_set()
    popup.focus_set()
    popup.wait_window()


# Основные операции
def check_paths():
    """Проверяет, что все пути заданы корректно и запускает копирование."""
    if input_dir == '' or output_dir == '':
        writelog(_('Input DIR or Output DIR are not defined!'))

    elif input_dir == output_dir:
        writelog(_('Input DIR and Output DIR must be different!'))
        return
    else:
        for path, subdirs, files in os.walk(input_dir):
            for file in files:
                # Перегоняем MP3 без лайвов и ремиксов в целевую директорию.
                filtered = re.search(r'^(?!(.*[Rr]emix.*|.*[Ll]ive.*)).*mp3',
                                     file)
                if filtered is not None:
                    source_file.append(f'{path}/{filtered.group(0)}')
    main_progressbar['maximum'] = len(source_file)
    for files in source_file:
        maincopy(files, output_dir)
    source_file.clear()


def processing():
    """Удаляет ремиксы и лайвы."""
    check_paths()
# Удаление ремиксов и лайвов
# TODO: Depricated
    liveregexp = r'.*\(.*[Rr]emix.*\).*|.*\(.*[Ll]ive.*\).*'
    for files in os.walk(output_dir):
        for file in files[2]:
            try:
                source_file.append(re.search(liveregexp, file).group(0))
            except Exception:
                pass
    for file in source_file:
        writelog(_('Removing Remix: ') + file)

        os.remove(f'{output_dir}/{file}')
        main_progressbar['value'] = main_progressbar['value'] + 1

        window.update_idletasks()
    source_file.clear()  # Очищаем список
    polish_filenames()


def polish_filenames():
    """Удаляет из имен треков мусор."""
# Готовим список свежепринесенных файлов с вычищенными ремиксами и лайвами
    for files in os.walk(output_dir):
        for file in files[2]:
            try:
                source_file.append(file)
            except Exception:
                pass

# Убираем из имен файлов мусор (номера треков в различном формате)
    main_progressbar['maximum'] = (main_progressbar['maximum'] +

                                   len(source_file))
    trashregexp = r'^[\d{1,2}\s\-\.]*'
    for file in source_file:
        new_file = re.sub(trashregexp, '', file)
        shutil.move(f'{output_dir}/{file}', f'{output_dir}/{new_file}')
        main_progressbar['value'] = main_progressbar['value'] + 1
        window.update_idletasks()
    source_file.clear()
    writelog(_('Completed!'))



# Копируем файлы
def maincopy(files, output_dir):
    """Копирует файлы."""
    writelog(f'{files}')
    filename = str.split(files, '/')
    writelog(filename[-1])
    shutil.copyfile(f'{files}', f'{output_dir}/{filename[-1]}')
    main_progressbar['value'] = main_progressbar['value'] + 1

    window.update_idletasks()
# TODO: Вывести запись логов в файл, убрать бокс с логом из окна.
# END FUNCTIONS #


# Вводим основные переменные
vers = getconfig()['core']['version']
langcode = getconfig()['settings']['locale']
# Локализация
gettext.translation('CarMusicSorter', localedir='l10n',
                    languages=[langcode]).install()
# Рисуем окно
window = Tk()
window.iconphoto(True, PhotoImage(file = 'data/imgs/main.png'))
window.geometry('370x270')
window.eval('tk::PlaceWindow . center')
window.title('Car Music Sorter')
window.resizable(False, False)

# Пути к оформлению
sourceicon = PhotoImage(file = 'data/imgs/20source.png')
desticon = PhotoImage(file = 'data/imgs/20dest.png')
launchicon = PhotoImage(file = 'data/imgs/20ok.png')
clearicon = PhotoImage(file = 'data/imgs/20clear.png')

# Основное меню
menu = Menu(window)
menu_about = Menu(menu, tearoff = 0)
menu_file = Menu(menu, tearoff = 0)
menu.add_cascade(label = _('File'), menu = menu_file)

menu.add_cascade(label = _('Info'), menu = menu_about)

# Элементы меню
menu_about.add_command(label = _('About'),
                       command = lambda: popup_about(vers),
                       accelerator = 'F1')

menu_file.add_command(label = _('Input Dir'),
                      command = lambda: workdirs('indir'),
                      accelerator = 'CTRL+O')
menu_file.add_command(label = _('Output Dir'),
                      command = lambda: workdirs('outdirs'),
                      accelerator = 'CTRL+D')
menu_file.add_command(label = _('Clear'),
                      command = lambda: workdirs('clear'),
                      accelerator = 'CTRL+R')
menu_file.add_separator()
menu_file.add_command(label = _('Settings'),
                      command = w_settings.popup_settings)
menu_file.add_separator()
menu_file.add_command(label = _('Exit'),
                      command = exit,
                      accelerator = 'CTRL+E')

# Биндим хоткеи к функциям
menu_file.bind_all('<Command-o>', lambda event: workdirs('indir'))
menu_file.bind_all('<Command-d>', lambda event: workdirs('outdir'))
menu_file.bind_all('<Command-r>', lambda event: workdirs('clear'))
menu_file.bind_all('<Command-e>', exit)

menu_about.bind_all('<F1>', lambda event: popup_about(vers))

window.config(menu = menu)
# Строим элеметны основного окна и группы
first_group = LabelFrame(window, text = _('IO Directories'))

first_group.grid(sticky = 'WE', column = 0, row = 0, padx = 5, pady = 10,
                 ipadx = 2, ipady = 4)

operation_group = LabelFrame(window, text = _('Operations'))
operation_group.grid(sticky = 'WE', column = 0, row = 3, padx = 5, pady = 5,
                     ipadx = 5, ipady = 5)

progress_group = LabelFrame(window, text = _('Progress'))
progress_group.grid(sticky = 'WE', column = 0, row = 1, padx = 5, pady = 5,
                    ipadx = 0, ipady = 2, rowspan = 2)

# Прогрессбар
main_progressbar = Progressbar(progress_group, length = 350, value = 0,
                               orient = 'horizontal', mode = 'determinate')
main_progressbar.grid(pady = 4, column = 0, row = 1)

# Поясняющие лейблы
source_label_text = _('Input DIR not defined')
dest_label_text = _('Output DIR not defined')

source_label = Label(first_group, text = source_label_text, justify = 'left')
source_label.grid(column = 1, row = 0)
dest_label = Label(first_group, text = dest_label_text, justify = 'left')
dest_label.grid(column = 1, row = 1)

# Кнопки
source_button = Button(first_group, text = _('Input Dir'),
                       command = lambda: workdirs('indir'), image = sourceicon,
                       width = 20, compound = 'left')
source_button.grid(row = 0, ipadx = 2, ipady = 2, padx = 4)

dest_button = Button(first_group, text = _('Output Dir'),
                     command = lambda: workdirs('outdir'), image = desticon,
                     width = 20, compound = 'left')
dest_button.grid(row = 1, ipadx = 2, ipady = 2, padx = 4)

launch_button = Button(operation_group, text = _('Process'),
                       command = processing, image = launchicon,
                       width = 20, compound = 'left')
launch_button.grid(column = 0, row = 2, ipadx = 2, ipady = 2, padx = 12)

clear_button = Button(operation_group, text = _('Clear'),
                      command = lambda: workdirs('clear'), image = clearicon,
                      width = 20, compound = 'left')

clear_button.grid(column = 1, row = 2, ipadx = 2, ipady = 2, padx = 0)

if __name__ == '__main__':
    window.mainloop()


1		"""Car Music Sorter."""
2	1	import gettext
3	1	import os
4	1	import re
5	1	import shutil
6	1	import w_settings
7	1
8		from sys import exit
9		from tkinter import Tk, PhotoImage, Menu, LabelFrame
10		from tkinter import Toplevel
11		from tkinter.ttk import Button, Label, Progressbar
12		from pathlib import Path
13		from f_getconfig import getconfig
14		from f_logging import writelog
15
16		import tkinter.filedialog as fd
17		input_dir = ''
18		output_dir = ''
19		source_file = []
20
21
22		# BEGIN FUNCTIONS #
23		# FIXME: Вынести по возможности в отдельные файлы
24		# Определение исходной и целевой директорий
25		def workdirs(param):
26		"""Открывает диалог выбора директории."""
27		if param == 'indir':
28		global input_dir
29		input_dir = fd.askdirectory(title = _('Open source directory'))
		0 ignored issues – show Comprehensibility Best Practice introduced 2022-01-04 18:00 UTC by Report Bug Copy Issue Report The variable `_` does not seem to be defined. Loading history...
30		if input_dir != '':
31		source_label.config(text = f'...{path_short(input_dir, 2)}')
32		writelog(_('Input DIR set to: ') + input_dir)
33		else:
34		input_dir = ''
35		elif param == 'outdir':
36		global output_dir
37		output_dir = fd.askdirectory(title = _('Set destination directory'))
38		if output_dir != '':
39		dest_label.config(text = f'...{path_short(output_dir, 2)}')
40		writelog(_('Output DIR set to: ') + output_dir)
41		else:
42		output_dir = ''
43		elif param == 'clear':
44		source_label.config(text = _('Input DIR not defined'))
45		dest_label.config(text = _('Output DIR not defined'))
46		main_progressbar['value'] = 0
47		input_dir = output_dir = ''
48
49
50		def path_short(path_string, len):
51		"""Сокращает путь для корректного отображения в лейбле."""
52		return Path(*Path(path_string).parts[-len:])
53
54
55		# Вызов "О программе"
56		def popup_about(vers):
57		"""Открывает окно 'О программе'."""
58		# Центровка окна
59		main_width = 400
60		main_height = 150
61		center_x_pos = int(window.winfo_screenwidth() / 2) - main_width
62		center_y_pos = int(window.winfo_screenheight() / 2) - main_height
63
64		popup = Toplevel()
65		popup.geometry(f'{main_width}x{main_height}+{center_x_pos}+{center_y_pos}')
66		popup.title(_('About'))
		0 ignored issues – show Comprehensibility Best Practice introduced 2022-01-04 18:00 UTC by Report Bug Copy Issue Report The variable `_` does not seem to be defined. Loading history...
67		imagepath = 'data/imgs/main.png'
68		img = PhotoImage(file = imagepath)
69		poplabel1 = Label(popup, image = img)
70		poplabel1.grid(sticky = 'W', column = 0, row = 0, rowspan = 2)
71
72		name_vers_str = 'Car Music Sorter\n\n' + _('Version: ') + vers
73		author_github = 'https://github.com/intervisionlord'
74		prog_author = _('\nAuthor: ') + 'Intervision\nGithub: ' + author_github
75		poplabel_maindesc = Label(popup,
76		text = name_vers_str + prog_author,
77		justify = 'left')
78		poplabel_maindesc.grid(sticky = 'W', column = 1, row = 0)
79		# Автор иконок
80		icons_author = _('Icons: ') + 'icon king1 ' + _('on') + ' freeicons.io'
81		poplabel_icons = Label(popup, text = icons_author, justify = 'left')
82		poplabel_icons.grid(sticky = 'W', column = 1, row = 1)
83
84		popup.grab_set()
85		popup.focus_set()
86		popup.wait_window()
87
88
89		# Основные операции
90		def check_paths():
91		"""Проверяет, что все пути заданы корректно и запускает копирование."""
92		if input_dir == '' or output_dir == '':
93		writelog(_('Input DIR or Output DIR are not defined!'))
		0 ignored issues – show Comprehensibility Best Practice introduced 2022-01-04 18:00 UTC by Report Bug Copy Issue Report The variable `_` does not seem to be defined. Loading history...
94		elif input_dir == output_dir:
95		writelog(_('Input DIR and Output DIR must be different!'))
96		return
97		else:
98		for path, subdirs, files in os.walk(input_dir):
99		for file in files:
100		# Перегоняем MP3 без лайвов и ремиксов в целевую директорию.
101		filtered = re.search(r'^(?!(.[Rr]emix.\|.[Ll]ive.)).*mp3',
102		file)
103		if filtered is not None:
104		source_file.append(f'{path}/{filtered.group(0)}')
105		main_progressbar['maximum'] = len(source_file)
106		for files in source_file:
107		maincopy(files, output_dir)
108		source_file.clear()
109
110
111		def processing():
112		"""Удаляет ремиксы и лайвы."""
113		check_paths()
114		# Удаление ремиксов и лайвов
115		# TODO: Depricated
116		liveregexp = r'.\(.[Rr]emix.\).\|.\(.[Ll]ive.\).'
117		for files in os.walk(output_dir):
118		for file in files[2]:
119		try:
120		source_file.append(re.search(liveregexp, file).group(0))
121		except Exception:
122		pass
123		for file in source_file:
124		writelog(_('Removing Remix: ') + file)
		0 ignored issues – show Comprehensibility Best Practice introduced 2022-01-04 18:00 UTC by Report Bug Copy Issue Report The variable `_` does not seem to be defined. Loading history...
125		os.remove(f'{output_dir}/{file}')
126		main_progressbar['value'] = main_progressbar['value'] + 1
		0 ignored issues – show Comprehensibility Best Practice introduced 2022-01-04 18:00 UTC by Report Bug Copy Issue Report The variable `main_progressbar` does not seem to be defined. Loading history...
127		window.update_idletasks()
128		source_file.clear() # Очищаем список
129		polish_filenames()
130
131
132		def polish_filenames():
133		"""Удаляет из имен треков мусор."""
134		# Готовим список свежепринесенных файлов с вычищенными ремиксами и лайвами
135		for files in os.walk(output_dir):
136		for file in files[2]:
137		try:
138		source_file.append(file)
139		except Exception:
140		pass
141
142		# Убираем из имен файлов мусор (номера треков в различном формате)
143		main_progressbar['maximum'] = (main_progressbar['maximum'] +
		0 ignored issues – show Comprehensibility Best Practice introduced 2022-01-04 18:00 UTC by Report Bug Copy Issue Report The variable `main_progressbar` does not seem to be defined. Loading history...
144		len(source_file))
145		trashregexp = r'^[\d{1,2}\s\-\.]*'
146		for file in source_file:
147		new_file = re.sub(trashregexp, '', file)
148		shutil.move(f'{output_dir}/{file}', f'{output_dir}/{new_file}')
149		main_progressbar['value'] = main_progressbar['value'] + 1
150		window.update_idletasks()
151		source_file.clear()
152		writelog(_('Completed!'))
		0 ignored issues – show Comprehensibility Best Practice introduced 2022-01-05 13:59 UTC by Report Bug Copy Issue Report The variable `_` does not seem to be defined. Loading history...
153
154
155		# Копируем файлы
156		def maincopy(files, output_dir):
157		"""Копирует файлы."""
158		writelog(f'{files}')
159		filename = str.split(files, '/')
160		writelog(filename[-1])
161		shutil.copyfile(f'{files}', f'{output_dir}/{filename[-1]}')
162		main_progressbar['value'] = main_progressbar['value'] + 1
		0 ignored issues – show Comprehensibility Best Practice introduced 2022-01-04 18:00 UTC by Report Bug Copy Issue Report The variable `main_progressbar` does not seem to be defined. Loading history...
163		window.update_idletasks()
164		# TODO: Вывести запись логов в файл, убрать бокс с логом из окна.
165		# END FUNCTIONS #
166
167
168		# Вводим основные переменные
169		vers = getconfig()['core']['version']
170		langcode = getconfig()['settings']['locale']
171		# Локализация
172		gettext.translation('CarMusicSorter', localedir='l10n',
173		languages=[langcode]).install()
174		# Рисуем окно
175		window = Tk()
176		window.iconphoto(True, PhotoImage(file = 'data/imgs/main.png'))
177		window.geometry('370x270')
178		window.eval('tk::PlaceWindow . center')
179		window.title('Car Music Sorter')
180		window.resizable(False, False)
181
182		# Пути к оформлению
183		sourceicon = PhotoImage(file = 'data/imgs/20source.png')
184		desticon = PhotoImage(file = 'data/imgs/20dest.png')
185		launchicon = PhotoImage(file = 'data/imgs/20ok.png')
186		clearicon = PhotoImage(file = 'data/imgs/20clear.png')
187
188		# Основное меню
189		menu = Menu(window)
190		menu_about = Menu(menu, tearoff = 0)
191		menu_file = Menu(menu, tearoff = 0)
192		menu.add_cascade(label = _('File'), menu = menu_file)
		0 ignored issues – show Comprehensibility Best Practice introduced 2022-01-04 18:00 UTC by Report Bug Copy Issue Report The variable `_` does not seem to be defined. Loading history...
193		menu.add_cascade(label = _('Info'), menu = menu_about)
194
195		# Элементы меню
196		menu_about.add_command(label = _('About'),
197		command = lambda: popup_about(vers),
198		accelerator = 'F1')
199
200		menu_file.add_command(label = _('Input Dir'),
201		command = lambda: workdirs('indir'),
202		accelerator = 'CTRL+O')
203		menu_file.add_command(label = _('Output Dir'),
204		command = lambda: workdirs('outdirs'),
205		accelerator = 'CTRL+D')
206		menu_file.add_command(label = _('Clear'),
207		command = lambda: workdirs('clear'),
208		accelerator = 'CTRL+R')
209		menu_file.add_separator()
210		menu_file.add_command(label = _('Settings'),
211		command = w_settings.popup_settings)
212		menu_file.add_separator()
213		menu_file.add_command(label = _('Exit'),
214		command = exit,
215		accelerator = 'CTRL+E')
216
217		# Биндим хоткеи к функциям
218		menu_file.bind_all('<Command-o>', lambda event: workdirs('indir'))
219		menu_file.bind_all('<Command-d>', lambda event: workdirs('outdir'))
220		menu_file.bind_all('<Command-r>', lambda event: workdirs('clear'))
221		menu_file.bind_all('<Command-e>', exit)
222
223		menu_about.bind_all('<F1>', lambda event: popup_about(vers))
224
225		window.config(menu = menu)
226		# Строим элеметны основного окна и группы
227		first_group = LabelFrame(window, text = _('IO Directories'))
228
229		first_group.grid(sticky = 'WE', column = 0, row = 0, padx = 5, pady = 10,
230		ipadx = 2, ipady = 4)
231
232		operation_group = LabelFrame(window, text = _('Operations'))
233		operation_group.grid(sticky = 'WE', column = 0, row = 3, padx = 5, pady = 5,
234		ipadx = 5, ipady = 5)
235
236		progress_group = LabelFrame(window, text = _('Progress'))
237		progress_group.grid(sticky = 'WE', column = 0, row = 1, padx = 5, pady = 5,
238		ipadx = 0, ipady = 2, rowspan = 2)
239
240		# Прогрессбар
241		main_progressbar = Progressbar(progress_group, length = 350, value = 0,
242		orient = 'horizontal', mode = 'determinate')
243		main_progressbar.grid(pady = 4, column = 0, row = 1)
244
245		# Поясняющие лейблы
246		source_label_text = _('Input DIR not defined')
247		dest_label_text = _('Output DIR not defined')
248
249		source_label = Label(first_group, text = source_label_text, justify = 'left')
250		source_label.grid(column = 1, row = 0)
251		dest_label = Label(first_group, text = dest_label_text, justify = 'left')
252		dest_label.grid(column = 1, row = 1)
253
254		# Кнопки
255		source_button = Button(first_group, text = _('Input Dir'),
256		command = lambda: workdirs('indir'), image = sourceicon,
257		width = 20, compound = 'left')
258		source_button.grid(row = 0, ipadx = 2, ipady = 2, padx = 4)
259
260		dest_button = Button(first_group, text = _('Output Dir'),
261		command = lambda: workdirs('outdir'), image = desticon,
262		width = 20, compound = 'left')
263		dest_button.grid(row = 1, ipadx = 2, ipady = 2, padx = 4)
264
265		launch_button = Button(operation_group, text = _('Process'),
266		command = processing, image = launchicon,
267		width = 20, compound = 'left')
268		launch_button.grid(column = 0, row = 2, ipadx = 2, ipady = 2, padx = 12)
269
270		clear_button = Button(operation_group, text = _('Clear'),
271		command = lambda: workdirs('clear'), image = clearicon,
272		width = 20, compound = 'left')
273
274		clear_button.grid(column = 1, row = 2, ipadx = 2, ipady = 2, padx = 0)
275
276		if __name__ == '__main__':
277		window.mainloop()
278

intervisionlord / CarMusicSorter

Push — dev ( 3dc5ca...6e7e16 )

CMS.check_paths() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like