function_requirements.php ➔ get_function_requirements() - Code Metrics - Inspection of "migrated the function requirements logic to the tf..." - interserver/myadmin-plugin-installer - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( 319182...81d536 )

by Joe

created 2017-08-25 01:39 UTC

function_requirements.php ➔ get_function_requirements() B

↳ Parent: Project

Complexity

Conditions	2
Paths	2

Size

Total Lines	516
Code Lines	514

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	514
nc	2
nop	0
dl	0
loc	516
rs	8.2857
c	0
b	0
f	0

How to fix Long Method

<?php
/**
 * @author Joe Huss <[email protected]>
 * @copyright 2017
 * @package Plugins
 */

/**
 * loads the files needed to run the given class or function
 *
 * @param $function
 * @return bool whether or not it found the given function/class
 */
function function_requirements($function) {
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
	return $GLOBALS['tf']->function_requirements($function);
}


1			<?php
2			/**
3			* @author Joe Huss <[email protected]>
4			* @copyright 2017
5			* @package Plugins
6			*/
7
8			/**
9			* loads the files needed to run the given class or function
10			*
11			* @param $function
12			* @return bool whether or not it found the given function/class
13			*/
14			function function_requirements($function) {
			0 ignored issues – show Coding Style introduced 2017-08-19 11:40 UTC by Report Bug Copy Issue Report `function_requirements` uses the super-global variable `$GLOBALS` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
15			return $GLOBALS['tf']->function_requirements($function);
16			}
17

interserver / myadmin-plugin-installer

Push — master ( 319182...81d536 )

function_requirements.php ➔ get_function_requirements() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like