Service::getResourceFromId() - Code Metrics - Inspection of "Fix spinner always on top" - interfasys/galleryplus - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — stable8.2 ( 09e830...ae9bfd )

by Olivier

created 2016-06-19 12:04 UTC

Service::getResourceFromId() A

↳ Parent: Service

Complexity

Conditions	4
Paths	4

Size

Total Lines	14
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	4

Importance

Changes

Metric	Value
dl	0
loc	14
ccs	7
cts	7
cp	1
rs	9.2
c	0
b	0
f	0
cc	4
eloc	8
nc	4
nop	1
crap	4

<?php
/**
 * ownCloud - galleryplus
 *
 * This file is licensed under the Affero General Public License version 3 or
 * later. See the COPYING file.
 *
 * @author Olivier Paroz <[email protected]>
 *
 * @copyright Olivier Paroz 2014-2015
 */

namespace OCA\GalleryPlus\Service;

use OCP\Files\Node;
use OCP\ILogger;

use OCA\GalleryPlus\Environment\Environment;

/**
 * Contains methods which all services will need
 *
 * @package OCA\GalleryPlus\Service
 */
abstract class Service {

	/**
	 * @var string
	 */
	protected $appName;
	/**
	 * @var Environment
	 */
	protected $environment;
	/**
	 * @var ILogger
	 */
	protected $logger;

	/**
	 * Constructor
	 *
	 * @param string $appName
	 * @param Environment $environment
	 * @param ILogger $logger
	 */
	public function __construct(
		$appName,
		Environment $environment,
		ILogger $logger
	) {
		$this->appName = $appName;
		$this->environment = $environment;
		$this->logger = $logger;
	}

	/**
	 * Returns the node matching the given ID
	 *
	 * @param int $nodeId ID of the resource to locate
	 *
	 * @return Node
	 * @throws NotFoundServiceException
	 */
	public function getResourceFromId($nodeId) {
		try {
			$node = $this->environment->getResourceFromId($nodeId);

			// Making extra sure that we can actually do something with the file
			if (!$node->getMimetype() || !$node->isReadable()) {
				throw new NotFoundServiceException("Can't access the file");
			}

			return $node;
		} catch (\Exception $exception) {
			throw new NotFoundServiceException($exception->getMessage());
		}
	}

}


1		<?php
2		/**
3		* ownCloud - galleryplus
4		*
5		* This file is licensed under the Affero General Public License version 3 or
6		* later. See the COPYING file.
7		*
8		* @author Olivier Paroz <[email protected]>
9		*
10		* @copyright Olivier Paroz 2014-2015
11		*/
12
13		namespace OCA\GalleryPlus\Service;
14
15		use OCP\Files\Node;
16		use OCP\ILogger;
17
18		use OCA\GalleryPlus\Environment\Environment;
19
20		/**
21		* Contains methods which all services will need
22		*
23		* @package OCA\GalleryPlus\Service
24		*/
25		abstract class Service {
26
27		/**
28		* @var string
29		*/
30		protected $appName;
31		/**
32		* @var Environment
33		*/
34		protected $environment;
35		/**
36		* @var ILogger
37		*/
38		protected $logger;
39
40		/**
41		* Constructor
42		*
43		* @param string $appName
44		* @param Environment $environment
45		* @param ILogger $logger
46		*/
47	108	public function __construct(
48		$appName,
49		Environment $environment,
50		ILogger $logger
51		) {
52	108	$this->appName = $appName;
53	108	$this->environment = $environment;
54	108	$this->logger = $logger;
55	108	}
56
57		/**
58		* Returns the node matching the given ID
59		*
60		* @param int $nodeId ID of the resource to locate
61		*
62		* @return Node
63		* @throws NotFoundServiceException
64		*/
65	14	public function getResourceFromId($nodeId) {
66		try {
67	14	$node = $this->environment->getResourceFromId($nodeId);
68
69		// Making extra sure that we can actually do something with the file
70	11	if (!$node->getMimetype() \|\| !$node->isReadable()) {
71	1	throw new NotFoundServiceException("Can't access the file");
72		}
73
74	10	return $node;
75	4	} catch (\Exception $exception) {
76	4	throw new NotFoundServiceException($exception->getMessage());
77		}
78		}
79
80		}
81

interfasys / galleryplus

Push — stable8.2 ( 09e830...ae9bfd )

Service::getResourceFromId() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like