PageLayoutUpdateManager::setFakeFiles() - Code Metrics - Inspection of "#4 Change tests/Util to tests/src" - integer-net/magento2-global-custom-layout - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — tests ( bccf67...74f795 )

by Willem

created 2020-05-05 07:06 UTC

PageLayoutUpdateManager::setFakeFiles() A

↳ Parent: PageLayoutUpdateManager

Complexity

Conditions	2
Paths	2

Size

Total Lines	6
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	4
dl	0
loc	6
rs	10
c	0
b	0
f	0
cc	2
nc	2
nop	2

<?php
declare(strict_types=1);

namespace IntegerNet\GlobalCustomLayout\Test\src;

use Magento\Cms\Api\Data\PageInterface;
use Magento\Cms\Model\Page\CustomLayout\CustomLayoutManager;

/**
 * Manager allowing to fake available files.
 */
class PageLayoutUpdateManager extends CustomLayoutManager
{
    /**
     * @var array Keys are Page IDs, values - file names.
     */
    private $fakeFiles = [];

    /**
     * Supply fake files for a Page.
     *
     * @param int $forPageId
     * @param string[]|null $files Pass null to reset.
     */
    public function setFakeFiles(int $forPageId, ?array $files): void
    {
        if ($files === null) {

            unset($this->fakeFiles[$forPageId]);
        } else {
            $this->fakeFiles[$forPageId] = $files;
        }
    }

    /**
     * Fetches fake/mock files added through $this->setFakeFiles()
     * for current Page and Global (0)
     *
     * If none found, fall back to original method
     *
     * @param PageInterface $page
     * @return array
     */
    public function fetchAvailableFiles(PageInterface $page): array
    {
        return array_unique(
            array_merge(
                ($this->fakeFiles[$page->getId()] ?? []),
                ($this->fakeFiles[0] ?? [])
            )
        ) ?: parent::fetchAvailableFiles($page);
    }
}


1			<?php
2			declare(strict_types=1);
3
4			namespace IntegerNet\GlobalCustomLayout\Test\src;
5
6			use Magento\Cms\Api\Data\PageInterface;
7			use Magento\Cms\Model\Page\CustomLayout\CustomLayoutManager;
8
9			/**
10			* Manager allowing to fake available files.
11			*/
12			class PageLayoutUpdateManager extends CustomLayoutManager
13			{
14			/**
15			* @var array Keys are Page IDs, values - file names.
16			*/
17			private $fakeFiles = [];
18
19			/**
20			* Supply fake files for a Page.
21			*
22			* @param int $forPageId
23			* @param string[]\|null $files Pass null to reset.
24			*/
25			public function setFakeFiles(int $forPageId, ?array $files): void
26			{
27			if ($files === null) {
			0 ignored issues – show introduced 2020-05-02 11:03 UTC by Report Bug Copy Issue Report The condition `$files === null` is always `false`. Loading history...
28			unset($this->fakeFiles[$forPageId]);
29			} else {
30			$this->fakeFiles[$forPageId] = $files;
31			}
32			}
33
34			/**
35			* Fetches fake/mock files added through $this->setFakeFiles()
36			* for current Page and Global (0)
37			*
38			* If none found, fall back to original method
39			*
40			* @param PageInterface $page
41			* @return array
42			*/
43			public function fetchAvailableFiles(PageInterface $page): array
44			{
45			return array_unique(
46			array_merge(
47			($this->fakeFiles[$page->getId()] ?? []),
48			($this->fakeFiles[0] ?? [])
49			)
50			) ?: parent::fetchAvailableFiles($page);
51			}
52			}
53

integer-net / magento2-global-custom-layout

Push — tests ( bccf67...74f795 )

PageLayoutUpdateManager::setFakeFiles() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like