Complex classes like XMLReader often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use XMLReader, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
8 | class XMLReader |
||
9 | { |
||
10 | /** |
||
11 | * XML Reader |
||
12 | * |
||
13 | * @var \XMLReader |
||
14 | */ |
||
15 | private $reader; |
||
16 | |||
17 | /** |
||
18 | * XML document |
||
19 | * |
||
20 | * @var \Inspirum\XML\Services\XML |
||
21 | */ |
||
22 | private $xml; |
||
23 | |||
24 | /** |
||
25 | * XMLReader constructor |
||
26 | * |
||
27 | * @param string $filepath |
||
28 | */ |
||
29 | 17 | public function __construct(string $filepath) |
|
34 | |||
35 | /** |
||
36 | * XMLReader destructor |
||
37 | */ |
||
38 | 13 | public function __destruct() |
|
42 | |||
43 | /** |
||
44 | * Open file |
||
45 | * |
||
46 | * @param string $filepath |
||
47 | * |
||
48 | * @return \XMLReader |
||
49 | * |
||
50 | * @throws \Exception |
||
51 | */ |
||
52 | 17 | private function open(string $filepath): BaseXMLReader |
|
68 | |||
69 | /** |
||
70 | * Parse file and yield next node |
||
71 | * |
||
72 | * @param string $nodeName |
||
73 | * |
||
74 | * @return \Generator|\Inspirum\XML\Services\XMLNode[] |
||
75 | */ |
||
76 | 7 | public function iterateNode(string $nodeName): iterable |
|
92 | |||
93 | /** |
||
94 | * Get next node |
||
95 | * |
||
96 | * @param string $nodeName |
||
97 | * |
||
98 | * @return \Inspirum\XML\Services\XMLNode|null |
||
99 | */ |
||
100 | 8 | public function nextNode(string $nodeName): ?XMLNode |
|
110 | |||
111 | /** |
||
112 | * Move to first element by tag name |
||
113 | * |
||
114 | * @param string $nodeName |
||
115 | * |
||
116 | * @return bool |
||
117 | */ |
||
118 | 14 | private function moveToNode(string $nodeName): bool |
|
128 | |||
129 | /** |
||
130 | * Move to next sibling element by tag name |
||
131 | * |
||
132 | * @param string $nodeName |
||
133 | * |
||
134 | * @return bool |
||
135 | */ |
||
136 | 5 | private function moveToNextNode(string $nodeName): bool |
|
146 | |||
147 | /** |
||
148 | * Return associative array of element by name |
||
149 | * |
||
150 | * @return \Inspirum\XML\Services\XMLNode|null |
||
151 | */ |
||
152 | 10 | private function readNode(): ?XMLNode |
|
192 | |||
193 | /** |
||
194 | * Move to next node in document |
||
195 | * |
||
196 | * @return bool |
||
197 | * |
||
198 | * @throws \DOMException |
||
199 | */ |
||
200 | 14 | private function read(): bool |
|
206 | |||
207 | /** |
||
208 | * Get current node name |
||
209 | * |
||
210 | * @return string |
||
211 | */ |
||
212 | 12 | private function getNodeName(): string |
|
216 | |||
217 | /** |
||
218 | * Get current node type |
||
219 | * |
||
220 | * @return int |
||
221 | */ |
||
222 | 12 | private function getNodeType(): int |
|
226 | |||
227 | /** |
||
228 | * Get current node value |
||
229 | * |
||
230 | * @return string |
||
231 | */ |
||
232 | 10 | private function getNodeValue(): string |
|
236 | |||
237 | /** |
||
238 | * If current node is element open tag |
||
239 | * |
||
240 | * @return bool |
||
241 | */ |
||
242 | 12 | private function isNodeElementType(): bool |
|
246 | |||
247 | /** |
||
248 | * If current node is element open tag |
||
249 | * |
||
250 | * @return bool |
||
251 | */ |
||
252 | 10 | private function isNodeEmptyElementType(): bool |
|
256 | |||
257 | /** |
||
258 | * If current node is element close tag |
||
259 | * |
||
260 | * @return bool |
||
261 | */ |
||
262 | 9 | private function isNodeElementEndType(): bool |
|
266 | |||
267 | /** |
||
268 | * If current node is text content |
||
269 | * |
||
270 | * @return bool |
||
271 | */ |
||
272 | 8 | private function isNodeTextType(): bool |
|
276 | |||
277 | /** |
||
278 | * If current node is given node type |
||
279 | * |
||
280 | * @param int $type |
||
281 | * |
||
282 | * @return bool |
||
283 | */ |
||
284 | 12 | private function isNodeType(int $type): bool |
|
288 | |||
289 | /** |
||
290 | * Get current node attributes |
||
291 | * |
||
292 | * @return array<string,string> |
||
293 | */ |
||
294 | 10 | private function getNodeAttributes(): array |
|
307 | |||
308 | /** |
||
309 | * Register custom error handler to throw Exception on warning message |
||
310 | * |
||
311 | * @param callable $callback |
||
312 | * |
||
313 | * @return mixed |
||
314 | * |
||
315 | * @throws \DOMException |
||
316 | */ |
||
317 | 26 | protected function withErrorHandler(callable $callback) |
|
331 | } |
||
332 |