Complex classes like XMLReader often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use XMLReader, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 8 | class XMLReader |
||
| 9 | { |
||
| 10 | /** |
||
| 11 | * XML Reader |
||
| 12 | * |
||
| 13 | * @var \XMLReader |
||
| 14 | */ |
||
| 15 | private $reader; |
||
| 16 | |||
| 17 | /** |
||
| 18 | * XML document |
||
| 19 | * |
||
| 20 | * @var \Inspirum\XML\Services\XML |
||
| 21 | */ |
||
| 22 | private $xml; |
||
| 23 | |||
| 24 | /** |
||
| 25 | * XMLReader constructor |
||
| 26 | * |
||
| 27 | * @param string $filepath |
||
| 28 | */ |
||
| 29 | 17 | public function __construct(string $filepath) |
|
| 34 | |||
| 35 | /** |
||
| 36 | * XMLReader destructor |
||
| 37 | */ |
||
| 38 | 13 | public function __destruct() |
|
| 42 | |||
| 43 | /** |
||
| 44 | * Open file |
||
| 45 | * |
||
| 46 | * @param string $filepath |
||
| 47 | * |
||
| 48 | * @return \XMLReader |
||
| 49 | * |
||
| 50 | * @throws \Exception |
||
| 51 | */ |
||
| 52 | 17 | private function open(string $filepath): BaseXMLReader |
|
| 68 | |||
| 69 | /** |
||
| 70 | * Parse file and yield next node |
||
| 71 | * |
||
| 72 | * @param string $nodeName |
||
| 73 | * |
||
| 74 | * @return \Generator|\Inspirum\XML\Services\XMLNode[] |
||
| 75 | */ |
||
| 76 | 7 | public function iterateNode(string $nodeName): iterable |
|
| 92 | |||
| 93 | /** |
||
| 94 | * Get next node |
||
| 95 | * |
||
| 96 | * @param string $nodeName |
||
| 97 | * |
||
| 98 | * @return \Inspirum\XML\Services\XMLNode|null |
||
| 99 | */ |
||
| 100 | 8 | public function nextNode(string $nodeName): ?XMLNode |
|
| 110 | |||
| 111 | /** |
||
| 112 | * Move to first element by tag name |
||
| 113 | * |
||
| 114 | * @param string $nodeName |
||
| 115 | * |
||
| 116 | * @return bool |
||
| 117 | */ |
||
| 118 | 14 | private function moveToNode(string $nodeName): bool |
|
| 128 | |||
| 129 | /** |
||
| 130 | * Move to next sibling element by tag name |
||
| 131 | * |
||
| 132 | * @param string $nodeName |
||
| 133 | * |
||
| 134 | * @return bool |
||
| 135 | */ |
||
| 136 | 5 | private function moveToNextNode(string $nodeName): bool |
|
| 152 | 10 | ||
| 153 | /** |
||
| 154 | 10 | * Return associative array of element by name |
|
| 155 | 10 | * |
|
| 156 | * @return \Inspirum\XML\Services\XMLNode|null |
||
| 157 | 10 | */ |
|
| 158 | 1 | private function readNode(): ?XMLNode |
|
| 198 | |||
| 199 | /** |
||
| 200 | 14 | * Move to next node in document |
|
| 201 | * |
||
| 202 | 14 | * @return bool |
|
| 203 | 14 | * |
|
| 204 | 14 | * @throws \DOMException |
|
| 205 | */ |
||
| 206 | private function read(): bool |
||
| 212 | 12 | ||
| 213 | /** |
||
| 214 | 12 | * Get current node name |
|
| 215 | * |
||
| 216 | * @return string |
||
| 217 | */ |
||
| 218 | private function getNodeName(): string |
||
| 222 | 12 | ||
| 223 | /** |
||
| 224 | 12 | * Get current node type |
|
| 225 | * |
||
| 226 | * @return int |
||
| 227 | */ |
||
| 228 | private function getNodeType(): int |
||
| 232 | 10 | ||
| 233 | /** |
||
| 234 | 10 | * Get current node value |
|
| 235 | * |
||
| 236 | * @return string |
||
| 237 | */ |
||
| 238 | private function getNodeValue(): string |
||
| 242 | 12 | ||
| 243 | /** |
||
| 244 | 12 | * If current node is element open tag |
|
| 245 | * |
||
| 246 | * @return bool |
||
| 247 | */ |
||
| 248 | private function isNodeElementType(): bool |
||
| 252 | 10 | ||
| 253 | /** |
||
| 254 | 10 | * If current node is element open tag |
|
| 255 | * |
||
| 256 | * @return bool |
||
| 257 | */ |
||
| 258 | private function isNodeEmptyElementType(): bool |
||
| 262 | 9 | ||
| 263 | /** |
||
| 264 | 9 | * If current node is element close tag |
|
| 265 | * |
||
| 266 | * @return bool |
||
| 267 | */ |
||
| 268 | private function isNodeElementEndType(): bool |
||
| 272 | 8 | ||
| 273 | /** |
||
| 274 | 8 | * If current node is text content |
|
| 275 | * |
||
| 276 | * @return bool |
||
| 277 | */ |
||
| 278 | private function isNodeTextType(): bool |
||
| 282 | |||
| 283 | /** |
||
| 284 | 12 | * If current node is given node type |
|
| 285 | * |
||
| 286 | 12 | * @param int $type |
|
| 287 | * |
||
| 288 | * @return bool |
||
| 289 | */ |
||
| 290 | private function isNodeType(int $type): bool |
||
| 294 | 10 | ||
| 295 | /** |
||
| 296 | 10 | * Get current node attributes |
|
| 297 | * |
||
| 298 | 10 | * @return array<string,string> |
|
| 299 | 6 | */ |
|
| 300 | 6 | private function getNodeAttributes(): array |
|
| 313 | |||
| 314 | /** |
||
| 315 | * Register custom error handler to throw Exception on warning message |
||
| 316 | * |
||
| 317 | 17 | * @param callable $callback |
|
| 318 | * |
||
| 319 | 17 | * @return mixed |
|
| 320 | 4 | * |
|
| 321 | 4 | * @throws \DOMException |
|
| 322 | */ |
||
| 323 | 17 | protected function withErrorHandler(callable $callback) |
|
| 337 | } |
||
| 338 |