Issues in DefaultMethod.php (master) - Issues in master - inspirum/balikobot-php - Measure and Improve Code Quality continuously with Scrutinizer

Issues (121)

src/Model/Method/DefaultMethod.php (1 issue)

Labels

Severity

Major 1

<?php

declare(strict_types=1);

namespace Inspirum\Balikobot\Model\Method;

use Inspirum\Arrayable\BaseModel;

/**
 * @extends \Inspirum\Arrayable\BaseModel<string,mixed>
 */
final class DefaultMethod extends BaseModel implements Method
{
    public function __construct(
        private readonly string $code,
    ) {
    }

    public function getCode(): string
    {
        return $this->code;
    }

    /** @inheritDoc */
    public function __toArray(): array
    {
        return [
interface HasName {
    /** @return string */
    public function getName();
}

class Name {
    public $name;
}

class User implements HasName {
    /** @return string|Name */
    public function getName() {
        return new Name('foo'); // This is a violation of the ``HasName`` interface
                                // which only allows a string value to be returned.
    }
}
            'code' => $this->code,
        ];
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Inspirum\Balikobot\Model\Method;
6
7		use Inspirum\Arrayable\BaseModel;
8
9		/**
10		* @extends \Inspirum\Arrayable\BaseModel<string,mixed>
11		*/
12		final class DefaultMethod extends BaseModel implements Method
13		{
14	7	public function __construct(
15		private readonly string $code,
16		) {
17	7	}
18
19	2	public function getCode(): string
20		{
21	2	return $this->code;
22		}
23
24		/** @inheritDoc */
25	2	public function __toArray(): array
26		{
27	2	return [
		0 ignored issues – show Bug Best Practice introduced 2022-08-07 19:31 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `return array('code' => $this->code)` returns the type `array<string,string>` which is incompatible with the return type mandated by `Inspirum\Arrayable\BaseModel::__toArray()` of `Inspirum\Arrayable\TValue[]`. In the issue above, the returned value is violating the contract defined by the mentioned interface. Let's take a look at an example: interface HasName { /** @return string / public function getName(); } class Name { public $name; } class User implements HasName { /* @return string\|Name */ public function getName() { return new Name('foo'); // This is a violation of the ``HasName`` interface // which only allows a string value to be returned. } } Loading history...
28	2	'code' => $this->code,
29	2	];
30		}
31		}
32

inspirum / balikobot-php

Issues (121)

src/Model/Method/DefaultMethod.php (1 issue)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like