Issues in DefaultManipulationUnit.php (master) - Issues in master - inspirum/balikobot-php - Measure and Improve Code Quality continuously with Scrutinizer

Issues (121)

Model/ManipulationUnit/DefaultManipulationUnit.php (1 issue)

Labels

Severity

Major 1

<?php

declare(strict_types=1);

namespace Inspirum\Balikobot\Model\ManipulationUnit;

use Inspirum\Arrayable\BaseModel;

/**
 * @extends \Inspirum\Arrayable\BaseModel<string,mixed>
 */
final class DefaultManipulationUnit extends BaseModel implements ManipulationUnit
{
    public function __construct(
        private readonly string $code,
        private readonly string $name,
    ) {
    }

    public function getCode(): string
    {
        return $this->code;
    }

    public function getName(): string
    {
        return $this->name;
    }

    /** @inheritDoc */
    public function __toArray(): array
    {
        return [
interface HasName {
    /** @return string */
    public function getName();
}

class Name {
    public $name;
}

class User implements HasName {
    /** @return string|Name */
    public function getName() {
        return new Name('foo'); // This is a violation of the ``HasName`` interface
                                // which only allows a string value to be returned.
    }
}
            'code' => $this->code,
            'name' => $this->name,
        ];
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Inspirum\Balikobot\Model\ManipulationUnit;
6
7		use Inspirum\Arrayable\BaseModel;
8
9		/**
10		* @extends \Inspirum\Arrayable\BaseModel<string,mixed>
11		*/
12		final class DefaultManipulationUnit extends BaseModel implements ManipulationUnit
13		{
14	5	public function __construct(
15		private readonly string $code,
16		private readonly string $name,
17		) {
18	5	}
19
20	1	public function getCode(): string
21		{
22	1	return $this->code;
23		}
24
25	1	public function getName(): string
26		{
27	1	return $this->name;
28		}
29
30		/** @inheritDoc */
31	2	public function __toArray(): array
32		{
33	2	return [
		0 ignored issues – show Bug Best Practice introduced 2022-08-07 19:31 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `return array('code' => $... 'name' => $this->name)` returns the type `array<string,string>` which is incompatible with the return type mandated by `Inspirum\Arrayable\BaseModel::__toArray()` of `Inspirum\Arrayable\TValue[]`. In the issue above, the returned value is violating the contract defined by the mentioned interface. Let's take a look at an example: interface HasName { /** @return string / public function getName(); } class Name { public $name; } class User implements HasName { /* @return string\|Name */ public function getName() { return new Name('foo'); // This is a violation of the ``HasName`` interface // which only allows a string value to be returned. } } Loading history...
34	2	'code' => $this->code,
35	2	'name' => $this->name,
36	2	];
37		}
38		}
39

inspirum / balikobot-php

Issues (121)

Model/ManipulationUnit/DefaultManipulationUnit.php (1 issue)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like