Wordlift_Batch_Analysis_Adapter - Code Metrics - Inspection of "bump to 3.14.2" - insideout10/wordlift-plugin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 69dad6...fb86a2 )

by David

created 2017-08-10 11:37 UTC

Wordlift_Batch_Analysis_Adapter A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	86
Duplicated Lines	52.33 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

Metric	Value
dl	45
loc	86
rs	10
c	0
b	0
f	0
wmc	10
lcom	1
cbo	1

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	submit_auto_selected_posts()	15	15	2
A	submit()	0	15	3
A	cancel()	15	15	2
A	clear_warning()	15	15	2

How to fix Duplicated Code

<?php
/**
 * Adapters: Batch Analysis Adapter.
 *
 * @since      3.14.2
 * @package    Wordlift
 * @subpackage Wordlift/includes
 */

/**
 * Define the {@link Wordlift_Batch_Analysis_Adapter} class.
 *
 * @since      3.14.2
 * @package    Wordlift
 * @subpackage Wordlift/includes
 */
class Wordlift_Batch_Analysis_Adapter {

	/**
	 * @var Wordlift_Batch_Analysis_Service
	 */
	private $batch_analysis_service;


	/**
	 * Wordlift_Batch_Analysis_Adapter constructor.
	 *
	 * @since 3.14.2
	 *
	 * @param \Wordlift_Batch_Analysis_Service $batch_analysis_service
	 */
	public function __construct( $batch_analysis_service ) {

		$this->batch_analysis_service = $batch_analysis_service;

	}

	public function submit_auto_selected_posts() {
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}

		if ( ! isset( $_REQUEST['link'] ) ) {
			wp_die( 'The `link` parameter is required.' );
		}

		$count = $this->batch_analysis_service->submit_auto_selected_posts( $_REQUEST['link'] );

		// Clear any buffer.
		ob_clean();

		// Send the response.
		wp_send_json_success( array( 'count' => $count ) );

	}

	public function submit() {
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}

		if ( ! isset( $_REQUEST['link'] ) || ! isset( $_REQUEST['post'] ) ) {
			wp_die( 'The `link` and `post` parameters are required.' );
		}

		$count = $this->batch_analysis_service->submit( (array) $_REQUEST['post'], $_REQUEST['link'] );

		// Clear any buffer.
		ob_clean();

		// Send the response.
		wp_send_json_success( array( 'count' => $count ) );

	}

	public function cancel() {
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}

		if ( ! isset( $_REQUEST['post'] ) ) {
			wp_die( 'The `post` parameter is required.' );
		}

		$count = $this->batch_analysis_service->cancel( (array) $_REQUEST['post'] );

		// Clear any buffer.
		ob_clean();

		// Send the response.
		wp_send_json_success( array( 'count' => $count ) );

	}

	public function clear_warning() {
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}

		if ( ! isset( $_REQUEST['post'] ) ) {
			wp_die( 'The `post` parameter is required.' );
		}

		$this->batch_analysis_service->clear_warning( (array) $_REQUEST['post'] );

		// Clear any buffer.
		ob_clean();

		// Send the response.
		wp_send_json_success();

	}

}


1		<?php
2		/**
3		* Adapters: Batch Analysis Adapter.
4		*
5		* @since 3.14.2
6		* @package Wordlift
7		* @subpackage Wordlift/includes
8		*/
9
10		/**
11		* Define the {@link Wordlift_Batch_Analysis_Adapter} class.
12		*
13		* @since 3.14.2
14		* @package Wordlift
15		* @subpackage Wordlift/includes
16		*/
17		class Wordlift_Batch_Analysis_Adapter {
18
19		/**
20		* @var Wordlift_Batch_Analysis_Service
21		*/
22		private $batch_analysis_service;
23
24
25		/**
26		* Wordlift_Batch_Analysis_Adapter constructor.
27		*
28		* @since 3.14.2
29		*
30		* @param \Wordlift_Batch_Analysis_Service $batch_analysis_service
31		*/
32		public function __construct( $batch_analysis_service ) {
33
34		$this->batch_analysis_service = $batch_analysis_service;
35
36		}
37
38	View Code Duplication	public function submit_auto_selected_posts() {
		0 ignored issues – show Duplication introduced 2017-08-10 11:42 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history... Coding Style introduced 2017-08-10 11:42 UTC by Report Bug Copy Issue Report `submit_auto_selected_posts` uses the super-global variable `$_REQUEST` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
39
40		if ( ! isset( $_REQUEST['link'] ) ) {
41		wp_die( 'The `link` parameter is required.' );
42		}
43
44		$count = $this->batch_analysis_service->submit_auto_selected_posts( $_REQUEST['link'] );
45
46		// Clear any buffer.
47		ob_clean();
48
49		// Send the response.
50		wp_send_json_success( array( 'count' => $count ) );
51
52		}
53
54		public function submit() {
		0 ignored issues – show Coding Style introduced 2017-08-10 11:42 UTC by Report Bug Copy Issue Report `submit` uses the super-global variable `$_REQUEST` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
55
56		if ( ! isset( $_REQUEST['link'] ) \|\| ! isset( $_REQUEST['post'] ) ) {
57		wp_die( 'The `link` and `post` parameters are required.' );
58		}
59
60		$count = $this->batch_analysis_service->submit( (array) $_REQUEST['post'], $_REQUEST['link'] );
61
62		// Clear any buffer.
63		ob_clean();
64
65		// Send the response.
66		wp_send_json_success( array( 'count' => $count ) );
67
68		}
69
70	View Code Duplication	public function cancel() {
		0 ignored issues – show Duplication introduced 2017-08-10 11:42 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history... Coding Style introduced 2017-08-10 11:42 UTC by Report Bug Copy Issue Report `cancel` uses the super-global variable `$_REQUEST` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
71
72		if ( ! isset( $_REQUEST['post'] ) ) {
73		wp_die( 'The `post` parameter is required.' );
74		}
75
76		$count = $this->batch_analysis_service->cancel( (array) $_REQUEST['post'] );
77
78		// Clear any buffer.
79		ob_clean();
80
81		// Send the response.
82		wp_send_json_success( array( 'count' => $count ) );
83
84		}
85
86	View Code Duplication	public function clear_warning() {
		0 ignored issues – show Duplication introduced 2017-08-10 11:42 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history... Coding Style introduced 2017-08-10 11:42 UTC by Report Bug Copy Issue Report `clear_warning` uses the super-global variable `$_REQUEST` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
87
88		if ( ! isset( $_REQUEST['post'] ) ) {
89		wp_die( 'The `post` parameter is required.' );
90		}
91
92		$this->batch_analysis_service->clear_warning( (array) $_REQUEST['post'] );
93
94		// Clear any buffer.
95		ob_clean();
96
97		// Send the response.
98		wp_send_json_success();
99
100		}
101
102		}
103

insideout10 / wordlift-plugin

Push — master ( 69dad6...fb86a2 )

Wordlift_Batch_Analysis_Adapter A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

5 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like