Wordlift_Jsonld_Service::get() - Code Metrics - Inspection of "update changelog" - insideout10/wordlift-plugin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 228e92...6a576a )

by David

created 2016-11-21 14:03 UTC

Wordlift_Jsonld_Service::get() B

↳ Parent: Wordlift_Jsonld_Service

Complexity

Conditions	3
Paths	4

Size

Total Lines	36
Code Lines	14

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	3
eloc	14
nc	4
nop	0
dl	0
loc	36
rs	8.8571
c	0
b	0
f	0

<?php
/**
 * Define the Wordlift_Jsonld_Service class to support JSON-LD.
 *
 * @since   3.8.0
 * @package Wordlift
 */

/**
 * This class exports an entity using JSON-LD.
 *
 * @since 3.8.0
 */
class Wordlift_Jsonld_Service {

	/**
	 * A {@link Wordlift_Entity_Service} instance.
	 *
	 * @since  3.8.0
	 * @access private
	 * @var Wordlift_Entity_Service $entity_service A {@link Wordlift_Entity_Service} instance.
	 */
	private $entity_service;

	/**
	 * A {@link Wordlift_Entity_To_Jsonld_Converter} instance.
	 *
	 * @since  3.8.0
	 * @access private
	 * @var \Wordlift_Entity_Post_To_Jsonld_Converter A {@link Wordlift_Entity_To_Jsonld_Converter} instance.
	 */
	private $entity_to_jsonld_converter;

	/**
	 * Create a JSON-LD service.
	 *
	 * @since 3.8.0
	 *
	 * @param \Wordlift_Entity_Service                  $entity_service             A {@link Wordlift_Entity_Service} instance.
	 * @param \Wordlift_Entity_Post_To_Jsonld_Converter $entity_to_jsonld_converter A {@link Wordlift_Entity_Post_To_Jsonld_Converter} instance.
	 */
	public function __construct( $entity_service, $entity_to_jsonld_converter ) {

		$this->entity_service             = $entity_service;
		$this->entity_to_jsonld_converter = $entity_to_jsonld_converter;

		add_action( 'wp_footer', array( $this, 'wp_footer' ), PHP_INT_MAX );
	}

	/**
	 * Hook to WP's wp_footer action and load the JSON-LD data.
	 *
	 * @since 3.8.0
	 */
	public function wp_footer() {

		// We only care about singular pages.
		if ( ! is_singular() ) {
			return;
		}

		// Get the entities related to the current post (and that are published).
		$post_id = get_the_ID();
		$posts   = $this->entity_service->is_entity( $post_id )
			? array( get_the_ID() )
			: array_unique( wl_core_get_related_entity_ids( $post_id, array(
				'status' => 'publish',
			) ) );

		// Build the URL to load the JSON-LD asynchronously.
		$url            = admin_url( 'admin-ajax.php?action=wl_jsonld' );
		$entity_service = $this->entity_service;
		$data           = implode( '&', array_map( function ( $item ) use ( $entity_service ) {
			return 'uri[]=' . rawurldecode( $entity_service->get_uri( $item ) );
		}, $posts ) );

		// Print the Javascript code.
		echo <<<EOF
<script type="text/javascript"><!--
(function($) { $( window ).on( 'load', function() { $.post('$url','$data').done(function(data) {
	$('head').append( '<script type="application/ld+json">'+JSON.stringify(data)+'</s' + 'cript>' );
}); }); })(jQuery);
// --></script>
EOF;
	}

	/**
	 * Process calls to the AJAX 'wl_jsonld' endpoint.
	 *
	 * @since 3.8.0
	 */
	public function get() {
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}

		// If no URI has been provided return an empty array.
		if ( ! isset( $_REQUEST['uri'] ) ) {
			wp_send_json( array() );
		}

		// Get an array of URIs to parse.
		$uris = is_array( $_REQUEST['uri'] ) ? $_REQUEST['uri'] : array( $_REQUEST['uri'] );

		// An array of references which is captured when converting an URI to a
		// json which we gather to further expand our json-ld.
		$references = array();

		// Set a reference to the entity_to_jsonld_converter to use in the closures.
		$entity_to_jsonld_converter = $this->entity_to_jsonld_converter;

		// Convert each URI to a JSON-LD array, while gathering referenced entities.
		// in the references array.
		$jsonld = array_merge(
			array_map( function ( $item ) use ( $entity_to_jsonld_converter, &$references ) {

				return $entity_to_jsonld_converter->convert( $item, $references );
			}, $uris ),
			// Convert each URI in the references array to JSON-LD. We don't output
			// entities already output above (hence the array_diff).
			array_map( function ( $item ) use ( $entity_to_jsonld_converter, &$references ) {

				return $entity_to_jsonld_converter->convert( $item, $references );
			}, array_diff( $references, $uris ) )
		);

		// Finally send the JSON-LD.
		wp_send_json( $jsonld );

	}

}


1			<?php
2			/**
3			* Define the Wordlift_Jsonld_Service class to support JSON-LD.
4			*
5			* @since 3.8.0
6			* @package Wordlift
7			*/
8
9			/**
10			* This class exports an entity using JSON-LD.
11			*
12			* @since 3.8.0
13			*/
14			class Wordlift_Jsonld_Service {
15
16			/**
17			* A {@link Wordlift_Entity_Service} instance.
18			*
19			* @since 3.8.0
20			* @access private
21			* @var Wordlift_Entity_Service $entity_service A {@link Wordlift_Entity_Service} instance.
22			*/
23			private $entity_service;
24
25			/**
26			* A {@link Wordlift_Entity_To_Jsonld_Converter} instance.
27			*
28			* @since 3.8.0
29			* @access private
30			* @var \Wordlift_Entity_Post_To_Jsonld_Converter A {@link Wordlift_Entity_To_Jsonld_Converter} instance.
31			*/
32			private $entity_to_jsonld_converter;
33
34			/**
35			* Create a JSON-LD service.
36			*
37			* @since 3.8.0
38			*
39			* @param \Wordlift_Entity_Service $entity_service A {@link Wordlift_Entity_Service} instance.
40			* @param \Wordlift_Entity_Post_To_Jsonld_Converter $entity_to_jsonld_converter A {@link Wordlift_Entity_Post_To_Jsonld_Converter} instance.
41			*/
42			public function __construct( $entity_service, $entity_to_jsonld_converter ) {
43
44			$this->entity_service = $entity_service;
45			$this->entity_to_jsonld_converter = $entity_to_jsonld_converter;
46
47			add_action( 'wp_footer', array( $this, 'wp_footer' ), PHP_INT_MAX );
48			}
49
50			/**
51			* Hook to WP's wp_footer action and load the JSON-LD data.
52			*
53			* @since 3.8.0
54			*/
55			public function wp_footer() {
56
57			// We only care about singular pages.
58			if ( ! is_singular() ) {
59			return;
60			}
61
62			// Get the entities related to the current post (and that are published).
63			$post_id = get_the_ID();
64			$posts = $this->entity_service->is_entity( $post_id )
65			? array( get_the_ID() )
66			: array_unique( wl_core_get_related_entity_ids( $post_id, array(
67			'status' => 'publish',
68			) ) );
69
70			// Build the URL to load the JSON-LD asynchronously.
71			$url = admin_url( 'admin-ajax.php?action=wl_jsonld' );
72			$entity_service = $this->entity_service;
73			$data = implode( '&', array_map( function ( $item ) use ( $entity_service ) {
74			return 'uri[]=' . rawurldecode( $entity_service->get_uri( $item ) );
75			}, $posts ) );
76
77			// Print the Javascript code.
78			echo <<<EOF
79			<script type="text/javascript"><!--
80			(function($) { $( window ).on( 'load', function() { $.post('$url','$data').done(function(data) {
81			$('head').append( '<script type="application/ld+json">'+JSON.stringify(data)+'</s' + 'cript>' );
82			}); }); })(jQuery);
83			// --></script>
84			EOF;
85			}
86
87			/**
88			* Process calls to the AJAX 'wl_jsonld' endpoint.
89			*
90			* @since 3.8.0
91			*/
92			public function get() {
			0 ignored issues – show Coding Style introduced 2016-11-03 16:39 UTC by Report Bug Copy Issue Report `get` uses the super-global variable `$_REQUEST` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
93
94			// If no URI has been provided return an empty array.
95			if ( ! isset( $_REQUEST['uri'] ) ) {
96			wp_send_json( array() );
97			}
98
99			// Get an array of URIs to parse.
100			$uris = is_array( $_REQUEST['uri'] ) ? $_REQUEST['uri'] : array( $_REQUEST['uri'] );
101
102			// An array of references which is captured when converting an URI to a
103			// json which we gather to further expand our json-ld.
104			$references = array();
105
106			// Set a reference to the entity_to_jsonld_converter to use in the closures.
107			$entity_to_jsonld_converter = $this->entity_to_jsonld_converter;
108
109			// Convert each URI to a JSON-LD array, while gathering referenced entities.
110			// in the references array.
111			$jsonld = array_merge(
112			array_map( function ( $item ) use ( $entity_to_jsonld_converter, &$references ) {
113
114			return $entity_to_jsonld_converter->convert( $item, $references );
115			}, $uris ),
116			// Convert each URI in the references array to JSON-LD. We don't output
117			// entities already output above (hence the array_diff).
118			array_map( function ( $item ) use ( $entity_to_jsonld_converter, &$references ) {
119
120			return $entity_to_jsonld_converter->convert( $item, $references );
121			}, array_diff( $references, $uris ) )
122			);
123
124			// Finally send the JSON-LD.
125			wp_send_json( $jsonld );
126
127			}
128
129			}
130

insideout10 / wordlift-plugin

Push — master ( 228e92...6a576a )

Wordlift_Jsonld_Service::get() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like