Wordlift_Metabox_Field_Integer::html_input() - Code Metrics - Inspection of "See #759: Make select metabox options translatable..." - insideout10/wordlift-plugin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( 4910e3...56d9e6 )

unknown

created 2018-03-01 15:22 UTC

Wordlift_Metabox_Field_Integer::html_input() B

↳ Parent: Wordlift_Metabox_Field_Integer

Complexity

Conditions	1
Paths	1

Size

Total Lines	26
Code Lines	13

Duplication

Lines	26
Ratio	100 %

Importance

Changes

Metric	Value
cc	1
eloc	13
nc	1
nop	1
dl	26
loc	26
rs	8.8571
c	0
b	0
f	0

<?php
/**
 * Metaxboxes: Integer Field.
 *
 * This file defines the Wordlift_Metabox_Field_Integer class which displays number field
 * in WordPress' entity posts pages.
 *
 * @since   3.18.0
 * @package Wordlift
 */

/**
 * The Wordlift_Metabox_Field_Integer class extends {@link WL_Metabox_Field} and provides
 * support for integer fields.
 *
 * @since   3.18.0
 * @package Wordlift
 */
class Wordlift_Metabox_Field_Integer extends WL_Metabox_Field {

	/**
	 * @inheritdoc
	 */
	public function html_input( $text ) {
		@ob_start();
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
		?>
			<div class="wl-input-wrapper">
				<input
					type="number"
					id="<?php echo esc_attr( $this->meta_name ); ?>"
					class="<?php echo esc_attr( $this->meta_name ); ?>"
					value="<?php echo esc_attr( $text ) ?>"
					name="wl_metaboxes[<?php echo $this->meta_name; ?>][]"
					style="width:88%"
					min="0"
				/>

				<button class="button wl-remove-input wl-button" type="button">
					<?php esc_html_e( 'Remove', 'wordlift' ); ?>
				</button>

				<div class="wl-input-notice"></div>
			</div>

		<?php
		$html = ob_get_clean();

		return $html;
	}
}


1		<?php
2		/**
3		* Metaxboxes: Integer Field.
4		*
5		* This file defines the Wordlift_Metabox_Field_Integer class which displays number field
6		* in WordPress' entity posts pages.
7		*
8		* @since 3.18.0
9		* @package Wordlift
10		*/
11
12		/**
13		* The Wordlift_Metabox_Field_Integer class extends {@link WL_Metabox_Field} and provides
14		* support for integer fields.
15		*
16		* @since 3.18.0
17		* @package Wordlift
18		*/
19	View Code Duplication	class Wordlift_Metabox_Field_Integer extends WL_Metabox_Field {
		0 ignored issues – show Duplication introduced 2018-03-01 15:26 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
20		/**
21		* @inheritdoc
22		*/
23		public function html_input( $text ) {
24		@ob_start();
		0 ignored issues – show Security Best Practice introduced 2018-03-01 15:26 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
25		?>
26		<div class="wl-input-wrapper">
27		<input
28		type="number"
29		id="<?php echo esc_attr( $this->meta_name ); ?>"
30		class="<?php echo esc_attr( $this->meta_name ); ?>"
31		value="<?php echo esc_attr( $text ) ?>"
32		name="wl_metaboxes[<?php echo $this->meta_name; ?>][]"
33		style="width:88%"
34		min="0"
35		/>
36
37		<button class="button wl-remove-input wl-button" type="button">
38		<?php esc_html_e( 'Remove', 'wordlift' ); ?>
39		</button>
40
41		<div class="wl-input-notice"></div>
42		</div>
43
44		<?php
45		$html = ob_get_clean();
46
47		return $html;
48		}
49		}
50

insideout10 / wordlift-plugin

Push — develop ( 4910e3...56d9e6 )

Wordlift_Metabox_Field_Integer::html_input() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like