insideout10 /
wordlift-plugin
| Conditions | 4 |
| Paths | 4 |
| Total Lines | 56 |
| Code Lines | 22 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 100 | public function enqueue_scripts() { |
||
| 101 | |||
| 102 | /** |
||
| 103 | * This function is provided for demonstration purposes only. |
||
| 104 | * |
||
| 105 | * An instance of this class should be passed to the run() function |
||
| 106 | * defined in Wordlift_Loader as all of the hooks are defined |
||
| 107 | * in that particular class. |
||
| 108 | * |
||
| 109 | * The Wordlift_Loader will then create the relationship |
||
| 110 | * between the defined hooks and the functions defined in this |
||
| 111 | * class. |
||
| 112 | */ |
||
| 113 | |||
| 114 | $configuration_service = Wordlift_Configuration_Service::get_instance(); |
||
| 115 | |||
| 116 | // Enqueue the admin scripts. |
||
| 117 | wp_enqueue_script( $this->plugin_name, plugin_dir_url( __FILE__ ) . 'js/wordlift-admin.bundle.js', array( |
||
| 118 | 'jquery', |
||
| 119 | 'underscore', |
||
| 120 | 'backbone', |
||
| 121 | ), $this->version, false ); |
||
| 122 | |||
| 123 | // Set the basic params. |
||
| 124 | $params = array( |
||
| 125 | // @todo scripts in admin should use wp.post. |
||
| 126 | 'ajax_url' => admin_url( 'admin-ajax.php' ), |
||
| 127 | // @todo remove specific actions from settings. |
||
| 128 | 'action' => 'entity_by_title', |
||
| 129 | 'datasetUri' => $configuration_service->get_dataset_uri(), |
||
| 130 | 'language' => $configuration_service->get_language_code(), |
||
| 131 | 'link_by_default' => $configuration_service->is_link_by_default(), |
||
| 132 | 'l10n' => array( |
||
| 133 | 'You already published an entity with the same name' => __( 'You already published an entity with the same name: ', 'wordlift' ), |
||
| 134 | 'logo_selection_title' => __( 'WordLift Choose Logo', 'wordlift' ), |
||
| 135 | 'logo_selection_button' => array( 'text' => __( 'Choose Logo', 'wordlift' ) ), |
||
| 136 | ), |
||
| 137 | ); |
||
| 138 | |||
| 139 | // Set post-related values if there's a current post. |
||
| 140 | if ( null !== $post = $entity_being_edited = get_post() ) { |
||
| 141 | |||
| 142 | $params['post_id'] = $entity_being_edited->ID; |
||
| 143 | $params['entityBeingEdited'] = isset( $entity_being_edited->post_type ) && Wordlift_Entity_Service::TYPE_NAME == $entity_being_edited->post_type && is_numeric( get_the_ID() ); |
||
| 144 | // We add the `itemId` here to give a chance to the analysis to use it in order to tell WLS to exclude it |
||
| 145 | // from the results, since we don't want the current entity to be discovered by the analysis. |
||
| 146 | // |
||
| 147 | // See https://github.com/insideout10/wordlift-plugin/issues/345 |
||
| 148 | $params['itemId'] = Wordlift_Entity_Service::get_instance()->get_uri( $entity_being_edited->ID ); |
||
| 149 | |||
| 150 | } |
||
| 151 | |||
| 152 | // Finally output the params as `wlSettings` for JavaScript code. |
||
| 153 | wp_localize_script( $this->plugin_name, 'wlSettings', $params ); |
||
| 154 | |||
| 155 | } |
||
| 156 | |||
| 158 |
