insideout10 / wordlift-plugin

src/ext/action-scheduler/tests/phpunit/schedules/ActionScheduler_IntervalSchedule_Test.php

Indentation +26 added lines, -26 removed lines

@@ -6,33 +6,33 @@
  * @group schedules
  */
 class ActionScheduler_IntervalSchedule_Test extends ActionScheduler_UnitTestCase {
-	public function test_creation() {
-		$time     = as_get_datetime_object();
-		$schedule = new ActionScheduler_IntervalSchedule( $time, HOUR_IN_SECONDS );
-		$this->assertEquals( $time, $schedule->get_date() );
-		$this->assertEquals( $time, $schedule->get_first_date() );
-	}
+    public function test_creation() {
+        $time     = as_get_datetime_object();
+        $schedule = new ActionScheduler_IntervalSchedule( $time, HOUR_IN_SECONDS );
+        $this->assertEquals( $time, $schedule->get_date() );
+        $this->assertEquals( $time, $schedule->get_first_date() );
+    }
 
-	public function test_creation_with_first_date() {
-		$first    = as_get_datetime_object();
-		$time     = as_get_datetime_object( '+12 hours' );
-		$schedule = new ActionScheduler_IntervalSchedule( $time, HOUR_IN_SECONDS, $first );
-		$this->assertEquals( $time, $schedule->get_date() );
-		$this->assertEquals( $first, $schedule->get_first_date() );
-	}
+    public function test_creation_with_first_date() {
+        $first    = as_get_datetime_object();
+        $time     = as_get_datetime_object( '+12 hours' );
+        $schedule = new ActionScheduler_IntervalSchedule( $time, HOUR_IN_SECONDS, $first );
+        $this->assertEquals( $time, $schedule->get_date() );
+        $this->assertEquals( $first, $schedule->get_first_date() );
+    }
 
-	public function test_next() {
-		$now      = time();
-		$start    = $now - 30;
-		$schedule = new ActionScheduler_IntervalSchedule( as_get_datetime_object( "@$start" ), MINUTE_IN_SECONDS );
-		$this->assertEquals( $start, $schedule->get_date()->getTimestamp() );
-		$this->assertEquals( $now + MINUTE_IN_SECONDS, $schedule->get_next( as_get_datetime_object() )->getTimestamp() );
-		$this->assertEquals( $start, $schedule->get_next( as_get_datetime_object( "@$start" ) )->getTimestamp() );
-	}
+    public function test_next() {
+        $now      = time();
+        $start    = $now - 30;
+        $schedule = new ActionScheduler_IntervalSchedule( as_get_datetime_object( "@$start" ), MINUTE_IN_SECONDS );
+        $this->assertEquals( $start, $schedule->get_date()->getTimestamp() );
+        $this->assertEquals( $now + MINUTE_IN_SECONDS, $schedule->get_next( as_get_datetime_object() )->getTimestamp() );
+        $this->assertEquals( $start, $schedule->get_next( as_get_datetime_object( "@$start" ) )->getTimestamp() );
+    }
 
-	public function test_is_recurring() {
-		$start    = time() - 30;
-		$schedule = new ActionScheduler_IntervalSchedule( as_get_datetime_object( "@$start" ), MINUTE_IN_SECONDS );
-		$this->assertTrue( $schedule->is_recurring() );
-	}
+    public function test_is_recurring() {
+        $start    = time() - 30;
+        $schedule = new ActionScheduler_IntervalSchedule( as_get_datetime_object( "@$start" ), MINUTE_IN_SECONDS );
+        $this->assertTrue( $schedule->is_recurring() );
+    }
 }

Spacing +13 added lines, -13 removed lines

@@ -8,31 +8,31 @@
 class ActionScheduler_IntervalSchedule_Test extends ActionScheduler_UnitTestCase {
 	public function test_creation() {
 		$time     = as_get_datetime_object();
-		$schedule = new ActionScheduler_IntervalSchedule( $time, HOUR_IN_SECONDS );
-		$this->assertEquals( $time, $schedule->get_date() );
-		$this->assertEquals( $time, $schedule->get_first_date() );
+		$schedule = new ActionScheduler_IntervalSchedule($time, HOUR_IN_SECONDS);
+		$this->assertEquals($time, $schedule->get_date());
+		$this->assertEquals($time, $schedule->get_first_date());
 	}
 
 	public function test_creation_with_first_date() {
 		$first    = as_get_datetime_object();
-		$time     = as_get_datetime_object( '+12 hours' );
-		$schedule = new ActionScheduler_IntervalSchedule( $time, HOUR_IN_SECONDS, $first );
-		$this->assertEquals( $time, $schedule->get_date() );
-		$this->assertEquals( $first, $schedule->get_first_date() );
+		$time     = as_get_datetime_object('+12 hours');
+		$schedule = new ActionScheduler_IntervalSchedule($time, HOUR_IN_SECONDS, $first);
+		$this->assertEquals($time, $schedule->get_date());
+		$this->assertEquals($first, $schedule->get_first_date());
 	}
 
 	public function test_next() {
 		$now      = time();
 		$start    = $now - 30;
-		$schedule = new ActionScheduler_IntervalSchedule( as_get_datetime_object( "@$start" ), MINUTE_IN_SECONDS );
-		$this->assertEquals( $start, $schedule->get_date()->getTimestamp() );
-		$this->assertEquals( $now + MINUTE_IN_SECONDS, $schedule->get_next( as_get_datetime_object() )->getTimestamp() );
-		$this->assertEquals( $start, $schedule->get_next( as_get_datetime_object( "@$start" ) )->getTimestamp() );
+		$schedule = new ActionScheduler_IntervalSchedule(as_get_datetime_object("@$start"), MINUTE_IN_SECONDS);
+		$this->assertEquals($start, $schedule->get_date()->getTimestamp());
+		$this->assertEquals($now + MINUTE_IN_SECONDS, $schedule->get_next(as_get_datetime_object())->getTimestamp());
+		$this->assertEquals($start, $schedule->get_next(as_get_datetime_object("@$start"))->getTimestamp());
 	}
 
 	public function test_is_recurring() {
 		$start    = time() - 30;
-		$schedule = new ActionScheduler_IntervalSchedule( as_get_datetime_object( "@$start" ), MINUTE_IN_SECONDS );
-		$this->assertTrue( $schedule->is_recurring() );
+		$schedule = new ActionScheduler_IntervalSchedule(as_get_datetime_object("@$start"), MINUTE_IN_SECONDS);
+		$this->assertTrue($schedule->is_recurring());
 	}
 }

src/ext/action-scheduler/tests/phpunit/schedules/ActionScheduler_NullSchedule_Test.php

Indentation +8 added lines, -8 removed lines

@@ -6,14 +6,14 @@
  * @group schedules
  */
 class ActionScheduler_NullSchedule_Test extends ActionScheduler_UnitTestCase {
-	public function test_null_schedule() {
-		$schedule = new ActionScheduler_NullSchedule();
-		$this->assertNull( $schedule->get_date() );
-	}
+    public function test_null_schedule() {
+        $schedule = new ActionScheduler_NullSchedule();
+        $this->assertNull( $schedule->get_date() );
+    }
 
-	public function test_is_recurring() {
-		$schedule = new ActionScheduler_NullSchedule();
-		$this->assertFalse( $schedule->is_recurring() );
-	}
+    public function test_is_recurring() {
+        $schedule = new ActionScheduler_NullSchedule();
+        $this->assertFalse( $schedule->is_recurring() );
+    }
 }
 

Spacing +2 added lines, -2 removed lines

@@ -8,12 +8,12 @@
 class ActionScheduler_NullSchedule_Test extends ActionScheduler_UnitTestCase {
 	public function test_null_schedule() {
 		$schedule = new ActionScheduler_NullSchedule();
-		$this->assertNull( $schedule->get_date() );
+		$this->assertNull($schedule->get_date());
 	}
 
 	public function test_is_recurring() {
 		$schedule = new ActionScheduler_NullSchedule();
-		$this->assertFalse( $schedule->is_recurring() );
+		$this->assertFalse($schedule->is_recurring());
 	}
 }
 

src/ext/action-scheduler/tests/phpunit/helpers/ActionScheduler_Compatibility_Test.php

Indentation +35 added lines, -35 removed lines

@@ -3,44 +3,44 @@
  * @group helpers
  */
 class ActionScheduler_Compatibility_Test extends ActionScheduler_UnitTestCase {
-	/**
-	 * Test the logic relating to ActionScheduler_Compatibility::raise_time_limit().
-	 */
-	public function test_raise_time_limit() {
-		// We'll want to restore things after this test.
-		$default_max_execution_time = ini_get( 'max_execution_time' );
+    /**
+     * Test the logic relating to ActionScheduler_Compatibility::raise_time_limit().
+     */
+    public function test_raise_time_limit() {
+        // We'll want to restore things after this test.
+        $default_max_execution_time = ini_get( 'max_execution_time' );
 
-		ini_set( 'max_execution_time', 0 );
-		ActionScheduler_Compatibility::raise_time_limit( 10 );
-		$this->assertSame(
-			'0',
-			ini_get( 'max_execution_time' ),
-			'If the max_execution_time was already zero (unlimited), then it will not be changed.'
-		);
+        ini_set( 'max_execution_time', 0 );
+        ActionScheduler_Compatibility::raise_time_limit( 10 );
+        $this->assertSame(
+            '0',
+            ini_get( 'max_execution_time' ),
+            'If the max_execution_time was already zero (unlimited), then it will not be changed.'
+        );
 
-		ini_set( 'max_execution_time', 60 );
-		ActionScheduler_Compatibility::raise_time_limit( 30 );
-		$this->assertSame(
-			'60',
-			ini_get( 'max_execution_time' ),
-			'If the max_execution_time was already a higher value than we specify, then it will not be changed.'
-		);
+        ini_set( 'max_execution_time', 60 );
+        ActionScheduler_Compatibility::raise_time_limit( 30 );
+        $this->assertSame(
+            '60',
+            ini_get( 'max_execution_time' ),
+            'If the max_execution_time was already a higher value than we specify, then it will not be changed.'
+        );
 
-		ActionScheduler_Compatibility::raise_time_limit( 200 );
-		$this->assertSame(
-			'200',
-			ini_get( 'max_execution_time' ),
-			'If the max_execution_time was a lower value than we specify, but was above zero, then it will be updated to the new value.'
-		);
+        ActionScheduler_Compatibility::raise_time_limit( 200 );
+        $this->assertSame(
+            '200',
+            ini_get( 'max_execution_time' ),
+            'If the max_execution_time was a lower value than we specify, but was above zero, then it will be updated to the new value.'
+        );
 
-		ActionScheduler_Compatibility::raise_time_limit( 0 );
-		$this->assertSame(
-			'0',
-			ini_get( 'max_execution_time' ),
-			'If the max_execution_time was a positive, non-zero value and we then specify zero (unlimited) as the new value, then it will be updated.'
-		);
+        ActionScheduler_Compatibility::raise_time_limit( 0 );
+        $this->assertSame(
+            '0',
+            ini_get( 'max_execution_time' ),
+            'If the max_execution_time was a positive, non-zero value and we then specify zero (unlimited) as the new value, then it will be updated.'
+        );
 
-		// Cleanup.
-		ini_set( 'max_execution_time', $default_max_execution_time );
-	}
+        // Cleanup.
+        ini_set( 'max_execution_time', $default_max_execution_time );
+    }
 }

Spacing +12 added lines, -12 removed lines

@@ -8,39 +8,39 @@
 	 */
 	public function test_raise_time_limit() {
 		// We'll want to restore things after this test.
-		$default_max_execution_time = ini_get( 'max_execution_time' );
+		$default_max_execution_time = ini_get('max_execution_time');
 
-		ini_set( 'max_execution_time', 0 );
-		ActionScheduler_Compatibility::raise_time_limit( 10 );
+		ini_set('max_execution_time', 0);
+		ActionScheduler_Compatibility::raise_time_limit(10);
 		$this->assertSame(
 			'0',
-			ini_get( 'max_execution_time' ),
+			ini_get('max_execution_time'),
 			'If the max_execution_time was already zero (unlimited), then it will not be changed.'
 		);
 
-		ini_set( 'max_execution_time', 60 );
-		ActionScheduler_Compatibility::raise_time_limit( 30 );
+		ini_set('max_execution_time', 60);
+		ActionScheduler_Compatibility::raise_time_limit(30);
 		$this->assertSame(
 			'60',
-			ini_get( 'max_execution_time' ),
+			ini_get('max_execution_time'),
 			'If the max_execution_time was already a higher value than we specify, then it will not be changed.'
 		);
 
-		ActionScheduler_Compatibility::raise_time_limit( 200 );
+		ActionScheduler_Compatibility::raise_time_limit(200);
 		$this->assertSame(
 			'200',
-			ini_get( 'max_execution_time' ),
+			ini_get('max_execution_time'),
 			'If the max_execution_time was a lower value than we specify, but was above zero, then it will be updated to the new value.'
 		);
 
-		ActionScheduler_Compatibility::raise_time_limit( 0 );
+		ActionScheduler_Compatibility::raise_time_limit(0);
 		$this->assertSame(
 			'0',
-			ini_get( 'max_execution_time' ),
+			ini_get('max_execution_time'),
 			'If the max_execution_time was a positive, non-zero value and we then specify zero (unlimited) as the new value, then it will be updated.'
 		);
 
 		// Cleanup.
-		ini_set( 'max_execution_time', $default_max_execution_time );
+		ini_set('max_execution_time', $default_max_execution_time);
 	}
 }

src/ext/action-scheduler/tests/phpunit/helpers/ActionScheduler_Callbacks.php

Indentation +24 added lines, -24 removed lines

@@ -1,31 +1,31 @@
 <?php
 
 class ActionScheduler_Callbacks {
-	/**
-	 * Scheduled action hook that can be used when we want to simulate an action
-	 * with a registered callback.
-	 */
-	const HOOK_WITH_CALLBACK = 'hook_with_callback';
+    /**
+     * Scheduled action hook that can be used when we want to simulate an action
+     * with a registered callback.
+     */
+    const HOOK_WITH_CALLBACK = 'hook_with_callback';
 
-	/**
-	 * Setup callbacks for different types of hook.
-	 */
-	public static function add_callbacks() {
-		add_action( self::HOOK_WITH_CALLBACK, array( __CLASS__, 'empty_callback' ) );
-	}
+    /**
+     * Setup callbacks for different types of hook.
+     */
+    public static function add_callbacks() {
+        add_action( self::HOOK_WITH_CALLBACK, array( __CLASS__, 'empty_callback' ) );
+    }
 
-	/**
-	 * Remove callbacks.
-	 */
-	public static function remove_callbacks() {
-		remove_action( self::HOOK_WITH_CALLBACK, array( __CLASS__, 'empty_callback' ) );
-	}
+    /**
+     * Remove callbacks.
+     */
+    public static function remove_callbacks() {
+        remove_action( self::HOOK_WITH_CALLBACK, array( __CLASS__, 'empty_callback' ) );
+    }
 
-	/**
-	 * This stub is used as the callback function for the ActionScheduler_Callbacks::HOOK_WITH_CALLBACK hook.
-	 *
-	 * Action Scheduler will mark actions as 'failed' if a callback does not exist, this
-	 * simply serves to act as the callback for various test scenarios in child classes.
-	 */
-	public static function empty_callback() {}
+    /**
+     * This stub is used as the callback function for the ActionScheduler_Callbacks::HOOK_WITH_CALLBACK hook.
+     *
+     * Action Scheduler will mark actions as 'failed' if a callback does not exist, this
+     * simply serves to act as the callback for various test scenarios in child classes.
+     */
+    public static function empty_callback() {}
 }

Spacing +2 added lines, -2 removed lines

@@ -11,14 +11,14 @@
 	 * Setup callbacks for different types of hook.
 	 */
 	public static function add_callbacks() {
-		add_action( self::HOOK_WITH_CALLBACK, array( __CLASS__, 'empty_callback' ) );
+		add_action(self::HOOK_WITH_CALLBACK, array(__CLASS__, 'empty_callback'));
 	}
 
 	/**
 	 * Remove callbacks.
 	 */
 	public static function remove_callbacks() {
-		remove_action( self::HOOK_WITH_CALLBACK, array( __CLASS__, 'empty_callback' ) );
+		remove_action(self::HOOK_WITH_CALLBACK, array(__CLASS__, 'empty_callback'));
 	}
 
 	/**

src/ext/action-scheduler/tests/phpunit/deprecated/ActionScheduler_UnitTestCase.php

Indentation +52 added lines, -52 removed lines

@@ -5,56 +5,56 @@
  */
 class ActionScheduler_UnitTestCase extends WP_UnitTestCase {
 
-	protected $existing_timezone;
-
-	/**
-	 * Perform test set-up work.
-	 */
-	public function set_up() {
-		ActionScheduler_Callbacks::add_callbacks();
-		parent::set_up();
-	}
-
-	/**
-	 * Perform test tear-down work.
-	 */
-	public function tear_down() {
-		ActionScheduler_Callbacks::remove_callbacks();
-		parent::tear_down();
-	}
-
-	/**
-	 * Counts the number of test cases executed by run(TestResult result).
-	 *
-	 * @return int
-	 */
-	public function count() {
-		return 'UTC' == date_default_timezone_get() ? 2 : 3;
-	}
-
-	/**
-	 * We want to run every test multiple times using a different timezone to make sure
-	 * that they are unaffected by changes to PHP's timezone.
-	 */
-	public function run( PHPUnit_Framework_TestResult $result = null ) {
-
-		if ( $result === null ) {
-			$result = $this->createResult();
-		}
-
-		if ( 'UTC' != ( $this->existing_timezone = date_default_timezone_get() ) ) {
-			date_default_timezone_set( 'UTC' );
-			$result->run( $this );
-		}
-
-		date_default_timezone_set( 'Pacific/Fiji' ); // UTC+12
-		$result->run( $this );
-
-		date_default_timezone_set( 'Pacific/Tahiti' ); // UTC-10: it's a magical place
-		$result->run( $this );
-
-		date_default_timezone_set( $this->existing_timezone );
-
-		return $result;
-	}
+    protected $existing_timezone;
+
+    /**
+     * Perform test set-up work.
+     */
+    public function set_up() {
+        ActionScheduler_Callbacks::add_callbacks();
+        parent::set_up();
+    }
+
+    /**
+     * Perform test tear-down work.
+     */
+    public function tear_down() {
+        ActionScheduler_Callbacks::remove_callbacks();
+        parent::tear_down();
+    }
+
+    /**
+     * Counts the number of test cases executed by run(TestResult result).
+     *
+     * @return int
+     */
+    public function count() {
+        return 'UTC' == date_default_timezone_get() ? 2 : 3;
+    }
+
+    /**
+     * We want to run every test multiple times using a different timezone to make sure
+     * that they are unaffected by changes to PHP's timezone.
+     */
+    public function run( PHPUnit_Framework_TestResult $result = null ) {
+
+        if ( $result === null ) {
+            $result = $this->createResult();
+        }
+
+        if ( 'UTC' != ( $this->existing_timezone = date_default_timezone_get() ) ) {
+            date_default_timezone_set( 'UTC' );
+            $result->run( $this );
+        }
+
+        date_default_timezone_set( 'Pacific/Fiji' ); // UTC+12
+        $result->run( $this );
+
+        date_default_timezone_set( 'Pacific/Tahiti' ); // UTC-10: it's a magical place
+        $result->run( $this );
+
+        date_default_timezone_set( $this->existing_timezone );
+
+        return $result;
+    }
 }

Spacing +10 added lines, -10 removed lines

@@ -36,24 +36,24 @@
 	 * We want to run every test multiple times using a different timezone to make sure
 	 * that they are unaffected by changes to PHP's timezone.
 	 */
-	public function run( PHPUnit_Framework_TestResult $result = null ) {
+	public function run(PHPUnit_Framework_TestResult $result = null) {
 
-		if ( $result === null ) {
+		if ($result === null) {
 			$result = $this->createResult();
 		}
 
-		if ( 'UTC' != ( $this->existing_timezone = date_default_timezone_get() ) ) {
-			date_default_timezone_set( 'UTC' );
-			$result->run( $this );
+		if ('UTC' != ($this->existing_timezone = date_default_timezone_get())) {
+			date_default_timezone_set('UTC');
+			$result->run($this);
 		}
 
-		date_default_timezone_set( 'Pacific/Fiji' ); // UTC+12
-		$result->run( $this );
+		date_default_timezone_set('Pacific/Fiji'); // UTC+12
+		$result->run($this);
 
-		date_default_timezone_set( 'Pacific/Tahiti' ); // UTC-10: it's a magical place
-		$result->run( $this );
+		date_default_timezone_set('Pacific/Tahiti'); // UTC-10: it's a magical place
+		$result->run($this);
 
-		date_default_timezone_set( $this->existing_timezone );
+		date_default_timezone_set($this->existing_timezone);
 
 		return $result;
 	}

src/ext/action-scheduler/tests/phpunit/jobs/ActionScheduler_Action_Test.php

Indentation +46 added lines, -46 removed lines

@@ -6,50 +6,50 @@
  * @group actions
  */
 class ActionScheduler_Action_Test extends ActionScheduler_UnitTestCase {
-	public function test_set_schedule() {
-		$time     = as_get_datetime_object();
-		$schedule = new ActionScheduler_SimpleSchedule( $time );
-		$action   = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule );
-		$this->assertEquals( $schedule, $action->get_schedule() );
-	}
-
-	public function test_null_schedule() {
-		$action = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK );
-		$this->assertInstanceOf( 'ActionScheduler_NullSchedule', $action->get_schedule() );
-	}
-
-	public function test_set_hook() {
-		$action = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK );
-		$this->assertEquals( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, $action->get_hook() );
-	}
-
-	public function test_args() {
-		$action = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK );
-		$this->assertEmpty( $action->get_args() );
-
-		$action = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( 5, 10, 15 ) );
-		$this->assertEqualSets( array( 5, 10, 15 ), $action->get_args() );
-	}
-
-	public function test_set_group() {
-		$action = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), null, 'my_group' );
-		$this->assertEquals( 'my_group', $action->get_group() );
-	}
-
-	public function test_execute() {
-		$mock = new MockAction();
-
-		$random = md5( rand() );
-		add_action( $random, array( $mock, 'action' ) );
-
-		$action = new ActionScheduler_Action( $random, array( $random ) );
-		$action->execute();
-
-		remove_action( $random, array( $mock, 'action' ) );
-
-		$this->assertSame( 1, $mock->get_call_count() );
-		$events = $mock->get_events();
-		$event  = reset( $events );
-		$this->assertEquals( $random, reset( $event['args'] ) );
-	}
+    public function test_set_schedule() {
+        $time     = as_get_datetime_object();
+        $schedule = new ActionScheduler_SimpleSchedule( $time );
+        $action   = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule );
+        $this->assertEquals( $schedule, $action->get_schedule() );
+    }
+
+    public function test_null_schedule() {
+        $action = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK );
+        $this->assertInstanceOf( 'ActionScheduler_NullSchedule', $action->get_schedule() );
+    }
+
+    public function test_set_hook() {
+        $action = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK );
+        $this->assertEquals( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, $action->get_hook() );
+    }
+
+    public function test_args() {
+        $action = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK );
+        $this->assertEmpty( $action->get_args() );
+
+        $action = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( 5, 10, 15 ) );
+        $this->assertEqualSets( array( 5, 10, 15 ), $action->get_args() );
+    }
+
+    public function test_set_group() {
+        $action = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), null, 'my_group' );
+        $this->assertEquals( 'my_group', $action->get_group() );
+    }
+
+    public function test_execute() {
+        $mock = new MockAction();
+
+        $random = md5( rand() );
+        add_action( $random, array( $mock, 'action' ) );
+
+        $action = new ActionScheduler_Action( $random, array( $random ) );
+        $action->execute();
+
+        remove_action( $random, array( $mock, 'action' ) );
+
+        $this->assertSame( 1, $mock->get_call_count() );
+        $events = $mock->get_events();
+        $event  = reset( $events );
+        $this->assertEquals( $random, reset( $event['args'] ) );
+    }
 }

Spacing +20 added lines, -20 removed lines

@@ -8,48 +8,48 @@
 class ActionScheduler_Action_Test extends ActionScheduler_UnitTestCase {
 	public function test_set_schedule() {
 		$time     = as_get_datetime_object();
-		$schedule = new ActionScheduler_SimpleSchedule( $time );
-		$action   = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule );
-		$this->assertEquals( $schedule, $action->get_schedule() );
+		$schedule = new ActionScheduler_SimpleSchedule($time);
+		$action   = new ActionScheduler_Action(ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule);
+		$this->assertEquals($schedule, $action->get_schedule());
 	}
 
 	public function test_null_schedule() {
-		$action = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK );
-		$this->assertInstanceOf( 'ActionScheduler_NullSchedule', $action->get_schedule() );
+		$action = new ActionScheduler_Action(ActionScheduler_Callbacks::HOOK_WITH_CALLBACK);
+		$this->assertInstanceOf('ActionScheduler_NullSchedule', $action->get_schedule());
 	}
 
 	public function test_set_hook() {
-		$action = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK );
-		$this->assertEquals( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, $action->get_hook() );
+		$action = new ActionScheduler_Action(ActionScheduler_Callbacks::HOOK_WITH_CALLBACK);
+		$this->assertEquals(ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, $action->get_hook());
 	}
 
 	public function test_args() {
-		$action = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK );
-		$this->assertEmpty( $action->get_args() );
+		$action = new ActionScheduler_Action(ActionScheduler_Callbacks::HOOK_WITH_CALLBACK);
+		$this->assertEmpty($action->get_args());
 
-		$action = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( 5, 10, 15 ) );
-		$this->assertEqualSets( array( 5, 10, 15 ), $action->get_args() );
+		$action = new ActionScheduler_Action(ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(5, 10, 15));
+		$this->assertEqualSets(array(5, 10, 15), $action->get_args());
 	}
 
 	public function test_set_group() {
-		$action = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), null, 'my_group' );
-		$this->assertEquals( 'my_group', $action->get_group() );
+		$action = new ActionScheduler_Action(ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), null, 'my_group');
+		$this->assertEquals('my_group', $action->get_group());
 	}
 
 	public function test_execute() {
 		$mock = new MockAction();
 
-		$random = md5( rand() );
-		add_action( $random, array( $mock, 'action' ) );
+		$random = md5(rand());
+		add_action($random, array($mock, 'action'));
 
-		$action = new ActionScheduler_Action( $random, array( $random ) );
+		$action = new ActionScheduler_Action($random, array($random));
 		$action->execute();
 
-		remove_action( $random, array( $mock, 'action' ) );
+		remove_action($random, array($mock, 'action'));
 
-		$this->assertSame( 1, $mock->get_call_count() );
+		$this->assertSame(1, $mock->get_call_count());
 		$events = $mock->get_events();
-		$event  = reset( $events );
-		$this->assertEquals( $random, reset( $event['args'] ) );
+		$event  = reset($events);
+		$this->assertEquals($random, reset($event['args']));
 	}
 }

src/ext/action-scheduler/tests/phpunit/jobs/ActionScheduler_NullAction_Test.php

Indentation +6 added lines, -6 removed lines

@@ -6,12 +6,12 @@
  * @group actions
  */
 class ActionScheduler_NullAction_Test extends ActionScheduler_UnitTestCase {
-	public function test_null_action() {
-		$action = new ActionScheduler_NullAction();
+    public function test_null_action() {
+        $action = new ActionScheduler_NullAction();
 
-		$this->assertEmpty( $action->get_hook() );
-		$this->assertEmpty( $action->get_args() );
-		$this->assertNull( $action->get_schedule()->get_date() );
-	}
+        $this->assertEmpty( $action->get_hook() );
+        $this->assertEmpty( $action->get_args() );
+        $this->assertNull( $action->get_schedule()->get_date() );
+    }
 }
 

Spacing +3 added lines, -3 removed lines

@@ -9,9 +9,9 @@
 	public function test_null_action() {
 		$action = new ActionScheduler_NullAction();
 
-		$this->assertEmpty( $action->get_hook() );
-		$this->assertEmpty( $action->get_args() );
-		$this->assertNull( $action->get_schedule()->get_date() );
+		$this->assertEmpty($action->get_hook());
+		$this->assertEmpty($action->get_args());
+		$this->assertNull($action->get_schedule()->get_date());
 	}
 }
 

src/ext/action-scheduler/tests/phpunit/runner/ActionScheduler_QueueCleaner_Test.php

Indentation +110 added lines, -110 removed lines

@@ -5,149 +5,149 @@
  */
 class ActionScheduler_QueueCleaner_Test extends ActionScheduler_UnitTestCase {
 
-	public function test_delete_old_actions() {
-		$store  = ActionScheduler::store();
-		$runner = ActionScheduler_Mocker::get_queue_runner( $store );
+    public function test_delete_old_actions() {
+        $store  = ActionScheduler::store();
+        $runner = ActionScheduler_Mocker::get_queue_runner( $store );
 
-		$random   = md5( rand() );
-		$schedule = new ActionScheduler_SimpleSchedule( as_get_datetime_object( '1 day ago' ) );
+        $random   = md5( rand() );
+        $schedule = new ActionScheduler_SimpleSchedule( as_get_datetime_object( '1 day ago' ) );
 
-		$created_actions = array();
-		for ( $i = 0; $i < 5; $i++ ) {
-			$action            = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( $random ), $schedule );
-			$created_actions[] = $store->save_action( $action );
-		}
+        $created_actions = array();
+        for ( $i = 0; $i < 5; $i++ ) {
+            $action            = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( $random ), $schedule );
+            $created_actions[] = $store->save_action( $action );
+        }
 
-		$runner->run();
+        $runner->run();
 
-		add_filter( 'action_scheduler_retention_period', '__return_zero' ); // delete any finished job
-		$cleaner = new ActionScheduler_QueueCleaner( $store );
-		$cleaner->delete_old_actions();
-		remove_filter( 'action_scheduler_retention_period', '__return_zero' );
+        add_filter( 'action_scheduler_retention_period', '__return_zero' ); // delete any finished job
+        $cleaner = new ActionScheduler_QueueCleaner( $store );
+        $cleaner->delete_old_actions();
+        remove_filter( 'action_scheduler_retention_period', '__return_zero' );
 
-		foreach ( $created_actions as $action_id ) {
-			$action = $store->fetch_action( $action_id );
-			$this->assertFalse( $action->is_finished() ); // it's a NullAction
-		}
-	}
+        foreach ( $created_actions as $action_id ) {
+            $action = $store->fetch_action( $action_id );
+            $this->assertFalse( $action->is_finished() ); // it's a NullAction
+        }
+    }
 
-	public function test_delete_canceled_actions() {
-		$store = ActionScheduler::store();
+    public function test_delete_canceled_actions() {
+        $store = ActionScheduler::store();
 
-		$random   = md5( rand() );
-		$schedule = new ActionScheduler_SimpleSchedule( as_get_datetime_object( '1 day ago' ) );
-
-		$created_actions = array();
-		for ( $i = 0; $i < 5; $i++ ) {
-			$action    = new ActionScheduler_Action( $random, array( $random ), $schedule );
-			$action_id = $store->save_action( $action );
-			$store->cancel_action( $action_id );
-			$created_actions[] = $action_id;
-		}
+        $random   = md5( rand() );
+        $schedule = new ActionScheduler_SimpleSchedule( as_get_datetime_object( '1 day ago' ) );
+
+        $created_actions = array();
+        for ( $i = 0; $i < 5; $i++ ) {
+            $action    = new ActionScheduler_Action( $random, array( $random ), $schedule );
+            $action_id = $store->save_action( $action );
+            $store->cancel_action( $action_id );
+            $created_actions[] = $action_id;
+        }
 
-		// track the actions that are deleted
-		$mock_action = new MockAction();
-		add_action( 'action_scheduler_deleted_action', array( $mock_action, 'action' ), 10, 1 );
-		add_filter( 'action_scheduler_retention_period', '__return_zero' ); // delete any finished job
+        // track the actions that are deleted
+        $mock_action = new MockAction();
+        add_action( 'action_scheduler_deleted_action', array( $mock_action, 'action' ), 10, 1 );
+        add_filter( 'action_scheduler_retention_period', '__return_zero' ); // delete any finished job
 
-		$cleaner = new ActionScheduler_QueueCleaner( $store );
-		$cleaner->delete_old_actions();
+        $cleaner = new ActionScheduler_QueueCleaner( $store );
+        $cleaner->delete_old_actions();
 
-		remove_filter( 'action_scheduler_retention_period', '__return_zero' );
-		remove_action( 'action_scheduler_deleted_action', array( $mock_action, 'action' ), 10 );
+        remove_filter( 'action_scheduler_retention_period', '__return_zero' );
+        remove_action( 'action_scheduler_deleted_action', array( $mock_action, 'action' ), 10 );
 
-		$deleted_actions = array();
-		foreach ( $mock_action->get_args() as $action ) {
-			$deleted_actions[] = reset( $action );
-		}
+        $deleted_actions = array();
+        foreach ( $mock_action->get_args() as $action ) {
+            $deleted_actions[] = reset( $action );
+        }
 
-		$this->assertEqualSets( $created_actions, $deleted_actions );
-	}
+        $this->assertEqualSets( $created_actions, $deleted_actions );
+    }
 
-	public function test_do_not_delete_recent_actions() {
-		$store  = ActionScheduler::store();
-		$runner = ActionScheduler_Mocker::get_queue_runner( $store );
+    public function test_do_not_delete_recent_actions() {
+        $store  = ActionScheduler::store();
+        $runner = ActionScheduler_Mocker::get_queue_runner( $store );
 
-		$random   = md5( rand() );
-		$schedule = new ActionScheduler_SimpleSchedule( as_get_datetime_object( '1 day ago' ) );
+        $random   = md5( rand() );
+        $schedule = new ActionScheduler_SimpleSchedule( as_get_datetime_object( '1 day ago' ) );
 
-		$created_actions = array();
-		for ( $i = 0; $i < 5; $i++ ) {
-			$action            = new ActionScheduler_Action( $random, array( $random ), $schedule );
-			$created_actions[] = $store->save_action( $action );
-		}
+        $created_actions = array();
+        for ( $i = 0; $i < 5; $i++ ) {
+            $action            = new ActionScheduler_Action( $random, array( $random ), $schedule );
+            $created_actions[] = $store->save_action( $action );
+        }
 
-		$runner->run();
+        $runner->run();
 
-		$cleaner = new ActionScheduler_QueueCleaner( $store );
-		$cleaner->delete_old_actions();
+        $cleaner = new ActionScheduler_QueueCleaner( $store );
+        $cleaner->delete_old_actions();
 
-		foreach ( $created_actions as $action_id ) {
-			$action = $store->fetch_action( $action_id );
-			$this->assertTrue( $action->is_finished() ); // It's a FinishedAction
-		}
-	}
+        foreach ( $created_actions as $action_id ) {
+            $action = $store->fetch_action( $action_id );
+            $this->assertTrue( $action->is_finished() ); // It's a FinishedAction
+        }
+    }
 
-	public function test_reset_unrun_actions() {
-		$store = ActionScheduler::store();
+    public function test_reset_unrun_actions() {
+        $store = ActionScheduler::store();
 
-		$random   = md5( rand() );
-		$schedule = new ActionScheduler_SimpleSchedule( as_get_datetime_object( '1 day ago' ) );
+        $random   = md5( rand() );
+        $schedule = new ActionScheduler_SimpleSchedule( as_get_datetime_object( '1 day ago' ) );
 
-		$created_actions = array();
-		for ( $i = 0; $i < 5; $i++ ) {
-			$action            = new ActionScheduler_Action( $random, array( $random ), $schedule );
-			$created_actions[] = $store->save_action( $action );
-		}
+        $created_actions = array();
+        for ( $i = 0; $i < 5; $i++ ) {
+            $action            = new ActionScheduler_Action( $random, array( $random ), $schedule );
+            $created_actions[] = $store->save_action( $action );
+        }
 
-		$store->stake_claim( 10 );
+        $store->stake_claim( 10 );
 
-		// don't actually process the jobs, to simulate a request that timed out
+        // don't actually process the jobs, to simulate a request that timed out
 
-		add_filter( 'action_scheduler_timeout_period', '__return_zero' ); // delete any finished job
-		$cleaner = new ActionScheduler_QueueCleaner( $store );
-		$cleaner->reset_timeouts();
+        add_filter( 'action_scheduler_timeout_period', '__return_zero' ); // delete any finished job
+        $cleaner = new ActionScheduler_QueueCleaner( $store );
+        $cleaner->reset_timeouts();
 
-		remove_filter( 'action_scheduler_timeout_period', '__return_zero' );
+        remove_filter( 'action_scheduler_timeout_period', '__return_zero' );
 
-		$claim = $store->stake_claim( 10 );
-		$this->assertEqualSets( $created_actions, $claim->get_actions() );
-	}
+        $claim = $store->stake_claim( 10 );
+        $this->assertEqualSets( $created_actions, $claim->get_actions() );
+    }
 
-	public function test_do_not_reset_failed_action() {
-		$store = ActionScheduler::store();
+    public function test_do_not_reset_failed_action() {
+        $store = ActionScheduler::store();
 
-		$random   = md5( rand() );
-		$schedule = new ActionScheduler_SimpleSchedule( as_get_datetime_object( '1 day ago' ) );
+        $random   = md5( rand() );
+        $schedule = new ActionScheduler_SimpleSchedule( as_get_datetime_object( '1 day ago' ) );
 
-		$created_actions = array();
-		for ( $i = 0; $i < 5; $i++ ) {
-			$action            = new ActionScheduler_Action( $random, array( $random ), $schedule );
-			$created_actions[] = $store->save_action( $action );
-		}
+        $created_actions = array();
+        for ( $i = 0; $i < 5; $i++ ) {
+            $action            = new ActionScheduler_Action( $random, array( $random ), $schedule );
+            $created_actions[] = $store->save_action( $action );
+        }
 
-		$claim = $store->stake_claim( 10 );
-		foreach ( $claim->get_actions() as $action_id ) {
-			// simulate the first action interrupted by an uncatchable fatal error
-			$store->log_execution( $action_id );
-			break;
-		}
+        $claim = $store->stake_claim( 10 );
+        foreach ( $claim->get_actions() as $action_id ) {
+            // simulate the first action interrupted by an uncatchable fatal error
+            $store->log_execution( $action_id );
+            break;
+        }
 
-		add_filter( 'action_scheduler_timeout_period', '__return_zero' ); // delete any finished job
-		$cleaner = new ActionScheduler_QueueCleaner( $store );
-		$cleaner->reset_timeouts();
-		remove_filter( 'action_scheduler_timeout_period', '__return_zero' );
+        add_filter( 'action_scheduler_timeout_period', '__return_zero' ); // delete any finished job
+        $cleaner = new ActionScheduler_QueueCleaner( $store );
+        $cleaner->reset_timeouts();
+        remove_filter( 'action_scheduler_timeout_period', '__return_zero' );
 
-		$new_claim = $store->stake_claim( 10 );
-		$this->assertCount( 4, $new_claim->get_actions() );
+        $new_claim = $store->stake_claim( 10 );
+        $this->assertCount( 4, $new_claim->get_actions() );
 
-		add_filter( 'action_scheduler_failure_period', '__return_zero' );
-		$cleaner->mark_failures();
-		remove_filter( 'action_scheduler_failure_period', '__return_zero' );
+        add_filter( 'action_scheduler_failure_period', '__return_zero' );
+        $cleaner->mark_failures();
+        remove_filter( 'action_scheduler_failure_period', '__return_zero' );
 
-		$failed = $store->query_actions( array( 'status' => ActionScheduler_Store::STATUS_FAILED ) );
-		$this->assertEquals( $created_actions[0], $failed[0] );
-		$this->assertCount( 1, $failed );
+        $failed = $store->query_actions( array( 'status' => ActionScheduler_Store::STATUS_FAILED ) );
+        $this->assertEquals( $created_actions[0], $failed[0] );
+        $this->assertCount( 1, $failed );
 
-	}
+    }
 }

Spacing +65 added lines, -65 removed lines

@@ -7,147 +7,147 @@
 
 	public function test_delete_old_actions() {
 		$store  = ActionScheduler::store();
-		$runner = ActionScheduler_Mocker::get_queue_runner( $store );
+		$runner = ActionScheduler_Mocker::get_queue_runner($store);
 
-		$random   = md5( rand() );
-		$schedule = new ActionScheduler_SimpleSchedule( as_get_datetime_object( '1 day ago' ) );
+		$random   = md5(rand());
+		$schedule = new ActionScheduler_SimpleSchedule(as_get_datetime_object('1 day ago'));
 
 		$created_actions = array();
-		for ( $i = 0; $i < 5; $i++ ) {
-			$action            = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( $random ), $schedule );
-			$created_actions[] = $store->save_action( $action );
+		for ($i = 0; $i < 5; $i++) {
+			$action            = new ActionScheduler_Action(ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array($random), $schedule);
+			$created_actions[] = $store->save_action($action);
 		}
 
 		$runner->run();
 
-		add_filter( 'action_scheduler_retention_period', '__return_zero' ); // delete any finished job
-		$cleaner = new ActionScheduler_QueueCleaner( $store );
+		add_filter('action_scheduler_retention_period', '__return_zero'); // delete any finished job
+		$cleaner = new ActionScheduler_QueueCleaner($store);
 		$cleaner->delete_old_actions();
-		remove_filter( 'action_scheduler_retention_period', '__return_zero' );
+		remove_filter('action_scheduler_retention_period', '__return_zero');
 
-		foreach ( $created_actions as $action_id ) {
-			$action = $store->fetch_action( $action_id );
-			$this->assertFalse( $action->is_finished() ); // it's a NullAction
+		foreach ($created_actions as $action_id) {
+			$action = $store->fetch_action($action_id);
+			$this->assertFalse($action->is_finished()); // it's a NullAction
 		}
 	}
 
 	public function test_delete_canceled_actions() {
 		$store = ActionScheduler::store();
 
-		$random   = md5( rand() );
-		$schedule = new ActionScheduler_SimpleSchedule( as_get_datetime_object( '1 day ago' ) );
+		$random   = md5(rand());
+		$schedule = new ActionScheduler_SimpleSchedule(as_get_datetime_object('1 day ago'));
 
 		$created_actions = array();
-		for ( $i = 0; $i < 5; $i++ ) {
-			$action    = new ActionScheduler_Action( $random, array( $random ), $schedule );
-			$action_id = $store->save_action( $action );
-			$store->cancel_action( $action_id );
+		for ($i = 0; $i < 5; $i++) {
+			$action    = new ActionScheduler_Action($random, array($random), $schedule);
+			$action_id = $store->save_action($action);
+			$store->cancel_action($action_id);
 			$created_actions[] = $action_id;
 		}
 
 		// track the actions that are deleted
 		$mock_action = new MockAction();
-		add_action( 'action_scheduler_deleted_action', array( $mock_action, 'action' ), 10, 1 );
-		add_filter( 'action_scheduler_retention_period', '__return_zero' ); // delete any finished job
+		add_action('action_scheduler_deleted_action', array($mock_action, 'action'), 10, 1);
+		add_filter('action_scheduler_retention_period', '__return_zero'); // delete any finished job
 
-		$cleaner = new ActionScheduler_QueueCleaner( $store );
+		$cleaner = new ActionScheduler_QueueCleaner($store);
 		$cleaner->delete_old_actions();
 
-		remove_filter( 'action_scheduler_retention_period', '__return_zero' );
-		remove_action( 'action_scheduler_deleted_action', array( $mock_action, 'action' ), 10 );
+		remove_filter('action_scheduler_retention_period', '__return_zero');
+		remove_action('action_scheduler_deleted_action', array($mock_action, 'action'), 10);
 
 		$deleted_actions = array();
-		foreach ( $mock_action->get_args() as $action ) {
-			$deleted_actions[] = reset( $action );
+		foreach ($mock_action->get_args() as $action) {
+			$deleted_actions[] = reset($action);
 		}
 
-		$this->assertEqualSets( $created_actions, $deleted_actions );
+		$this->assertEqualSets($created_actions, $deleted_actions);
 	}
 
 	public function test_do_not_delete_recent_actions() {
 		$store  = ActionScheduler::store();
-		$runner = ActionScheduler_Mocker::get_queue_runner( $store );
+		$runner = ActionScheduler_Mocker::get_queue_runner($store);
 
-		$random   = md5( rand() );
-		$schedule = new ActionScheduler_SimpleSchedule( as_get_datetime_object( '1 day ago' ) );
+		$random   = md5(rand());
+		$schedule = new ActionScheduler_SimpleSchedule(as_get_datetime_object('1 day ago'));
 
 		$created_actions = array();
-		for ( $i = 0; $i < 5; $i++ ) {
-			$action            = new ActionScheduler_Action( $random, array( $random ), $schedule );
-			$created_actions[] = $store->save_action( $action );
+		for ($i = 0; $i < 5; $i++) {
+			$action            = new ActionScheduler_Action($random, array($random), $schedule);
+			$created_actions[] = $store->save_action($action);
 		}
 
 		$runner->run();
 
-		$cleaner = new ActionScheduler_QueueCleaner( $store );
+		$cleaner = new ActionScheduler_QueueCleaner($store);
 		$cleaner->delete_old_actions();
 
-		foreach ( $created_actions as $action_id ) {
-			$action = $store->fetch_action( $action_id );
-			$this->assertTrue( $action->is_finished() ); // It's a FinishedAction
+		foreach ($created_actions as $action_id) {
+			$action = $store->fetch_action($action_id);
+			$this->assertTrue($action->is_finished()); // It's a FinishedAction
 		}
 	}
 
 	public function test_reset_unrun_actions() {
 		$store = ActionScheduler::store();
 
-		$random   = md5( rand() );
-		$schedule = new ActionScheduler_SimpleSchedule( as_get_datetime_object( '1 day ago' ) );
+		$random   = md5(rand());
+		$schedule = new ActionScheduler_SimpleSchedule(as_get_datetime_object('1 day ago'));
 
 		$created_actions = array();
-		for ( $i = 0; $i < 5; $i++ ) {
-			$action            = new ActionScheduler_Action( $random, array( $random ), $schedule );
-			$created_actions[] = $store->save_action( $action );
+		for ($i = 0; $i < 5; $i++) {
+			$action            = new ActionScheduler_Action($random, array($random), $schedule);
+			$created_actions[] = $store->save_action($action);
 		}
 
-		$store->stake_claim( 10 );
+		$store->stake_claim(10);
 
 		// don't actually process the jobs, to simulate a request that timed out
 
-		add_filter( 'action_scheduler_timeout_period', '__return_zero' ); // delete any finished job
-		$cleaner = new ActionScheduler_QueueCleaner( $store );
+		add_filter('action_scheduler_timeout_period', '__return_zero'); // delete any finished job
+		$cleaner = new ActionScheduler_QueueCleaner($store);
 		$cleaner->reset_timeouts();
 
-		remove_filter( 'action_scheduler_timeout_period', '__return_zero' );
+		remove_filter('action_scheduler_timeout_period', '__return_zero');
 
-		$claim = $store->stake_claim( 10 );
-		$this->assertEqualSets( $created_actions, $claim->get_actions() );
+		$claim = $store->stake_claim(10);
+		$this->assertEqualSets($created_actions, $claim->get_actions());
 	}
 
 	public function test_do_not_reset_failed_action() {
 		$store = ActionScheduler::store();
 
-		$random   = md5( rand() );
-		$schedule = new ActionScheduler_SimpleSchedule( as_get_datetime_object( '1 day ago' ) );
+		$random   = md5(rand());
+		$schedule = new ActionScheduler_SimpleSchedule(as_get_datetime_object('1 day ago'));
 
 		$created_actions = array();
-		for ( $i = 0; $i < 5; $i++ ) {
-			$action            = new ActionScheduler_Action( $random, array( $random ), $schedule );
-			$created_actions[] = $store->save_action( $action );
+		for ($i = 0; $i < 5; $i++) {
+			$action            = new ActionScheduler_Action($random, array($random), $schedule);
+			$created_actions[] = $store->save_action($action);
 		}
 
-		$claim = $store->stake_claim( 10 );
-		foreach ( $claim->get_actions() as $action_id ) {
+		$claim = $store->stake_claim(10);
+		foreach ($claim->get_actions() as $action_id) {
 			// simulate the first action interrupted by an uncatchable fatal error
-			$store->log_execution( $action_id );
+			$store->log_execution($action_id);
 			break;
 		}
 
-		add_filter( 'action_scheduler_timeout_period', '__return_zero' ); // delete any finished job
-		$cleaner = new ActionScheduler_QueueCleaner( $store );
+		add_filter('action_scheduler_timeout_period', '__return_zero'); // delete any finished job
+		$cleaner = new ActionScheduler_QueueCleaner($store);
 		$cleaner->reset_timeouts();
-		remove_filter( 'action_scheduler_timeout_period', '__return_zero' );
+		remove_filter('action_scheduler_timeout_period', '__return_zero');
 
-		$new_claim = $store->stake_claim( 10 );
-		$this->assertCount( 4, $new_claim->get_actions() );
+		$new_claim = $store->stake_claim(10);
+		$this->assertCount(4, $new_claim->get_actions());
 
-		add_filter( 'action_scheduler_failure_period', '__return_zero' );
+		add_filter('action_scheduler_failure_period', '__return_zero');
 		$cleaner->mark_failures();
-		remove_filter( 'action_scheduler_failure_period', '__return_zero' );
+		remove_filter('action_scheduler_failure_period', '__return_zero');
 
-		$failed = $store->query_actions( array( 'status' => ActionScheduler_Store::STATUS_FAILED ) );
-		$this->assertEquals( $created_actions[0], $failed[0] );
-		$this->assertCount( 1, $failed );
+		$failed = $store->query_actions(array('status' => ActionScheduler_Store::STATUS_FAILED));
+		$this->assertEquals($created_actions[0], $failed[0]);
+		$this->assertCount(1, $failed);
 
 	}
 }

src/ext/action-scheduler/tests/phpunit/runner/ActionScheduler_QueueRunner_Test.php

Indentation +358 added lines, -358 removed lines

@@ -6,387 +6,387 @@
  * @group runners
  */
 class ActionScheduler_QueueRunner_Test extends ActionScheduler_UnitTestCase {
-	public function test_create_runner() {
-		$store       = ActionScheduler::store();
-		$runner      = ActionScheduler_Mocker::get_queue_runner( $store );
-		$actions_run = $runner->run();
+    public function test_create_runner() {
+        $store       = ActionScheduler::store();
+        $runner      = ActionScheduler_Mocker::get_queue_runner( $store );
+        $actions_run = $runner->run();
 
-		$this->assertSame( 0, $actions_run );
-	}
+        $this->assertSame( 0, $actions_run );
+    }
 
-	public function test_run() {
-		$store  = ActionScheduler::store();
-		$runner = ActionScheduler_Mocker::get_queue_runner( $store );
+    public function test_run() {
+        $store  = ActionScheduler::store();
+        $runner = ActionScheduler_Mocker::get_queue_runner( $store );
 
-		$mock   = new MockAction();
-		$random = md5( rand() );
-		add_action( $random, array( $mock, 'action' ) );
-		$schedule = new ActionScheduler_SimpleSchedule( as_get_datetime_object( '1 day ago' ) );
+        $mock   = new MockAction();
+        $random = md5( rand() );
+        add_action( $random, array( $mock, 'action' ) );
+        $schedule = new ActionScheduler_SimpleSchedule( as_get_datetime_object( '1 day ago' ) );
 
-		for ( $i = 0; $i < 5; $i++ ) {
-			$action = new ActionScheduler_Action( $random, array( $random ), $schedule );
-			$store->save_action( $action );
-		}
+        for ( $i = 0; $i < 5; $i++ ) {
+            $action = new ActionScheduler_Action( $random, array( $random ), $schedule );
+            $store->save_action( $action );
+        }
 
-		$actions_run = $runner->run();
+        $actions_run = $runner->run();
 
-		remove_action( $random, array( $mock, 'action' ) );
+        remove_action( $random, array( $mock, 'action' ) );
 
-		$this->assertEquals( 5, $mock->get_call_count() );
-		$this->assertEquals( 5, $actions_run );
-	}
+        $this->assertEquals( 5, $mock->get_call_count() );
+        $this->assertEquals( 5, $actions_run );
+    }
 
-	public function test_run_with_future_actions() {
-		$store  = ActionScheduler::store();
-		$runner = ActionScheduler_Mocker::get_queue_runner( $store );
+    public function test_run_with_future_actions() {
+        $store  = ActionScheduler::store();
+        $runner = ActionScheduler_Mocker::get_queue_runner( $store );
 
-		$mock   = new MockAction();
-		$random = md5( rand() );
-		add_action( $random, array( $mock, 'action' ) );
-		$schedule = new ActionScheduler_SimpleSchedule( as_get_datetime_object( '1 day ago' ) );
+        $mock   = new MockAction();
+        $random = md5( rand() );
+        add_action( $random, array( $mock, 'action' ) );
+        $schedule = new ActionScheduler_SimpleSchedule( as_get_datetime_object( '1 day ago' ) );
 
-		for ( $i = 0; $i < 3; $i++ ) {
-			$action = new ActionScheduler_Action( $random, array( $random ), $schedule );
-			$store->save_action( $action );
-		}
+        for ( $i = 0; $i < 3; $i++ ) {
+            $action = new ActionScheduler_Action( $random, array( $random ), $schedule );
+            $store->save_action( $action );
+        }
 
-		$schedule = new ActionScheduler_SimpleSchedule( as_get_datetime_object( 'tomorrow' ) );
-		for ( $i = 0; $i < 3; $i++ ) {
-			$action = new ActionScheduler_Action( $random, array( $random ), $schedule );
-			$store->save_action( $action );
-		}
+        $schedule = new ActionScheduler_SimpleSchedule( as_get_datetime_object( 'tomorrow' ) );
+        for ( $i = 0; $i < 3; $i++ ) {
+            $action = new ActionScheduler_Action( $random, array( $random ), $schedule );
+            $store->save_action( $action );
+        }
 
-		$actions_run = $runner->run();
+        $actions_run = $runner->run();
 
-		remove_action( $random, array( $mock, 'action' ) );
+        remove_action( $random, array( $mock, 'action' ) );
 
-		$this->assertEquals( 3, $mock->get_call_count() );
-		$this->assertEquals( 3, $actions_run );
-	}
+        $this->assertEquals( 3, $mock->get_call_count() );
+        $this->assertEquals( 3, $actions_run );
+    }
 
-	public function test_completed_action_status() {
-		$store  = ActionScheduler::store();
-		$runner = ActionScheduler_Mocker::get_queue_runner( $store );
+    public function test_completed_action_status() {
+        $store  = ActionScheduler::store();
+        $runner = ActionScheduler_Mocker::get_queue_runner( $store );
 
-		$random   = md5( rand() );
-		$schedule = new ActionScheduler_SimpleSchedule( as_get_datetime_object( '12 hours ago' ) );
+        $random   = md5( rand() );
+        $schedule = new ActionScheduler_SimpleSchedule( as_get_datetime_object( '12 hours ago' ) );
 
-		$action    = new ActionScheduler_Action( $random, array(), $schedule );
-		$action_id = $store->save_action( $action );
+        $action    = new ActionScheduler_Action( $random, array(), $schedule );
+        $action_id = $store->save_action( $action );
 
-		$runner->run();
+        $runner->run();
 
-		$finished_action = $store->fetch_action( $action_id );
+        $finished_action = $store->fetch_action( $action_id );
 
-		$this->assertTrue( $finished_action->is_finished() );
-	}
+        $this->assertTrue( $finished_action->is_finished() );
+    }
 
-	public function test_next_instance_of_cron_action() {
-		// Create an action with daily Cron expression (i.e. midnight each day)
-		$random    = md5( rand() );
-		$action_id = ActionScheduler::factory()->cron( $random, array(), null, '0 0 * * *' );
-		$store     = ActionScheduler::store();
-		$runner    = ActionScheduler_Mocker::get_queue_runner( $store );
+    public function test_next_instance_of_cron_action() {
+        // Create an action with daily Cron expression (i.e. midnight each day)
+        $random    = md5( rand() );
+        $action_id = ActionScheduler::factory()->cron( $random, array(), null, '0 0 * * *' );
+        $store     = ActionScheduler::store();
+        $runner    = ActionScheduler_Mocker::get_queue_runner( $store );
 
-		// Make sure the 1st instance of the action is scheduled to occur tomorrow
-		$date = as_get_datetime_object( 'tomorrow' );
-		$date->modify( '-1 minute' );
-		$claim = $store->stake_claim( 10, $date );
-		$this->assertCount( 0, $claim->get_actions() );
+        // Make sure the 1st instance of the action is scheduled to occur tomorrow
+        $date = as_get_datetime_object( 'tomorrow' );
+        $date->modify( '-1 minute' );
+        $claim = $store->stake_claim( 10, $date );
+        $this->assertCount( 0, $claim->get_actions() );
 
-		$store->release_claim( $claim );
+        $store->release_claim( $claim );
 
-		$date->modify( '+1 minute' );
+        $date->modify( '+1 minute' );
 
-		$claim   = $store->stake_claim( 10, $date );
-		$actions = $claim->get_actions();
-		$this->assertCount( 1, $actions );
-
-		$fetched_action_id = reset( $actions );
-		$fetched_action    = $store->fetch_action( $fetched_action_id );
-
-		$this->assertEquals( $fetched_action_id, $action_id );
-		$this->assertEquals( $random, $fetched_action->get_hook() );
-		$this->assertEquals( $date->getTimestamp(), $fetched_action->get_schedule()->get_date()->getTimestamp(), '', 1 );
-
-		$store->release_claim( $claim );
-
-		// Make sure the 2nd instance of the cron action is scheduled to occur tomorrow still
-		$runner->process_action( $action_id );
-
-		$claim   = $store->stake_claim( 10, $date );
-		$actions = $claim->get_actions();
-		$this->assertCount( 1, $actions );
-
-		$fetched_action_id = reset( $actions );
-		$fetched_action    = $store->fetch_action( $fetched_action_id );
-
-		$this->assertNotEquals( $fetched_action_id, $action_id );
-		$this->assertEquals( $random, $fetched_action->get_hook() );
-		$this->assertEquals( $date->getTimestamp(), $fetched_action->get_schedule()->get_date()->getTimestamp(), '', 1 );
-	}
-
-	public function test_next_instance_of_interval_action() {
-		// Create an action to recur every 24 hours, with the first instance scheduled to run 12 hours ago
-		$random    = md5( rand() );
-		$date      = as_get_datetime_object( '12 hours ago' );
-		$action_id = ActionScheduler::factory()->recurring( $random, array(), $date->getTimestamp(), DAY_IN_SECONDS );
-		$store     = ActionScheduler::store();
-		$runner    = ActionScheduler_Mocker::get_queue_runner( $store );
-
-		// Make sure the 1st instance of the action is scheduled to occur 12 hours ago
-		$claim   = $store->stake_claim( 10, $date );
-		$actions = $claim->get_actions();
-		$this->assertCount( 1, $actions );
-
-		$fetched_action_id = reset( $actions );
-		$fetched_action    = $store->fetch_action( $fetched_action_id );
-
-		$this->assertEquals( $fetched_action_id, $action_id );
-		$this->assertEquals( $random, $fetched_action->get_hook() );
-		$this->assertEquals( $date->getTimestamp(), $fetched_action->get_schedule()->get_date()->getTimestamp(), '', 1 );
-
-		$store->release_claim( $claim );
-
-		// Make sure after the queue is run, the 2nd instance of the action is scheduled to occur in 24 hours
-		$runner->run();
-
-		$date    = as_get_datetime_object( '+1 day' );
-		$claim   = $store->stake_claim( 10, $date );
-		$actions = $claim->get_actions();
-		$this->assertCount( 1, $actions );
-
-		$fetched_action_id = reset( $actions );
-		$fetched_action    = $store->fetch_action( $fetched_action_id );
-
-		$this->assertNotEquals( $fetched_action_id, $action_id );
-		$this->assertEquals( $random, $fetched_action->get_hook() );
-		$this->assertEquals( $date->getTimestamp(), $fetched_action->get_schedule()->get_date()->getTimestamp(), '', 1 );
-
-		$store->release_claim( $claim );
-
-		// Make sure the 3rd instance of the cron action is scheduled for 24 hours from now, as the action was run early, ahead of schedule
-		$runner->process_action( $fetched_action_id );
-		$date = as_get_datetime_object( '+1 day' );
-
-		$claim   = $store->stake_claim( 10, $date );
-		$actions = $claim->get_actions();
-		$this->assertCount( 1, $actions );
-
-		$fetched_action_id = reset( $actions );
-		$fetched_action    = $store->fetch_action( $fetched_action_id );
-
-		$this->assertNotEquals( $fetched_action_id, $action_id );
-		$this->assertEquals( $random, $fetched_action->get_hook() );
-		$this->assertEquals( $date->getTimestamp(), $fetched_action->get_schedule()->get_date()->getTimestamp(), '', 1 );
-	}
-
-	/**
-	 * As soon as one recurring action has been executed its replacement will be scheduled.
-	 *
-	 * This is true even if the current action fails. This makes sense, since a failure may be temporary in nature.
-	 * However, if the same recurring action consistently fails then it is likely that there is a problem and we should
-	 * stop creating new instances. This test outlines the expected behavior in this regard.
-	 *
-	 * @return void
-	 */
-	public function test_failing_recurring_actions_are_not_rescheduled_when_threshold_met() {
-		$store           = ActionScheduler_Store::instance();
-		$runner          = ActionScheduler_Mocker::get_queue_runner( $store );
-		$created_actions = array();
-
-		// Create 4 failed actions (one below the threshold of what counts as 'consistently failing').
-		for ( $i = 0; $i < 3; $i++ ) {
-			// We give each action a unique set of args, this illustrates that in the context of determining consistent
-			// failure we care only about the hook and not other properties of the action.
-			$args      = array( 'unique-' . $i => hash( 'md5', $i ) );
-			$hook      = 'will-fail';
-			$date      = as_get_datetime_object( 12 - $i . ' hours ago' );
-			$action_id = as_schedule_recurring_action( $date->getTimestamp(), HOUR_IN_SECONDS, $hook, $args );
-			$store->mark_failure( $action_id );
-			$created_actions[] = $action_id;
-		}
-
-		// Now create a further action using the same hook, that is also destined to fail.
-		$date              = as_get_datetime_object( '6 hours ago' );
-		$pending_action_id = as_schedule_recurring_action( $date->getTimestamp(), HOUR_IN_SECONDS, $hook, $args );
-		$created_actions[] = $pending_action_id;
-
-		// Process the queue!
-		$runner->run();
-		$pending_actions       = $store->query_actions(
-			array(
-				'hook'   => $hook,
-				'args'   => $args,
-				'status' => ActionScheduler_Store::STATUS_PENDING,
-			)
-		);
-		$new_pending_action_id = current( $pending_actions );
-
-		// We now have 5 instances of the same recurring action. 4 have already failed, one is pending.
-		$this->assertCount( 1, $pending_actions, 'If the threshold for consistent failure has not been met, a replacement action should have been scheduled.' );
-		$this->assertNotContains( $new_pending_action_id, $created_actions, 'Confirm that the replacement action is new, and not one of those we created manually earlier in the test.' );
-
-		// Process the pending action (we do this directly instead of via `$runner->run()` because it won't actually
-		// become due for another hour).
-		$runner->process_action( $new_pending_action_id );
-		$pending_actions = $store->query_actions(
-			array(
-				'hook'   => $hook,
-				'args'   => $args,
-				'status' => ActionScheduler_Store::STATUS_PENDING,
-			)
-		);
-
-		// Now 5 instances of the same recurring action have all failed, therefore the threshold for consistent failure
-		// has been met and, this time, a new action should *not* have been scheduled.
-		$this->assertCount( 0, $pending_actions, 'The failure threshold (5 consecutive fails for recurring actions with the same signature) having been met, no further actions were scheduled.' );
-	}
-
-	public function test_hooked_into_wp_cron() {
-		$next = wp_next_scheduled( ActionScheduler_QueueRunner::WP_CRON_HOOK, array( 'WP Cron' ) );
-		$this->assertNotEmpty( $next );
-	}
-
-	public function test_batch_count_limit() {
-		$store  = ActionScheduler::store();
-		$runner = ActionScheduler_Mocker::get_queue_runner( $store );
-
-		$mock   = new MockAction();
-		$random = md5( rand() );
-		add_action( $random, array( $mock, 'action' ) );
-		$schedule = new ActionScheduler_SimpleSchedule( new ActionScheduler_DateTime( '1 day ago' ) );
-
-		for ( $i = 0; $i < 2; $i++ ) {
-			$action = new ActionScheduler_Action( $random, array( $random ), $schedule );
-			$store->save_action( $action );
-		}
-
-		$claim = $store->stake_claim();
-
-		$actions_run = $runner->run();
-
-		$this->assertSame( 0, $mock->get_call_count() );
-		$this->assertSame( 0, $actions_run );
-
-		$store->release_claim( $claim );
-
-		$actions_run = $runner->run();
-
-		$this->assertEquals( 2, $mock->get_call_count() );
-		$this->assertEquals( 2, $actions_run );
-
-		remove_action( $random, array( $mock, 'action' ) );
-	}
-
-	public function test_changing_batch_count_limit() {
-		$store  = ActionScheduler::store();
-		$runner = ActionScheduler_Mocker::get_queue_runner( $store );
-
-		$random   = md5( rand() );
-		$schedule = new ActionScheduler_SimpleSchedule( new ActionScheduler_DateTime( '1 day ago' ) );
-
-		for ( $i = 0; $i < 30; $i++ ) {
-			$action = new ActionScheduler_Action( $random, array( $random ), $schedule );
-			$store->save_action( $action );
-		}
-
-		$claims = array();
-
-		for ( $i = 0; $i < 5; $i++ ) {
-			$claims[] = $store->stake_claim( 5 );
-		}
-
-		$mock1 = new MockAction();
-		add_action( $random, array( $mock1, 'action' ) );
-		$actions_run = $runner->run();
-		remove_action( $random, array( $mock1, 'action' ) );
-
-		$this->assertSame( 0, $mock1->get_call_count() );
-		$this->assertSame( 0, $actions_run );
-
-		add_filter( 'action_scheduler_queue_runner_concurrent_batches', array( $this, 'return_6' ) );
-
-		$mock2 = new MockAction();
-		add_action( $random, array( $mock2, 'action' ) );
-		$actions_run = $runner->run();
-		remove_action( $random, array( $mock2, 'action' ) );
-
-		$this->assertEquals( 5, $mock2->get_call_count() );
-		$this->assertEquals( 5, $actions_run );
-
-		remove_filter( 'action_scheduler_queue_runner_concurrent_batches', array( $this, 'return_6' ) );
-
-		for ( $i = 0; $i < 5; $i++ ) { // to make up for the actions we just processed
-			$action = new ActionScheduler_Action( $random, array( $random ), $schedule );
-			$store->save_action( $action );
-		}
-
-		$mock3 = new MockAction();
-		add_action( $random, array( $mock3, 'action' ) );
-		$actions_run = $runner->run();
-		remove_action( $random, array( $mock3, 'action' ) );
-
-		$this->assertSame( 0, $mock3->get_call_count() );
-		$this->assertSame( 0, $actions_run );
-
-		remove_filter( 'action_scheduler_queue_runner_concurrent_batches', array( $this, 'return_6' ) );
-	}
-
-	public function return_6() {
-		return 6;
-	}
-
-	public function test_store_fetch_action_failure_schedule_next_instance() {
-		$random    = md5( rand() );
-		$schedule  = new ActionScheduler_IntervalSchedule( as_get_datetime_object( '12 hours ago' ), DAY_IN_SECONDS );
-		$action    = new ActionScheduler_Action( $random, array(), $schedule );
-		$action_id = ActionScheduler::store()->save_action( $action );
-
-		// Set up a mock store that will throw an exception when fetching actions.
-		$store = $this
-					->getMockBuilder( 'ActionScheduler_wpPostStore' )
-					->setMethods( array( 'fetch_action' ) )
-					->getMock();
-		$store
-			->method( 'fetch_action' )
-			->with( array( $action_id ) )
-			->will( $this->throwException( new Exception() ) );
-
-		// Set up a mock queue runner to verify that schedule_next_instance()
-		// isn't called for an undefined $action.
-		$runner = $this
-					->getMockBuilder( 'ActionScheduler_QueueRunner' )
-					->setConstructorArgs( array( $store ) )
-					->setMethods( array( 'schedule_next_instance' ) )
-					->getMock();
-		$runner
-			->expects( $this->never() )
-			->method( 'schedule_next_instance' );
-
-		$runner->run();
-
-		// Set up a mock store that will throw an exception when fetching actions.
-		$store2 = $this
-					->getMockBuilder( 'ActionScheduler_wpPostStore' )
-					->setMethods( array( 'fetch_action' ) )
-					->getMock();
-		$store2
-			->method( 'fetch_action' )
-			->with( array( $action_id ) )
-			->willReturn( null );
-
-		// Set up a mock queue runner to verify that schedule_next_instance()
-		// isn't called for an undefined $action.
-		$runner2 = $this
-					->getMockBuilder( 'ActionScheduler_QueueRunner' )
-					->setConstructorArgs( array( $store ) )
-					->setMethods( array( 'schedule_next_instance' ) )
-					->getMock();
-		$runner2
-			->expects( $this->never() )
-			->method( 'schedule_next_instance' );
-
-		$runner2->run();
-	}
+        $claim   = $store->stake_claim( 10, $date );
+        $actions = $claim->get_actions();
+        $this->assertCount( 1, $actions );
+
+        $fetched_action_id = reset( $actions );
+        $fetched_action    = $store->fetch_action( $fetched_action_id );
+
+        $this->assertEquals( $fetched_action_id, $action_id );
+        $this->assertEquals( $random, $fetched_action->get_hook() );
+        $this->assertEquals( $date->getTimestamp(), $fetched_action->get_schedule()->get_date()->getTimestamp(), '', 1 );
+
+        $store->release_claim( $claim );
+
+        // Make sure the 2nd instance of the cron action is scheduled to occur tomorrow still
+        $runner->process_action( $action_id );
+
+        $claim   = $store->stake_claim( 10, $date );
+        $actions = $claim->get_actions();
+        $this->assertCount( 1, $actions );
+
+        $fetched_action_id = reset( $actions );
+        $fetched_action    = $store->fetch_action( $fetched_action_id );
+
+        $this->assertNotEquals( $fetched_action_id, $action_id );
+        $this->assertEquals( $random, $fetched_action->get_hook() );
+        $this->assertEquals( $date->getTimestamp(), $fetched_action->get_schedule()->get_date()->getTimestamp(), '', 1 );
+    }
+
+    public function test_next_instance_of_interval_action() {
+        // Create an action to recur every 24 hours, with the first instance scheduled to run 12 hours ago
+        $random    = md5( rand() );
+        $date      = as_get_datetime_object( '12 hours ago' );
+        $action_id = ActionScheduler::factory()->recurring( $random, array(), $date->getTimestamp(), DAY_IN_SECONDS );
+        $store     = ActionScheduler::store();
+        $runner    = ActionScheduler_Mocker::get_queue_runner( $store );
+
+        // Make sure the 1st instance of the action is scheduled to occur 12 hours ago
+        $claim   = $store->stake_claim( 10, $date );
+        $actions = $claim->get_actions();
+        $this->assertCount( 1, $actions );
+
+        $fetched_action_id = reset( $actions );
+        $fetched_action    = $store->fetch_action( $fetched_action_id );
+
+        $this->assertEquals( $fetched_action_id, $action_id );
+        $this->assertEquals( $random, $fetched_action->get_hook() );
+        $this->assertEquals( $date->getTimestamp(), $fetched_action->get_schedule()->get_date()->getTimestamp(), '', 1 );
+
+        $store->release_claim( $claim );
+
+        // Make sure after the queue is run, the 2nd instance of the action is scheduled to occur in 24 hours
+        $runner->run();
+
+        $date    = as_get_datetime_object( '+1 day' );
+        $claim   = $store->stake_claim( 10, $date );
+        $actions = $claim->get_actions();
+        $this->assertCount( 1, $actions );
+
+        $fetched_action_id = reset( $actions );
+        $fetched_action    = $store->fetch_action( $fetched_action_id );
+
+        $this->assertNotEquals( $fetched_action_id, $action_id );
+        $this->assertEquals( $random, $fetched_action->get_hook() );
+        $this->assertEquals( $date->getTimestamp(), $fetched_action->get_schedule()->get_date()->getTimestamp(), '', 1 );
+
+        $store->release_claim( $claim );
+
+        // Make sure the 3rd instance of the cron action is scheduled for 24 hours from now, as the action was run early, ahead of schedule
+        $runner->process_action( $fetched_action_id );
+        $date = as_get_datetime_object( '+1 day' );
+
+        $claim   = $store->stake_claim( 10, $date );
+        $actions = $claim->get_actions();
+        $this->assertCount( 1, $actions );
+
+        $fetched_action_id = reset( $actions );
+        $fetched_action    = $store->fetch_action( $fetched_action_id );
+
+        $this->assertNotEquals( $fetched_action_id, $action_id );
+        $this->assertEquals( $random, $fetched_action->get_hook() );
+        $this->assertEquals( $date->getTimestamp(), $fetched_action->get_schedule()->get_date()->getTimestamp(), '', 1 );
+    }
+
+    /**
+     * As soon as one recurring action has been executed its replacement will be scheduled.
+     *
+     * This is true even if the current action fails. This makes sense, since a failure may be temporary in nature.
+     * However, if the same recurring action consistently fails then it is likely that there is a problem and we should
+     * stop creating new instances. This test outlines the expected behavior in this regard.
+     *
+     * @return void
+     */
+    public function test_failing_recurring_actions_are_not_rescheduled_when_threshold_met() {
+        $store           = ActionScheduler_Store::instance();
+        $runner          = ActionScheduler_Mocker::get_queue_runner( $store );
+        $created_actions = array();
+
+        // Create 4 failed actions (one below the threshold of what counts as 'consistently failing').
+        for ( $i = 0; $i < 3; $i++ ) {
+            // We give each action a unique set of args, this illustrates that in the context of determining consistent
+            // failure we care only about the hook and not other properties of the action.
+            $args      = array( 'unique-' . $i => hash( 'md5', $i ) );
+            $hook      = 'will-fail';
+            $date      = as_get_datetime_object( 12 - $i . ' hours ago' );
+            $action_id = as_schedule_recurring_action( $date->getTimestamp(), HOUR_IN_SECONDS, $hook, $args );
+            $store->mark_failure( $action_id );
+            $created_actions[] = $action_id;
+        }
+
+        // Now create a further action using the same hook, that is also destined to fail.
+        $date              = as_get_datetime_object( '6 hours ago' );
+        $pending_action_id = as_schedule_recurring_action( $date->getTimestamp(), HOUR_IN_SECONDS, $hook, $args );
+        $created_actions[] = $pending_action_id;
+
+        // Process the queue!
+        $runner->run();
+        $pending_actions       = $store->query_actions(
+            array(
+                'hook'   => $hook,
+                'args'   => $args,
+                'status' => ActionScheduler_Store::STATUS_PENDING,
+            )
+        );
+        $new_pending_action_id = current( $pending_actions );
+
+        // We now have 5 instances of the same recurring action. 4 have already failed, one is pending.
+        $this->assertCount( 1, $pending_actions, 'If the threshold for consistent failure has not been met, a replacement action should have been scheduled.' );
+        $this->assertNotContains( $new_pending_action_id, $created_actions, 'Confirm that the replacement action is new, and not one of those we created manually earlier in the test.' );
+
+        // Process the pending action (we do this directly instead of via `$runner->run()` because it won't actually
+        // become due for another hour).
+        $runner->process_action( $new_pending_action_id );
+        $pending_actions = $store->query_actions(
+            array(
+                'hook'   => $hook,
+                'args'   => $args,
+                'status' => ActionScheduler_Store::STATUS_PENDING,
+            )
+        );
+
+        // Now 5 instances of the same recurring action have all failed, therefore the threshold for consistent failure
+        // has been met and, this time, a new action should *not* have been scheduled.
+        $this->assertCount( 0, $pending_actions, 'The failure threshold (5 consecutive fails for recurring actions with the same signature) having been met, no further actions were scheduled.' );
+    }
+
+    public function test_hooked_into_wp_cron() {
+        $next = wp_next_scheduled( ActionScheduler_QueueRunner::WP_CRON_HOOK, array( 'WP Cron' ) );
+        $this->assertNotEmpty( $next );
+    }
+
+    public function test_batch_count_limit() {
+        $store  = ActionScheduler::store();
+        $runner = ActionScheduler_Mocker::get_queue_runner( $store );
+
+        $mock   = new MockAction();
+        $random = md5( rand() );
+        add_action( $random, array( $mock, 'action' ) );
+        $schedule = new ActionScheduler_SimpleSchedule( new ActionScheduler_DateTime( '1 day ago' ) );
+
+        for ( $i = 0; $i < 2; $i++ ) {
+            $action = new ActionScheduler_Action( $random, array( $random ), $schedule );
+            $store->save_action( $action );
+        }
+
+        $claim = $store->stake_claim();
+
+        $actions_run = $runner->run();
+
+        $this->assertSame( 0, $mock->get_call_count() );
+        $this->assertSame( 0, $actions_run );
+
+        $store->release_claim( $claim );
+
+        $actions_run = $runner->run();
+
+        $this->assertEquals( 2, $mock->get_call_count() );
+        $this->assertEquals( 2, $actions_run );
+
+        remove_action( $random, array( $mock, 'action' ) );
+    }
+
+    public function test_changing_batch_count_limit() {
+        $store  = ActionScheduler::store();
+        $runner = ActionScheduler_Mocker::get_queue_runner( $store );
+
+        $random   = md5( rand() );
+        $schedule = new ActionScheduler_SimpleSchedule( new ActionScheduler_DateTime( '1 day ago' ) );
+
+        for ( $i = 0; $i < 30; $i++ ) {
+            $action = new ActionScheduler_Action( $random, array( $random ), $schedule );
+            $store->save_action( $action );
+        }
+
+        $claims = array();
+
+        for ( $i = 0; $i < 5; $i++ ) {
+            $claims[] = $store->stake_claim( 5 );
+        }
+
+        $mock1 = new MockAction();
+        add_action( $random, array( $mock1, 'action' ) );
+        $actions_run = $runner->run();
+        remove_action( $random, array( $mock1, 'action' ) );
+
+        $this->assertSame( 0, $mock1->get_call_count() );
+        $this->assertSame( 0, $actions_run );
+
+        add_filter( 'action_scheduler_queue_runner_concurrent_batches', array( $this, 'return_6' ) );
+
+        $mock2 = new MockAction();
+        add_action( $random, array( $mock2, 'action' ) );
+        $actions_run = $runner->run();
+        remove_action( $random, array( $mock2, 'action' ) );
+
+        $this->assertEquals( 5, $mock2->get_call_count() );
+        $this->assertEquals( 5, $actions_run );
+
+        remove_filter( 'action_scheduler_queue_runner_concurrent_batches', array( $this, 'return_6' ) );
+
+        for ( $i = 0; $i < 5; $i++ ) { // to make up for the actions we just processed
+            $action = new ActionScheduler_Action( $random, array( $random ), $schedule );
+            $store->save_action( $action );
+        }
+
+        $mock3 = new MockAction();
+        add_action( $random, array( $mock3, 'action' ) );
+        $actions_run = $runner->run();
+        remove_action( $random, array( $mock3, 'action' ) );
+
+        $this->assertSame( 0, $mock3->get_call_count() );
+        $this->assertSame( 0, $actions_run );
+
+        remove_filter( 'action_scheduler_queue_runner_concurrent_batches', array( $this, 'return_6' ) );
+    }
+
+    public function return_6() {
+        return 6;
+    }
+
+    public function test_store_fetch_action_failure_schedule_next_instance() {
+        $random    = md5( rand() );
+        $schedule  = new ActionScheduler_IntervalSchedule( as_get_datetime_object( '12 hours ago' ), DAY_IN_SECONDS );
+        $action    = new ActionScheduler_Action( $random, array(), $schedule );
+        $action_id = ActionScheduler::store()->save_action( $action );
+
+        // Set up a mock store that will throw an exception when fetching actions.
+        $store = $this
+                    ->getMockBuilder( 'ActionScheduler_wpPostStore' )
+                    ->setMethods( array( 'fetch_action' ) )
+                    ->getMock();
+        $store
+            ->method( 'fetch_action' )
+            ->with( array( $action_id ) )
+            ->will( $this->throwException( new Exception() ) );
+
+        // Set up a mock queue runner to verify that schedule_next_instance()
+        // isn't called for an undefined $action.
+        $runner = $this
+                    ->getMockBuilder( 'ActionScheduler_QueueRunner' )
+                    ->setConstructorArgs( array( $store ) )
+                    ->setMethods( array( 'schedule_next_instance' ) )
+                    ->getMock();
+        $runner
+            ->expects( $this->never() )
+            ->method( 'schedule_next_instance' );
+
+        $runner->run();
+
+        // Set up a mock store that will throw an exception when fetching actions.
+        $store2 = $this
+                    ->getMockBuilder( 'ActionScheduler_wpPostStore' )
+                    ->setMethods( array( 'fetch_action' ) )
+                    ->getMock();
+        $store2
+            ->method( 'fetch_action' )
+            ->with( array( $action_id ) )
+            ->willReturn( null );
+
+        // Set up a mock queue runner to verify that schedule_next_instance()
+        // isn't called for an undefined $action.
+        $runner2 = $this
+                    ->getMockBuilder( 'ActionScheduler_QueueRunner' )
+                    ->setConstructorArgs( array( $store ) )
+                    ->setMethods( array( 'schedule_next_instance' ) )
+                    ->getMock();
+        $runner2
+            ->expects( $this->never() )
+            ->method( 'schedule_next_instance' );
+
+        $runner2->run();
+    }
 }

Spacing +167 added lines, -167 removed lines

@@ -8,177 +8,177 @@ 
 class ActionScheduler_QueueRunner_Test extends ActionScheduler_UnitTestCase {
 	public function test_create_runner() {
 		$store       = ActionScheduler::store();
-		$runner      = ActionScheduler_Mocker::get_queue_runner( $store );
+		$runner      = ActionScheduler_Mocker::get_queue_runner($store);
 		$actions_run = $runner->run();
 
-		$this->assertSame( 0, $actions_run );
+		$this->assertSame(0, $actions_run);
 	}
 
 	public function test_run() {
 		$store  = ActionScheduler::store();
-		$runner = ActionScheduler_Mocker::get_queue_runner( $store );
+		$runner = ActionScheduler_Mocker::get_queue_runner($store);
 
 		$mock   = new MockAction();
-		$random = md5( rand() );
-		add_action( $random, array( $mock, 'action' ) );
-		$schedule = new ActionScheduler_SimpleSchedule( as_get_datetime_object( '1 day ago' ) );
+		$random = md5(rand());
+		add_action($random, array($mock, 'action'));
+		$schedule = new ActionScheduler_SimpleSchedule(as_get_datetime_object('1 day ago'));
 
-		for ( $i = 0; $i < 5; $i++ ) {
-			$action = new ActionScheduler_Action( $random, array( $random ), $schedule );
-			$store->save_action( $action );
+		for ($i = 0; $i < 5; $i++) {
+			$action = new ActionScheduler_Action($random, array($random), $schedule);
+			$store->save_action($action);
 		}
 
 		$actions_run = $runner->run();
 
-		remove_action( $random, array( $mock, 'action' ) );
+		remove_action($random, array($mock, 'action'));
 
-		$this->assertEquals( 5, $mock->get_call_count() );
-		$this->assertEquals( 5, $actions_run );
+		$this->assertEquals(5, $mock->get_call_count());
+		$this->assertEquals(5, $actions_run);
 	}
 
 	public function test_run_with_future_actions() {
 		$store  = ActionScheduler::store();
-		$runner = ActionScheduler_Mocker::get_queue_runner( $store );
+		$runner = ActionScheduler_Mocker::get_queue_runner($store);
 
 		$mock   = new MockAction();
-		$random = md5( rand() );
-		add_action( $random, array( $mock, 'action' ) );
-		$schedule = new ActionScheduler_SimpleSchedule( as_get_datetime_object( '1 day ago' ) );
+		$random = md5(rand());
+		add_action($random, array($mock, 'action'));
+		$schedule = new ActionScheduler_SimpleSchedule(as_get_datetime_object('1 day ago'));
 
-		for ( $i = 0; $i < 3; $i++ ) {
-			$action = new ActionScheduler_Action( $random, array( $random ), $schedule );
-			$store->save_action( $action );
+		for ($i = 0; $i < 3; $i++) {
+			$action = new ActionScheduler_Action($random, array($random), $schedule);
+			$store->save_action($action);
 		}
 
-		$schedule = new ActionScheduler_SimpleSchedule( as_get_datetime_object( 'tomorrow' ) );
-		for ( $i = 0; $i < 3; $i++ ) {
-			$action = new ActionScheduler_Action( $random, array( $random ), $schedule );
-			$store->save_action( $action );
+		$schedule = new ActionScheduler_SimpleSchedule(as_get_datetime_object('tomorrow'));
+		for ($i = 0; $i < 3; $i++) {
+			$action = new ActionScheduler_Action($random, array($random), $schedule);
+			$store->save_action($action);
 		}
 
 		$actions_run = $runner->run();
 
-		remove_action( $random, array( $mock, 'action' ) );
+		remove_action($random, array($mock, 'action'));
 
-		$this->assertEquals( 3, $mock->get_call_count() );
-		$this->assertEquals( 3, $actions_run );
+		$this->assertEquals(3, $mock->get_call_count());
+		$this->assertEquals(3, $actions_run);
 	}
 
 	public function test_completed_action_status() {
 		$store  = ActionScheduler::store();
-		$runner = ActionScheduler_Mocker::get_queue_runner( $store );
+		$runner = ActionScheduler_Mocker::get_queue_runner($store);
 
-		$random   = md5( rand() );
-		$schedule = new ActionScheduler_SimpleSchedule( as_get_datetime_object( '12 hours ago' ) );
+		$random   = md5(rand());
+		$schedule = new ActionScheduler_SimpleSchedule(as_get_datetime_object('12 hours ago'));
 
-		$action    = new ActionScheduler_Action( $random, array(), $schedule );
-		$action_id = $store->save_action( $action );
+		$action    = new ActionScheduler_Action($random, array(), $schedule);
+		$action_id = $store->save_action($action);
 
 		$runner->run();
 
-		$finished_action = $store->fetch_action( $action_id );
+		$finished_action = $store->fetch_action($action_id);
 
-		$this->assertTrue( $finished_action->is_finished() );
+		$this->assertTrue($finished_action->is_finished());
 	}
 
 	public function test_next_instance_of_cron_action() {
 		// Create an action with daily Cron expression (i.e. midnight each day)
-		$random    = md5( rand() );
-		$action_id = ActionScheduler::factory()->cron( $random, array(), null, '0 0 * * *' );
+		$random    = md5(rand());
+		$action_id = ActionScheduler::factory()->cron($random, array(), null, '0 0 * * *');
 		$store     = ActionScheduler::store();
-		$runner    = ActionScheduler_Mocker::get_queue_runner( $store );
+		$runner    = ActionScheduler_Mocker::get_queue_runner($store);
 
 		// Make sure the 1st instance of the action is scheduled to occur tomorrow
-		$date = as_get_datetime_object( 'tomorrow' );
-		$date->modify( '-1 minute' );
-		$claim = $store->stake_claim( 10, $date );
-		$this->assertCount( 0, $claim->get_actions() );
+		$date = as_get_datetime_object('tomorrow');
+		$date->modify('-1 minute');
+		$claim = $store->stake_claim(10, $date);
+		$this->assertCount(0, $claim->get_actions());
 
-		$store->release_claim( $claim );
+		$store->release_claim($claim);
 
-		$date->modify( '+1 minute' );
+		$date->modify('+1 minute');
 
-		$claim   = $store->stake_claim( 10, $date );
+		$claim   = $store->stake_claim(10, $date);
 		$actions = $claim->get_actions();
-		$this->assertCount( 1, $actions );
+		$this->assertCount(1, $actions);
 
-		$fetched_action_id = reset( $actions );
-		$fetched_action    = $store->fetch_action( $fetched_action_id );
+		$fetched_action_id = reset($actions);
+		$fetched_action    = $store->fetch_action($fetched_action_id);
 
-		$this->assertEquals( $fetched_action_id, $action_id );
-		$this->assertEquals( $random, $fetched_action->get_hook() );
-		$this->assertEquals( $date->getTimestamp(), $fetched_action->get_schedule()->get_date()->getTimestamp(), '', 1 );
+		$this->assertEquals($fetched_action_id, $action_id);
+		$this->assertEquals($random, $fetched_action->get_hook());
+		$this->assertEquals($date->getTimestamp(), $fetched_action->get_schedule()->get_date()->getTimestamp(), '', 1);
 
-		$store->release_claim( $claim );
+		$store->release_claim($claim);
 
 		// Make sure the 2nd instance of the cron action is scheduled to occur tomorrow still
-		$runner->process_action( $action_id );
+		$runner->process_action($action_id);
 
-		$claim   = $store->stake_claim( 10, $date );
+		$claim   = $store->stake_claim(10, $date);
 		$actions = $claim->get_actions();
-		$this->assertCount( 1, $actions );
+		$this->assertCount(1, $actions);
 
-		$fetched_action_id = reset( $actions );
-		$fetched_action    = $store->fetch_action( $fetched_action_id );
+		$fetched_action_id = reset($actions);
+		$fetched_action    = $store->fetch_action($fetched_action_id);
 
-		$this->assertNotEquals( $fetched_action_id, $action_id );
-		$this->assertEquals( $random, $fetched_action->get_hook() );
-		$this->assertEquals( $date->getTimestamp(), $fetched_action->get_schedule()->get_date()->getTimestamp(), '', 1 );
+		$this->assertNotEquals($fetched_action_id, $action_id);
+		$this->assertEquals($random, $fetched_action->get_hook());
+		$this->assertEquals($date->getTimestamp(), $fetched_action->get_schedule()->get_date()->getTimestamp(), '', 1);
 	}
 
 	public function test_next_instance_of_interval_action() {
 		// Create an action to recur every 24 hours, with the first instance scheduled to run 12 hours ago
-		$random    = md5( rand() );
-		$date      = as_get_datetime_object( '12 hours ago' );
-		$action_id = ActionScheduler::factory()->recurring( $random, array(), $date->getTimestamp(), DAY_IN_SECONDS );
+		$random    = md5(rand());
+		$date      = as_get_datetime_object('12 hours ago');
+		$action_id = ActionScheduler::factory()->recurring($random, array(), $date->getTimestamp(), DAY_IN_SECONDS);
 		$store     = ActionScheduler::store();
-		$runner    = ActionScheduler_Mocker::get_queue_runner( $store );
+		$runner    = ActionScheduler_Mocker::get_queue_runner($store);
 
 		// Make sure the 1st instance of the action is scheduled to occur 12 hours ago
-		$claim   = $store->stake_claim( 10, $date );
+		$claim   = $store->stake_claim(10, $date);
 		$actions = $claim->get_actions();
-		$this->assertCount( 1, $actions );
+		$this->assertCount(1, $actions);
 
-		$fetched_action_id = reset( $actions );
-		$fetched_action    = $store->fetch_action( $fetched_action_id );
+		$fetched_action_id = reset($actions);
+		$fetched_action    = $store->fetch_action($fetched_action_id);
 
-		$this->assertEquals( $fetched_action_id, $action_id );
-		$this->assertEquals( $random, $fetched_action->get_hook() );
-		$this->assertEquals( $date->getTimestamp(), $fetched_action->get_schedule()->get_date()->getTimestamp(), '', 1 );
+		$this->assertEquals($fetched_action_id, $action_id);
+		$this->assertEquals($random, $fetched_action->get_hook());
+		$this->assertEquals($date->getTimestamp(), $fetched_action->get_schedule()->get_date()->getTimestamp(), '', 1);
 
-		$store->release_claim( $claim );
+		$store->release_claim($claim);
 
 		// Make sure after the queue is run, the 2nd instance of the action is scheduled to occur in 24 hours
 		$runner->run();
 
-		$date    = as_get_datetime_object( '+1 day' );
-		$claim   = $store->stake_claim( 10, $date );
+		$date    = as_get_datetime_object('+1 day');
+		$claim   = $store->stake_claim(10, $date);
 		$actions = $claim->get_actions();
-		$this->assertCount( 1, $actions );
+		$this->assertCount(1, $actions);
 
-		$fetched_action_id = reset( $actions );
-		$fetched_action    = $store->fetch_action( $fetched_action_id );
+		$fetched_action_id = reset($actions);
+		$fetched_action    = $store->fetch_action($fetched_action_id);
 
-		$this->assertNotEquals( $fetched_action_id, $action_id );
-		$this->assertEquals( $random, $fetched_action->get_hook() );
-		$this->assertEquals( $date->getTimestamp(), $fetched_action->get_schedule()->get_date()->getTimestamp(), '', 1 );
+		$this->assertNotEquals($fetched_action_id, $action_id);
+		$this->assertEquals($random, $fetched_action->get_hook());
+		$this->assertEquals($date->getTimestamp(), $fetched_action->get_schedule()->get_date()->getTimestamp(), '', 1);
 
-		$store->release_claim( $claim );
+		$store->release_claim($claim);
 
 		// Make sure the 3rd instance of the cron action is scheduled for 24 hours from now, as the action was run early, ahead of schedule
-		$runner->process_action( $fetched_action_id );
-		$date = as_get_datetime_object( '+1 day' );
+		$runner->process_action($fetched_action_id);
+		$date = as_get_datetime_object('+1 day');
 
-		$claim   = $store->stake_claim( 10, $date );
+		$claim   = $store->stake_claim(10, $date);
 		$actions = $claim->get_actions();
-		$this->assertCount( 1, $actions );
+		$this->assertCount(1, $actions);
 
-		$fetched_action_id = reset( $actions );
-		$fetched_action    = $store->fetch_action( $fetched_action_id );
+		$fetched_action_id = reset($actions);
+		$fetched_action    = $store->fetch_action($fetched_action_id);
 
-		$this->assertNotEquals( $fetched_action_id, $action_id );
-		$this->assertEquals( $random, $fetched_action->get_hook() );
-		$this->assertEquals( $date->getTimestamp(), $fetched_action->get_schedule()->get_date()->getTimestamp(), '', 1 );
+		$this->assertNotEquals($fetched_action_id, $action_id);
+		$this->assertEquals($random, $fetched_action->get_hook());
+		$this->assertEquals($date->getTimestamp(), $fetched_action->get_schedule()->get_date()->getTimestamp(), '', 1);
 	}
 
 	/**
@@ -192,44 +192,44 @@ 
 	 */
 	public function test_failing_recurring_actions_are_not_rescheduled_when_threshold_met() {
 		$store           = ActionScheduler_Store::instance();
-		$runner          = ActionScheduler_Mocker::get_queue_runner( $store );
+		$runner          = ActionScheduler_Mocker::get_queue_runner($store);
 		$created_actions = array();
 
 		// Create 4 failed actions (one below the threshold of what counts as 'consistently failing').
-		for ( $i = 0; $i < 3; $i++ ) {
+		for ($i = 0; $i < 3; $i++) {
 			// We give each action a unique set of args, this illustrates that in the context of determining consistent
 			// failure we care only about the hook and not other properties of the action.
-			$args      = array( 'unique-' . $i => hash( 'md5', $i ) );
+			$args      = array('unique-'.$i => hash('md5', $i));
 			$hook      = 'will-fail';
-			$date      = as_get_datetime_object( 12 - $i . ' hours ago' );
-			$action_id = as_schedule_recurring_action( $date->getTimestamp(), HOUR_IN_SECONDS, $hook, $args );
-			$store->mark_failure( $action_id );
+			$date      = as_get_datetime_object(12 - $i.' hours ago');
+			$action_id = as_schedule_recurring_action($date->getTimestamp(), HOUR_IN_SECONDS, $hook, $args);
+			$store->mark_failure($action_id);
 			$created_actions[] = $action_id;
 		}
 
 		// Now create a further action using the same hook, that is also destined to fail.
-		$date              = as_get_datetime_object( '6 hours ago' );
-		$pending_action_id = as_schedule_recurring_action( $date->getTimestamp(), HOUR_IN_SECONDS, $hook, $args );
+		$date              = as_get_datetime_object('6 hours ago');
+		$pending_action_id = as_schedule_recurring_action($date->getTimestamp(), HOUR_IN_SECONDS, $hook, $args);
 		$created_actions[] = $pending_action_id;
 
 		// Process the queue!
 		$runner->run();
-		$pending_actions       = $store->query_actions(
+		$pending_actions = $store->query_actions(
 			array(
 				'hook'   => $hook,
 				'args'   => $args,
 				'status' => ActionScheduler_Store::STATUS_PENDING,
 			)
 		);
-		$new_pending_action_id = current( $pending_actions );
+		$new_pending_action_id = current($pending_actions);
 
 		// We now have 5 instances of the same recurring action. 4 have already failed, one is pending.
-		$this->assertCount( 1, $pending_actions, 'If the threshold for consistent failure has not been met, a replacement action should have been scheduled.' );
-		$this->assertNotContains( $new_pending_action_id, $created_actions, 'Confirm that the replacement action is new, and not one of those we created manually earlier in the test.' );
+		$this->assertCount(1, $pending_actions, 'If the threshold for consistent failure has not been met, a replacement action should have been scheduled.');
+		$this->assertNotContains($new_pending_action_id, $created_actions, 'Confirm that the replacement action is new, and not one of those we created manually earlier in the test.');
 
 		// Process the pending action (we do this directly instead of via `$runner->run()` because it won't actually
 		// become due for another hour).
-		$runner->process_action( $new_pending_action_id );
+		$runner->process_action($new_pending_action_id);
 		$pending_actions = $store->query_actions(
 			array(
 				'hook'   => $hook,
@@ -240,97 +240,97 @@ 
 
 		// Now 5 instances of the same recurring action have all failed, therefore the threshold for consistent failure
 		// has been met and, this time, a new action should *not* have been scheduled.
-		$this->assertCount( 0, $pending_actions, 'The failure threshold (5 consecutive fails for recurring actions with the same signature) having been met, no further actions were scheduled.' );
+		$this->assertCount(0, $pending_actions, 'The failure threshold (5 consecutive fails for recurring actions with the same signature) having been met, no further actions were scheduled.');
 	}
 
 	public function test_hooked_into_wp_cron() {
-		$next = wp_next_scheduled( ActionScheduler_QueueRunner::WP_CRON_HOOK, array( 'WP Cron' ) );
-		$this->assertNotEmpty( $next );
+		$next = wp_next_scheduled(ActionScheduler_QueueRunner::WP_CRON_HOOK, array('WP Cron'));
+		$this->assertNotEmpty($next);
 	}
 
 	public function test_batch_count_limit() {
 		$store  = ActionScheduler::store();
-		$runner = ActionScheduler_Mocker::get_queue_runner( $store );
+		$runner = ActionScheduler_Mocker::get_queue_runner($store);
 
 		$mock   = new MockAction();
-		$random = md5( rand() );
-		add_action( $random, array( $mock, 'action' ) );
-		$schedule = new ActionScheduler_SimpleSchedule( new ActionScheduler_DateTime( '1 day ago' ) );
+		$random = md5(rand());
+		add_action($random, array($mock, 'action'));
+		$schedule = new ActionScheduler_SimpleSchedule(new ActionScheduler_DateTime('1 day ago'));
 
-		for ( $i = 0; $i < 2; $i++ ) {
-			$action = new ActionScheduler_Action( $random, array( $random ), $schedule );
-			$store->save_action( $action );
+		for ($i = 0; $i < 2; $i++) {
+			$action = new ActionScheduler_Action($random, array($random), $schedule);
+			$store->save_action($action);
 		}
 
 		$claim = $store->stake_claim();
 
 		$actions_run = $runner->run();
 
-		$this->assertSame( 0, $mock->get_call_count() );
-		$this->assertSame( 0, $actions_run );
+		$this->assertSame(0, $mock->get_call_count());
+		$this->assertSame(0, $actions_run);
 
-		$store->release_claim( $claim );
+		$store->release_claim($claim);
 
 		$actions_run = $runner->run();
 
-		$this->assertEquals( 2, $mock->get_call_count() );
-		$this->assertEquals( 2, $actions_run );
+		$this->assertEquals(2, $mock->get_call_count());
+		$this->assertEquals(2, $actions_run);
 
-		remove_action( $random, array( $mock, 'action' ) );
+		remove_action($random, array($mock, 'action'));
 	}
 
 	public function test_changing_batch_count_limit() {
 		$store  = ActionScheduler::store();
-		$runner = ActionScheduler_Mocker::get_queue_runner( $store );
+		$runner = ActionScheduler_Mocker::get_queue_runner($store);
 
-		$random   = md5( rand() );
-		$schedule = new ActionScheduler_SimpleSchedule( new ActionScheduler_DateTime( '1 day ago' ) );
+		$random   = md5(rand());
+		$schedule = new ActionScheduler_SimpleSchedule(new ActionScheduler_DateTime('1 day ago'));
 
-		for ( $i = 0; $i < 30; $i++ ) {
-			$action = new ActionScheduler_Action( $random, array( $random ), $schedule );
-			$store->save_action( $action );
+		for ($i = 0; $i < 30; $i++) {
+			$action = new ActionScheduler_Action($random, array($random), $schedule);
+			$store->save_action($action);
 		}
 
 		$claims = array();
 
-		for ( $i = 0; $i < 5; $i++ ) {
-			$claims[] = $store->stake_claim( 5 );
+		for ($i = 0; $i < 5; $i++) {
+			$claims[] = $store->stake_claim(5);
 		}
 
 		$mock1 = new MockAction();
-		add_action( $random, array( $mock1, 'action' ) );
+		add_action($random, array($mock1, 'action'));
 		$actions_run = $runner->run();
-		remove_action( $random, array( $mock1, 'action' ) );
+		remove_action($random, array($mock1, 'action'));
 
-		$this->assertSame( 0, $mock1->get_call_count() );
-		$this->assertSame( 0, $actions_run );
+		$this->assertSame(0, $mock1->get_call_count());
+		$this->assertSame(0, $actions_run);
 
-		add_filter( 'action_scheduler_queue_runner_concurrent_batches', array( $this, 'return_6' ) );
+		add_filter('action_scheduler_queue_runner_concurrent_batches', array($this, 'return_6'));
 
 		$mock2 = new MockAction();
-		add_action( $random, array( $mock2, 'action' ) );
+		add_action($random, array($mock2, 'action'));
 		$actions_run = $runner->run();
-		remove_action( $random, array( $mock2, 'action' ) );
+		remove_action($random, array($mock2, 'action'));
 
-		$this->assertEquals( 5, $mock2->get_call_count() );
-		$this->assertEquals( 5, $actions_run );
+		$this->assertEquals(5, $mock2->get_call_count());
+		$this->assertEquals(5, $actions_run);
 
-		remove_filter( 'action_scheduler_queue_runner_concurrent_batches', array( $this, 'return_6' ) );
+		remove_filter('action_scheduler_queue_runner_concurrent_batches', array($this, 'return_6'));
 
-		for ( $i = 0; $i < 5; $i++ ) { // to make up for the actions we just processed
-			$action = new ActionScheduler_Action( $random, array( $random ), $schedule );
-			$store->save_action( $action );
+		for ($i = 0; $i < 5; $i++) { // to make up for the actions we just processed
+			$action = new ActionScheduler_Action($random, array($random), $schedule);
+			$store->save_action($action);
 		}
 
 		$mock3 = new MockAction();
-		add_action( $random, array( $mock3, 'action' ) );
+		add_action($random, array($mock3, 'action'));
 		$actions_run = $runner->run();
-		remove_action( $random, array( $mock3, 'action' ) );
+		remove_action($random, array($mock3, 'action'));
 
-		$this->assertSame( 0, $mock3->get_call_count() );
-		$this->assertSame( 0, $actions_run );
+		$this->assertSame(0, $mock3->get_call_count());
+		$this->assertSame(0, $actions_run);
 
-		remove_filter( 'action_scheduler_queue_runner_concurrent_batches', array( $this, 'return_6' ) );
+		remove_filter('action_scheduler_queue_runner_concurrent_batches', array($this, 'return_6'));
 	}
 
 	public function return_6() {
@@ -338,54 +338,54 @@ 
 	}
 
 	public function test_store_fetch_action_failure_schedule_next_instance() {
-		$random    = md5( rand() );
-		$schedule  = new ActionScheduler_IntervalSchedule( as_get_datetime_object( '12 hours ago' ), DAY_IN_SECONDS );
-		$action    = new ActionScheduler_Action( $random, array(), $schedule );
-		$action_id = ActionScheduler::store()->save_action( $action );
+		$random    = md5(rand());
+		$schedule  = new ActionScheduler_IntervalSchedule(as_get_datetime_object('12 hours ago'), DAY_IN_SECONDS);
+		$action    = new ActionScheduler_Action($random, array(), $schedule);
+		$action_id = ActionScheduler::store()->save_action($action);
 
 		// Set up a mock store that will throw an exception when fetching actions.
 		$store = $this
-					->getMockBuilder( 'ActionScheduler_wpPostStore' )
-					->setMethods( array( 'fetch_action' ) )
+					->getMockBuilder('ActionScheduler_wpPostStore')
+					->setMethods(array('fetch_action'))
 					->getMock();
 		$store
-			->method( 'fetch_action' )
-			->with( array( $action_id ) )
-			->will( $this->throwException( new Exception() ) );
+			->method('fetch_action')
+			->with(array($action_id))
+			->will($this->throwException(new Exception()));
 
 		// Set up a mock queue runner to verify that schedule_next_instance()
 		// isn't called for an undefined $action.
 		$runner = $this
-					->getMockBuilder( 'ActionScheduler_QueueRunner' )
-					->setConstructorArgs( array( $store ) )
-					->setMethods( array( 'schedule_next_instance' ) )
+					->getMockBuilder('ActionScheduler_QueueRunner')
+					->setConstructorArgs(array($store))
+					->setMethods(array('schedule_next_instance'))
 					->getMock();
 		$runner
-			->expects( $this->never() )
-			->method( 'schedule_next_instance' );
+			->expects($this->never())
+			->method('schedule_next_instance');
 
 		$runner->run();
 
 		// Set up a mock store that will throw an exception when fetching actions.
 		$store2 = $this
-					->getMockBuilder( 'ActionScheduler_wpPostStore' )
-					->setMethods( array( 'fetch_action' ) )
+					->getMockBuilder('ActionScheduler_wpPostStore')
+					->setMethods(array('fetch_action'))
 					->getMock();
 		$store2
-			->method( 'fetch_action' )
-			->with( array( $action_id ) )
-			->willReturn( null );
+			->method('fetch_action')
+			->with(array($action_id))
+			->willReturn(null);
 
 		// Set up a mock queue runner to verify that schedule_next_instance()
 		// isn't called for an undefined $action.
 		$runner2 = $this
-					->getMockBuilder( 'ActionScheduler_QueueRunner' )
-					->setConstructorArgs( array( $store ) )
-					->setMethods( array( 'schedule_next_instance' ) )
+					->getMockBuilder('ActionScheduler_QueueRunner')
+					->setConstructorArgs(array($store))
+					->setMethods(array('schedule_next_instance'))
 					->getMock();
 		$runner2
-			->expects( $this->never() )
-			->method( 'schedule_next_instance' );
+			->expects($this->never())
+			->method('schedule_next_instance');
 
 		$runner2->run();
 	}