Wordlift\Videoobject\Api\Rest_Controller

Complexity

Total Complexity

10

Size/Duplication

Total Lines	89
Duplicated Lines	53.93 %

Coupling/Cohesion

Components	0
Dependencies	3

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	register_all_routes()	0	7	1
A	get_all_videos()	0	7	1
A	save_all_videos()	0	18	3
A	register_get_all_videos_route()	21	21	2
A	register_save_all_videos_route()	27	27	3

<?php
/**
 * @since 3.31.0
 * @author Naveen Muthusamy <naveen@wordlift.io>
 */

namespace Wordlift\Videoobject\Api;

use Wordlift\Videoobject\Data\Video_Storage\Video_Storage_Factory;
use Wordlift\Videoobject\Data\Video\Video;
use WP_REST_Server;

class Rest_Controller {

	public function register_all_routes() {
		$that = $this;
		add_action( 'rest_api_init', function () use ( $that ) {
			$that->register_get_all_videos_route();
			$that->register_save_all_videos_route();
		} );
	}

	public function get_all_videos( $request ) {
		$data    = $request->get_params();
		$post_id = (int) $data['post_id'];
		$storage = Video_Storage_Factory::get_storage();

		return $storage->get_all_videos( $post_id );
	}

	public function save_all_videos( $request ) {
		$data    = $request->get_params();
		$post_id = (int) $data['post_id'];
		$videos  = (array) $data['videos'];
		if ( ! $videos ) {

The expression $videos of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

			return;
		}
		$storage = Video_Storage_Factory::get_storage();
		$storage->remove_all_videos( $post_id );

		foreach ( $videos as $video ) {
			$video_obj = new Video();
			$video_obj->from( (array) $video );
			$storage->add_video( $post_id, $video_obj );
		}


	}

	private function register_get_all_videos_route() {

This method seems to be duplicated in your project.

		register_rest_route(
			WL_REST_ROUTE_DEFAULT_NAMESPACE,
			'/videos',
			array(
				'methods'             => WP_REST_Server::CREATABLE,
				'callback'            => array( $this, 'get_all_videos' ),
				'permission_callback' => function () {
					return current_user_can( 'manage_options' );
				},
				'args'                => array(
					'post_id' => array(
						'validate_callback' => function ( $param, $request, $key ) {

The parameter $request is not used and could be removed.

The parameter $key is not used and could be removed.

							return is_numeric( $param ) && $param;
						},
						'required'          => true,
					),
				),
			)
		);
	}

	private function register_save_all_videos_route() {

This method seems to be duplicated in your project.

		register_rest_route(
			WL_REST_ROUTE_DEFAULT_NAMESPACE,
			'/videos/save',
			array(
				'methods'             => WP_REST_Server::CREATABLE,
				'callback'            => array( $this, 'save_all_videos' ),
				'permission_callback' => function () {
					return current_user_can( 'manage_options' );
				},
				'args'                => array(
					'post_id' => array(
						'validate_callback' => function ( $param, $request, $key ) {

The parameter $request is not used and could be removed.

The parameter $key is not used and could be removed.

							return is_numeric( $param ) && $param;
						},
						'required'          => true,
					),
					'videos'  => array(
						'validate_callback' => function ( $param, $request, $key ) {

The parameter $request is not used and could be removed.

The parameter $key is not used and could be removed.

							return is_array( $param ) && $param;

The expression $param of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

						},
						'required'          => true,
					),
				),
			)
		);
	}


}