insideout10 / wordlift-plugin

src/libraries/action-scheduler/tests/phpunit/migration/Config_Test.php

Indentation +20 added lines, -20 removed lines

@@ -8,27 +8,27 @@
  * @group migration
  */
 class Config_Test extends ActionScheduler_UnitTestCase {
-	public function test_source_store_required() {
-		$config = new Config();
-		$this->expectException( \RuntimeException::class );
-		$config->get_source_store();
-	}
+    public function test_source_store_required() {
+        $config = new Config();
+        $this->expectException( \RuntimeException::class );
+        $config->get_source_store();
+    }
 
-	public function test_source_logger_required() {
-		$config = new Config();
-		$this->expectException( \RuntimeException::class );
-		$config->get_source_logger();
-	}
+    public function test_source_logger_required() {
+        $config = new Config();
+        $this->expectException( \RuntimeException::class );
+        $config->get_source_logger();
+    }
 
-	public function test_destination_store_required() {
-		$config = new Config();
-		$this->expectException( \RuntimeException::class );
-		$config->get_destination_store();
-	}
+    public function test_destination_store_required() {
+        $config = new Config();
+        $this->expectException( \RuntimeException::class );
+        $config->get_destination_store();
+    }
 
-	public function test_destination_logger_required() {
-		$config = new Config();
-		$this->expectException( \RuntimeException::class );
-		$config->get_destination_logger();
-	}
+    public function test_destination_logger_required() {
+        $config = new Config();
+        $this->expectException( \RuntimeException::class );
+        $config->get_destination_logger();
+    }
 }

Spacing +4 added lines, -4 removed lines

@@ -10,25 +10,25 @@
 class Config_Test extends ActionScheduler_UnitTestCase {
 	public function test_source_store_required() {
 		$config = new Config();
-		$this->expectException( \RuntimeException::class );
+		$this->expectException(\RuntimeException::class);
 		$config->get_source_store();
 	}
 
 	public function test_source_logger_required() {
 		$config = new Config();
-		$this->expectException( \RuntimeException::class );
+		$this->expectException(\RuntimeException::class);
 		$config->get_source_logger();
 	}
 
 	public function test_destination_store_required() {
 		$config = new Config();
-		$this->expectException( \RuntimeException::class );
+		$this->expectException(\RuntimeException::class);
 		$config->get_destination_store();
 	}
 
 	public function test_destination_logger_required() {
 		$config = new Config();
-		$this->expectException( \RuntimeException::class );
+		$this->expectException(\RuntimeException::class);
 		$config->get_destination_logger();
 	}
 }

src/libraries/action-scheduler/tests/phpunit/migration/Scheduler_Test.php

Indentation +135 added lines, -135 removed lines

@@ -9,139 +9,139 @@
  * @group migration
  */
 class Scheduler_Test extends ActionScheduler_UnitTestCase {
-	public function setUp() {
-		parent::setUp();
-		if ( ! taxonomy_exists( PostStore::GROUP_TAXONOMY ) ) {
-			// register the post type and taxonomy necessary for the store to work
-			$store = new PostStore();
-			$store->init();
-		}
-	}
-
-	public function test_migration_is_complete() {
-		ActionScheduler_DataController::mark_migration_complete();
-		$this->assertTrue( ActionScheduler_DataController::is_migration_complete() );
-	}
-
-	public function test_migration_is_not_complete() {
-		$this->assertFalse( ActionScheduler_DataController::is_migration_complete() );
-		update_option( ActionScheduler_DataController::STATUS_FLAG, 'something_random' );
-		$this->assertFalse( ActionScheduler_DataController::is_migration_complete() );
-	}
-
-	public function test_migration_is_scheduled() {
-		// Clear the any existing migration hooks that have already been setup.
-		as_unschedule_all_actions( Scheduler::HOOK );
-
-		$scheduler = new Scheduler();
-		$this->assertFalse(
-			$scheduler->is_migration_scheduled(),
-			'Migration is not automatically scheduled when a new ' . Scheduler::class . ' instance is created.'
-		);
-
-		$scheduler->schedule_migration();
-		$this->assertTrue(
-			$scheduler->is_migration_scheduled(),
-			'Migration is scheduled only after schedule_migration() has been called.'
-		);
-	}
-
-	public function test_scheduler_runs_migration() {
-		$source_store      = new PostStore();
-		$destination_store = new ActionScheduler_DBStore();
-
-		$return_5 = function () {
-			return 5;
-		};
-		add_filter( 'action_scheduler/migration_batch_size', $return_5 );
-
-		// Make sure successive migration actions are delayed so all actions aren't migrated at once on separate hooks
-		$return_60 = function () {
-			return 60;
-		};
-		add_filter( 'action_scheduler/migration_interval', $return_60 );
-
-		for ( $i = 0; $i < 10; $i ++ ) {
-			$time     = as_get_datetime_object( $i + 1 . ' minutes' );
-			$schedule = new ActionScheduler_SimpleSchedule( $time );
-			$action   = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule );
-			$future[] = $source_store->save_action( $action );
-
-			$time     = as_get_datetime_object( $i + 1 . ' minutes ago' );
-			$schedule = new ActionScheduler_SimpleSchedule( $time );
-			$action   = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule );
-			$due[]    = $source_store->save_action( $action );
-		}
-
-		$this->assertCount( 20, $source_store->query_actions( array( 'per_page' => 0 ) ) );
-
-		$scheduler = new Scheduler();
-		$scheduler->unschedule_migration();
-		$scheduler->schedule_migration( time() - 1 );
-
-		$queue_runner = ActionScheduler_Mocker::get_queue_runner( $destination_store );
-		$queue_runner->run();
-
-		// 5 actions should have moved from the source store when the queue runner triggered the migration action
-		$this->assertCount(
-			15,
-			$source_store->query_actions(
-				array(
-					'per_page' => 0,
-					'hook'     => ActionScheduler_Callbacks::HOOK_WITH_CALLBACK,
-				)
-			)
-		);
-
-		remove_filter( 'action_scheduler/migration_batch_size', $return_5 );
-		remove_filter( 'action_scheduler/migration_interval', $return_60 );
-	}
-
-	public function test_scheduler_marks_itself_complete() {
-		$source_store      = new PostStore();
-		$destination_store = new ActionScheduler_DBStore();
-
-		for ( $i = 0; $i < 5; $i ++ ) {
-			$time     = as_get_datetime_object( $i + 1 . ' minutes ago' );
-			$schedule = new ActionScheduler_SimpleSchedule( $time );
-			$action   = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule );
-			$due[]    = $source_store->save_action( $action );
-		}
-
-		$this->assertCount( 5, $source_store->query_actions( array( 'per_page' => 0 ) ) );
-
-		$scheduler = new Scheduler();
-		$scheduler->unschedule_migration();
-		$scheduler->schedule_migration( time() - 1 );
-
-		$queue_runner = ActionScheduler_Mocker::get_queue_runner( $destination_store );
-		$queue_runner->run();
-
-		// All actions should have moved from the source store when the queue runner triggered the migration action
-		$this->assertCount(
-			0,
-			$source_store->query_actions(
-				array(
-					'per_page' => 0,
-					'hook'     => ActionScheduler_Callbacks::HOOK_WITH_CALLBACK,
-				)
-			)
-		);
-
-		// schedule another so we can get it to run immediately
-		$scheduler->unschedule_migration();
-		$scheduler->schedule_migration( time() - 1 );
-
-		// run again so it knows that there's nothing left to process
-		$queue_runner->run();
-
-		$scheduler->unhook();
-
-		// ensure the flag is set marking migration as complete
-		$this->assertTrue( ActionScheduler_DataController::is_migration_complete() );
-
-		// ensure that another instance has not been scheduled
-		$this->assertFalse( $scheduler->is_migration_scheduled() );
-
-	}
+    public function setUp() {
+        parent::setUp();
+        if ( ! taxonomy_exists( PostStore::GROUP_TAXONOMY ) ) {
+            // register the post type and taxonomy necessary for the store to work
+            $store = new PostStore();
+            $store->init();
+        }
+    }
+
+    public function test_migration_is_complete() {
+        ActionScheduler_DataController::mark_migration_complete();
+        $this->assertTrue( ActionScheduler_DataController::is_migration_complete() );
+    }
+
+    public function test_migration_is_not_complete() {
+        $this->assertFalse( ActionScheduler_DataController::is_migration_complete() );
+        update_option( ActionScheduler_DataController::STATUS_FLAG, 'something_random' );
+        $this->assertFalse( ActionScheduler_DataController::is_migration_complete() );
+    }
+
+    public function test_migration_is_scheduled() {
+        // Clear the any existing migration hooks that have already been setup.
+        as_unschedule_all_actions( Scheduler::HOOK );
+
+        $scheduler = new Scheduler();
+        $this->assertFalse(
+            $scheduler->is_migration_scheduled(),
+            'Migration is not automatically scheduled when a new ' . Scheduler::class . ' instance is created.'
+        );
+
+        $scheduler->schedule_migration();
+        $this->assertTrue(
+            $scheduler->is_migration_scheduled(),
+            'Migration is scheduled only after schedule_migration() has been called.'
+        );
+    }
+
+    public function test_scheduler_runs_migration() {
+        $source_store      = new PostStore();
+        $destination_store = new ActionScheduler_DBStore();
+
+        $return_5 = function () {
+            return 5;
+        };
+        add_filter( 'action_scheduler/migration_batch_size', $return_5 );
+
+        // Make sure successive migration actions are delayed so all actions aren't migrated at once on separate hooks
+        $return_60 = function () {
+            return 60;
+        };
+        add_filter( 'action_scheduler/migration_interval', $return_60 );
+
+        for ( $i = 0; $i < 10; $i ++ ) {
+            $time     = as_get_datetime_object( $i + 1 . ' minutes' );
+            $schedule = new ActionScheduler_SimpleSchedule( $time );
+            $action   = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule );
+            $future[] = $source_store->save_action( $action );
+
+            $time     = as_get_datetime_object( $i + 1 . ' minutes ago' );
+            $schedule = new ActionScheduler_SimpleSchedule( $time );
+            $action   = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule );
+            $due[]    = $source_store->save_action( $action );
+        }
+
+        $this->assertCount( 20, $source_store->query_actions( array( 'per_page' => 0 ) ) );
+
+        $scheduler = new Scheduler();
+        $scheduler->unschedule_migration();
+        $scheduler->schedule_migration( time() - 1 );
+
+        $queue_runner = ActionScheduler_Mocker::get_queue_runner( $destination_store );
+        $queue_runner->run();
+
+        // 5 actions should have moved from the source store when the queue runner triggered the migration action
+        $this->assertCount(
+            15,
+            $source_store->query_actions(
+                array(
+                    'per_page' => 0,
+                    'hook'     => ActionScheduler_Callbacks::HOOK_WITH_CALLBACK,
+                )
+            )
+        );
+
+        remove_filter( 'action_scheduler/migration_batch_size', $return_5 );
+        remove_filter( 'action_scheduler/migration_interval', $return_60 );
+    }
+
+    public function test_scheduler_marks_itself_complete() {
+        $source_store      = new PostStore();
+        $destination_store = new ActionScheduler_DBStore();
+
+        for ( $i = 0; $i < 5; $i ++ ) {
+            $time     = as_get_datetime_object( $i + 1 . ' minutes ago' );
+            $schedule = new ActionScheduler_SimpleSchedule( $time );
+            $action   = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule );
+            $due[]    = $source_store->save_action( $action );
+        }
+
+        $this->assertCount( 5, $source_store->query_actions( array( 'per_page' => 0 ) ) );
+
+        $scheduler = new Scheduler();
+        $scheduler->unschedule_migration();
+        $scheduler->schedule_migration( time() - 1 );
+
+        $queue_runner = ActionScheduler_Mocker::get_queue_runner( $destination_store );
+        $queue_runner->run();
+
+        // All actions should have moved from the source store when the queue runner triggered the migration action
+        $this->assertCount(
+            0,
+            $source_store->query_actions(
+                array(
+                    'per_page' => 0,
+                    'hook'     => ActionScheduler_Callbacks::HOOK_WITH_CALLBACK,
+                )
+            )
+        );
+
+        // schedule another so we can get it to run immediately
+        $scheduler->unschedule_migration();
+        $scheduler->schedule_migration( time() - 1 );
+
+        // run again so it knows that there's nothing left to process
+        $queue_runner->run();
+
+        $scheduler->unhook();
+
+        // ensure the flag is set marking migration as complete
+        $this->assertTrue( ActionScheduler_DataController::is_migration_complete() );
+
+        // ensure that another instance has not been scheduled
+        $this->assertFalse( $scheduler->is_migration_scheduled() );
+
+    }
 }

Spacing +38 added lines, -38 removed lines

@@ -11,7 +11,7 @@ 
 class Scheduler_Test extends ActionScheduler_UnitTestCase {
 	public function setUp() {
 		parent::setUp();
-		if ( ! taxonomy_exists( PostStore::GROUP_TAXONOMY ) ) {
+		if ( ! taxonomy_exists(PostStore::GROUP_TAXONOMY)) {
 			// register the post type and taxonomy necessary for the store to work
 			$store = new PostStore();
 			$store->init();
@@ -20,23 +20,23 @@ 
 
 	public function test_migration_is_complete() {
 		ActionScheduler_DataController::mark_migration_complete();
-		$this->assertTrue( ActionScheduler_DataController::is_migration_complete() );
+		$this->assertTrue(ActionScheduler_DataController::is_migration_complete());
 	}
 
 	public function test_migration_is_not_complete() {
-		$this->assertFalse( ActionScheduler_DataController::is_migration_complete() );
-		update_option( ActionScheduler_DataController::STATUS_FLAG, 'something_random' );
-		$this->assertFalse( ActionScheduler_DataController::is_migration_complete() );
+		$this->assertFalse(ActionScheduler_DataController::is_migration_complete());
+		update_option(ActionScheduler_DataController::STATUS_FLAG, 'something_random');
+		$this->assertFalse(ActionScheduler_DataController::is_migration_complete());
 	}
 
 	public function test_migration_is_scheduled() {
 		// Clear the any existing migration hooks that have already been setup.
-		as_unschedule_all_actions( Scheduler::HOOK );
+		as_unschedule_all_actions(Scheduler::HOOK);
 
 		$scheduler = new Scheduler();
 		$this->assertFalse(
 			$scheduler->is_migration_scheduled(),
-			'Migration is not automatically scheduled when a new ' . Scheduler::class . ' instance is created.'
+			'Migration is not automatically scheduled when a new '.Scheduler::class.' instance is created.'
 		);
 
 		$scheduler->schedule_migration();
@@ -50,36 +50,36 @@ 
 		$source_store      = new PostStore();
 		$destination_store = new ActionScheduler_DBStore();
 
-		$return_5 = function () {
+		$return_5 = function() {
 			return 5;
 		};
-		add_filter( 'action_scheduler/migration_batch_size', $return_5 );
+		add_filter('action_scheduler/migration_batch_size', $return_5);
 
 		// Make sure successive migration actions are delayed so all actions aren't migrated at once on separate hooks
-		$return_60 = function () {
+		$return_60 = function() {
 			return 60;
 		};
-		add_filter( 'action_scheduler/migration_interval', $return_60 );
-
-		for ( $i = 0; $i < 10; $i ++ ) {
-			$time     = as_get_datetime_object( $i + 1 . ' minutes' );
-			$schedule = new ActionScheduler_SimpleSchedule( $time );
-			$action   = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule );
-			$future[] = $source_store->save_action( $action );
-
-			$time     = as_get_datetime_object( $i + 1 . ' minutes ago' );
-			$schedule = new ActionScheduler_SimpleSchedule( $time );
-			$action   = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule );
-			$due[]    = $source_store->save_action( $action );
+		add_filter('action_scheduler/migration_interval', $return_60);
+
+		for ($i = 0; $i < 10; $i++) {
+			$time     = as_get_datetime_object($i + 1.' minutes');
+			$schedule = new ActionScheduler_SimpleSchedule($time);
+			$action   = new ActionScheduler_Action(ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule);
+			$future[] = $source_store->save_action($action);
+
+			$time     = as_get_datetime_object($i + 1.' minutes ago');
+			$schedule = new ActionScheduler_SimpleSchedule($time);
+			$action   = new ActionScheduler_Action(ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule);
+			$due[]    = $source_store->save_action($action);
 		}
 
-		$this->assertCount( 20, $source_store->query_actions( array( 'per_page' => 0 ) ) );
+		$this->assertCount(20, $source_store->query_actions(array('per_page' => 0)));
 
 		$scheduler = new Scheduler();
 		$scheduler->unschedule_migration();
-		$scheduler->schedule_migration( time() - 1 );
+		$scheduler->schedule_migration(time() - 1);
 
-		$queue_runner = ActionScheduler_Mocker::get_queue_runner( $destination_store );
+		$queue_runner = ActionScheduler_Mocker::get_queue_runner($destination_store);
 		$queue_runner->run();
 
 		// 5 actions should have moved from the source store when the queue runner triggered the migration action
@@ -93,28 +93,28 @@ 
 			)
 		);
 
-		remove_filter( 'action_scheduler/migration_batch_size', $return_5 );
-		remove_filter( 'action_scheduler/migration_interval', $return_60 );
+		remove_filter('action_scheduler/migration_batch_size', $return_5);
+		remove_filter('action_scheduler/migration_interval', $return_60);
 	}
 
 	public function test_scheduler_marks_itself_complete() {
 		$source_store      = new PostStore();
 		$destination_store = new ActionScheduler_DBStore();
 
-		for ( $i = 0; $i < 5; $i ++ ) {
-			$time     = as_get_datetime_object( $i + 1 . ' minutes ago' );
-			$schedule = new ActionScheduler_SimpleSchedule( $time );
-			$action   = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule );
-			$due[]    = $source_store->save_action( $action );
+		for ($i = 0; $i < 5; $i++) {
+			$time     = as_get_datetime_object($i + 1.' minutes ago');
+			$schedule = new ActionScheduler_SimpleSchedule($time);
+			$action   = new ActionScheduler_Action(ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule);
+			$due[]    = $source_store->save_action($action);
 		}
 
-		$this->assertCount( 5, $source_store->query_actions( array( 'per_page' => 0 ) ) );
+		$this->assertCount(5, $source_store->query_actions(array('per_page' => 0)));
 
 		$scheduler = new Scheduler();
 		$scheduler->unschedule_migration();
-		$scheduler->schedule_migration( time() - 1 );
+		$scheduler->schedule_migration(time() - 1);
 
-		$queue_runner = ActionScheduler_Mocker::get_queue_runner( $destination_store );
+		$queue_runner = ActionScheduler_Mocker::get_queue_runner($destination_store);
 		$queue_runner->run();
 
 		// All actions should have moved from the source store when the queue runner triggered the migration action
@@ -130,7 +130,7 @@ 
 
 		// schedule another so we can get it to run immediately
 		$scheduler->unschedule_migration();
-		$scheduler->schedule_migration( time() - 1 );
+		$scheduler->schedule_migration(time() - 1);
 
 		// run again so it knows that there's nothing left to process
 		$queue_runner->run();
@@ -138,10 +138,10 @@ 
 		$scheduler->unhook();
 
 		// ensure the flag is set marking migration as complete
-		$this->assertTrue( ActionScheduler_DataController::is_migration_complete() );
+		$this->assertTrue(ActionScheduler_DataController::is_migration_complete());
 
 		// ensure that another instance has not been scheduled
-		$this->assertFalse( $scheduler->is_migration_scheduled() );
+		$this->assertFalse($scheduler->is_migration_scheduled());
 
 	}
 }

src/libraries/action-scheduler/tests/phpunit/migration/ActionMigrator_Test.php

Indentation +133 added lines, -133 removed lines

@@ -9,137 +9,137 @@
  * @group migration
  */
 class ActionMigrator_Test extends ActionScheduler_UnitTestCase {
-	public function setUp() {
-		parent::setUp();
-		if ( ! taxonomy_exists( ActionScheduler_wpPostStore::GROUP_TAXONOMY ) ) {
-			// register the post type and taxonomy necessary for the store to work
-			$store = new ActionScheduler_wpPostStore();
-			$store->init();
-		}
-	}
-
-	public function test_migrate_from_wpPost_to_db() {
-		$source      = new ActionScheduler_wpPostStore();
-		$destination = new ActionScheduler_DBStore();
-		$migrator    = new ActionMigrator( $source, $destination, $this->get_log_migrator() );
-
-		$time      = as_get_datetime_object();
-		$schedule  = new ActionScheduler_SimpleSchedule( $time );
-		$action    = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule, 'my_group' );
-		$action_id = $source->save_action( $action );
-
-		$new_id = $migrator->migrate( $action_id );
-
-		// ensure we get the same record out of the new store as we stored in the old
-		$retrieved = $destination->fetch_action( $new_id );
-		$this->assertEquals( $action->get_hook(), $retrieved->get_hook() );
-		$this->assertEqualSets( $action->get_args(), $retrieved->get_args() );
-		$this->assertEquals( $action->get_schedule()->get_date()->format( 'U' ), $retrieved->get_schedule()->get_date()->format( 'U' ) );
-		$this->assertEquals( $action->get_group(), $retrieved->get_group() );
-		$this->assertEquals( \ActionScheduler_Store::STATUS_PENDING, $destination->get_status( $new_id ) );
-
-		// ensure that the record in the old store does not exist
-		$old_action = $source->fetch_action( $action_id );
-		$this->assertInstanceOf( 'ActionScheduler_NullAction', $old_action );
-	}
-
-	public function test_does_not_migrate_missing_action_from_wpPost_to_db() {
-		$source      = new ActionScheduler_wpPostStore();
-		$destination = new ActionScheduler_DBStore();
-		$migrator    = new ActionMigrator( $source, $destination, $this->get_log_migrator() );
-
-		$action_id = rand( 100, 100000 );
-
-		$new_id = $migrator->migrate( $action_id );
-		$this->assertSame( 0, $new_id );
-
-		// ensure we get the same record out of the new store as we stored in the old
-		$retrieved = $destination->fetch_action( $new_id );
-		$this->assertInstanceOf( 'ActionScheduler_NullAction', $retrieved );
-	}
-
-	public function test_migrate_completed_action_from_wpPost_to_db() {
-		$source      = new ActionScheduler_wpPostStore();
-		$destination = new ActionScheduler_DBStore();
-		$migrator    = new ActionMigrator( $source, $destination, $this->get_log_migrator() );
-
-		$time      = as_get_datetime_object();
-		$schedule  = new ActionScheduler_SimpleSchedule( $time );
-		$action    = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule, 'my_group' );
-		$action_id = $source->save_action( $action );
-		$source->mark_complete( $action_id );
-
-		$new_id = $migrator->migrate( $action_id );
-
-		// ensure we get the same record out of the new store as we stored in the old
-		$retrieved = $destination->fetch_action( $new_id );
-		$this->assertEquals( $action->get_hook(), $retrieved->get_hook() );
-		$this->assertEqualSets( $action->get_args(), $retrieved->get_args() );
-		$this->assertEquals( $action->get_schedule()->get_date()->format( 'U' ), $retrieved->get_schedule()->get_date()->format( 'U' ) );
-		$this->assertEquals( $action->get_group(), $retrieved->get_group() );
-		$this->assertTrue( $retrieved->is_finished() );
-		$this->assertEquals( \ActionScheduler_Store::STATUS_COMPLETE, $destination->get_status( $new_id ) );
-
-		// ensure that the record in the old store does not exist
-		$old_action = $source->fetch_action( $action_id );
-		$this->assertInstanceOf( 'ActionScheduler_NullAction', $old_action );
-	}
-
-	public function test_migrate_failed_action_from_wpPost_to_db() {
-		$source      = new ActionScheduler_wpPostStore();
-		$destination = new ActionScheduler_DBStore();
-		$migrator    = new ActionMigrator( $source, $destination, $this->get_log_migrator() );
-
-		$time      = as_get_datetime_object();
-		$schedule  = new ActionScheduler_SimpleSchedule( $time );
-		$action    = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule, 'my_group' );
-		$action_id = $source->save_action( $action );
-		$source->mark_failure( $action_id );
-
-		$new_id = $migrator->migrate( $action_id );
-
-		// ensure we get the same record out of the new store as we stored in the old
-		$retrieved = $destination->fetch_action( $new_id );
-		$this->assertEquals( $action->get_hook(), $retrieved->get_hook() );
-		$this->assertEqualSets( $action->get_args(), $retrieved->get_args() );
-		$this->assertEquals( $action->get_schedule()->get_date()->format( 'U' ), $retrieved->get_schedule()->get_date()->format( 'U' ) );
-		$this->assertEquals( $action->get_group(), $retrieved->get_group() );
-		$this->assertTrue( $retrieved->is_finished() );
-		$this->assertEquals( \ActionScheduler_Store::STATUS_FAILED, $destination->get_status( $new_id ) );
-
-		// ensure that the record in the old store does not exist
-		$old_action = $source->fetch_action( $action_id );
-		$this->assertInstanceOf( 'ActionScheduler_NullAction', $old_action );
-	}
-
-	public function test_migrate_canceled_action_from_wpPost_to_db() {
-		$source      = new ActionScheduler_wpPostStore();
-		$destination = new ActionScheduler_DBStore();
-		$migrator    = new ActionMigrator( $source, $destination, $this->get_log_migrator() );
-
-		$time      = as_get_datetime_object();
-		$schedule  = new ActionScheduler_SimpleSchedule( $time );
-		$action    = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule, 'my_group' );
-		$action_id = $source->save_action( $action );
-		$source->cancel_action( $action_id );
-
-		$new_id = $migrator->migrate( $action_id );
-
-		// ensure we get the same record out of the new store as we stored in the old
-		$retrieved = $destination->fetch_action( $new_id );
-		$this->assertEquals( $action->get_hook(), $retrieved->get_hook() );
-		$this->assertEqualSets( $action->get_args(), $retrieved->get_args() );
-		$this->assertEquals( $action->get_schedule()->get_date()->format( 'U' ), $retrieved->get_schedule()->get_date()->format( 'U' ) );
-		$this->assertEquals( $action->get_group(), $retrieved->get_group() );
-		$this->assertTrue( $retrieved->is_finished() );
-		$this->assertEquals( \ActionScheduler_Store::STATUS_CANCELED, $destination->get_status( $new_id ) );
-
-		// ensure that the record in the old store does not exist
-		$old_action = $source->fetch_action( $action_id );
-		$this->assertInstanceOf( 'ActionScheduler_NullAction', $old_action );
-	}
-
-	private function get_log_migrator() {
-		return new LogMigrator( \ActionScheduler::logger(), new ActionScheduler_DBLogger() );
-	}
+    public function setUp() {
+        parent::setUp();
+        if ( ! taxonomy_exists( ActionScheduler_wpPostStore::GROUP_TAXONOMY ) ) {
+            // register the post type and taxonomy necessary for the store to work
+            $store = new ActionScheduler_wpPostStore();
+            $store->init();
+        }
+    }
+
+    public function test_migrate_from_wpPost_to_db() {
+        $source      = new ActionScheduler_wpPostStore();
+        $destination = new ActionScheduler_DBStore();
+        $migrator    = new ActionMigrator( $source, $destination, $this->get_log_migrator() );
+
+        $time      = as_get_datetime_object();
+        $schedule  = new ActionScheduler_SimpleSchedule( $time );
+        $action    = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule, 'my_group' );
+        $action_id = $source->save_action( $action );
+
+        $new_id = $migrator->migrate( $action_id );
+
+        // ensure we get the same record out of the new store as we stored in the old
+        $retrieved = $destination->fetch_action( $new_id );
+        $this->assertEquals( $action->get_hook(), $retrieved->get_hook() );
+        $this->assertEqualSets( $action->get_args(), $retrieved->get_args() );
+        $this->assertEquals( $action->get_schedule()->get_date()->format( 'U' ), $retrieved->get_schedule()->get_date()->format( 'U' ) );
+        $this->assertEquals( $action->get_group(), $retrieved->get_group() );
+        $this->assertEquals( \ActionScheduler_Store::STATUS_PENDING, $destination->get_status( $new_id ) );
+
+        // ensure that the record in the old store does not exist
+        $old_action = $source->fetch_action( $action_id );
+        $this->assertInstanceOf( 'ActionScheduler_NullAction', $old_action );
+    }
+
+    public function test_does_not_migrate_missing_action_from_wpPost_to_db() {
+        $source      = new ActionScheduler_wpPostStore();
+        $destination = new ActionScheduler_DBStore();
+        $migrator    = new ActionMigrator( $source, $destination, $this->get_log_migrator() );
+
+        $action_id = rand( 100, 100000 );
+
+        $new_id = $migrator->migrate( $action_id );
+        $this->assertSame( 0, $new_id );
+
+        // ensure we get the same record out of the new store as we stored in the old
+        $retrieved = $destination->fetch_action( $new_id );
+        $this->assertInstanceOf( 'ActionScheduler_NullAction', $retrieved );
+    }
+
+    public function test_migrate_completed_action_from_wpPost_to_db() {
+        $source      = new ActionScheduler_wpPostStore();
+        $destination = new ActionScheduler_DBStore();
+        $migrator    = new ActionMigrator( $source, $destination, $this->get_log_migrator() );
+
+        $time      = as_get_datetime_object();
+        $schedule  = new ActionScheduler_SimpleSchedule( $time );
+        $action    = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule, 'my_group' );
+        $action_id = $source->save_action( $action );
+        $source->mark_complete( $action_id );
+
+        $new_id = $migrator->migrate( $action_id );
+
+        // ensure we get the same record out of the new store as we stored in the old
+        $retrieved = $destination->fetch_action( $new_id );
+        $this->assertEquals( $action->get_hook(), $retrieved->get_hook() );
+        $this->assertEqualSets( $action->get_args(), $retrieved->get_args() );
+        $this->assertEquals( $action->get_schedule()->get_date()->format( 'U' ), $retrieved->get_schedule()->get_date()->format( 'U' ) );
+        $this->assertEquals( $action->get_group(), $retrieved->get_group() );
+        $this->assertTrue( $retrieved->is_finished() );
+        $this->assertEquals( \ActionScheduler_Store::STATUS_COMPLETE, $destination->get_status( $new_id ) );
+
+        // ensure that the record in the old store does not exist
+        $old_action = $source->fetch_action( $action_id );
+        $this->assertInstanceOf( 'ActionScheduler_NullAction', $old_action );
+    }
+
+    public function test_migrate_failed_action_from_wpPost_to_db() {
+        $source      = new ActionScheduler_wpPostStore();
+        $destination = new ActionScheduler_DBStore();
+        $migrator    = new ActionMigrator( $source, $destination, $this->get_log_migrator() );
+
+        $time      = as_get_datetime_object();
+        $schedule  = new ActionScheduler_SimpleSchedule( $time );
+        $action    = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule, 'my_group' );
+        $action_id = $source->save_action( $action );
+        $source->mark_failure( $action_id );
+
+        $new_id = $migrator->migrate( $action_id );
+
+        // ensure we get the same record out of the new store as we stored in the old
+        $retrieved = $destination->fetch_action( $new_id );
+        $this->assertEquals( $action->get_hook(), $retrieved->get_hook() );
+        $this->assertEqualSets( $action->get_args(), $retrieved->get_args() );
+        $this->assertEquals( $action->get_schedule()->get_date()->format( 'U' ), $retrieved->get_schedule()->get_date()->format( 'U' ) );
+        $this->assertEquals( $action->get_group(), $retrieved->get_group() );
+        $this->assertTrue( $retrieved->is_finished() );
+        $this->assertEquals( \ActionScheduler_Store::STATUS_FAILED, $destination->get_status( $new_id ) );
+
+        // ensure that the record in the old store does not exist
+        $old_action = $source->fetch_action( $action_id );
+        $this->assertInstanceOf( 'ActionScheduler_NullAction', $old_action );
+    }
+
+    public function test_migrate_canceled_action_from_wpPost_to_db() {
+        $source      = new ActionScheduler_wpPostStore();
+        $destination = new ActionScheduler_DBStore();
+        $migrator    = new ActionMigrator( $source, $destination, $this->get_log_migrator() );
+
+        $time      = as_get_datetime_object();
+        $schedule  = new ActionScheduler_SimpleSchedule( $time );
+        $action    = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule, 'my_group' );
+        $action_id = $source->save_action( $action );
+        $source->cancel_action( $action_id );
+
+        $new_id = $migrator->migrate( $action_id );
+
+        // ensure we get the same record out of the new store as we stored in the old
+        $retrieved = $destination->fetch_action( $new_id );
+        $this->assertEquals( $action->get_hook(), $retrieved->get_hook() );
+        $this->assertEqualSets( $action->get_args(), $retrieved->get_args() );
+        $this->assertEquals( $action->get_schedule()->get_date()->format( 'U' ), $retrieved->get_schedule()->get_date()->format( 'U' ) );
+        $this->assertEquals( $action->get_group(), $retrieved->get_group() );
+        $this->assertTrue( $retrieved->is_finished() );
+        $this->assertEquals( \ActionScheduler_Store::STATUS_CANCELED, $destination->get_status( $new_id ) );
+
+        // ensure that the record in the old store does not exist
+        $old_action = $source->fetch_action( $action_id );
+        $this->assertInstanceOf( 'ActionScheduler_NullAction', $old_action );
+    }
+
+    private function get_log_migrator() {
+        return new LogMigrator( \ActionScheduler::logger(), new ActionScheduler_DBLogger() );
+    }
 }

Spacing +66 added lines, -66 removed lines

@@ -11,7 +11,7 @@ 
 class ActionMigrator_Test extends ActionScheduler_UnitTestCase {
 	public function setUp() {
 		parent::setUp();
-		if ( ! taxonomy_exists( ActionScheduler_wpPostStore::GROUP_TAXONOMY ) ) {
+		if ( ! taxonomy_exists(ActionScheduler_wpPostStore::GROUP_TAXONOMY)) {
 			// register the post type and taxonomy necessary for the store to work
 			$store = new ActionScheduler_wpPostStore();
 			$store->init();
@@ -21,125 +21,125 @@ 
 	public function test_migrate_from_wpPost_to_db() {
 		$source      = new ActionScheduler_wpPostStore();
 		$destination = new ActionScheduler_DBStore();
-		$migrator    = new ActionMigrator( $source, $destination, $this->get_log_migrator() );
+		$migrator    = new ActionMigrator($source, $destination, $this->get_log_migrator());
 
 		$time      = as_get_datetime_object();
-		$schedule  = new ActionScheduler_SimpleSchedule( $time );
-		$action    = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule, 'my_group' );
-		$action_id = $source->save_action( $action );
+		$schedule  = new ActionScheduler_SimpleSchedule($time);
+		$action    = new ActionScheduler_Action(ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule, 'my_group');
+		$action_id = $source->save_action($action);
 
-		$new_id = $migrator->migrate( $action_id );
+		$new_id = $migrator->migrate($action_id);
 
 		// ensure we get the same record out of the new store as we stored in the old
-		$retrieved = $destination->fetch_action( $new_id );
-		$this->assertEquals( $action->get_hook(), $retrieved->get_hook() );
-		$this->assertEqualSets( $action->get_args(), $retrieved->get_args() );
-		$this->assertEquals( $action->get_schedule()->get_date()->format( 'U' ), $retrieved->get_schedule()->get_date()->format( 'U' ) );
-		$this->assertEquals( $action->get_group(), $retrieved->get_group() );
-		$this->assertEquals( \ActionScheduler_Store::STATUS_PENDING, $destination->get_status( $new_id ) );
+		$retrieved = $destination->fetch_action($new_id);
+		$this->assertEquals($action->get_hook(), $retrieved->get_hook());
+		$this->assertEqualSets($action->get_args(), $retrieved->get_args());
+		$this->assertEquals($action->get_schedule()->get_date()->format('U'), $retrieved->get_schedule()->get_date()->format('U'));
+		$this->assertEquals($action->get_group(), $retrieved->get_group());
+		$this->assertEquals(\ActionScheduler_Store::STATUS_PENDING, $destination->get_status($new_id));
 
 		// ensure that the record in the old store does not exist
-		$old_action = $source->fetch_action( $action_id );
-		$this->assertInstanceOf( 'ActionScheduler_NullAction', $old_action );
+		$old_action = $source->fetch_action($action_id);
+		$this->assertInstanceOf('ActionScheduler_NullAction', $old_action);
 	}
 
 	public function test_does_not_migrate_missing_action_from_wpPost_to_db() {
 		$source      = new ActionScheduler_wpPostStore();
 		$destination = new ActionScheduler_DBStore();
-		$migrator    = new ActionMigrator( $source, $destination, $this->get_log_migrator() );
+		$migrator    = new ActionMigrator($source, $destination, $this->get_log_migrator());
 
-		$action_id = rand( 100, 100000 );
+		$action_id = rand(100, 100000);
 
-		$new_id = $migrator->migrate( $action_id );
-		$this->assertSame( 0, $new_id );
+		$new_id = $migrator->migrate($action_id);
+		$this->assertSame(0, $new_id);
 
 		// ensure we get the same record out of the new store as we stored in the old
-		$retrieved = $destination->fetch_action( $new_id );
-		$this->assertInstanceOf( 'ActionScheduler_NullAction', $retrieved );
+		$retrieved = $destination->fetch_action($new_id);
+		$this->assertInstanceOf('ActionScheduler_NullAction', $retrieved);
 	}
 
 	public function test_migrate_completed_action_from_wpPost_to_db() {
 		$source      = new ActionScheduler_wpPostStore();
 		$destination = new ActionScheduler_DBStore();
-		$migrator    = new ActionMigrator( $source, $destination, $this->get_log_migrator() );
+		$migrator    = new ActionMigrator($source, $destination, $this->get_log_migrator());
 
 		$time      = as_get_datetime_object();
-		$schedule  = new ActionScheduler_SimpleSchedule( $time );
-		$action    = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule, 'my_group' );
-		$action_id = $source->save_action( $action );
-		$source->mark_complete( $action_id );
+		$schedule  = new ActionScheduler_SimpleSchedule($time);
+		$action    = new ActionScheduler_Action(ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule, 'my_group');
+		$action_id = $source->save_action($action);
+		$source->mark_complete($action_id);
 
-		$new_id = $migrator->migrate( $action_id );
+		$new_id = $migrator->migrate($action_id);
 
 		// ensure we get the same record out of the new store as we stored in the old
-		$retrieved = $destination->fetch_action( $new_id );
-		$this->assertEquals( $action->get_hook(), $retrieved->get_hook() );
-		$this->assertEqualSets( $action->get_args(), $retrieved->get_args() );
-		$this->assertEquals( $action->get_schedule()->get_date()->format( 'U' ), $retrieved->get_schedule()->get_date()->format( 'U' ) );
-		$this->assertEquals( $action->get_group(), $retrieved->get_group() );
-		$this->assertTrue( $retrieved->is_finished() );
-		$this->assertEquals( \ActionScheduler_Store::STATUS_COMPLETE, $destination->get_status( $new_id ) );
+		$retrieved = $destination->fetch_action($new_id);
+		$this->assertEquals($action->get_hook(), $retrieved->get_hook());
+		$this->assertEqualSets($action->get_args(), $retrieved->get_args());
+		$this->assertEquals($action->get_schedule()->get_date()->format('U'), $retrieved->get_schedule()->get_date()->format('U'));
+		$this->assertEquals($action->get_group(), $retrieved->get_group());
+		$this->assertTrue($retrieved->is_finished());
+		$this->assertEquals(\ActionScheduler_Store::STATUS_COMPLETE, $destination->get_status($new_id));
 
 		// ensure that the record in the old store does not exist
-		$old_action = $source->fetch_action( $action_id );
-		$this->assertInstanceOf( 'ActionScheduler_NullAction', $old_action );
+		$old_action = $source->fetch_action($action_id);
+		$this->assertInstanceOf('ActionScheduler_NullAction', $old_action);
 	}
 
 	public function test_migrate_failed_action_from_wpPost_to_db() {
 		$source      = new ActionScheduler_wpPostStore();
 		$destination = new ActionScheduler_DBStore();
-		$migrator    = new ActionMigrator( $source, $destination, $this->get_log_migrator() );
+		$migrator    = new ActionMigrator($source, $destination, $this->get_log_migrator());
 
 		$time      = as_get_datetime_object();
-		$schedule  = new ActionScheduler_SimpleSchedule( $time );
-		$action    = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule, 'my_group' );
-		$action_id = $source->save_action( $action );
-		$source->mark_failure( $action_id );
+		$schedule  = new ActionScheduler_SimpleSchedule($time);
+		$action    = new ActionScheduler_Action(ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule, 'my_group');
+		$action_id = $source->save_action($action);
+		$source->mark_failure($action_id);
 
-		$new_id = $migrator->migrate( $action_id );
+		$new_id = $migrator->migrate($action_id);
 
 		// ensure we get the same record out of the new store as we stored in the old
-		$retrieved = $destination->fetch_action( $new_id );
-		$this->assertEquals( $action->get_hook(), $retrieved->get_hook() );
-		$this->assertEqualSets( $action->get_args(), $retrieved->get_args() );
-		$this->assertEquals( $action->get_schedule()->get_date()->format( 'U' ), $retrieved->get_schedule()->get_date()->format( 'U' ) );
-		$this->assertEquals( $action->get_group(), $retrieved->get_group() );
-		$this->assertTrue( $retrieved->is_finished() );
-		$this->assertEquals( \ActionScheduler_Store::STATUS_FAILED, $destination->get_status( $new_id ) );
+		$retrieved = $destination->fetch_action($new_id);
+		$this->assertEquals($action->get_hook(), $retrieved->get_hook());
+		$this->assertEqualSets($action->get_args(), $retrieved->get_args());
+		$this->assertEquals($action->get_schedule()->get_date()->format('U'), $retrieved->get_schedule()->get_date()->format('U'));
+		$this->assertEquals($action->get_group(), $retrieved->get_group());
+		$this->assertTrue($retrieved->is_finished());
+		$this->assertEquals(\ActionScheduler_Store::STATUS_FAILED, $destination->get_status($new_id));
 
 		// ensure that the record in the old store does not exist
-		$old_action = $source->fetch_action( $action_id );
-		$this->assertInstanceOf( 'ActionScheduler_NullAction', $old_action );
+		$old_action = $source->fetch_action($action_id);
+		$this->assertInstanceOf('ActionScheduler_NullAction', $old_action);
 	}
 
 	public function test_migrate_canceled_action_from_wpPost_to_db() {
 		$source      = new ActionScheduler_wpPostStore();
 		$destination = new ActionScheduler_DBStore();
-		$migrator    = new ActionMigrator( $source, $destination, $this->get_log_migrator() );
+		$migrator    = new ActionMigrator($source, $destination, $this->get_log_migrator());
 
 		$time      = as_get_datetime_object();
-		$schedule  = new ActionScheduler_SimpleSchedule( $time );
-		$action    = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule, 'my_group' );
-		$action_id = $source->save_action( $action );
-		$source->cancel_action( $action_id );
+		$schedule  = new ActionScheduler_SimpleSchedule($time);
+		$action    = new ActionScheduler_Action(ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule, 'my_group');
+		$action_id = $source->save_action($action);
+		$source->cancel_action($action_id);
 
-		$new_id = $migrator->migrate( $action_id );
+		$new_id = $migrator->migrate($action_id);
 
 		// ensure we get the same record out of the new store as we stored in the old
-		$retrieved = $destination->fetch_action( $new_id );
-		$this->assertEquals( $action->get_hook(), $retrieved->get_hook() );
-		$this->assertEqualSets( $action->get_args(), $retrieved->get_args() );
-		$this->assertEquals( $action->get_schedule()->get_date()->format( 'U' ), $retrieved->get_schedule()->get_date()->format( 'U' ) );
-		$this->assertEquals( $action->get_group(), $retrieved->get_group() );
-		$this->assertTrue( $retrieved->is_finished() );
-		$this->assertEquals( \ActionScheduler_Store::STATUS_CANCELED, $destination->get_status( $new_id ) );
+		$retrieved = $destination->fetch_action($new_id);
+		$this->assertEquals($action->get_hook(), $retrieved->get_hook());
+		$this->assertEqualSets($action->get_args(), $retrieved->get_args());
+		$this->assertEquals($action->get_schedule()->get_date()->format('U'), $retrieved->get_schedule()->get_date()->format('U'));
+		$this->assertEquals($action->get_group(), $retrieved->get_group());
+		$this->assertTrue($retrieved->is_finished());
+		$this->assertEquals(\ActionScheduler_Store::STATUS_CANCELED, $destination->get_status($new_id));
 
 		// ensure that the record in the old store does not exist
-		$old_action = $source->fetch_action( $action_id );
-		$this->assertInstanceOf( 'ActionScheduler_NullAction', $old_action );
+		$old_action = $source->fetch_action($action_id);
+		$this->assertInstanceOf('ActionScheduler_NullAction', $old_action);
 	}
 
 	private function get_log_migrator() {
-		return new LogMigrator( \ActionScheduler::logger(), new ActionScheduler_DBLogger() );
+		return new LogMigrator(\ActionScheduler::logger(), new ActionScheduler_DBLogger());
 	}
 }

src/libraries/action-scheduler/tests/phpunit/migration/LogMigrator_Test.php

Indentation +37 added lines, -37 removed lines

@@ -8,46 +8,46 @@
  * @group migration
  */
 class LogMigrator_Test extends ActionScheduler_UnitTestCase {
-	function setUp() {
-		parent::setUp();
-		if ( ! taxonomy_exists( ActionScheduler_wpPostStore::GROUP_TAXONOMY ) ) {
-			// register the post type and taxonomy necessary for the store to work
-			$store = new ActionScheduler_wpPostStore();
-			$store->init();
-		}
-	}
+    function setUp() {
+        parent::setUp();
+        if ( ! taxonomy_exists( ActionScheduler_wpPostStore::GROUP_TAXONOMY ) ) {
+            // register the post type and taxonomy necessary for the store to work
+            $store = new ActionScheduler_wpPostStore();
+            $store->init();
+        }
+    }
 
-	public function test_migrate_from_wpComment_to_db() {
-		$source                = new ActionScheduler_wpCommentLogger();
-		$destination           = new ActionScheduler_DBLogger();
-		$migrator              = new LogMigrator( $source, $destination );
-		$source_action_id      = rand( 10, 10000 );
-		$destination_action_id = rand( 10, 10000 );
+    public function test_migrate_from_wpComment_to_db() {
+        $source                = new ActionScheduler_wpCommentLogger();
+        $destination           = new ActionScheduler_DBLogger();
+        $migrator              = new LogMigrator( $source, $destination );
+        $source_action_id      = rand( 10, 10000 );
+        $destination_action_id = rand( 10, 10000 );
 
-		$logs = array();
-		for ( $i = 0; $i < 3; $i++ ) {
-			for ( $j = 0; $j < 5; $j++ ) {
-				$logs[ $i ][ $j ] = md5( rand() );
-				if ( $i == 1 ) {
-					$source->log( $source_action_id, $logs[ $i ][ $j ] );
-				}
-			}
-		}
+        $logs = array();
+        for ( $i = 0; $i < 3; $i++ ) {
+            for ( $j = 0; $j < 5; $j++ ) {
+                $logs[ $i ][ $j ] = md5( rand() );
+                if ( $i == 1 ) {
+                    $source->log( $source_action_id, $logs[ $i ][ $j ] );
+                }
+            }
+        }
 
-		$migrator->migrate( $source_action_id, $destination_action_id );
+        $migrator->migrate( $source_action_id, $destination_action_id );
 
-		$migrated = $destination->get_logs( $destination_action_id );
-		$this->assertEqualSets(
-			$logs[1],
-			array_map(
-				function ( $log ) {
-					return $log->get_message();
-				},
-				$migrated
-			)
-		);
+        $migrated = $destination->get_logs( $destination_action_id );
+        $this->assertEqualSets(
+            $logs[1],
+            array_map(
+                function ( $log ) {
+                    return $log->get_message();
+                },
+                $migrated
+            )
+        );
 
-		// no API for deleting logs, so we leave them for manual cleanup later
-		$this->assertCount( 5, $source->get_logs( $source_action_id ) );
-	}
+        // no API for deleting logs, so we leave them for manual cleanup later
+        $this->assertCount( 5, $source->get_logs( $source_action_id ) );
+    }
 }

Spacing +13 added lines, -13 removed lines

@@ -10,7 +10,7 @@ 
 class LogMigrator_Test extends ActionScheduler_UnitTestCase {
 	function setUp() {
 		parent::setUp();
-		if ( ! taxonomy_exists( ActionScheduler_wpPostStore::GROUP_TAXONOMY ) ) {
+		if ( ! taxonomy_exists(ActionScheduler_wpPostStore::GROUP_TAXONOMY)) {
 			// register the post type and taxonomy necessary for the store to work
 			$store = new ActionScheduler_wpPostStore();
 			$store->init();
@@ -20,27 +20,27 @@ 
 	public function test_migrate_from_wpComment_to_db() {
 		$source                = new ActionScheduler_wpCommentLogger();
 		$destination           = new ActionScheduler_DBLogger();
-		$migrator              = new LogMigrator( $source, $destination );
-		$source_action_id      = rand( 10, 10000 );
-		$destination_action_id = rand( 10, 10000 );
+		$migrator              = new LogMigrator($source, $destination);
+		$source_action_id      = rand(10, 10000);
+		$destination_action_id = rand(10, 10000);
 
 		$logs = array();
-		for ( $i = 0; $i < 3; $i++ ) {
-			for ( $j = 0; $j < 5; $j++ ) {
-				$logs[ $i ][ $j ] = md5( rand() );
-				if ( $i == 1 ) {
-					$source->log( $source_action_id, $logs[ $i ][ $j ] );
+		for ($i = 0; $i < 3; $i++) {
+			for ($j = 0; $j < 5; $j++) {
+				$logs[$i][$j] = md5(rand());
+				if ($i == 1) {
+					$source->log($source_action_id, $logs[$i][$j]);
 				}
 			}
 		}
 
-		$migrator->migrate( $source_action_id, $destination_action_id );
+		$migrator->migrate($source_action_id, $destination_action_id);
 
-		$migrated = $destination->get_logs( $destination_action_id );
+		$migrated = $destination->get_logs($destination_action_id);
 		$this->assertEqualSets(
 			$logs[1],
 			array_map(
-				function ( $log ) {
+				function($log) {
 					return $log->get_message();
 				},
 				$migrated
@@ -48,6 +48,6 @@ 
 		);
 
 		// no API for deleting logs, so we leave them for manual cleanup later
-		$this->assertCount( 5, $source->get_logs( $source_action_id ) );
+		$this->assertCount(5, $source->get_logs($source_action_id));
 	}
 }

src/libraries/action-scheduler/tests/phpunit/migration/Runner_Test.php

Indentation +105 added lines, -105 removed lines

@@ -11,110 +11,110 @@
  * @group migration
  */
 class Runner_Test extends ActionScheduler_UnitTestCase {
-	public function setUp() {
-		parent::setUp();
-		if ( ! taxonomy_exists( PostStore::GROUP_TAXONOMY ) ) {
-			// register the post type and taxonomy necessary for the store to work
-			$store = new PostStore();
-			$store->init();
-		}
-	}
-
-	public function test_migrate_batches() {
-		$source_store       = new PostStore();
-		$destination_store  = new ActionScheduler_DBStore();
-		$source_logger      = new CommentLogger();
-		$destination_logger = new ActionScheduler_DBLogger();
-
-		$config = new Config();
-		$config->set_source_store( $source_store );
-		$config->set_source_logger( $source_logger );
-		$config->set_destination_store( $destination_store );
-		$config->set_destination_logger( $destination_logger );
-
-		$runner = new Runner( $config );
-
-		$due      = array();
-		$future   = array();
-		$complete = array();
-
-		for ( $i = 0; $i < 5; $i ++ ) {
-			$time     = as_get_datetime_object( $i + 1 . ' minutes' );
-			$schedule = new ActionScheduler_SimpleSchedule( $time );
-			$action   = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule );
-			$future[] = $source_store->save_action( $action );
-
-			$time     = as_get_datetime_object( $i + 1 . ' minutes ago' );
-			$schedule = new ActionScheduler_SimpleSchedule( $time );
-			$action   = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule );
-			$due[]    = $source_store->save_action( $action );
-
-			$time       = as_get_datetime_object( $i + 1 . ' minutes ago' );
-			$schedule   = new ActionScheduler_SimpleSchedule( $time );
-			$action     = new ActionScheduler_FinishedAction( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule );
-			$complete[] = $source_store->save_action( $action );
-		}
-
-		$created = $source_store->query_actions( array( 'per_page' => 0 ) );
-		$this->assertCount( 15, $created );
-
-		$runner->run( 10 );
-
-		// due actions should migrate in the first batch
-		$migrated = $destination_store->query_actions(
-			array(
-				'per_page' => 0,
-				'hook'     => ActionScheduler_Callbacks::HOOK_WITH_CALLBACK,
-			)
-		);
-		$this->assertCount( 5, $migrated );
-
-		$remaining = $source_store->query_actions(
-			array(
-				'per_page' => 0,
-				'hook'     => ActionScheduler_Callbacks::HOOK_WITH_CALLBACK,
-			)
-		);
-		$this->assertCount( 10, $remaining );
-
-		$runner->run( 10 );
-
-		// pending actions should migrate in the second batch
-		$migrated = $destination_store->query_actions(
-			array(
-				'per_page' => 0,
-				'hook'     => ActionScheduler_Callbacks::HOOK_WITH_CALLBACK,
-			)
-		);
-		$this->assertCount( 10, $migrated );
-
-		$remaining = $source_store->query_actions(
-			array(
-				'per_page' => 0,
-				'hook'     => ActionScheduler_Callbacks::HOOK_WITH_CALLBACK,
-			)
-		);
-		$this->assertCount( 5, $remaining );
-
-		$runner->run( 10 );
-
-		// completed actions should migrate in the third batch
-		$migrated = $destination_store->query_actions(
-			array(
-				'per_page' => 0,
-				'hook'     => ActionScheduler_Callbacks::HOOK_WITH_CALLBACK,
-			)
-		);
-		$this->assertCount( 15, $migrated );
-
-		$remaining = $source_store->query_actions(
-			array(
-				'per_page' => 0,
-				'hook'     => ActionScheduler_Callbacks::HOOK_WITH_CALLBACK,
-			)
-		);
-		$this->assertCount( 0, $remaining );
-
-	}
+    public function setUp() {
+        parent::setUp();
+        if ( ! taxonomy_exists( PostStore::GROUP_TAXONOMY ) ) {
+            // register the post type and taxonomy necessary for the store to work
+            $store = new PostStore();
+            $store->init();
+        }
+    }
+
+    public function test_migrate_batches() {
+        $source_store       = new PostStore();
+        $destination_store  = new ActionScheduler_DBStore();
+        $source_logger      = new CommentLogger();
+        $destination_logger = new ActionScheduler_DBLogger();
+
+        $config = new Config();
+        $config->set_source_store( $source_store );
+        $config->set_source_logger( $source_logger );
+        $config->set_destination_store( $destination_store );
+        $config->set_destination_logger( $destination_logger );
+
+        $runner = new Runner( $config );
+
+        $due      = array();
+        $future   = array();
+        $complete = array();
+
+        for ( $i = 0; $i < 5; $i ++ ) {
+            $time     = as_get_datetime_object( $i + 1 . ' minutes' );
+            $schedule = new ActionScheduler_SimpleSchedule( $time );
+            $action   = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule );
+            $future[] = $source_store->save_action( $action );
+
+            $time     = as_get_datetime_object( $i + 1 . ' minutes ago' );
+            $schedule = new ActionScheduler_SimpleSchedule( $time );
+            $action   = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule );
+            $due[]    = $source_store->save_action( $action );
+
+            $time       = as_get_datetime_object( $i + 1 . ' minutes ago' );
+            $schedule   = new ActionScheduler_SimpleSchedule( $time );
+            $action     = new ActionScheduler_FinishedAction( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule );
+            $complete[] = $source_store->save_action( $action );
+        }
+
+        $created = $source_store->query_actions( array( 'per_page' => 0 ) );
+        $this->assertCount( 15, $created );
+
+        $runner->run( 10 );
+
+        // due actions should migrate in the first batch
+        $migrated = $destination_store->query_actions(
+            array(
+                'per_page' => 0,
+                'hook'     => ActionScheduler_Callbacks::HOOK_WITH_CALLBACK,
+            )
+        );
+        $this->assertCount( 5, $migrated );
+
+        $remaining = $source_store->query_actions(
+            array(
+                'per_page' => 0,
+                'hook'     => ActionScheduler_Callbacks::HOOK_WITH_CALLBACK,
+            )
+        );
+        $this->assertCount( 10, $remaining );
+
+        $runner->run( 10 );
+
+        // pending actions should migrate in the second batch
+        $migrated = $destination_store->query_actions(
+            array(
+                'per_page' => 0,
+                'hook'     => ActionScheduler_Callbacks::HOOK_WITH_CALLBACK,
+            )
+        );
+        $this->assertCount( 10, $migrated );
+
+        $remaining = $source_store->query_actions(
+            array(
+                'per_page' => 0,
+                'hook'     => ActionScheduler_Callbacks::HOOK_WITH_CALLBACK,
+            )
+        );
+        $this->assertCount( 5, $remaining );
+
+        $runner->run( 10 );
+
+        // completed actions should migrate in the third batch
+        $migrated = $destination_store->query_actions(
+            array(
+                'per_page' => 0,
+                'hook'     => ActionScheduler_Callbacks::HOOK_WITH_CALLBACK,
+            )
+        );
+        $this->assertCount( 15, $migrated );
+
+        $remaining = $source_store->query_actions(
+            array(
+                'per_page' => 0,
+                'hook'     => ActionScheduler_Callbacks::HOOK_WITH_CALLBACK,
+            )
+        );
+        $this->assertCount( 0, $remaining );
+
+    }
 
 }

Spacing +32 added lines, -32 removed lines

@@ -13,7 +13,7 @@ 
 class Runner_Test extends ActionScheduler_UnitTestCase {
 	public function setUp() {
 		parent::setUp();
-		if ( ! taxonomy_exists( PostStore::GROUP_TAXONOMY ) ) {
+		if ( ! taxonomy_exists(PostStore::GROUP_TAXONOMY)) {
 			// register the post type and taxonomy necessary for the store to work
 			$store = new PostStore();
 			$store->init();
@@ -27,38 +27,38 @@ 
 		$destination_logger = new ActionScheduler_DBLogger();
 
 		$config = new Config();
-		$config->set_source_store( $source_store );
-		$config->set_source_logger( $source_logger );
-		$config->set_destination_store( $destination_store );
-		$config->set_destination_logger( $destination_logger );
+		$config->set_source_store($source_store);
+		$config->set_source_logger($source_logger);
+		$config->set_destination_store($destination_store);
+		$config->set_destination_logger($destination_logger);
 
-		$runner = new Runner( $config );
+		$runner = new Runner($config);
 
 		$due      = array();
 		$future   = array();
 		$complete = array();
 
-		for ( $i = 0; $i < 5; $i ++ ) {
-			$time     = as_get_datetime_object( $i + 1 . ' minutes' );
-			$schedule = new ActionScheduler_SimpleSchedule( $time );
-			$action   = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule );
-			$future[] = $source_store->save_action( $action );
-
-			$time     = as_get_datetime_object( $i + 1 . ' minutes ago' );
-			$schedule = new ActionScheduler_SimpleSchedule( $time );
-			$action   = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule );
-			$due[]    = $source_store->save_action( $action );
-
-			$time       = as_get_datetime_object( $i + 1 . ' minutes ago' );
-			$schedule   = new ActionScheduler_SimpleSchedule( $time );
-			$action     = new ActionScheduler_FinishedAction( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule );
-			$complete[] = $source_store->save_action( $action );
+		for ($i = 0; $i < 5; $i++) {
+			$time     = as_get_datetime_object($i + 1.' minutes');
+			$schedule = new ActionScheduler_SimpleSchedule($time);
+			$action   = new ActionScheduler_Action(ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule);
+			$future[] = $source_store->save_action($action);
+
+			$time     = as_get_datetime_object($i + 1.' minutes ago');
+			$schedule = new ActionScheduler_SimpleSchedule($time);
+			$action   = new ActionScheduler_Action(ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule);
+			$due[]    = $source_store->save_action($action);
+
+			$time       = as_get_datetime_object($i + 1.' minutes ago');
+			$schedule   = new ActionScheduler_SimpleSchedule($time);
+			$action     = new ActionScheduler_FinishedAction(ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule);
+			$complete[] = $source_store->save_action($action);
 		}
 
-		$created = $source_store->query_actions( array( 'per_page' => 0 ) );
-		$this->assertCount( 15, $created );
+		$created = $source_store->query_actions(array('per_page' => 0));
+		$this->assertCount(15, $created);
 
-		$runner->run( 10 );
+		$runner->run(10);
 
 		// due actions should migrate in the first batch
 		$migrated = $destination_store->query_actions(
@@ -67,7 +67,7 @@ 
 				'hook'     => ActionScheduler_Callbacks::HOOK_WITH_CALLBACK,
 			)
 		);
-		$this->assertCount( 5, $migrated );
+		$this->assertCount(5, $migrated);
 
 		$remaining = $source_store->query_actions(
 			array(
@@ -75,9 +75,9 @@ 
 				'hook'     => ActionScheduler_Callbacks::HOOK_WITH_CALLBACK,
 			)
 		);
-		$this->assertCount( 10, $remaining );
+		$this->assertCount(10, $remaining);
 
-		$runner->run( 10 );
+		$runner->run(10);
 
 		// pending actions should migrate in the second batch
 		$migrated = $destination_store->query_actions(
@@ -86,7 +86,7 @@ 
 				'hook'     => ActionScheduler_Callbacks::HOOK_WITH_CALLBACK,
 			)
 		);
-		$this->assertCount( 10, $migrated );
+		$this->assertCount(10, $migrated);
 
 		$remaining = $source_store->query_actions(
 			array(
@@ -94,9 +94,9 @@ 
 				'hook'     => ActionScheduler_Callbacks::HOOK_WITH_CALLBACK,
 			)
 		);
-		$this->assertCount( 5, $remaining );
+		$this->assertCount(5, $remaining);
 
-		$runner->run( 10 );
+		$runner->run(10);
 
 		// completed actions should migrate in the third batch
 		$migrated = $destination_store->query_actions(
@@ -105,7 +105,7 @@ 
 				'hook'     => ActionScheduler_Callbacks::HOOK_WITH_CALLBACK,
 			)
 		);
-		$this->assertCount( 15, $migrated );
+		$this->assertCount(15, $migrated);
 
 		$remaining = $source_store->query_actions(
 			array(
@@ -113,7 +113,7 @@ 
 				'hook'     => ActionScheduler_Callbacks::HOOK_WITH_CALLBACK,
 			)
 		);
-		$this->assertCount( 0, $remaining );
+		$this->assertCount(0, $remaining);
 
 	}
 

src/libraries/action-scheduler/tests/phpunit/migration/BatchFetcher_Test.php

Indentation +64 added lines, -64 removed lines

@@ -9,68 +9,68 @@
  * @group migration
  */
 class BatchFetcher_Test extends ActionScheduler_UnitTestCase {
-	public function setUp() {
-		parent::setUp();
-		if ( ! taxonomy_exists( PostStore::GROUP_TAXONOMY ) ) {
-			// register the post type and taxonomy necessary for the store to work
-			$store = new PostStore();
-			$store->init();
-		}
-	}
-
-	public function test_nothing_to_migrate() {
-		$store         = new PostStore();
-		$batch_fetcher = new BatchFetcher( $store );
-
-		$actions = $batch_fetcher->fetch();
-		$this->assertEmpty( $actions );
-	}
-
-	public function test_get_due_before_future() {
-		$store  = new PostStore();
-		$due    = array();
-		$future = array();
-
-		for ( $i = 0; $i < 5; $i ++ ) {
-			$time     = as_get_datetime_object( $i + 1 . ' minutes' );
-			$schedule = new ActionScheduler_SimpleSchedule( $time );
-			$action   = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule );
-			$future[] = $store->save_action( $action );
-
-			$time     = as_get_datetime_object( $i + 1 . ' minutes ago' );
-			$schedule = new ActionScheduler_SimpleSchedule( $time );
-			$action   = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule );
-			$due[]    = $store->save_action( $action );
-		}
-
-		$batch_fetcher = new BatchFetcher( $store );
-
-		$actions = $batch_fetcher->fetch();
-
-		$this->assertEqualSets( $due, $actions );
-	}
-
-	public function test_get_future_before_complete() {
-		$store    = new PostStore();
-		$future   = array();
-		$complete = array();
-
-		for ( $i = 0; $i < 5; $i ++ ) {
-			$time     = as_get_datetime_object( $i + 1 . ' minutes' );
-			$schedule = new ActionScheduler_SimpleSchedule( $time );
-			$action   = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule );
-			$future[] = $store->save_action( $action );
-
-			$time       = as_get_datetime_object( $i + 1 . ' minutes ago' );
-			$schedule   = new ActionScheduler_SimpleSchedule( $time );
-			$action     = new ActionScheduler_FinishedAction( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule );
-			$complete[] = $store->save_action( $action );
-		}
-
-		$batch_fetcher = new BatchFetcher( $store );
-
-		$actions = $batch_fetcher->fetch();
-
-		$this->assertEqualSets( $future, $actions );
-	}
+    public function setUp() {
+        parent::setUp();
+        if ( ! taxonomy_exists( PostStore::GROUP_TAXONOMY ) ) {
+            // register the post type and taxonomy necessary for the store to work
+            $store = new PostStore();
+            $store->init();
+        }
+    }
+
+    public function test_nothing_to_migrate() {
+        $store         = new PostStore();
+        $batch_fetcher = new BatchFetcher( $store );
+
+        $actions = $batch_fetcher->fetch();
+        $this->assertEmpty( $actions );
+    }
+
+    public function test_get_due_before_future() {
+        $store  = new PostStore();
+        $due    = array();
+        $future = array();
+
+        for ( $i = 0; $i < 5; $i ++ ) {
+            $time     = as_get_datetime_object( $i + 1 . ' minutes' );
+            $schedule = new ActionScheduler_SimpleSchedule( $time );
+            $action   = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule );
+            $future[] = $store->save_action( $action );
+
+            $time     = as_get_datetime_object( $i + 1 . ' minutes ago' );
+            $schedule = new ActionScheduler_SimpleSchedule( $time );
+            $action   = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule );
+            $due[]    = $store->save_action( $action );
+        }
+
+        $batch_fetcher = new BatchFetcher( $store );
+
+        $actions = $batch_fetcher->fetch();
+
+        $this->assertEqualSets( $due, $actions );
+    }
+
+    public function test_get_future_before_complete() {
+        $store    = new PostStore();
+        $future   = array();
+        $complete = array();
+
+        for ( $i = 0; $i < 5; $i ++ ) {
+            $time     = as_get_datetime_object( $i + 1 . ' minutes' );
+            $schedule = new ActionScheduler_SimpleSchedule( $time );
+            $action   = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule );
+            $future[] = $store->save_action( $action );
+
+            $time       = as_get_datetime_object( $i + 1 . ' minutes ago' );
+            $schedule   = new ActionScheduler_SimpleSchedule( $time );
+            $action     = new ActionScheduler_FinishedAction( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule );
+            $complete[] = $store->save_action( $action );
+        }
+
+        $batch_fetcher = new BatchFetcher( $store );
+
+        $actions = $batch_fetcher->fetch();
+
+        $this->assertEqualSets( $future, $actions );
+    }
 }

Spacing +25 added lines, -25 removed lines

@@ -11,7 +11,7 @@ 
 class BatchFetcher_Test extends ActionScheduler_UnitTestCase {
 	public function setUp() {
 		parent::setUp();
-		if ( ! taxonomy_exists( PostStore::GROUP_TAXONOMY ) ) {
+		if ( ! taxonomy_exists(PostStore::GROUP_TAXONOMY)) {
 			// register the post type and taxonomy necessary for the store to work
 			$store = new PostStore();
 			$store->init();
@@ -20,10 +20,10 @@ 
 
 	public function test_nothing_to_migrate() {
 		$store         = new PostStore();
-		$batch_fetcher = new BatchFetcher( $store );
+		$batch_fetcher = new BatchFetcher($store);
 
 		$actions = $batch_fetcher->fetch();
-		$this->assertEmpty( $actions );
+		$this->assertEmpty($actions);
 	}
 
 	public function test_get_due_before_future() {
@@ -31,23 +31,23 @@ 
 		$due    = array();
 		$future = array();
 
-		for ( $i = 0; $i < 5; $i ++ ) {
-			$time     = as_get_datetime_object( $i + 1 . ' minutes' );
-			$schedule = new ActionScheduler_SimpleSchedule( $time );
-			$action   = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule );
-			$future[] = $store->save_action( $action );
+		for ($i = 0; $i < 5; $i++) {
+			$time     = as_get_datetime_object($i + 1.' minutes');
+			$schedule = new ActionScheduler_SimpleSchedule($time);
+			$action   = new ActionScheduler_Action(ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule);
+			$future[] = $store->save_action($action);
 
-			$time     = as_get_datetime_object( $i + 1 . ' minutes ago' );
-			$schedule = new ActionScheduler_SimpleSchedule( $time );
-			$action   = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule );
-			$due[]    = $store->save_action( $action );
+			$time     = as_get_datetime_object($i + 1.' minutes ago');
+			$schedule = new ActionScheduler_SimpleSchedule($time);
+			$action   = new ActionScheduler_Action(ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule);
+			$due[]    = $store->save_action($action);
 		}
 
-		$batch_fetcher = new BatchFetcher( $store );
+		$batch_fetcher = new BatchFetcher($store);
 
 		$actions = $batch_fetcher->fetch();
 
-		$this->assertEqualSets( $due, $actions );
+		$this->assertEqualSets($due, $actions);
 	}
 
 	public function test_get_future_before_complete() {
@@ -55,22 +55,22 @@ 
 		$future   = array();
 		$complete = array();
 
-		for ( $i = 0; $i < 5; $i ++ ) {
-			$time     = as_get_datetime_object( $i + 1 . ' minutes' );
-			$schedule = new ActionScheduler_SimpleSchedule( $time );
-			$action   = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule );
-			$future[] = $store->save_action( $action );
+		for ($i = 0; $i < 5; $i++) {
+			$time     = as_get_datetime_object($i + 1.' minutes');
+			$schedule = new ActionScheduler_SimpleSchedule($time);
+			$action   = new ActionScheduler_Action(ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule);
+			$future[] = $store->save_action($action);
 
-			$time       = as_get_datetime_object( $i + 1 . ' minutes ago' );
-			$schedule   = new ActionScheduler_SimpleSchedule( $time );
-			$action     = new ActionScheduler_FinishedAction( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule );
-			$complete[] = $store->save_action( $action );
+			$time       = as_get_datetime_object($i + 1.' minutes ago');
+			$schedule   = new ActionScheduler_SimpleSchedule($time);
+			$action     = new ActionScheduler_FinishedAction(ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule);
+			$complete[] = $store->save_action($action);
 		}
 
-		$batch_fetcher = new BatchFetcher( $store );
+		$batch_fetcher = new BatchFetcher($store);
 
 		$actions = $batch_fetcher->fetch();
 
-		$this->assertEqualSets( $future, $actions );
+		$this->assertEqualSets($future, $actions);
 	}
 }

src/libraries/action-scheduler/tests/phpunit/jobstore/ActionScheduler_DBStore_Test.php

Indentation +546 added lines, -546 removed lines

@@ -9,550 +9,550 @@
  */
 class ActionScheduler_DBStore_Test extends AbstractStoreTest {
 
-	public function setUp() {
-		global $wpdb;
-
-		// Delete all actions before each test.
-		$wpdb->query( "DELETE FROM {$wpdb->actionscheduler_actions}" );
-
-		parent::setUp();
-	}
-
-	/**
-	 * Get data store for tests.
-	 *
-	 * @return ActionScheduler_DBStore
-	 */
-	protected function get_store() {
-		return new ActionScheduler_DBStore();
-	}
-
-	public function test_create_action() {
-		$time      = as_get_datetime_object();
-		$schedule  = new ActionScheduler_SimpleSchedule( $time );
-		$action    = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule );
-		$store     = new ActionScheduler_DBStore();
-		$action_id = $store->save_action( $action );
-
-		$this->assertNotEmpty( $action_id );
-	}
-
-	public function test_create_action_with_scheduled_date() {
-		$time        = as_get_datetime_object( strtotime( '-1 week' ) );
-		$action      = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), new ActionScheduler_SimpleSchedule( $time ) );
-		$store       = new ActionScheduler_DBStore();
-		$action_id   = $store->save_action( $action, $time );
-		$action_date = $store->get_date( $action_id );
-
-		$this->assertEquals( $time->format( 'U' ), $action_date->format( 'U' ) );
-	}
-
-	public function test_retrieve_action() {
-		$time      = as_get_datetime_object();
-		$schedule  = new ActionScheduler_SimpleSchedule( $time );
-		$action    = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule, 'my_group' );
-		$store     = new ActionScheduler_DBStore();
-		$action_id = $store->save_action( $action );
-
-		$retrieved = $store->fetch_action( $action_id );
-		$this->assertEquals( $action->get_hook(), $retrieved->get_hook() );
-		$this->assertEqualSets( $action->get_args(), $retrieved->get_args() );
-		$this->assertEquals( $action->get_schedule()->get_date()->format( 'U' ), $retrieved->get_schedule()->get_date()->format( 'U' ) );
-		$this->assertEquals( $action->get_group(), $retrieved->get_group() );
-	}
-
-	public function test_cancel_action() {
-		$time      = as_get_datetime_object();
-		$schedule  = new ActionScheduler_SimpleSchedule( $time );
-		$action    = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule, 'my_group' );
-		$store     = new ActionScheduler_DBStore();
-		$action_id = $store->save_action( $action );
-		$store->cancel_action( $action_id );
-
-		$fetched = $store->fetch_action( $action_id );
-		$this->assertInstanceOf( 'ActionScheduler_CanceledAction', $fetched );
-	}
-
-	public function test_cancel_actions_by_hook() {
-		$store   = new ActionScheduler_DBStore();
-		$actions = array();
-		$hook    = 'by_hook_test';
-		for ( $day = 1; $day <= 3; $day++ ) {
-			$delta     = sprintf( '+%d day', $day );
-			$time      = as_get_datetime_object( $delta );
-			$schedule  = new ActionScheduler_SimpleSchedule( $time );
-			$action    = new ActionScheduler_Action( $hook, array(), $schedule, 'my_group' );
-			$actions[] = $store->save_action( $action );
-		}
-		$store->cancel_actions_by_hook( $hook );
-
-		foreach ( $actions as $action_id ) {
-			$fetched = $store->fetch_action( $action_id );
-			$this->assertInstanceOf( 'ActionScheduler_CanceledAction', $fetched );
-		}
-	}
-
-	public function test_cancel_actions_by_group() {
-		$store   = new ActionScheduler_DBStore();
-		$actions = array();
-		$group   = 'by_group_test';
-		for ( $day = 1; $day <= 3; $day++ ) {
-			$delta     = sprintf( '+%d day', $day );
-			$time      = as_get_datetime_object( $delta );
-			$schedule  = new ActionScheduler_SimpleSchedule( $time );
-			$action    = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule, $group );
-			$actions[] = $store->save_action( $action );
-		}
-		$store->cancel_actions_by_group( $group );
-
-		foreach ( $actions as $action_id ) {
-			$fetched = $store->fetch_action( $action_id );
-			$this->assertInstanceOf( 'ActionScheduler_CanceledAction', $fetched );
-		}
-	}
-
-	public function test_claim_actions() {
-		$created_actions = array();
-		$store           = new ActionScheduler_DBStore();
-		for ( $i = 3; $i > - 3; $i -- ) {
-			$time     = as_get_datetime_object( $i . ' hours' );
-			$schedule = new ActionScheduler_SimpleSchedule( $time );
-			$action   = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( $i ), $schedule, 'my_group' );
-
-			$created_actions[] = $store->save_action( $action );
-		}
-
-		$claim = $store->stake_claim();
-		$this->assertInstanceof( 'ActionScheduler_ActionClaim', $claim );
-
-		$this->assertCount( 3, $claim->get_actions() );
-		$this->assertEqualSets( array_slice( $created_actions, 3, 3 ), $claim->get_actions() );
-	}
-
-	public function test_claim_actions_order() {
-
-		$store           = new ActionScheduler_DBStore();
-		$schedule        = new ActionScheduler_SimpleSchedule( as_get_datetime_object( '-1 hour' ) );
-		$created_actions = array(
-			$store->save_action( new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( 1 ), $schedule, 'my_group' ) ),
-			$store->save_action( new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( 1 ), $schedule, 'my_group' ) ),
-		);
-
-		$claim = $store->stake_claim();
-		$this->assertInstanceof( 'ActionScheduler_ActionClaim', $claim );
-
-		// Verify uniqueness of action IDs.
-		$this->assertCount( 2, array_unique( $created_actions ) );
-
-		// Verify the count and order of the actions.
-		$claimed_actions = $claim->get_actions();
-		$this->assertCount( 2, $claimed_actions );
-		$this->assertEquals( $created_actions, $claimed_actions );
-
-		// Verify the reversed order doesn't pass.
-		$reversed_actions = array_reverse( $created_actions );
-		$this->assertNotEquals( $reversed_actions, $claimed_actions );
-	}
-
-	public function test_claim_actions_by_hooks() {
-		$created_actions = $created_actions_by_hook = array();
-		$store           = new ActionScheduler_DBStore();
-		$unique_hook_one = 'my_unique_hook_one';
-		$unique_hook_two = 'my_unique_hook_two';
-		$unique_hooks    = array(
-			$unique_hook_one,
-			$unique_hook_two,
-		);
-
-		for ( $i = 3; $i > - 3; $i -- ) {
-			foreach ( $unique_hooks as $unique_hook ) {
-				$time     = as_get_datetime_object( $i . ' hours' );
-				$schedule = new ActionScheduler_SimpleSchedule( $time );
-				$action   = new ActionScheduler_Action( $unique_hook, array( $i ), $schedule, 'my_group' );
-
-				$action_id         = $store->save_action( $action );
-				$created_actions[] = $created_actions_by_hook[ $unique_hook ][] = $action_id;
-			}
-		}
-
-		$claim = $store->stake_claim( 10, null, $unique_hooks );
-		$this->assertInstanceof( 'ActionScheduler_ActionClaim', $claim );
-		$this->assertCount( 6, $claim->get_actions() );
-		$this->assertEqualSets( array_slice( $created_actions, 6, 6 ), $claim->get_actions() );
-
-		$store->release_claim( $claim );
-
-		$claim = $store->stake_claim( 10, null, array( $unique_hook_one ) );
-		$this->assertInstanceof( 'ActionScheduler_ActionClaim', $claim );
-		$this->assertCount( 3, $claim->get_actions() );
-		$this->assertEqualSets( array_slice( $created_actions_by_hook[ $unique_hook_one ], 3, 3 ), $claim->get_actions() );
-
-		$store->release_claim( $claim );
-
-		$claim = $store->stake_claim( 10, null, array( $unique_hook_two ) );
-		$this->assertInstanceof( 'ActionScheduler_ActionClaim', $claim );
-		$this->assertCount( 3, $claim->get_actions() );
-		$this->assertEqualSets( array_slice( $created_actions_by_hook[ $unique_hook_two ], 3, 3 ), $claim->get_actions() );
-	}
-
-	public function test_claim_actions_by_group() {
-		$created_actions  = array();
-		$store            = new ActionScheduler_DBStore();
-		$unique_group_one = 'my_unique_group_one';
-		$unique_group_two = 'my_unique_group_two';
-		$unique_groups    = array(
-			$unique_group_one,
-			$unique_group_two,
-		);
-
-		for ( $i = 3; $i > - 3; $i -- ) {
-			foreach ( $unique_groups as $unique_group ) {
-				$time     = as_get_datetime_object( $i . ' hours' );
-				$schedule = new ActionScheduler_SimpleSchedule( $time );
-				$action   = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( $i ), $schedule, $unique_group );
-
-				$created_actions[ $unique_group ][] = $store->save_action( $action );
-			}
-		}
-
-		$claim = $store->stake_claim( 10, null, array(), $unique_group_one );
-		$this->assertInstanceof( 'ActionScheduler_ActionClaim', $claim );
-		$this->assertCount( 3, $claim->get_actions() );
-		$this->assertEqualSets( array_slice( $created_actions[ $unique_group_one ], 3, 3 ), $claim->get_actions() );
-
-		$store->release_claim( $claim );
-
-		$claim = $store->stake_claim( 10, null, array(), $unique_group_two );
-		$this->assertInstanceof( 'ActionScheduler_ActionClaim', $claim );
-		$this->assertCount( 3, $claim->get_actions() );
-		$this->assertEqualSets( array_slice( $created_actions[ $unique_group_two ], 3, 3 ), $claim->get_actions() );
-	}
-
-	public function test_claim_actions_by_hook_and_group() {
-		$created_actions = $created_actions_by_hook = array();
-		$store           = new ActionScheduler_DBStore();
-
-		$unique_hook_one = 'my_other_unique_hook_one';
-		$unique_hook_two = 'my_other_unique_hook_two';
-		$unique_hooks    = array(
-			$unique_hook_one,
-			$unique_hook_two,
-		);
-
-		$unique_group_one = 'my_other_other_unique_group_one';
-		$unique_group_two = 'my_other_unique_group_two';
-		$unique_groups    = array(
-			$unique_group_one,
-			$unique_group_two,
-		);
-
-		for ( $i = 3; $i > - 3; $i -- ) {
-			foreach ( $unique_hooks as $unique_hook ) {
-				foreach ( $unique_groups as $unique_group ) {
-					$time     = as_get_datetime_object( $i . ' hours' );
-					$schedule = new ActionScheduler_SimpleSchedule( $time );
-					$action   = new ActionScheduler_Action( $unique_hook, array( $i ), $schedule, $unique_group );
-
-					$action_id                          = $store->save_action( $action );
-					$created_actions[ $unique_group ][] = $action_id;
-					$created_actions_by_hook[ $unique_hook ][ $unique_group ][] = $action_id;
-				}
-			}
-		}
-
-		/** Test Both Hooks with Each Group */
-
-		$claim = $store->stake_claim( 10, null, $unique_hooks, $unique_group_one );
-		$this->assertInstanceof( 'ActionScheduler_ActionClaim', $claim );
-		$this->assertCount( 6, $claim->get_actions() );
-		$this->assertEqualSets( array_slice( $created_actions[ $unique_group_one ], 6, 6 ), $claim->get_actions() );
-
-		$store->release_claim( $claim );
-
-		$claim = $store->stake_claim( 10, null, $unique_hooks, $unique_group_two );
-		$this->assertInstanceof( 'ActionScheduler_ActionClaim', $claim );
-		$this->assertCount( 6, $claim->get_actions() );
-		$this->assertEqualSets( array_slice( $created_actions[ $unique_group_two ], 6, 6 ), $claim->get_actions() );
-
-		$store->release_claim( $claim );
-
-		/** Test Just One Hook with Group One */
-
-		$claim = $store->stake_claim( 10, null, array( $unique_hook_one ), $unique_group_one );
-		$this->assertInstanceof( 'ActionScheduler_ActionClaim', $claim );
-		$this->assertCount( 3, $claim->get_actions() );
-		$this->assertEqualSets( array_slice( $created_actions_by_hook[ $unique_hook_one ][ $unique_group_one ], 3, 3 ), $claim->get_actions() );
-
-		$store->release_claim( $claim );
-
-		$claim = $store->stake_claim( 24, null, array( $unique_hook_two ), $unique_group_one );
-		$this->assertInstanceof( 'ActionScheduler_ActionClaim', $claim );
-		$this->assertCount( 3, $claim->get_actions() );
-		$this->assertEqualSets( array_slice( $created_actions_by_hook[ $unique_hook_two ][ $unique_group_one ], 3, 3 ), $claim->get_actions() );
-
-		$store->release_claim( $claim );
-
-		/** Test Just One Hook with Group Two */
-
-		$claim = $store->stake_claim( 10, null, array( $unique_hook_one ), $unique_group_two );
-		$this->assertInstanceof( 'ActionScheduler_ActionClaim', $claim );
-		$this->assertCount( 3, $claim->get_actions() );
-		$this->assertEqualSets( array_slice( $created_actions_by_hook[ $unique_hook_one ][ $unique_group_two ], 3, 3 ), $claim->get_actions() );
-
-		$store->release_claim( $claim );
-
-		$claim = $store->stake_claim( 24, null, array( $unique_hook_two ), $unique_group_two );
-		$this->assertInstanceof( 'ActionScheduler_ActionClaim', $claim );
-		$this->assertCount( 3, $claim->get_actions() );
-		$this->assertEqualSets( array_slice( $created_actions_by_hook[ $unique_hook_two ][ $unique_group_two ], 3, 3 ), $claim->get_actions() );
-	}
-
-	/**
-	 * The query used to claim actions explicitly ignores future pending actions, but it
-	 * is still possible under unusual conditions (such as if MySQL runs out of temporary
-	 * storage space) for such actions to be returned.
-	 *
-	 * When this happens, we still expect the store to filter them out, otherwise there is
-	 * a risk that actions will be unexpectedly processed ahead of time.
-	 *
-	 * @see https://github.com/woocommerce/action-scheduler/issues/634
-	 */
-	public function test_claim_filters_out_unexpected_future_actions() {
-		$group = __METHOD__;
-		$store = new ActionScheduler_DBStore();
-
-		// Create 4 actions: 2 that are already due (-3hrs and -1hrs) and 2 that are not yet due (+1hr and +3hrs).
-		for ( $i = -3; $i <= 3; $i += 2 ) {
-			$schedule     = new ActionScheduler_SimpleSchedule( as_get_datetime_object( $i . ' hours' ) );
-			$action_ids[] = $store->save_action( new ActionScheduler_Action( 'test_' . $i, array(), $schedule, $group ) );
-		}
-
-		// This callback is used to simulate the unusual conditions whereby MySQL might unexpectedly return future
-		// actions, contrary to the conditions used by the store object when staking its claim.
-		$simulate_unexpected_db_behavior = function ( $sql ) use ( $action_ids ) {
-			global $wpdb;
-
-			// Look out for the claim update query, ignore all others.
-			if (
-				0 !== strpos( $sql, "UPDATE $wpdb->actionscheduler_actions" )
-				|| ! preg_match( "/claim_id = 0 AND scheduled_date_gmt <= '([0-9:\-\s]{19})'/", $sql, $matches )
-				|| count( $matches ) !== 2
-			) {
-				return $sql;
-			}
-
-			// Now modify the query, forcing it to also return the future actions we created.
-			return str_replace( $matches[1], as_get_datetime_object( '+4 hours' )->format( 'Y-m-d H:i:s' ), $sql );
-		};
-
-		add_filter( 'query', $simulate_unexpected_db_behavior );
-		$claim           = $store->stake_claim( 10, null, array(), $group );
-		$claimed_actions = $claim->get_actions();
-		$this->assertCount( 2, $claimed_actions );
-
-		// Cleanup.
-		remove_filter( 'query', $simulate_unexpected_db_behavior );
-		$store->release_claim( $claim );
-	}
-
-	public function test_duplicate_claim() {
-		$created_actions = array();
-		$store           = new ActionScheduler_DBStore();
-		for ( $i = 0; $i > - 3; $i -- ) {
-			$time     = as_get_datetime_object( $i . ' hours' );
-			$schedule = new ActionScheduler_SimpleSchedule( $time );
-			$action   = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( $i ), $schedule, 'my_group' );
-
-			$created_actions[] = $store->save_action( $action );
-		}
-
-		$claim1 = $store->stake_claim();
-		$claim2 = $store->stake_claim();
-		$this->assertCount( 3, $claim1->get_actions() );
-		$this->assertCount( 0, $claim2->get_actions() );
-	}
-
-	public function test_release_claim() {
-		$created_actions = array();
-		$store           = new ActionScheduler_DBStore();
-		for ( $i = 0; $i > - 3; $i -- ) {
-			$time     = as_get_datetime_object( $i . ' hours' );
-			$schedule = new ActionScheduler_SimpleSchedule( $time );
-			$action   = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( $i ), $schedule, 'my_group' );
-
-			$created_actions[] = $store->save_action( $action );
-		}
-
-		$claim1 = $store->stake_claim();
-
-		$store->release_claim( $claim1 );
-
-		$claim2 = $store->stake_claim();
-		$this->assertCount( 3, $claim2->get_actions() );
-	}
-
-	public function test_search() {
-		$created_actions = array();
-		$store           = new ActionScheduler_DBStore();
-		for ( $i = - 3; $i <= 3; $i ++ ) {
-			$time     = as_get_datetime_object( $i . ' hours' );
-			$schedule = new ActionScheduler_SimpleSchedule( $time );
-			$action   = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( $i ), $schedule, 'my_group' );
-
-			$created_actions[] = $store->save_action( $action );
-		}
-
-		$next_no_args = $store->find_action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK );
-		$this->assertEquals( $created_actions[0], $next_no_args );
-
-		$next_with_args = $store->find_action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( 'args' => array( 1 ) ) );
-		$this->assertEquals( $created_actions[4], $next_with_args );
-
-		$non_existent = $store->find_action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( 'args' => array( 17 ) ) );
-		$this->assertNull( $non_existent );
-	}
-
-	public function test_search_by_group() {
-		$store    = new ActionScheduler_DBStore();
-		$schedule = new ActionScheduler_SimpleSchedule( as_get_datetime_object( 'tomorrow' ) );
-
-		$abc = $store->save_action( new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( 1 ), $schedule, 'abc' ) );
-		$def = $store->save_action( new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( 1 ), $schedule, 'def' ) );
-		$ghi = $store->save_action( new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( 1 ), $schedule, 'ghi' ) );
-
-		$this->assertEquals( $abc, $store->find_action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( 'group' => 'abc' ) ) );
-		$this->assertEquals( $def, $store->find_action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( 'group' => 'def' ) ) );
-		$this->assertEquals( $ghi, $store->find_action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( 'group' => 'ghi' ) ) );
-	}
-
-	public function test_get_run_date() {
-		$time      = as_get_datetime_object( '-10 minutes' );
-		$schedule  = new ActionScheduler_IntervalSchedule( $time, HOUR_IN_SECONDS );
-		$action    = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule );
-		$store     = new ActionScheduler_DBStore();
-		$action_id = $store->save_action( $action );
-
-		$this->assertEquals( $time->format( 'U' ), $store->get_date( $action_id )->format( 'U' ) );
-
-		$action = $store->fetch_action( $action_id );
-		$action->execute();
-		$now = as_get_datetime_object();
-		$store->mark_complete( $action_id );
-
-		$this->assertEquals( $now->format( 'U' ), $store->get_date( $action_id )->format( 'U' ) );
-
-		$next          = $action->get_schedule()->get_next( $now );
-		$new_action_id = $store->save_action( $action, $next );
-
-		$this->assertEquals( (int) ( $now->format( 'U' ) ) + HOUR_IN_SECONDS, $store->get_date( $new_action_id )->format( 'U' ) );
-	}
-
-	/**
-	 * Test creating a unique action.
-	 */
-	public function test_create_action_unique() {
-		$time     = as_get_datetime_object();
-		$hook     = md5( rand() );
-		$schedule = new ActionScheduler_SimpleSchedule( $time );
-		$store    = new ActionScheduler_DBStore();
-		$action   = new ActionScheduler_Action( $hook, array(), $schedule );
-
-		$action_id = $store->save_action( $action );
-		$this->assertNotEquals( 0, $action_id );
-		$action_from_db = $store->fetch_action( $action_id );
-		$this->assertTrue( is_a( $action_from_db, ActionScheduler_Action::class ) );
-
-		$action              = new ActionScheduler_Action( $hook, array(), $schedule );
-		$action_id_duplicate = $store->save_unique_action( $action );
-		$this->assertSame( 0, $action_id_duplicate );
-	}
-
-	/**
-	 * Test saving unique actions across different groups. Different groups should be saved, same groups shouldn't.
-	 */
-	public function test_create_action_unique_with_different_groups() {
-		$time     = as_get_datetime_object();
-		$hook     = md5( rand() );
-		$schedule = new ActionScheduler_SimpleSchedule( $time );
-		$store    = new ActionScheduler_DBStore();
-		$action   = new ActionScheduler_Action( $hook, array(), $schedule, 'group1' );
-
-		$action_id      = $store->save_action( $action );
-		$action_from_db = $store->fetch_action( $action_id );
-		$this->assertNotEquals( 0, $action_id );
-		$this->assertTrue( is_a( $action_from_db, ActionScheduler_Action::class ) );
-
-		$action2          = new ActionScheduler_Action( $hook, array(), $schedule, 'group2' );
-		$action_id_group2 = $store->save_unique_action( $action2 );
-		$this->assertNotEquals( 0, $action_id_group2 );
-		$action_2_from_db = $store->fetch_action( $action_id_group2 );
-		$this->assertTrue( is_a( $action_2_from_db, ActionScheduler_Action::class ) );
-
-		$action3                 = new ActionScheduler_Action( $hook, array(), $schedule, 'group2' );
-		$action_id_group2_double = $store->save_unique_action( $action3 );
-		$this->assertSame( 0, $action_id_group2_double );
-	}
-
-	/**
-	 * Test saving a unique action first, and then successfully scheduling a non-unique action.
-	 */
-	public function test_create_action_unique_and_then_non_unique() {
-		$time     = as_get_datetime_object();
-		$hook     = md5( rand() );
-		$schedule = new ActionScheduler_SimpleSchedule( $time );
-		$store    = new ActionScheduler_DBStore();
-		$action   = new ActionScheduler_Action( $hook, array(), $schedule );
-
-		$action_id = $store->save_unique_action( $action );
-		$this->assertNotEquals( 0, $action_id );
-		$action_from_db = $store->fetch_action( $action_id );
-		$this->assertTrue( is_a( $action_from_db, ActionScheduler_Action::class ) );
-
-		// Non unique action is scheduled even if the previous one was unique.
-		$action              = new ActionScheduler_Action( $hook, array(), $schedule );
-		$action_id_duplicate = $store->save_action( $action );
-		$this->assertNotEquals( 0, $action_id_duplicate );
-		$action_from_db_duplicate = $store->fetch_action( $action_id_duplicate );
-		$this->assertTrue( is_a( $action_from_db_duplicate, ActionScheduler_Action::class ) );
-	}
-
-	/**
-	 * Test asserting that action when an action is created with empty args, it matches with actions created with args for uniqueness.
-	 */
-	public function test_create_action_unique_with_empty_array() {
-		$time     = as_get_datetime_object();
-		$hook     = md5( rand() );
-		$schedule = new ActionScheduler_SimpleSchedule( $time );
-		$store    = new ActionScheduler_DBStore();
-		$action   = new ActionScheduler_Action( $hook, array( 'foo' => 'bar' ), $schedule );
-
-		$action_id = $store->save_unique_action( $action );
-		$this->assertNotEquals( 0, $action_id );
-		$action_from_db = $store->fetch_action( $action_id );
-		$this->assertTrue( is_a( $action_from_db, ActionScheduler_Action::class ) );
-
-		$action_with_empty_args = new ActionScheduler_Action( $hook, array(), $schedule );
-		$action_id_duplicate    = $store->save_unique_action( $action_with_empty_args );
-		$this->assertSame( 0, $action_id_duplicate );
-	}
-
-	/**
-	 * Uniqueness does not check for args, so actions with different args can't be scheduled when unique is true.
-	 */
-	public function test_create_action_unique_with_different_args_still_fail() {
-		$time     = as_get_datetime_object();
-		$hook     = md5( rand() );
-		$schedule = new ActionScheduler_SimpleSchedule( $time );
-		$store    = new ActionScheduler_DBStore();
-		$action   = new ActionScheduler_Action( $hook, array( 'foo' => 'bar' ), $schedule );
-
-		$action_id = $store->save_unique_action( $action );
-		$this->assertNotEquals( 0, $action_id );
-		$action_from_db = $store->fetch_action( $action_id );
-		$this->assertTrue( is_a( $action_from_db, ActionScheduler_Action::class ) );
-
-		$action_with_diff_args = new ActionScheduler_Action( $hook, array( 'foo' => 'bazz' ), $schedule );
-		$action_id_duplicate   = $store->save_unique_action( $action_with_diff_args );
-		$this->assertSame( 0, $action_id_duplicate );
-	}
+    public function setUp() {
+        global $wpdb;
+
+        // Delete all actions before each test.
+        $wpdb->query( "DELETE FROM {$wpdb->actionscheduler_actions}" );
+
+        parent::setUp();
+    }
+
+    /**
+     * Get data store for tests.
+     *
+     * @return ActionScheduler_DBStore
+     */
+    protected function get_store() {
+        return new ActionScheduler_DBStore();
+    }
+
+    public function test_create_action() {
+        $time      = as_get_datetime_object();
+        $schedule  = new ActionScheduler_SimpleSchedule( $time );
+        $action    = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule );
+        $store     = new ActionScheduler_DBStore();
+        $action_id = $store->save_action( $action );
+
+        $this->assertNotEmpty( $action_id );
+    }
+
+    public function test_create_action_with_scheduled_date() {
+        $time        = as_get_datetime_object( strtotime( '-1 week' ) );
+        $action      = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), new ActionScheduler_SimpleSchedule( $time ) );
+        $store       = new ActionScheduler_DBStore();
+        $action_id   = $store->save_action( $action, $time );
+        $action_date = $store->get_date( $action_id );
+
+        $this->assertEquals( $time->format( 'U' ), $action_date->format( 'U' ) );
+    }
+
+    public function test_retrieve_action() {
+        $time      = as_get_datetime_object();
+        $schedule  = new ActionScheduler_SimpleSchedule( $time );
+        $action    = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule, 'my_group' );
+        $store     = new ActionScheduler_DBStore();
+        $action_id = $store->save_action( $action );
+
+        $retrieved = $store->fetch_action( $action_id );
+        $this->assertEquals( $action->get_hook(), $retrieved->get_hook() );
+        $this->assertEqualSets( $action->get_args(), $retrieved->get_args() );
+        $this->assertEquals( $action->get_schedule()->get_date()->format( 'U' ), $retrieved->get_schedule()->get_date()->format( 'U' ) );
+        $this->assertEquals( $action->get_group(), $retrieved->get_group() );
+    }
+
+    public function test_cancel_action() {
+        $time      = as_get_datetime_object();
+        $schedule  = new ActionScheduler_SimpleSchedule( $time );
+        $action    = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule, 'my_group' );
+        $store     = new ActionScheduler_DBStore();
+        $action_id = $store->save_action( $action );
+        $store->cancel_action( $action_id );
+
+        $fetched = $store->fetch_action( $action_id );
+        $this->assertInstanceOf( 'ActionScheduler_CanceledAction', $fetched );
+    }
+
+    public function test_cancel_actions_by_hook() {
+        $store   = new ActionScheduler_DBStore();
+        $actions = array();
+        $hook    = 'by_hook_test';
+        for ( $day = 1; $day <= 3; $day++ ) {
+            $delta     = sprintf( '+%d day', $day );
+            $time      = as_get_datetime_object( $delta );
+            $schedule  = new ActionScheduler_SimpleSchedule( $time );
+            $action    = new ActionScheduler_Action( $hook, array(), $schedule, 'my_group' );
+            $actions[] = $store->save_action( $action );
+        }
+        $store->cancel_actions_by_hook( $hook );
+
+        foreach ( $actions as $action_id ) {
+            $fetched = $store->fetch_action( $action_id );
+            $this->assertInstanceOf( 'ActionScheduler_CanceledAction', $fetched );
+        }
+    }
+
+    public function test_cancel_actions_by_group() {
+        $store   = new ActionScheduler_DBStore();
+        $actions = array();
+        $group   = 'by_group_test';
+        for ( $day = 1; $day <= 3; $day++ ) {
+            $delta     = sprintf( '+%d day', $day );
+            $time      = as_get_datetime_object( $delta );
+            $schedule  = new ActionScheduler_SimpleSchedule( $time );
+            $action    = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule, $group );
+            $actions[] = $store->save_action( $action );
+        }
+        $store->cancel_actions_by_group( $group );
+
+        foreach ( $actions as $action_id ) {
+            $fetched = $store->fetch_action( $action_id );
+            $this->assertInstanceOf( 'ActionScheduler_CanceledAction', $fetched );
+        }
+    }
+
+    public function test_claim_actions() {
+        $created_actions = array();
+        $store           = new ActionScheduler_DBStore();
+        for ( $i = 3; $i > - 3; $i -- ) {
+            $time     = as_get_datetime_object( $i . ' hours' );
+            $schedule = new ActionScheduler_SimpleSchedule( $time );
+            $action   = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( $i ), $schedule, 'my_group' );
+
+            $created_actions[] = $store->save_action( $action );
+        }
+
+        $claim = $store->stake_claim();
+        $this->assertInstanceof( 'ActionScheduler_ActionClaim', $claim );
+
+        $this->assertCount( 3, $claim->get_actions() );
+        $this->assertEqualSets( array_slice( $created_actions, 3, 3 ), $claim->get_actions() );
+    }
+
+    public function test_claim_actions_order() {
+
+        $store           = new ActionScheduler_DBStore();
+        $schedule        = new ActionScheduler_SimpleSchedule( as_get_datetime_object( '-1 hour' ) );
+        $created_actions = array(
+            $store->save_action( new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( 1 ), $schedule, 'my_group' ) ),
+            $store->save_action( new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( 1 ), $schedule, 'my_group' ) ),
+        );
+
+        $claim = $store->stake_claim();
+        $this->assertInstanceof( 'ActionScheduler_ActionClaim', $claim );
+
+        // Verify uniqueness of action IDs.
+        $this->assertCount( 2, array_unique( $created_actions ) );
+
+        // Verify the count and order of the actions.
+        $claimed_actions = $claim->get_actions();
+        $this->assertCount( 2, $claimed_actions );
+        $this->assertEquals( $created_actions, $claimed_actions );
+
+        // Verify the reversed order doesn't pass.
+        $reversed_actions = array_reverse( $created_actions );
+        $this->assertNotEquals( $reversed_actions, $claimed_actions );
+    }
+
+    public function test_claim_actions_by_hooks() {
+        $created_actions = $created_actions_by_hook = array();
+        $store           = new ActionScheduler_DBStore();
+        $unique_hook_one = 'my_unique_hook_one';
+        $unique_hook_two = 'my_unique_hook_two';
+        $unique_hooks    = array(
+            $unique_hook_one,
+            $unique_hook_two,
+        );
+
+        for ( $i = 3; $i > - 3; $i -- ) {
+            foreach ( $unique_hooks as $unique_hook ) {
+                $time     = as_get_datetime_object( $i . ' hours' );
+                $schedule = new ActionScheduler_SimpleSchedule( $time );
+                $action   = new ActionScheduler_Action( $unique_hook, array( $i ), $schedule, 'my_group' );
+
+                $action_id         = $store->save_action( $action );
+                $created_actions[] = $created_actions_by_hook[ $unique_hook ][] = $action_id;
+            }
+        }
+
+        $claim = $store->stake_claim( 10, null, $unique_hooks );
+        $this->assertInstanceof( 'ActionScheduler_ActionClaim', $claim );
+        $this->assertCount( 6, $claim->get_actions() );
+        $this->assertEqualSets( array_slice( $created_actions, 6, 6 ), $claim->get_actions() );
+
+        $store->release_claim( $claim );
+
+        $claim = $store->stake_claim( 10, null, array( $unique_hook_one ) );
+        $this->assertInstanceof( 'ActionScheduler_ActionClaim', $claim );
+        $this->assertCount( 3, $claim->get_actions() );
+        $this->assertEqualSets( array_slice( $created_actions_by_hook[ $unique_hook_one ], 3, 3 ), $claim->get_actions() );
+
+        $store->release_claim( $claim );
+
+        $claim = $store->stake_claim( 10, null, array( $unique_hook_two ) );
+        $this->assertInstanceof( 'ActionScheduler_ActionClaim', $claim );
+        $this->assertCount( 3, $claim->get_actions() );
+        $this->assertEqualSets( array_slice( $created_actions_by_hook[ $unique_hook_two ], 3, 3 ), $claim->get_actions() );
+    }
+
+    public function test_claim_actions_by_group() {
+        $created_actions  = array();
+        $store            = new ActionScheduler_DBStore();
+        $unique_group_one = 'my_unique_group_one';
+        $unique_group_two = 'my_unique_group_two';
+        $unique_groups    = array(
+            $unique_group_one,
+            $unique_group_two,
+        );
+
+        for ( $i = 3; $i > - 3; $i -- ) {
+            foreach ( $unique_groups as $unique_group ) {
+                $time     = as_get_datetime_object( $i . ' hours' );
+                $schedule = new ActionScheduler_SimpleSchedule( $time );
+                $action   = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( $i ), $schedule, $unique_group );
+
+                $created_actions[ $unique_group ][] = $store->save_action( $action );
+            }
+        }
+
+        $claim = $store->stake_claim( 10, null, array(), $unique_group_one );
+        $this->assertInstanceof( 'ActionScheduler_ActionClaim', $claim );
+        $this->assertCount( 3, $claim->get_actions() );
+        $this->assertEqualSets( array_slice( $created_actions[ $unique_group_one ], 3, 3 ), $claim->get_actions() );
+
+        $store->release_claim( $claim );
+
+        $claim = $store->stake_claim( 10, null, array(), $unique_group_two );
+        $this->assertInstanceof( 'ActionScheduler_ActionClaim', $claim );
+        $this->assertCount( 3, $claim->get_actions() );
+        $this->assertEqualSets( array_slice( $created_actions[ $unique_group_two ], 3, 3 ), $claim->get_actions() );
+    }
+
+    public function test_claim_actions_by_hook_and_group() {
+        $created_actions = $created_actions_by_hook = array();
+        $store           = new ActionScheduler_DBStore();
+
+        $unique_hook_one = 'my_other_unique_hook_one';
+        $unique_hook_two = 'my_other_unique_hook_two';
+        $unique_hooks    = array(
+            $unique_hook_one,
+            $unique_hook_two,
+        );
+
+        $unique_group_one = 'my_other_other_unique_group_one';
+        $unique_group_two = 'my_other_unique_group_two';
+        $unique_groups    = array(
+            $unique_group_one,
+            $unique_group_two,
+        );
+
+        for ( $i = 3; $i > - 3; $i -- ) {
+            foreach ( $unique_hooks as $unique_hook ) {
+                foreach ( $unique_groups as $unique_group ) {
+                    $time     = as_get_datetime_object( $i . ' hours' );
+                    $schedule = new ActionScheduler_SimpleSchedule( $time );
+                    $action   = new ActionScheduler_Action( $unique_hook, array( $i ), $schedule, $unique_group );
+
+                    $action_id                          = $store->save_action( $action );
+                    $created_actions[ $unique_group ][] = $action_id;
+                    $created_actions_by_hook[ $unique_hook ][ $unique_group ][] = $action_id;
+                }
+            }
+        }
+
+        /** Test Both Hooks with Each Group */
+
+        $claim = $store->stake_claim( 10, null, $unique_hooks, $unique_group_one );
+        $this->assertInstanceof( 'ActionScheduler_ActionClaim', $claim );
+        $this->assertCount( 6, $claim->get_actions() );
+        $this->assertEqualSets( array_slice( $created_actions[ $unique_group_one ], 6, 6 ), $claim->get_actions() );
+
+        $store->release_claim( $claim );
+
+        $claim = $store->stake_claim( 10, null, $unique_hooks, $unique_group_two );
+        $this->assertInstanceof( 'ActionScheduler_ActionClaim', $claim );
+        $this->assertCount( 6, $claim->get_actions() );
+        $this->assertEqualSets( array_slice( $created_actions[ $unique_group_two ], 6, 6 ), $claim->get_actions() );
+
+        $store->release_claim( $claim );
+
+        /** Test Just One Hook with Group One */
+
+        $claim = $store->stake_claim( 10, null, array( $unique_hook_one ), $unique_group_one );
+        $this->assertInstanceof( 'ActionScheduler_ActionClaim', $claim );
+        $this->assertCount( 3, $claim->get_actions() );
+        $this->assertEqualSets( array_slice( $created_actions_by_hook[ $unique_hook_one ][ $unique_group_one ], 3, 3 ), $claim->get_actions() );
+
+        $store->release_claim( $claim );
+
+        $claim = $store->stake_claim( 24, null, array( $unique_hook_two ), $unique_group_one );
+        $this->assertInstanceof( 'ActionScheduler_ActionClaim', $claim );
+        $this->assertCount( 3, $claim->get_actions() );
+        $this->assertEqualSets( array_slice( $created_actions_by_hook[ $unique_hook_two ][ $unique_group_one ], 3, 3 ), $claim->get_actions() );
+
+        $store->release_claim( $claim );
+
+        /** Test Just One Hook with Group Two */
+
+        $claim = $store->stake_claim( 10, null, array( $unique_hook_one ), $unique_group_two );
+        $this->assertInstanceof( 'ActionScheduler_ActionClaim', $claim );
+        $this->assertCount( 3, $claim->get_actions() );
+        $this->assertEqualSets( array_slice( $created_actions_by_hook[ $unique_hook_one ][ $unique_group_two ], 3, 3 ), $claim->get_actions() );
+
+        $store->release_claim( $claim );
+
+        $claim = $store->stake_claim( 24, null, array( $unique_hook_two ), $unique_group_two );
+        $this->assertInstanceof( 'ActionScheduler_ActionClaim', $claim );
+        $this->assertCount( 3, $claim->get_actions() );
+        $this->assertEqualSets( array_slice( $created_actions_by_hook[ $unique_hook_two ][ $unique_group_two ], 3, 3 ), $claim->get_actions() );
+    }
+
+    /**
+     * The query used to claim actions explicitly ignores future pending actions, but it
+     * is still possible under unusual conditions (such as if MySQL runs out of temporary
+     * storage space) for such actions to be returned.
+     *
+     * When this happens, we still expect the store to filter them out, otherwise there is
+     * a risk that actions will be unexpectedly processed ahead of time.
+     *
+     * @see https://github.com/woocommerce/action-scheduler/issues/634
+     */
+    public function test_claim_filters_out_unexpected_future_actions() {
+        $group = __METHOD__;
+        $store = new ActionScheduler_DBStore();
+
+        // Create 4 actions: 2 that are already due (-3hrs and -1hrs) and 2 that are not yet due (+1hr and +3hrs).
+        for ( $i = -3; $i <= 3; $i += 2 ) {
+            $schedule     = new ActionScheduler_SimpleSchedule( as_get_datetime_object( $i . ' hours' ) );
+            $action_ids[] = $store->save_action( new ActionScheduler_Action( 'test_' . $i, array(), $schedule, $group ) );
+        }
+
+        // This callback is used to simulate the unusual conditions whereby MySQL might unexpectedly return future
+        // actions, contrary to the conditions used by the store object when staking its claim.
+        $simulate_unexpected_db_behavior = function ( $sql ) use ( $action_ids ) {
+            global $wpdb;
+
+            // Look out for the claim update query, ignore all others.
+            if (
+                0 !== strpos( $sql, "UPDATE $wpdb->actionscheduler_actions" )
+                || ! preg_match( "/claim_id = 0 AND scheduled_date_gmt <= '([0-9:\-\s]{19})'/", $sql, $matches )
+                || count( $matches ) !== 2
+            ) {
+                return $sql;
+            }
+
+            // Now modify the query, forcing it to also return the future actions we created.
+            return str_replace( $matches[1], as_get_datetime_object( '+4 hours' )->format( 'Y-m-d H:i:s' ), $sql );
+        };
+
+        add_filter( 'query', $simulate_unexpected_db_behavior );
+        $claim           = $store->stake_claim( 10, null, array(), $group );
+        $claimed_actions = $claim->get_actions();
+        $this->assertCount( 2, $claimed_actions );
+
+        // Cleanup.
+        remove_filter( 'query', $simulate_unexpected_db_behavior );
+        $store->release_claim( $claim );
+    }
+
+    public function test_duplicate_claim() {
+        $created_actions = array();
+        $store           = new ActionScheduler_DBStore();
+        for ( $i = 0; $i > - 3; $i -- ) {
+            $time     = as_get_datetime_object( $i . ' hours' );
+            $schedule = new ActionScheduler_SimpleSchedule( $time );
+            $action   = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( $i ), $schedule, 'my_group' );
+
+            $created_actions[] = $store->save_action( $action );
+        }
+
+        $claim1 = $store->stake_claim();
+        $claim2 = $store->stake_claim();
+        $this->assertCount( 3, $claim1->get_actions() );
+        $this->assertCount( 0, $claim2->get_actions() );
+    }
+
+    public function test_release_claim() {
+        $created_actions = array();
+        $store           = new ActionScheduler_DBStore();
+        for ( $i = 0; $i > - 3; $i -- ) {
+            $time     = as_get_datetime_object( $i . ' hours' );
+            $schedule = new ActionScheduler_SimpleSchedule( $time );
+            $action   = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( $i ), $schedule, 'my_group' );
+
+            $created_actions[] = $store->save_action( $action );
+        }
+
+        $claim1 = $store->stake_claim();
+
+        $store->release_claim( $claim1 );
+
+        $claim2 = $store->stake_claim();
+        $this->assertCount( 3, $claim2->get_actions() );
+    }
+
+    public function test_search() {
+        $created_actions = array();
+        $store           = new ActionScheduler_DBStore();
+        for ( $i = - 3; $i <= 3; $i ++ ) {
+            $time     = as_get_datetime_object( $i . ' hours' );
+            $schedule = new ActionScheduler_SimpleSchedule( $time );
+            $action   = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( $i ), $schedule, 'my_group' );
+
+            $created_actions[] = $store->save_action( $action );
+        }
+
+        $next_no_args = $store->find_action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK );
+        $this->assertEquals( $created_actions[0], $next_no_args );
+
+        $next_with_args = $store->find_action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( 'args' => array( 1 ) ) );
+        $this->assertEquals( $created_actions[4], $next_with_args );
+
+        $non_existent = $store->find_action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( 'args' => array( 17 ) ) );
+        $this->assertNull( $non_existent );
+    }
+
+    public function test_search_by_group() {
+        $store    = new ActionScheduler_DBStore();
+        $schedule = new ActionScheduler_SimpleSchedule( as_get_datetime_object( 'tomorrow' ) );
+
+        $abc = $store->save_action( new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( 1 ), $schedule, 'abc' ) );
+        $def = $store->save_action( new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( 1 ), $schedule, 'def' ) );
+        $ghi = $store->save_action( new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( 1 ), $schedule, 'ghi' ) );
+
+        $this->assertEquals( $abc, $store->find_action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( 'group' => 'abc' ) ) );
+        $this->assertEquals( $def, $store->find_action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( 'group' => 'def' ) ) );
+        $this->assertEquals( $ghi, $store->find_action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( 'group' => 'ghi' ) ) );
+    }
+
+    public function test_get_run_date() {
+        $time      = as_get_datetime_object( '-10 minutes' );
+        $schedule  = new ActionScheduler_IntervalSchedule( $time, HOUR_IN_SECONDS );
+        $action    = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule );
+        $store     = new ActionScheduler_DBStore();
+        $action_id = $store->save_action( $action );
+
+        $this->assertEquals( $time->format( 'U' ), $store->get_date( $action_id )->format( 'U' ) );
+
+        $action = $store->fetch_action( $action_id );
+        $action->execute();
+        $now = as_get_datetime_object();
+        $store->mark_complete( $action_id );
+
+        $this->assertEquals( $now->format( 'U' ), $store->get_date( $action_id )->format( 'U' ) );
+
+        $next          = $action->get_schedule()->get_next( $now );
+        $new_action_id = $store->save_action( $action, $next );
+
+        $this->assertEquals( (int) ( $now->format( 'U' ) ) + HOUR_IN_SECONDS, $store->get_date( $new_action_id )->format( 'U' ) );
+    }
+
+    /**
+     * Test creating a unique action.
+     */
+    public function test_create_action_unique() {
+        $time     = as_get_datetime_object();
+        $hook     = md5( rand() );
+        $schedule = new ActionScheduler_SimpleSchedule( $time );
+        $store    = new ActionScheduler_DBStore();
+        $action   = new ActionScheduler_Action( $hook, array(), $schedule );
+
+        $action_id = $store->save_action( $action );
+        $this->assertNotEquals( 0, $action_id );
+        $action_from_db = $store->fetch_action( $action_id );
+        $this->assertTrue( is_a( $action_from_db, ActionScheduler_Action::class ) );
+
+        $action              = new ActionScheduler_Action( $hook, array(), $schedule );
+        $action_id_duplicate = $store->save_unique_action( $action );
+        $this->assertSame( 0, $action_id_duplicate );
+    }
+
+    /**
+     * Test saving unique actions across different groups. Different groups should be saved, same groups shouldn't.
+     */
+    public function test_create_action_unique_with_different_groups() {
+        $time     = as_get_datetime_object();
+        $hook     = md5( rand() );
+        $schedule = new ActionScheduler_SimpleSchedule( $time );
+        $store    = new ActionScheduler_DBStore();
+        $action   = new ActionScheduler_Action( $hook, array(), $schedule, 'group1' );
+
+        $action_id      = $store->save_action( $action );
+        $action_from_db = $store->fetch_action( $action_id );
+        $this->assertNotEquals( 0, $action_id );
+        $this->assertTrue( is_a( $action_from_db, ActionScheduler_Action::class ) );
+
+        $action2          = new ActionScheduler_Action( $hook, array(), $schedule, 'group2' );
+        $action_id_group2 = $store->save_unique_action( $action2 );
+        $this->assertNotEquals( 0, $action_id_group2 );
+        $action_2_from_db = $store->fetch_action( $action_id_group2 );
+        $this->assertTrue( is_a( $action_2_from_db, ActionScheduler_Action::class ) );
+
+        $action3                 = new ActionScheduler_Action( $hook, array(), $schedule, 'group2' );
+        $action_id_group2_double = $store->save_unique_action( $action3 );
+        $this->assertSame( 0, $action_id_group2_double );
+    }
+
+    /**
+     * Test saving a unique action first, and then successfully scheduling a non-unique action.
+     */
+    public function test_create_action_unique_and_then_non_unique() {
+        $time     = as_get_datetime_object();
+        $hook     = md5( rand() );
+        $schedule = new ActionScheduler_SimpleSchedule( $time );
+        $store    = new ActionScheduler_DBStore();
+        $action   = new ActionScheduler_Action( $hook, array(), $schedule );
+
+        $action_id = $store->save_unique_action( $action );
+        $this->assertNotEquals( 0, $action_id );
+        $action_from_db = $store->fetch_action( $action_id );
+        $this->assertTrue( is_a( $action_from_db, ActionScheduler_Action::class ) );
+
+        // Non unique action is scheduled even if the previous one was unique.
+        $action              = new ActionScheduler_Action( $hook, array(), $schedule );
+        $action_id_duplicate = $store->save_action( $action );
+        $this->assertNotEquals( 0, $action_id_duplicate );
+        $action_from_db_duplicate = $store->fetch_action( $action_id_duplicate );
+        $this->assertTrue( is_a( $action_from_db_duplicate, ActionScheduler_Action::class ) );
+    }
+
+    /**
+     * Test asserting that action when an action is created with empty args, it matches with actions created with args for uniqueness.
+     */
+    public function test_create_action_unique_with_empty_array() {
+        $time     = as_get_datetime_object();
+        $hook     = md5( rand() );
+        $schedule = new ActionScheduler_SimpleSchedule( $time );
+        $store    = new ActionScheduler_DBStore();
+        $action   = new ActionScheduler_Action( $hook, array( 'foo' => 'bar' ), $schedule );
+
+        $action_id = $store->save_unique_action( $action );
+        $this->assertNotEquals( 0, $action_id );
+        $action_from_db = $store->fetch_action( $action_id );
+        $this->assertTrue( is_a( $action_from_db, ActionScheduler_Action::class ) );
+
+        $action_with_empty_args = new ActionScheduler_Action( $hook, array(), $schedule );
+        $action_id_duplicate    = $store->save_unique_action( $action_with_empty_args );
+        $this->assertSame( 0, $action_id_duplicate );
+    }
+
+    /**
+     * Uniqueness does not check for args, so actions with different args can't be scheduled when unique is true.
+     */
+    public function test_create_action_unique_with_different_args_still_fail() {
+        $time     = as_get_datetime_object();
+        $hook     = md5( rand() );
+        $schedule = new ActionScheduler_SimpleSchedule( $time );
+        $store    = new ActionScheduler_DBStore();
+        $action   = new ActionScheduler_Action( $hook, array( 'foo' => 'bar' ), $schedule );
+
+        $action_id = $store->save_unique_action( $action );
+        $this->assertNotEquals( 0, $action_id );
+        $action_from_db = $store->fetch_action( $action_id );
+        $this->assertTrue( is_a( $action_from_db, ActionScheduler_Action::class ) );
+
+        $action_with_diff_args = new ActionScheduler_Action( $hook, array( 'foo' => 'bazz' ), $schedule );
+        $action_id_duplicate   = $store->save_unique_action( $action_with_diff_args );
+        $this->assertSame( 0, $action_id_duplicate );
+    }
 }

Spacing +251 added lines, -251 removed lines

@@ -13,7 +13,7 @@ 
 		global $wpdb;
 
 		// Delete all actions before each test.
-		$wpdb->query( "DELETE FROM {$wpdb->actionscheduler_actions}" );
+		$wpdb->query("DELETE FROM {$wpdb->actionscheduler_actions}");
 
 		parent::setUp();
 	}
@@ -29,66 +29,66 @@ 
 
 	public function test_create_action() {
 		$time      = as_get_datetime_object();
-		$schedule  = new ActionScheduler_SimpleSchedule( $time );
-		$action    = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule );
+		$schedule  = new ActionScheduler_SimpleSchedule($time);
+		$action    = new ActionScheduler_Action(ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule);
 		$store     = new ActionScheduler_DBStore();
-		$action_id = $store->save_action( $action );
+		$action_id = $store->save_action($action);
 
-		$this->assertNotEmpty( $action_id );
+		$this->assertNotEmpty($action_id);
 	}
 
 	public function test_create_action_with_scheduled_date() {
-		$time        = as_get_datetime_object( strtotime( '-1 week' ) );
-		$action      = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), new ActionScheduler_SimpleSchedule( $time ) );
+		$time        = as_get_datetime_object(strtotime('-1 week'));
+		$action      = new ActionScheduler_Action(ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), new ActionScheduler_SimpleSchedule($time));
 		$store       = new ActionScheduler_DBStore();
-		$action_id   = $store->save_action( $action, $time );
-		$action_date = $store->get_date( $action_id );
+		$action_id   = $store->save_action($action, $time);
+		$action_date = $store->get_date($action_id);
 
-		$this->assertEquals( $time->format( 'U' ), $action_date->format( 'U' ) );
+		$this->assertEquals($time->format('U'), $action_date->format('U'));
 	}
 
 	public function test_retrieve_action() {
 		$time      = as_get_datetime_object();
-		$schedule  = new ActionScheduler_SimpleSchedule( $time );
-		$action    = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule, 'my_group' );
+		$schedule  = new ActionScheduler_SimpleSchedule($time);
+		$action    = new ActionScheduler_Action(ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule, 'my_group');
 		$store     = new ActionScheduler_DBStore();
-		$action_id = $store->save_action( $action );
+		$action_id = $store->save_action($action);
 
-		$retrieved = $store->fetch_action( $action_id );
-		$this->assertEquals( $action->get_hook(), $retrieved->get_hook() );
-		$this->assertEqualSets( $action->get_args(), $retrieved->get_args() );
-		$this->assertEquals( $action->get_schedule()->get_date()->format( 'U' ), $retrieved->get_schedule()->get_date()->format( 'U' ) );
-		$this->assertEquals( $action->get_group(), $retrieved->get_group() );
+		$retrieved = $store->fetch_action($action_id);
+		$this->assertEquals($action->get_hook(), $retrieved->get_hook());
+		$this->assertEqualSets($action->get_args(), $retrieved->get_args());
+		$this->assertEquals($action->get_schedule()->get_date()->format('U'), $retrieved->get_schedule()->get_date()->format('U'));
+		$this->assertEquals($action->get_group(), $retrieved->get_group());
 	}
 
 	public function test_cancel_action() {
 		$time      = as_get_datetime_object();
-		$schedule  = new ActionScheduler_SimpleSchedule( $time );
-		$action    = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule, 'my_group' );
+		$schedule  = new ActionScheduler_SimpleSchedule($time);
+		$action    = new ActionScheduler_Action(ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule, 'my_group');
 		$store     = new ActionScheduler_DBStore();
-		$action_id = $store->save_action( $action );
-		$store->cancel_action( $action_id );
+		$action_id = $store->save_action($action);
+		$store->cancel_action($action_id);
 
-		$fetched = $store->fetch_action( $action_id );
-		$this->assertInstanceOf( 'ActionScheduler_CanceledAction', $fetched );
+		$fetched = $store->fetch_action($action_id);
+		$this->assertInstanceOf('ActionScheduler_CanceledAction', $fetched);
 	}
 
 	public function test_cancel_actions_by_hook() {
 		$store   = new ActionScheduler_DBStore();
 		$actions = array();
 		$hook    = 'by_hook_test';
-		for ( $day = 1; $day <= 3; $day++ ) {
-			$delta     = sprintf( '+%d day', $day );
-			$time      = as_get_datetime_object( $delta );
-			$schedule  = new ActionScheduler_SimpleSchedule( $time );
-			$action    = new ActionScheduler_Action( $hook, array(), $schedule, 'my_group' );
-			$actions[] = $store->save_action( $action );
+		for ($day = 1; $day <= 3; $day++) {
+			$delta     = sprintf('+%d day', $day);
+			$time      = as_get_datetime_object($delta);
+			$schedule  = new ActionScheduler_SimpleSchedule($time);
+			$action    = new ActionScheduler_Action($hook, array(), $schedule, 'my_group');
+			$actions[] = $store->save_action($action);
 		}
-		$store->cancel_actions_by_hook( $hook );
+		$store->cancel_actions_by_hook($hook);
 
-		foreach ( $actions as $action_id ) {
-			$fetched = $store->fetch_action( $action_id );
-			$this->assertInstanceOf( 'ActionScheduler_CanceledAction', $fetched );
+		foreach ($actions as $action_id) {
+			$fetched = $store->fetch_action($action_id);
+			$this->assertInstanceOf('ActionScheduler_CanceledAction', $fetched);
 		}
 	}
 
@@ -96,62 +96,62 @@ 
 		$store   = new ActionScheduler_DBStore();
 		$actions = array();
 		$group   = 'by_group_test';
-		for ( $day = 1; $day <= 3; $day++ ) {
-			$delta     = sprintf( '+%d day', $day );
-			$time      = as_get_datetime_object( $delta );
-			$schedule  = new ActionScheduler_SimpleSchedule( $time );
-			$action    = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule, $group );
-			$actions[] = $store->save_action( $action );
+		for ($day = 1; $day <= 3; $day++) {
+			$delta     = sprintf('+%d day', $day);
+			$time      = as_get_datetime_object($delta);
+			$schedule  = new ActionScheduler_SimpleSchedule($time);
+			$action    = new ActionScheduler_Action(ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule, $group);
+			$actions[] = $store->save_action($action);
 		}
-		$store->cancel_actions_by_group( $group );
+		$store->cancel_actions_by_group($group);
 
-		foreach ( $actions as $action_id ) {
-			$fetched = $store->fetch_action( $action_id );
-			$this->assertInstanceOf( 'ActionScheduler_CanceledAction', $fetched );
+		foreach ($actions as $action_id) {
+			$fetched = $store->fetch_action($action_id);
+			$this->assertInstanceOf('ActionScheduler_CanceledAction', $fetched);
 		}
 	}
 
 	public function test_claim_actions() {
 		$created_actions = array();
 		$store           = new ActionScheduler_DBStore();
-		for ( $i = 3; $i > - 3; $i -- ) {
-			$time     = as_get_datetime_object( $i . ' hours' );
-			$schedule = new ActionScheduler_SimpleSchedule( $time );
-			$action   = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( $i ), $schedule, 'my_group' );
+		for ($i = 3; $i > - 3; $i--) {
+			$time     = as_get_datetime_object($i.' hours');
+			$schedule = new ActionScheduler_SimpleSchedule($time);
+			$action   = new ActionScheduler_Action(ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array($i), $schedule, 'my_group');
 
-			$created_actions[] = $store->save_action( $action );
+			$created_actions[] = $store->save_action($action);
 		}
 
 		$claim = $store->stake_claim();
-		$this->assertInstanceof( 'ActionScheduler_ActionClaim', $claim );
+		$this->assertInstanceof('ActionScheduler_ActionClaim', $claim);
 
-		$this->assertCount( 3, $claim->get_actions() );
-		$this->assertEqualSets( array_slice( $created_actions, 3, 3 ), $claim->get_actions() );
+		$this->assertCount(3, $claim->get_actions());
+		$this->assertEqualSets(array_slice($created_actions, 3, 3), $claim->get_actions());
 	}
 
 	public function test_claim_actions_order() {
 
 		$store           = new ActionScheduler_DBStore();
-		$schedule        = new ActionScheduler_SimpleSchedule( as_get_datetime_object( '-1 hour' ) );
+		$schedule        = new ActionScheduler_SimpleSchedule(as_get_datetime_object('-1 hour'));
 		$created_actions = array(
-			$store->save_action( new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( 1 ), $schedule, 'my_group' ) ),
-			$store->save_action( new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( 1 ), $schedule, 'my_group' ) ),
+			$store->save_action(new ActionScheduler_Action(ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(1), $schedule, 'my_group')),
+			$store->save_action(new ActionScheduler_Action(ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(1), $schedule, 'my_group')),
 		);
 
 		$claim = $store->stake_claim();
-		$this->assertInstanceof( 'ActionScheduler_ActionClaim', $claim );
+		$this->assertInstanceof('ActionScheduler_ActionClaim', $claim);
 
 		// Verify uniqueness of action IDs.
-		$this->assertCount( 2, array_unique( $created_actions ) );
+		$this->assertCount(2, array_unique($created_actions));
 
 		// Verify the count and order of the actions.
 		$claimed_actions = $claim->get_actions();
-		$this->assertCount( 2, $claimed_actions );
-		$this->assertEquals( $created_actions, $claimed_actions );
+		$this->assertCount(2, $claimed_actions);
+		$this->assertEquals($created_actions, $claimed_actions);
 
 		// Verify the reversed order doesn't pass.
-		$reversed_actions = array_reverse( $created_actions );
-		$this->assertNotEquals( $reversed_actions, $claimed_actions );
+		$reversed_actions = array_reverse($created_actions);
+		$this->assertNotEquals($reversed_actions, $claimed_actions);
 	}
 
 	public function test_claim_actions_by_hooks() {
@@ -164,35 +164,35 @@ 
 			$unique_hook_two,
 		);
 
-		for ( $i = 3; $i > - 3; $i -- ) {
-			foreach ( $unique_hooks as $unique_hook ) {
-				$time     = as_get_datetime_object( $i . ' hours' );
-				$schedule = new ActionScheduler_SimpleSchedule( $time );
-				$action   = new ActionScheduler_Action( $unique_hook, array( $i ), $schedule, 'my_group' );
+		for ($i = 3; $i > - 3; $i--) {
+			foreach ($unique_hooks as $unique_hook) {
+				$time     = as_get_datetime_object($i.' hours');
+				$schedule = new ActionScheduler_SimpleSchedule($time);
+				$action   = new ActionScheduler_Action($unique_hook, array($i), $schedule, 'my_group');
 
-				$action_id         = $store->save_action( $action );
-				$created_actions[] = $created_actions_by_hook[ $unique_hook ][] = $action_id;
+				$action_id         = $store->save_action($action);
+				$created_actions[] = $created_actions_by_hook[$unique_hook][] = $action_id;
 			}
 		}
 
-		$claim = $store->stake_claim( 10, null, $unique_hooks );
-		$this->assertInstanceof( 'ActionScheduler_ActionClaim', $claim );
-		$this->assertCount( 6, $claim->get_actions() );
-		$this->assertEqualSets( array_slice( $created_actions, 6, 6 ), $claim->get_actions() );
+		$claim = $store->stake_claim(10, null, $unique_hooks);
+		$this->assertInstanceof('ActionScheduler_ActionClaim', $claim);
+		$this->assertCount(6, $claim->get_actions());
+		$this->assertEqualSets(array_slice($created_actions, 6, 6), $claim->get_actions());
 
-		$store->release_claim( $claim );
+		$store->release_claim($claim);
 
-		$claim = $store->stake_claim( 10, null, array( $unique_hook_one ) );
-		$this->assertInstanceof( 'ActionScheduler_ActionClaim', $claim );
-		$this->assertCount( 3, $claim->get_actions() );
-		$this->assertEqualSets( array_slice( $created_actions_by_hook[ $unique_hook_one ], 3, 3 ), $claim->get_actions() );
+		$claim = $store->stake_claim(10, null, array($unique_hook_one));
+		$this->assertInstanceof('ActionScheduler_ActionClaim', $claim);
+		$this->assertCount(3, $claim->get_actions());
+		$this->assertEqualSets(array_slice($created_actions_by_hook[$unique_hook_one], 3, 3), $claim->get_actions());
 
-		$store->release_claim( $claim );
+		$store->release_claim($claim);
 
-		$claim = $store->stake_claim( 10, null, array( $unique_hook_two ) );
-		$this->assertInstanceof( 'ActionScheduler_ActionClaim', $claim );
-		$this->assertCount( 3, $claim->get_actions() );
-		$this->assertEqualSets( array_slice( $created_actions_by_hook[ $unique_hook_two ], 3, 3 ), $claim->get_actions() );
+		$claim = $store->stake_claim(10, null, array($unique_hook_two));
+		$this->assertInstanceof('ActionScheduler_ActionClaim', $claim);
+		$this->assertCount(3, $claim->get_actions());
+		$this->assertEqualSets(array_slice($created_actions_by_hook[$unique_hook_two], 3, 3), $claim->get_actions());
 	}
 
 	public function test_claim_actions_by_group() {
@@ -205,27 +205,27 @@ 
 			$unique_group_two,
 		);
 
-		for ( $i = 3; $i > - 3; $i -- ) {
-			foreach ( $unique_groups as $unique_group ) {
-				$time     = as_get_datetime_object( $i . ' hours' );
-				$schedule = new ActionScheduler_SimpleSchedule( $time );
-				$action   = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( $i ), $schedule, $unique_group );
+		for ($i = 3; $i > - 3; $i--) {
+			foreach ($unique_groups as $unique_group) {
+				$time     = as_get_datetime_object($i.' hours');
+				$schedule = new ActionScheduler_SimpleSchedule($time);
+				$action   = new ActionScheduler_Action(ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array($i), $schedule, $unique_group);
 
-				$created_actions[ $unique_group ][] = $store->save_action( $action );
+				$created_actions[$unique_group][] = $store->save_action($action);
 			}
 		}
 
-		$claim = $store->stake_claim( 10, null, array(), $unique_group_one );
-		$this->assertInstanceof( 'ActionScheduler_ActionClaim', $claim );
-		$this->assertCount( 3, $claim->get_actions() );
-		$this->assertEqualSets( array_slice( $created_actions[ $unique_group_one ], 3, 3 ), $claim->get_actions() );
+		$claim = $store->stake_claim(10, null, array(), $unique_group_one);
+		$this->assertInstanceof('ActionScheduler_ActionClaim', $claim);
+		$this->assertCount(3, $claim->get_actions());
+		$this->assertEqualSets(array_slice($created_actions[$unique_group_one], 3, 3), $claim->get_actions());
 
-		$store->release_claim( $claim );
+		$store->release_claim($claim);
 
-		$claim = $store->stake_claim( 10, null, array(), $unique_group_two );
-		$this->assertInstanceof( 'ActionScheduler_ActionClaim', $claim );
-		$this->assertCount( 3, $claim->get_actions() );
-		$this->assertEqualSets( array_slice( $created_actions[ $unique_group_two ], 3, 3 ), $claim->get_actions() );
+		$claim = $store->stake_claim(10, null, array(), $unique_group_two);
+		$this->assertInstanceof('ActionScheduler_ActionClaim', $claim);
+		$this->assertCount(3, $claim->get_actions());
+		$this->assertEqualSets(array_slice($created_actions[$unique_group_two], 3, 3), $claim->get_actions());
 	}
 
 	public function test_claim_actions_by_hook_and_group() {
@@ -246,65 +246,65 @@ 
 			$unique_group_two,
 		);
 
-		for ( $i = 3; $i > - 3; $i -- ) {
-			foreach ( $unique_hooks as $unique_hook ) {
-				foreach ( $unique_groups as $unique_group ) {
-					$time     = as_get_datetime_object( $i . ' hours' );
-					$schedule = new ActionScheduler_SimpleSchedule( $time );
-					$action   = new ActionScheduler_Action( $unique_hook, array( $i ), $schedule, $unique_group );
+		for ($i = 3; $i > - 3; $i--) {
+			foreach ($unique_hooks as $unique_hook) {
+				foreach ($unique_groups as $unique_group) {
+					$time     = as_get_datetime_object($i.' hours');
+					$schedule = new ActionScheduler_SimpleSchedule($time);
+					$action   = new ActionScheduler_Action($unique_hook, array($i), $schedule, $unique_group);
 
-					$action_id                          = $store->save_action( $action );
-					$created_actions[ $unique_group ][] = $action_id;
-					$created_actions_by_hook[ $unique_hook ][ $unique_group ][] = $action_id;
+					$action_id                          = $store->save_action($action);
+					$created_actions[$unique_group][] = $action_id;
+					$created_actions_by_hook[$unique_hook][$unique_group][] = $action_id;
 				}
 			}
 		}
 
 		/** Test Both Hooks with Each Group */
 
-		$claim = $store->stake_claim( 10, null, $unique_hooks, $unique_group_one );
-		$this->assertInstanceof( 'ActionScheduler_ActionClaim', $claim );
-		$this->assertCount( 6, $claim->get_actions() );
-		$this->assertEqualSets( array_slice( $created_actions[ $unique_group_one ], 6, 6 ), $claim->get_actions() );
+		$claim = $store->stake_claim(10, null, $unique_hooks, $unique_group_one);
+		$this->assertInstanceof('ActionScheduler_ActionClaim', $claim);
+		$this->assertCount(6, $claim->get_actions());
+		$this->assertEqualSets(array_slice($created_actions[$unique_group_one], 6, 6), $claim->get_actions());
 
-		$store->release_claim( $claim );
+		$store->release_claim($claim);
 
-		$claim = $store->stake_claim( 10, null, $unique_hooks, $unique_group_two );
-		$this->assertInstanceof( 'ActionScheduler_ActionClaim', $claim );
-		$this->assertCount( 6, $claim->get_actions() );
-		$this->assertEqualSets( array_slice( $created_actions[ $unique_group_two ], 6, 6 ), $claim->get_actions() );
+		$claim = $store->stake_claim(10, null, $unique_hooks, $unique_group_two);
+		$this->assertInstanceof('ActionScheduler_ActionClaim', $claim);
+		$this->assertCount(6, $claim->get_actions());
+		$this->assertEqualSets(array_slice($created_actions[$unique_group_two], 6, 6), $claim->get_actions());
 
-		$store->release_claim( $claim );
+		$store->release_claim($claim);
 
 		/** Test Just One Hook with Group One */
 
-		$claim = $store->stake_claim( 10, null, array( $unique_hook_one ), $unique_group_one );
-		$this->assertInstanceof( 'ActionScheduler_ActionClaim', $claim );
-		$this->assertCount( 3, $claim->get_actions() );
-		$this->assertEqualSets( array_slice( $created_actions_by_hook[ $unique_hook_one ][ $unique_group_one ], 3, 3 ), $claim->get_actions() );
+		$claim = $store->stake_claim(10, null, array($unique_hook_one), $unique_group_one);
+		$this->assertInstanceof('ActionScheduler_ActionClaim', $claim);
+		$this->assertCount(3, $claim->get_actions());
+		$this->assertEqualSets(array_slice($created_actions_by_hook[$unique_hook_one][$unique_group_one], 3, 3), $claim->get_actions());
 
-		$store->release_claim( $claim );
+		$store->release_claim($claim);
 
-		$claim = $store->stake_claim( 24, null, array( $unique_hook_two ), $unique_group_one );
-		$this->assertInstanceof( 'ActionScheduler_ActionClaim', $claim );
-		$this->assertCount( 3, $claim->get_actions() );
-		$this->assertEqualSets( array_slice( $created_actions_by_hook[ $unique_hook_two ][ $unique_group_one ], 3, 3 ), $claim->get_actions() );
+		$claim = $store->stake_claim(24, null, array($unique_hook_two), $unique_group_one);
+		$this->assertInstanceof('ActionScheduler_ActionClaim', $claim);
+		$this->assertCount(3, $claim->get_actions());
+		$this->assertEqualSets(array_slice($created_actions_by_hook[$unique_hook_two][$unique_group_one], 3, 3), $claim->get_actions());
 
-		$store->release_claim( $claim );
+		$store->release_claim($claim);
 
 		/** Test Just One Hook with Group Two */
 
-		$claim = $store->stake_claim( 10, null, array( $unique_hook_one ), $unique_group_two );
-		$this->assertInstanceof( 'ActionScheduler_ActionClaim', $claim );
-		$this->assertCount( 3, $claim->get_actions() );
-		$this->assertEqualSets( array_slice( $created_actions_by_hook[ $unique_hook_one ][ $unique_group_two ], 3, 3 ), $claim->get_actions() );
+		$claim = $store->stake_claim(10, null, array($unique_hook_one), $unique_group_two);
+		$this->assertInstanceof('ActionScheduler_ActionClaim', $claim);
+		$this->assertCount(3, $claim->get_actions());
+		$this->assertEqualSets(array_slice($created_actions_by_hook[$unique_hook_one][$unique_group_two], 3, 3), $claim->get_actions());
 
-		$store->release_claim( $claim );
+		$store->release_claim($claim);
 
-		$claim = $store->stake_claim( 24, null, array( $unique_hook_two ), $unique_group_two );
-		$this->assertInstanceof( 'ActionScheduler_ActionClaim', $claim );
-		$this->assertCount( 3, $claim->get_actions() );
-		$this->assertEqualSets( array_slice( $created_actions_by_hook[ $unique_hook_two ][ $unique_group_two ], 3, 3 ), $claim->get_actions() );
+		$claim = $store->stake_claim(24, null, array($unique_hook_two), $unique_group_two);
+		$this->assertInstanceof('ActionScheduler_ActionClaim', $claim);
+		$this->assertCount(3, $claim->get_actions());
+		$this->assertEqualSets(array_slice($created_actions_by_hook[$unique_hook_two][$unique_group_two], 3, 3), $claim->get_actions());
 	}
 
 	/**
@@ -322,129 +322,129 @@ 
 		$store = new ActionScheduler_DBStore();
 
 		// Create 4 actions: 2 that are already due (-3hrs and -1hrs) and 2 that are not yet due (+1hr and +3hrs).
-		for ( $i = -3; $i <= 3; $i += 2 ) {
-			$schedule     = new ActionScheduler_SimpleSchedule( as_get_datetime_object( $i . ' hours' ) );
-			$action_ids[] = $store->save_action( new ActionScheduler_Action( 'test_' . $i, array(), $schedule, $group ) );
+		for ($i = -3; $i <= 3; $i += 2) {
+			$schedule     = new ActionScheduler_SimpleSchedule(as_get_datetime_object($i.' hours'));
+			$action_ids[] = $store->save_action(new ActionScheduler_Action('test_'.$i, array(), $schedule, $group));
 		}
 
 		// This callback is used to simulate the unusual conditions whereby MySQL might unexpectedly return future
 		// actions, contrary to the conditions used by the store object when staking its claim.
-		$simulate_unexpected_db_behavior = function ( $sql ) use ( $action_ids ) {
+		$simulate_unexpected_db_behavior = function($sql) use ($action_ids) {
 			global $wpdb;
 
 			// Look out for the claim update query, ignore all others.
 			if (
-				0 !== strpos( $sql, "UPDATE $wpdb->actionscheduler_actions" )
-				|| ! preg_match( "/claim_id = 0 AND scheduled_date_gmt <= '([0-9:\-\s]{19})'/", $sql, $matches )
-				|| count( $matches ) !== 2
+				0 !== strpos($sql, "UPDATE $wpdb->actionscheduler_actions")
+				|| ! preg_match("/claim_id = 0 AND scheduled_date_gmt <= '([0-9:\-\s]{19})'/", $sql, $matches)
+				|| count($matches) !== 2
 			) {
 				return $sql;
 			}
 
 			// Now modify the query, forcing it to also return the future actions we created.
-			return str_replace( $matches[1], as_get_datetime_object( '+4 hours' )->format( 'Y-m-d H:i:s' ), $sql );
+			return str_replace($matches[1], as_get_datetime_object('+4 hours')->format('Y-m-d H:i:s'), $sql);
 		};
 
-		add_filter( 'query', $simulate_unexpected_db_behavior );
-		$claim           = $store->stake_claim( 10, null, array(), $group );
+		add_filter('query', $simulate_unexpected_db_behavior);
+		$claim           = $store->stake_claim(10, null, array(), $group);
 		$claimed_actions = $claim->get_actions();
-		$this->assertCount( 2, $claimed_actions );
+		$this->assertCount(2, $claimed_actions);
 
 		// Cleanup.
-		remove_filter( 'query', $simulate_unexpected_db_behavior );
-		$store->release_claim( $claim );
+		remove_filter('query', $simulate_unexpected_db_behavior);
+		$store->release_claim($claim);
 	}
 
 	public function test_duplicate_claim() {
 		$created_actions = array();
 		$store           = new ActionScheduler_DBStore();
-		for ( $i = 0; $i > - 3; $i -- ) {
-			$time     = as_get_datetime_object( $i . ' hours' );
-			$schedule = new ActionScheduler_SimpleSchedule( $time );
-			$action   = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( $i ), $schedule, 'my_group' );
+		for ($i = 0; $i > - 3; $i--) {
+			$time     = as_get_datetime_object($i.' hours');
+			$schedule = new ActionScheduler_SimpleSchedule($time);
+			$action   = new ActionScheduler_Action(ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array($i), $schedule, 'my_group');
 
-			$created_actions[] = $store->save_action( $action );
+			$created_actions[] = $store->save_action($action);
 		}
 
 		$claim1 = $store->stake_claim();
 		$claim2 = $store->stake_claim();
-		$this->assertCount( 3, $claim1->get_actions() );
-		$this->assertCount( 0, $claim2->get_actions() );
+		$this->assertCount(3, $claim1->get_actions());
+		$this->assertCount(0, $claim2->get_actions());
 	}
 
 	public function test_release_claim() {
 		$created_actions = array();
 		$store           = new ActionScheduler_DBStore();
-		for ( $i = 0; $i > - 3; $i -- ) {
-			$time     = as_get_datetime_object( $i . ' hours' );
-			$schedule = new ActionScheduler_SimpleSchedule( $time );
-			$action   = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( $i ), $schedule, 'my_group' );
+		for ($i = 0; $i > - 3; $i--) {
+			$time     = as_get_datetime_object($i.' hours');
+			$schedule = new ActionScheduler_SimpleSchedule($time);
+			$action   = new ActionScheduler_Action(ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array($i), $schedule, 'my_group');
 
-			$created_actions[] = $store->save_action( $action );
+			$created_actions[] = $store->save_action($action);
 		}
 
 		$claim1 = $store->stake_claim();
 
-		$store->release_claim( $claim1 );
+		$store->release_claim($claim1);
 
 		$claim2 = $store->stake_claim();
-		$this->assertCount( 3, $claim2->get_actions() );
+		$this->assertCount(3, $claim2->get_actions());
 	}
 
 	public function test_search() {
 		$created_actions = array();
 		$store           = new ActionScheduler_DBStore();
-		for ( $i = - 3; $i <= 3; $i ++ ) {
-			$time     = as_get_datetime_object( $i . ' hours' );
-			$schedule = new ActionScheduler_SimpleSchedule( $time );
-			$action   = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( $i ), $schedule, 'my_group' );
+		for ($i = - 3; $i <= 3; $i++) {
+			$time     = as_get_datetime_object($i.' hours');
+			$schedule = new ActionScheduler_SimpleSchedule($time);
+			$action   = new ActionScheduler_Action(ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array($i), $schedule, 'my_group');
 
-			$created_actions[] = $store->save_action( $action );
+			$created_actions[] = $store->save_action($action);
 		}
 
-		$next_no_args = $store->find_action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK );
-		$this->assertEquals( $created_actions[0], $next_no_args );
+		$next_no_args = $store->find_action(ActionScheduler_Callbacks::HOOK_WITH_CALLBACK);
+		$this->assertEquals($created_actions[0], $next_no_args);
 
-		$next_with_args = $store->find_action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( 'args' => array( 1 ) ) );
-		$this->assertEquals( $created_actions[4], $next_with_args );
+		$next_with_args = $store->find_action(ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array('args' => array(1)));
+		$this->assertEquals($created_actions[4], $next_with_args);
 
-		$non_existent = $store->find_action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( 'args' => array( 17 ) ) );
-		$this->assertNull( $non_existent );
+		$non_existent = $store->find_action(ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array('args' => array(17)));
+		$this->assertNull($non_existent);
 	}
 
 	public function test_search_by_group() {
 		$store    = new ActionScheduler_DBStore();
-		$schedule = new ActionScheduler_SimpleSchedule( as_get_datetime_object( 'tomorrow' ) );
+		$schedule = new ActionScheduler_SimpleSchedule(as_get_datetime_object('tomorrow'));
 
-		$abc = $store->save_action( new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( 1 ), $schedule, 'abc' ) );
-		$def = $store->save_action( new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( 1 ), $schedule, 'def' ) );
-		$ghi = $store->save_action( new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( 1 ), $schedule, 'ghi' ) );
+		$abc = $store->save_action(new ActionScheduler_Action(ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(1), $schedule, 'abc'));
+		$def = $store->save_action(new ActionScheduler_Action(ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(1), $schedule, 'def'));
+		$ghi = $store->save_action(new ActionScheduler_Action(ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(1), $schedule, 'ghi'));
 
-		$this->assertEquals( $abc, $store->find_action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( 'group' => 'abc' ) ) );
-		$this->assertEquals( $def, $store->find_action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( 'group' => 'def' ) ) );
-		$this->assertEquals( $ghi, $store->find_action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( 'group' => 'ghi' ) ) );
+		$this->assertEquals($abc, $store->find_action(ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array('group' => 'abc')));
+		$this->assertEquals($def, $store->find_action(ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array('group' => 'def')));
+		$this->assertEquals($ghi, $store->find_action(ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array('group' => 'ghi')));
 	}
 
 	public function test_get_run_date() {
-		$time      = as_get_datetime_object( '-10 minutes' );
-		$schedule  = new ActionScheduler_IntervalSchedule( $time, HOUR_IN_SECONDS );
-		$action    = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule );
+		$time      = as_get_datetime_object('-10 minutes');
+		$schedule  = new ActionScheduler_IntervalSchedule($time, HOUR_IN_SECONDS);
+		$action    = new ActionScheduler_Action(ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule);
 		$store     = new ActionScheduler_DBStore();
-		$action_id = $store->save_action( $action );
+		$action_id = $store->save_action($action);
 
-		$this->assertEquals( $time->format( 'U' ), $store->get_date( $action_id )->format( 'U' ) );
+		$this->assertEquals($time->format('U'), $store->get_date($action_id)->format('U'));
 
-		$action = $store->fetch_action( $action_id );
+		$action = $store->fetch_action($action_id);
 		$action->execute();
 		$now = as_get_datetime_object();
-		$store->mark_complete( $action_id );
+		$store->mark_complete($action_id);
 
-		$this->assertEquals( $now->format( 'U' ), $store->get_date( $action_id )->format( 'U' ) );
+		$this->assertEquals($now->format('U'), $store->get_date($action_id)->format('U'));
 
-		$next          = $action->get_schedule()->get_next( $now );
-		$new_action_id = $store->save_action( $action, $next );
+		$next          = $action->get_schedule()->get_next($now);
+		$new_action_id = $store->save_action($action, $next);
 
-		$this->assertEquals( (int) ( $now->format( 'U' ) ) + HOUR_IN_SECONDS, $store->get_date( $new_action_id )->format( 'U' ) );
+		$this->assertEquals((int) ($now->format('U')) + HOUR_IN_SECONDS, $store->get_date($new_action_id)->format('U'));
 	}
 
 	/**
@@ -452,19 +452,19 @@ 
 	 */
 	public function test_create_action_unique() {
 		$time     = as_get_datetime_object();
-		$hook     = md5( rand() );
-		$schedule = new ActionScheduler_SimpleSchedule( $time );
+		$hook     = md5(rand());
+		$schedule = new ActionScheduler_SimpleSchedule($time);
 		$store    = new ActionScheduler_DBStore();
-		$action   = new ActionScheduler_Action( $hook, array(), $schedule );
+		$action   = new ActionScheduler_Action($hook, array(), $schedule);
 
-		$action_id = $store->save_action( $action );
-		$this->assertNotEquals( 0, $action_id );
-		$action_from_db = $store->fetch_action( $action_id );
-		$this->assertTrue( is_a( $action_from_db, ActionScheduler_Action::class ) );
+		$action_id = $store->save_action($action);
+		$this->assertNotEquals(0, $action_id);
+		$action_from_db = $store->fetch_action($action_id);
+		$this->assertTrue(is_a($action_from_db, ActionScheduler_Action::class));
 
-		$action              = new ActionScheduler_Action( $hook, array(), $schedule );
-		$action_id_duplicate = $store->save_unique_action( $action );
-		$this->assertSame( 0, $action_id_duplicate );
+		$action              = new ActionScheduler_Action($hook, array(), $schedule);
+		$action_id_duplicate = $store->save_unique_action($action);
+		$this->assertSame(0, $action_id_duplicate);
 	}
 
 	/**
@@ -472,25 +472,25 @@ 
 	 */
 	public function test_create_action_unique_with_different_groups() {
 		$time     = as_get_datetime_object();
-		$hook     = md5( rand() );
-		$schedule = new ActionScheduler_SimpleSchedule( $time );
+		$hook     = md5(rand());
+		$schedule = new ActionScheduler_SimpleSchedule($time);
 		$store    = new ActionScheduler_DBStore();
-		$action   = new ActionScheduler_Action( $hook, array(), $schedule, 'group1' );
-
-		$action_id      = $store->save_action( $action );
-		$action_from_db = $store->fetch_action( $action_id );
-		$this->assertNotEquals( 0, $action_id );
-		$this->assertTrue( is_a( $action_from_db, ActionScheduler_Action::class ) );
-
-		$action2          = new ActionScheduler_Action( $hook, array(), $schedule, 'group2' );
-		$action_id_group2 = $store->save_unique_action( $action2 );
-		$this->assertNotEquals( 0, $action_id_group2 );
-		$action_2_from_db = $store->fetch_action( $action_id_group2 );
-		$this->assertTrue( is_a( $action_2_from_db, ActionScheduler_Action::class ) );
-
-		$action3                 = new ActionScheduler_Action( $hook, array(), $schedule, 'group2' );
-		$action_id_group2_double = $store->save_unique_action( $action3 );
-		$this->assertSame( 0, $action_id_group2_double );
+		$action   = new ActionScheduler_Action($hook, array(), $schedule, 'group1');
+
+		$action_id      = $store->save_action($action);
+		$action_from_db = $store->fetch_action($action_id);
+		$this->assertNotEquals(0, $action_id);
+		$this->assertTrue(is_a($action_from_db, ActionScheduler_Action::class));
+
+		$action2          = new ActionScheduler_Action($hook, array(), $schedule, 'group2');
+		$action_id_group2 = $store->save_unique_action($action2);
+		$this->assertNotEquals(0, $action_id_group2);
+		$action_2_from_db = $store->fetch_action($action_id_group2);
+		$this->assertTrue(is_a($action_2_from_db, ActionScheduler_Action::class));
+
+		$action3                 = new ActionScheduler_Action($hook, array(), $schedule, 'group2');
+		$action_id_group2_double = $store->save_unique_action($action3);
+		$this->assertSame(0, $action_id_group2_double);
 	}
 
 	/**
@@ -498,22 +498,22 @@ 
 	 */
 	public function test_create_action_unique_and_then_non_unique() {
 		$time     = as_get_datetime_object();
-		$hook     = md5( rand() );
-		$schedule = new ActionScheduler_SimpleSchedule( $time );
+		$hook     = md5(rand());
+		$schedule = new ActionScheduler_SimpleSchedule($time);
 		$store    = new ActionScheduler_DBStore();
-		$action   = new ActionScheduler_Action( $hook, array(), $schedule );
+		$action   = new ActionScheduler_Action($hook, array(), $schedule);
 
-		$action_id = $store->save_unique_action( $action );
-		$this->assertNotEquals( 0, $action_id );
-		$action_from_db = $store->fetch_action( $action_id );
-		$this->assertTrue( is_a( $action_from_db, ActionScheduler_Action::class ) );
+		$action_id = $store->save_unique_action($action);
+		$this->assertNotEquals(0, $action_id);
+		$action_from_db = $store->fetch_action($action_id);
+		$this->assertTrue(is_a($action_from_db, ActionScheduler_Action::class));
 
 		// Non unique action is scheduled even if the previous one was unique.
-		$action              = new ActionScheduler_Action( $hook, array(), $schedule );
-		$action_id_duplicate = $store->save_action( $action );
-		$this->assertNotEquals( 0, $action_id_duplicate );
-		$action_from_db_duplicate = $store->fetch_action( $action_id_duplicate );
-		$this->assertTrue( is_a( $action_from_db_duplicate, ActionScheduler_Action::class ) );
+		$action              = new ActionScheduler_Action($hook, array(), $schedule);
+		$action_id_duplicate = $store->save_action($action);
+		$this->assertNotEquals(0, $action_id_duplicate);
+		$action_from_db_duplicate = $store->fetch_action($action_id_duplicate);
+		$this->assertTrue(is_a($action_from_db_duplicate, ActionScheduler_Action::class));
 	}
 
 	/**
@@ -521,19 +521,19 @@ 
 	 */
 	public function test_create_action_unique_with_empty_array() {
 		$time     = as_get_datetime_object();
-		$hook     = md5( rand() );
-		$schedule = new ActionScheduler_SimpleSchedule( $time );
+		$hook     = md5(rand());
+		$schedule = new ActionScheduler_SimpleSchedule($time);
 		$store    = new ActionScheduler_DBStore();
-		$action   = new ActionScheduler_Action( $hook, array( 'foo' => 'bar' ), $schedule );
+		$action   = new ActionScheduler_Action($hook, array('foo' => 'bar'), $schedule);
 
-		$action_id = $store->save_unique_action( $action );
-		$this->assertNotEquals( 0, $action_id );
-		$action_from_db = $store->fetch_action( $action_id );
-		$this->assertTrue( is_a( $action_from_db, ActionScheduler_Action::class ) );
+		$action_id = $store->save_unique_action($action);
+		$this->assertNotEquals(0, $action_id);
+		$action_from_db = $store->fetch_action($action_id);
+		$this->assertTrue(is_a($action_from_db, ActionScheduler_Action::class));
 
-		$action_with_empty_args = new ActionScheduler_Action( $hook, array(), $schedule );
-		$action_id_duplicate    = $store->save_unique_action( $action_with_empty_args );
-		$this->assertSame( 0, $action_id_duplicate );
+		$action_with_empty_args = new ActionScheduler_Action($hook, array(), $schedule);
+		$action_id_duplicate    = $store->save_unique_action($action_with_empty_args);
+		$this->assertSame(0, $action_id_duplicate);
 	}
 
 	/**
@@ -541,18 +541,18 @@ 
 	 */
 	public function test_create_action_unique_with_different_args_still_fail() {
 		$time     = as_get_datetime_object();
-		$hook     = md5( rand() );
-		$schedule = new ActionScheduler_SimpleSchedule( $time );
+		$hook     = md5(rand());
+		$schedule = new ActionScheduler_SimpleSchedule($time);
 		$store    = new ActionScheduler_DBStore();
-		$action   = new ActionScheduler_Action( $hook, array( 'foo' => 'bar' ), $schedule );
+		$action   = new ActionScheduler_Action($hook, array('foo' => 'bar'), $schedule);
 
-		$action_id = $store->save_unique_action( $action );
-		$this->assertNotEquals( 0, $action_id );
-		$action_from_db = $store->fetch_action( $action_id );
-		$this->assertTrue( is_a( $action_from_db, ActionScheduler_Action::class ) );
+		$action_id = $store->save_unique_action($action);
+		$this->assertNotEquals(0, $action_id);
+		$action_from_db = $store->fetch_action($action_id);
+		$this->assertTrue(is_a($action_from_db, ActionScheduler_Action::class));
 
-		$action_with_diff_args = new ActionScheduler_Action( $hook, array( 'foo' => 'bazz' ), $schedule );
-		$action_id_duplicate   = $store->save_unique_action( $action_with_diff_args );
-		$this->assertSame( 0, $action_id_duplicate );
+		$action_with_diff_args = new ActionScheduler_Action($hook, array('foo' => 'bazz'), $schedule);
+		$action_id_duplicate   = $store->save_unique_action($action_with_diff_args);
+		$this->assertSame(0, $action_id_duplicate);
 	}
 }

src/libraries/action-scheduler/tests/phpunit/jobstore/ActionScheduler_wpPostStore_Test.php

Indentation +453 added lines, -453 removed lines

@@ -9,457 +9,457 @@
  */
 class ActionScheduler_wpPostStore_Test extends AbstractStoreTest {
 
-	/**
-	 * Get data store for tests.
-	 *
-	 * @return ActionScheduler_wpPostStore
-	 */
-	protected function get_store() {
-		return new ActionScheduler_wpPostStore();
-	}
-
-	public function test_create_action() {
-		$time      = as_get_datetime_object();
-		$schedule  = new ActionScheduler_SimpleSchedule( $time );
-		$action    = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule );
-		$store     = new ActionScheduler_wpPostStore();
-		$action_id = $store->save_action( $action );
-
-		$this->assertNotEmpty( $action_id );
-	}
-
-	public function test_create_action_with_scheduled_date() {
-		$time   = as_get_datetime_object( strtotime( '-1 week' ) );
-		$action = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), new ActionScheduler_SimpleSchedule( $time ) );
-		$store  = new ActionScheduler_wpPostStore();
-
-		$action_id   = $store->save_action( $action, $time );
-		$action_date = $store->get_date( $action_id );
-
-		$this->assertEquals( $time->getTimestamp(), $action_date->getTimestamp() );
-	}
-
-	public function test_retrieve_action() {
-		$time      = as_get_datetime_object();
-		$schedule  = new ActionScheduler_SimpleSchedule( $time );
-		$action    = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule, 'my_group' );
-		$store     = new ActionScheduler_wpPostStore();
-		$action_id = $store->save_action( $action );
-
-		$retrieved = $store->fetch_action( $action_id );
-		$this->assertEquals( $action->get_hook(), $retrieved->get_hook() );
-		$this->assertEqualSets( $action->get_args(), $retrieved->get_args() );
-		$this->assertEquals( $action->get_schedule()->get_date()->getTimestamp(), $retrieved->get_schedule()->get_date()->getTimestamp() );
-		$this->assertEquals( $action->get_group(), $retrieved->get_group() );
-	}
-
-	/**
-	 * @dataProvider provide_bad_args
-	 *
-	 * @param string $content
-	 */
-	public function test_action_bad_args( $content ) {
-		$store   = new ActionScheduler_wpPostStore();
-		$post_id = wp_insert_post(
-			array(
-				'post_type'    => ActionScheduler_wpPostStore::POST_TYPE,
-				'post_status'  => ActionScheduler_Store::STATUS_PENDING,
-				'post_content' => $content,
-			)
-		);
-
-		$fetched = $store->fetch_action( $post_id );
-		$this->assertInstanceOf( 'ActionScheduler_NullSchedule', $fetched->get_schedule() );
-	}
-
-	public function provide_bad_args() {
-		return array(
-			array( '{"bad_json":true}}' ),
-		);
-	}
-
-	public function test_cancel_action() {
-		$time      = as_get_datetime_object();
-		$schedule  = new ActionScheduler_SimpleSchedule( $time );
-		$action    = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule, 'my_group' );
-		$store     = new ActionScheduler_wpPostStore();
-		$action_id = $store->save_action( $action );
-		$store->cancel_action( $action_id );
-
-		$fetched = $store->fetch_action( $action_id );
-		$this->assertInstanceOf( 'ActionScheduler_CanceledAction', $fetched );
-	}
-
-	public function test_cancel_actions_by_hook() {
-		$store   = new ActionScheduler_wpPostStore();
-		$actions = array();
-		$hook    = 'by_hook_test';
-		for ( $day = 1; $day <= 3; $day++ ) {
-			$delta     = sprintf( '+%d day', $day );
-			$time      = as_get_datetime_object( $delta );
-			$schedule  = new ActionScheduler_SimpleSchedule( $time );
-			$action    = new ActionScheduler_Action( $hook, array(), $schedule, 'my_group' );
-			$actions[] = $store->save_action( $action );
-		}
-		$store->cancel_actions_by_hook( $hook );
-
-		foreach ( $actions as $action_id ) {
-			$fetched = $store->fetch_action( $action_id );
-			$this->assertInstanceOf( 'ActionScheduler_CanceledAction', $fetched );
-		}
-	}
-
-	public function test_cancel_actions_by_group() {
-		$store   = new ActionScheduler_wpPostStore();
-		$actions = array();
-		$group   = 'by_group_test';
-
-		for ( $day = 1; $day <= 3; $day++ ) {
-			$delta     = sprintf( '+%d day', $day );
-			$time      = as_get_datetime_object( $delta );
-			$schedule  = new ActionScheduler_SimpleSchedule( $time );
-			$action    = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule, $group );
-			$actions[] = $store->save_action( $action );
-		}
-		$store->cancel_actions_by_group( $group );
-
-		foreach ( $actions as $action_id ) {
-			$fetched = $store->fetch_action( $action_id );
-			$this->assertInstanceOf( 'ActionScheduler_CanceledAction', $fetched );
-		}
-	}
-
-	public function test_claim_actions() {
-		$created_actions = array();
-		$store           = new ActionScheduler_wpPostStore();
-		for ( $i = 3; $i > -3; $i-- ) {
-			$time              = as_get_datetime_object( $i . ' hours' );
-			$schedule          = new ActionScheduler_SimpleSchedule( $time );
-			$action            = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( $i ), $schedule, 'my_group' );
-			$created_actions[] = $store->save_action( $action );
-		}
-
-		$claim = $store->stake_claim();
-		$this->assertInstanceof( 'ActionScheduler_ActionClaim', $claim );
-
-		$this->assertCount( 3, $claim->get_actions() );
-		$this->assertEqualSets( array_slice( $created_actions, 3, 3 ), $claim->get_actions() );
-	}
-
-	public function test_claim_actions_order() {
-		$store           = new ActionScheduler_wpPostStore();
-		$schedule        = new ActionScheduler_SimpleSchedule( as_get_datetime_object( '-1 hour' ) );
-		$created_actions = array(
-			$store->save_action( new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( 1 ), $schedule, 'my_group' ) ),
-			$store->save_action( new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( 1 ), $schedule, 'my_group' ) ),
-		);
-
-		$claim = $store->stake_claim();
-		$this->assertInstanceof( 'ActionScheduler_ActionClaim', $claim );
-
-		// Verify uniqueness of action IDs.
-		$this->assertCount( 2, array_unique( $created_actions ) );
-
-		// Verify the count and order of the actions.
-		$claimed_actions = $claim->get_actions();
-		$this->assertCount( 2, $claimed_actions );
-		$this->assertEquals( $created_actions, $claimed_actions );
-
-		// Verify the reversed order doesn't pass.
-		$reversed_actions = array_reverse( $created_actions );
-		$this->assertNotEquals( $reversed_actions, $claimed_actions );
-	}
-
-	public function test_duplicate_claim() {
-		$created_actions = array();
-		$store           = new ActionScheduler_wpPostStore();
-		for ( $i = 0; $i > -3; $i-- ) {
-			$time              = as_get_datetime_object( $i . ' hours' );
-			$schedule          = new ActionScheduler_SimpleSchedule( $time );
-			$action            = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( $i ), $schedule, 'my_group' );
-			$created_actions[] = $store->save_action( $action );
-		}
-
-		$claim1 = $store->stake_claim();
-		$claim2 = $store->stake_claim();
-		$this->assertCount( 3, $claim1->get_actions() );
-		$this->assertCount( 0, $claim2->get_actions() );
-	}
-
-	public function test_release_claim() {
-		$created_actions = array();
-		$store           = new ActionScheduler_wpPostStore();
-		for ( $i = 0; $i > -3; $i-- ) {
-			$time              = as_get_datetime_object( $i . ' hours' );
-			$schedule          = new ActionScheduler_SimpleSchedule( $time );
-			$action            = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( $i ), $schedule, 'my_group' );
-			$created_actions[] = $store->save_action( $action );
-		}
-
-		$claim1 = $store->stake_claim();
-
-		$store->release_claim( $claim1 );
-
-		$claim2 = $store->stake_claim();
-		$this->assertCount( 3, $claim2->get_actions() );
-	}
-
-	public function test_search() {
-		$created_actions = array();
-		$store           = new ActionScheduler_wpPostStore();
-		for ( $i = -3; $i <= 3; $i++ ) {
-			$time              = as_get_datetime_object( $i . ' hours' );
-			$schedule          = new ActionScheduler_SimpleSchedule( $time );
-			$action            = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( $i ), $schedule, 'my_group' );
-			$created_actions[] = $store->save_action( $action );
-		}
-
-		$next_no_args = $store->find_action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK );
-		$this->assertEquals( $created_actions[0], $next_no_args );
-
-		$next_with_args = $store->find_action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( 'args' => array( 1 ) ) );
-		$this->assertEquals( $created_actions[4], $next_with_args );
-
-		$non_existent = $store->find_action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( 'args' => array( 17 ) ) );
-		$this->assertNull( $non_existent );
-	}
-
-	public function test_search_by_group() {
-		$store    = new ActionScheduler_wpPostStore();
-		$schedule = new ActionScheduler_SimpleSchedule( as_get_datetime_object( 'tomorrow' ) );
-		$abc      = $store->save_action( new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( 1 ), $schedule, 'abc' ) );
-		$def      = $store->save_action( new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( 1 ), $schedule, 'def' ) );
-		$ghi      = $store->save_action( new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( 1 ), $schedule, 'ghi' ) );
-
-		$this->assertEquals( $abc, $store->find_action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( 'group' => 'abc' ) ) );
-		$this->assertEquals( $def, $store->find_action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( 'group' => 'def' ) ) );
-		$this->assertEquals( $ghi, $store->find_action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( 'group' => 'ghi' ) ) );
-	}
-
-	public function test_post_author() {
-		$current_user = get_current_user_id();
-
-		$time      = as_get_datetime_object();
-		$schedule  = new ActionScheduler_SimpleSchedule( $time );
-		$action    = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule );
-		$store     = new ActionScheduler_wpPostStore();
-		$action_id = $store->save_action( $action );
-
-		$post = get_post( $action_id );
-		$this->assertSame( 0, $post->post_author );
-
-		$new_user = $this->factory->user->create_object(
-			array(
-				'user_login' => __FUNCTION__,
-				'user_pass'  => md5( rand() ),
-			)
-		);
-		wp_set_current_user( $new_user );
-
-		$schedule  = new ActionScheduler_SimpleSchedule( $time );
-		$action    = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule );
-		$action_id = $store->save_action( $action );
-		$post      = get_post( $action_id );
-		$this->assertSame( 0, $post->post_author );
-
-		wp_set_current_user( $current_user );
-	}
-
-	/**
-	 * @issue 13
-	 */
-	public function test_post_status_for_recurring_action() {
-		$time      = as_get_datetime_object( '10 minutes' );
-		$schedule  = new ActionScheduler_IntervalSchedule( $time, HOUR_IN_SECONDS );
-		$action    = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule );
-		$store     = new ActionScheduler_wpPostStore();
-		$action_id = $store->save_action( $action );
-
-		$action = $store->fetch_action( $action_id );
-		$action->execute();
-		$store->mark_complete( $action_id );
-
-		$next          = $action->get_schedule()->get_next( as_get_datetime_object() );
-		$new_action_id = $store->save_action( $action, $next );
-
-		$this->assertEquals( 'publish', get_post_status( $action_id ) );
-		$this->assertEquals( 'pending', get_post_status( $new_action_id ) );
-	}
-
-	public function test_get_run_date() {
-		$time      = as_get_datetime_object( '-10 minutes' );
-		$schedule  = new ActionScheduler_IntervalSchedule( $time, HOUR_IN_SECONDS );
-		$action    = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule );
-		$store     = new ActionScheduler_wpPostStore();
-		$action_id = $store->save_action( $action );
-
-		$this->assertEquals( $store->get_date( $action_id )->getTimestamp(), $time->getTimestamp() );
-
-		$action = $store->fetch_action( $action_id );
-		$action->execute();
-		$now = as_get_datetime_object();
-		$store->mark_complete( $action_id );
-
-		$this->assertEquals( $store->get_date( $action_id )->getTimestamp(), $now->getTimestamp(), '', 1 ); // allow timestamp to be 1 second off for older versions of PHP
-
-		$next          = $action->get_schedule()->get_next( $now );
-		$new_action_id = $store->save_action( $action, $next );
-
-		$this->assertEquals( (int) ( $now->getTimestamp() ) + HOUR_IN_SECONDS, $store->get_date( $new_action_id )->getTimestamp() );
-	}
-
-	public function test_claim_actions_by_hooks() {
-		$hook1    = __FUNCTION__ . '_hook_1';
-		$hook2    = __FUNCTION__ . '_hook_2';
-		$store    = new ActionScheduler_wpPostStore();
-		$schedule = new ActionScheduler_SimpleSchedule( as_get_datetime_object( '-1 hour' ) );
-
-		$action1 = $store->save_action( new ActionScheduler_Action( $hook1, array(), $schedule ) );
-		$action2 = $store->save_action( new ActionScheduler_Action( $hook2, array(), $schedule ) );
-
-		// Claiming no hooks should include all actions.
-		$claim = $store->stake_claim( 10 );
-		$this->assertCount( 2, $claim->get_actions() );
-		$this->assertContains( $action1, $claim->get_actions() );
-		$this->assertContains( $action2, $claim->get_actions() );
-		$store->release_claim( $claim );
-
-		// Claiming a hook should claim only actions with that hook
-		$claim = $store->stake_claim( 10, null, array( $hook1 ) );
-		$this->assertCount( 1, $claim->get_actions() );
-		$this->assertContains( $action1, $claim->get_actions() );
-		$store->release_claim( $claim );
-
-		// Claiming two hooks should claim actions with either of those hooks
-		$claim = $store->stake_claim( 10, null, array( $hook1, $hook2 ) );
-		$this->assertCount( 2, $claim->get_actions() );
-		$this->assertContains( $action1, $claim->get_actions() );
-		$this->assertContains( $action2, $claim->get_actions() );
-		$store->release_claim( $claim );
-
-		// Claiming two hooks should claim actions with either of those hooks
-		$claim = $store->stake_claim( 10, null, array( __METHOD__ . '_hook_3' ) );
-		$this->assertCount( 0, $claim->get_actions() );
-		$this->assertNotContains( $action1, $claim->get_actions() );
-		$this->assertNotContains( $action2, $claim->get_actions() );
-		$store->release_claim( $claim );
-	}
-
-	/**
-	 * @issue 121
-	 */
-	public function test_claim_actions_by_group() {
-		$group1   = md5( rand() );
-		$store    = new ActionScheduler_wpPostStore();
-		$schedule = new ActionScheduler_SimpleSchedule( as_get_datetime_object( '-1 hour' ) );
-
-		$action1 = $store->save_action( new ActionScheduler_Action( __METHOD__, array(), $schedule, $group1 ) );
-		$action2 = $store->save_action( new ActionScheduler_Action( __METHOD__, array(), $schedule ) );
-
-		// Claiming no group should include all actions.
-		$claim = $store->stake_claim( 10 );
-		$this->assertCount( 2, $claim->get_actions() );
-		$this->assertContains( $action1, $claim->get_actions() );
-		$this->assertContains( $action2, $claim->get_actions() );
-		$store->release_claim( $claim );
-
-		// Claiming a group should claim only actions in that group.
-		$claim = $store->stake_claim( 10, null, array(), $group1 );
-		$this->assertCount( 1, $claim->get_actions() );
-		$this->assertContains( $action1, $claim->get_actions() );
-		$store->release_claim( $claim );
-	}
-
-	public function test_claim_actions_by_hook_and_group() {
-		$hook1    = __FUNCTION__ . '_hook_1';
-		$hook2    = __FUNCTION__ . '_hook_2';
-		$hook3    = __FUNCTION__ . '_hook_3';
-		$group1   = 'group_' . md5( rand() );
-		$group2   = 'group_' . md5( rand() );
-		$store    = new ActionScheduler_wpPostStore();
-		$schedule = new ActionScheduler_SimpleSchedule( as_get_datetime_object( '-1 hour' ) );
-
-		$action1 = $store->save_action( new ActionScheduler_Action( $hook1, array(), $schedule, $group1 ) );
-		$action2 = $store->save_action( new ActionScheduler_Action( $hook2, array(), $schedule ) );
-		$action3 = $store->save_action( new ActionScheduler_Action( $hook3, array(), $schedule, $group2 ) );
-
-		// Claiming no hooks or group should include all actions.
-		$claim = $store->stake_claim( 10 );
-		$this->assertCount( 3, $claim->get_actions() );
-		$this->assertContains( $action1, $claim->get_actions() );
-		$this->assertContains( $action2, $claim->get_actions() );
-		$store->release_claim( $claim );
-
-		// Claiming a group and hook should claim only actions in that group.
-		$claim = $store->stake_claim( 10, null, array( $hook1 ), $group1 );
-		$this->assertCount( 1, $claim->get_actions() );
-		$this->assertContains( $action1, $claim->get_actions() );
-		$store->release_claim( $claim );
-
-		// Claiming a group and hook should claim only actions with that hook in that group.
-		$claim = $store->stake_claim( 10, null, array( $hook2 ), $group1 );
-		$this->assertCount( 0, $claim->get_actions() );
-		$this->assertNotContains( $action1, $claim->get_actions() );
-		$this->assertNotContains( $action2, $claim->get_actions() );
-		$store->release_claim( $claim );
-
-		// Claiming a group and hook should claim only actions with that hook in that group.
-		$claim = $store->stake_claim( 10, null, array( $hook1, $hook2 ), $group2 );
-		$this->assertCount( 0, $claim->get_actions() );
-		$this->assertNotContains( $action1, $claim->get_actions() );
-		$this->assertNotContains( $action2, $claim->get_actions() );
-		$store->release_claim( $claim );
-	}
-
-	/**
-	 * The query used to claim actions explicitly ignores future pending actions, but it
-	 * is still possible under unusual conditions (such as if MySQL runs out of temporary
-	 * storage space) for such actions to be returned.
-	 *
-	 * When this happens, we still expect the store to filter them out, otherwise there is
-	 * a risk that actions will be unexpectedly processed ahead of time.
-	 *
-	 * @see https://github.com/woocommerce/action-scheduler/issues/634
-	 */
-	public function test_claim_filters_out_unexpected_future_actions() {
-		$group = __METHOD__;
-		$store = new ActionScheduler_wpPostStore();
-
-		// Create 4 actions: 2 that are already due (-3hrs and -1hrs) and 2 that are not yet due (+1hr and +3hrs).
-		for ( $i = -3; $i <= 3; $i += 2 ) {
-			$schedule     = new ActionScheduler_SimpleSchedule( as_get_datetime_object( $i . ' hours' ) );
-			$action_ids[] = $store->save_action( new ActionScheduler_Action( 'test_' . $i, array(), $schedule, $group ) );
-		}
-
-		// This callback is used to simulate the unusual conditions whereby MySQL might unexpectedly return future
-		// actions, contrary to the conditions used by the store object when staking its claim.
-		$simulate_unexpected_db_behavior = function ( $sql ) use ( $action_ids ) {
-			global $wpdb;
-
-			$post_type = ActionScheduler_wpPostStore::POST_TYPE;
-			$pending   = ActionScheduler_wpPostStore::STATUS_PENDING;
-
-			// Look out for the claim update query, ignore all others.
-			if (
-				0 !== strpos( $sql, "UPDATE $wpdb->posts" )
-				|| 0 !== strpos( $sql, "WHERE post_type = '$post_type' AND post_status = '$pending' AND post_password = ''" )
-				|| ! preg_match( "/AND post_date_gmt <= '([0-9:\-\s]{19})'/", $sql, $matches )
-				|| count( $matches ) !== 2
-			) {
-				return $sql;
-			}
-
-			// Now modify the query, forcing it to also return the future actions we created.
-			return str_replace( $matches[1], as_get_datetime_object( '+4 hours' )->format( 'Y-m-d H:i:s' ), $sql );
-		};
-
-		add_filter( 'query', $simulate_unexpected_db_behavior );
-		$claim           = $store->stake_claim( 10, null, array(), $group );
-		$claimed_actions = $claim->get_actions();
-		$this->assertCount( 2, $claimed_actions );
-
-		// Cleanup.
-		remove_filter( 'query', $simulate_unexpected_db_behavior );
-		$store->release_claim( $claim );
-	}
+    /**
+     * Get data store for tests.
+     *
+     * @return ActionScheduler_wpPostStore
+     */
+    protected function get_store() {
+        return new ActionScheduler_wpPostStore();
+    }
+
+    public function test_create_action() {
+        $time      = as_get_datetime_object();
+        $schedule  = new ActionScheduler_SimpleSchedule( $time );
+        $action    = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule );
+        $store     = new ActionScheduler_wpPostStore();
+        $action_id = $store->save_action( $action );
+
+        $this->assertNotEmpty( $action_id );
+    }
+
+    public function test_create_action_with_scheduled_date() {
+        $time   = as_get_datetime_object( strtotime( '-1 week' ) );
+        $action = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), new ActionScheduler_SimpleSchedule( $time ) );
+        $store  = new ActionScheduler_wpPostStore();
+
+        $action_id   = $store->save_action( $action, $time );
+        $action_date = $store->get_date( $action_id );
+
+        $this->assertEquals( $time->getTimestamp(), $action_date->getTimestamp() );
+    }
+
+    public function test_retrieve_action() {
+        $time      = as_get_datetime_object();
+        $schedule  = new ActionScheduler_SimpleSchedule( $time );
+        $action    = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule, 'my_group' );
+        $store     = new ActionScheduler_wpPostStore();
+        $action_id = $store->save_action( $action );
+
+        $retrieved = $store->fetch_action( $action_id );
+        $this->assertEquals( $action->get_hook(), $retrieved->get_hook() );
+        $this->assertEqualSets( $action->get_args(), $retrieved->get_args() );
+        $this->assertEquals( $action->get_schedule()->get_date()->getTimestamp(), $retrieved->get_schedule()->get_date()->getTimestamp() );
+        $this->assertEquals( $action->get_group(), $retrieved->get_group() );
+    }
+
+    /**
+     * @dataProvider provide_bad_args
+     *
+     * @param string $content
+     */
+    public function test_action_bad_args( $content ) {
+        $store   = new ActionScheduler_wpPostStore();
+        $post_id = wp_insert_post(
+            array(
+                'post_type'    => ActionScheduler_wpPostStore::POST_TYPE,
+                'post_status'  => ActionScheduler_Store::STATUS_PENDING,
+                'post_content' => $content,
+            )
+        );
+
+        $fetched = $store->fetch_action( $post_id );
+        $this->assertInstanceOf( 'ActionScheduler_NullSchedule', $fetched->get_schedule() );
+    }
+
+    public function provide_bad_args() {
+        return array(
+            array( '{"bad_json":true}}' ),
+        );
+    }
+
+    public function test_cancel_action() {
+        $time      = as_get_datetime_object();
+        $schedule  = new ActionScheduler_SimpleSchedule( $time );
+        $action    = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule, 'my_group' );
+        $store     = new ActionScheduler_wpPostStore();
+        $action_id = $store->save_action( $action );
+        $store->cancel_action( $action_id );
+
+        $fetched = $store->fetch_action( $action_id );
+        $this->assertInstanceOf( 'ActionScheduler_CanceledAction', $fetched );
+    }
+
+    public function test_cancel_actions_by_hook() {
+        $store   = new ActionScheduler_wpPostStore();
+        $actions = array();
+        $hook    = 'by_hook_test';
+        for ( $day = 1; $day <= 3; $day++ ) {
+            $delta     = sprintf( '+%d day', $day );
+            $time      = as_get_datetime_object( $delta );
+            $schedule  = new ActionScheduler_SimpleSchedule( $time );
+            $action    = new ActionScheduler_Action( $hook, array(), $schedule, 'my_group' );
+            $actions[] = $store->save_action( $action );
+        }
+        $store->cancel_actions_by_hook( $hook );
+
+        foreach ( $actions as $action_id ) {
+            $fetched = $store->fetch_action( $action_id );
+            $this->assertInstanceOf( 'ActionScheduler_CanceledAction', $fetched );
+        }
+    }
+
+    public function test_cancel_actions_by_group() {
+        $store   = new ActionScheduler_wpPostStore();
+        $actions = array();
+        $group   = 'by_group_test';
+
+        for ( $day = 1; $day <= 3; $day++ ) {
+            $delta     = sprintf( '+%d day', $day );
+            $time      = as_get_datetime_object( $delta );
+            $schedule  = new ActionScheduler_SimpleSchedule( $time );
+            $action    = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule, $group );
+            $actions[] = $store->save_action( $action );
+        }
+        $store->cancel_actions_by_group( $group );
+
+        foreach ( $actions as $action_id ) {
+            $fetched = $store->fetch_action( $action_id );
+            $this->assertInstanceOf( 'ActionScheduler_CanceledAction', $fetched );
+        }
+    }
+
+    public function test_claim_actions() {
+        $created_actions = array();
+        $store           = new ActionScheduler_wpPostStore();
+        for ( $i = 3; $i > -3; $i-- ) {
+            $time              = as_get_datetime_object( $i . ' hours' );
+            $schedule          = new ActionScheduler_SimpleSchedule( $time );
+            $action            = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( $i ), $schedule, 'my_group' );
+            $created_actions[] = $store->save_action( $action );
+        }
+
+        $claim = $store->stake_claim();
+        $this->assertInstanceof( 'ActionScheduler_ActionClaim', $claim );
+
+        $this->assertCount( 3, $claim->get_actions() );
+        $this->assertEqualSets( array_slice( $created_actions, 3, 3 ), $claim->get_actions() );
+    }
+
+    public function test_claim_actions_order() {
+        $store           = new ActionScheduler_wpPostStore();
+        $schedule        = new ActionScheduler_SimpleSchedule( as_get_datetime_object( '-1 hour' ) );
+        $created_actions = array(
+            $store->save_action( new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( 1 ), $schedule, 'my_group' ) ),
+            $store->save_action( new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( 1 ), $schedule, 'my_group' ) ),
+        );
+
+        $claim = $store->stake_claim();
+        $this->assertInstanceof( 'ActionScheduler_ActionClaim', $claim );
+
+        // Verify uniqueness of action IDs.
+        $this->assertCount( 2, array_unique( $created_actions ) );
+
+        // Verify the count and order of the actions.
+        $claimed_actions = $claim->get_actions();
+        $this->assertCount( 2, $claimed_actions );
+        $this->assertEquals( $created_actions, $claimed_actions );
+
+        // Verify the reversed order doesn't pass.
+        $reversed_actions = array_reverse( $created_actions );
+        $this->assertNotEquals( $reversed_actions, $claimed_actions );
+    }
+
+    public function test_duplicate_claim() {
+        $created_actions = array();
+        $store           = new ActionScheduler_wpPostStore();
+        for ( $i = 0; $i > -3; $i-- ) {
+            $time              = as_get_datetime_object( $i . ' hours' );
+            $schedule          = new ActionScheduler_SimpleSchedule( $time );
+            $action            = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( $i ), $schedule, 'my_group' );
+            $created_actions[] = $store->save_action( $action );
+        }
+
+        $claim1 = $store->stake_claim();
+        $claim2 = $store->stake_claim();
+        $this->assertCount( 3, $claim1->get_actions() );
+        $this->assertCount( 0, $claim2->get_actions() );
+    }
+
+    public function test_release_claim() {
+        $created_actions = array();
+        $store           = new ActionScheduler_wpPostStore();
+        for ( $i = 0; $i > -3; $i-- ) {
+            $time              = as_get_datetime_object( $i . ' hours' );
+            $schedule          = new ActionScheduler_SimpleSchedule( $time );
+            $action            = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( $i ), $schedule, 'my_group' );
+            $created_actions[] = $store->save_action( $action );
+        }
+
+        $claim1 = $store->stake_claim();
+
+        $store->release_claim( $claim1 );
+
+        $claim2 = $store->stake_claim();
+        $this->assertCount( 3, $claim2->get_actions() );
+    }
+
+    public function test_search() {
+        $created_actions = array();
+        $store           = new ActionScheduler_wpPostStore();
+        for ( $i = -3; $i <= 3; $i++ ) {
+            $time              = as_get_datetime_object( $i . ' hours' );
+            $schedule          = new ActionScheduler_SimpleSchedule( $time );
+            $action            = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( $i ), $schedule, 'my_group' );
+            $created_actions[] = $store->save_action( $action );
+        }
+
+        $next_no_args = $store->find_action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK );
+        $this->assertEquals( $created_actions[0], $next_no_args );
+
+        $next_with_args = $store->find_action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( 'args' => array( 1 ) ) );
+        $this->assertEquals( $created_actions[4], $next_with_args );
+
+        $non_existent = $store->find_action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( 'args' => array( 17 ) ) );
+        $this->assertNull( $non_existent );
+    }
+
+    public function test_search_by_group() {
+        $store    = new ActionScheduler_wpPostStore();
+        $schedule = new ActionScheduler_SimpleSchedule( as_get_datetime_object( 'tomorrow' ) );
+        $abc      = $store->save_action( new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( 1 ), $schedule, 'abc' ) );
+        $def      = $store->save_action( new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( 1 ), $schedule, 'def' ) );
+        $ghi      = $store->save_action( new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( 1 ), $schedule, 'ghi' ) );
+
+        $this->assertEquals( $abc, $store->find_action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( 'group' => 'abc' ) ) );
+        $this->assertEquals( $def, $store->find_action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( 'group' => 'def' ) ) );
+        $this->assertEquals( $ghi, $store->find_action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( 'group' => 'ghi' ) ) );
+    }
+
+    public function test_post_author() {
+        $current_user = get_current_user_id();
+
+        $time      = as_get_datetime_object();
+        $schedule  = new ActionScheduler_SimpleSchedule( $time );
+        $action    = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule );
+        $store     = new ActionScheduler_wpPostStore();
+        $action_id = $store->save_action( $action );
+
+        $post = get_post( $action_id );
+        $this->assertSame( 0, $post->post_author );
+
+        $new_user = $this->factory->user->create_object(
+            array(
+                'user_login' => __FUNCTION__,
+                'user_pass'  => md5( rand() ),
+            )
+        );
+        wp_set_current_user( $new_user );
+
+        $schedule  = new ActionScheduler_SimpleSchedule( $time );
+        $action    = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule );
+        $action_id = $store->save_action( $action );
+        $post      = get_post( $action_id );
+        $this->assertSame( 0, $post->post_author );
+
+        wp_set_current_user( $current_user );
+    }
+
+    /**
+     * @issue 13
+     */
+    public function test_post_status_for_recurring_action() {
+        $time      = as_get_datetime_object( '10 minutes' );
+        $schedule  = new ActionScheduler_IntervalSchedule( $time, HOUR_IN_SECONDS );
+        $action    = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule );
+        $store     = new ActionScheduler_wpPostStore();
+        $action_id = $store->save_action( $action );
+
+        $action = $store->fetch_action( $action_id );
+        $action->execute();
+        $store->mark_complete( $action_id );
+
+        $next          = $action->get_schedule()->get_next( as_get_datetime_object() );
+        $new_action_id = $store->save_action( $action, $next );
+
+        $this->assertEquals( 'publish', get_post_status( $action_id ) );
+        $this->assertEquals( 'pending', get_post_status( $new_action_id ) );
+    }
+
+    public function test_get_run_date() {
+        $time      = as_get_datetime_object( '-10 minutes' );
+        $schedule  = new ActionScheduler_IntervalSchedule( $time, HOUR_IN_SECONDS );
+        $action    = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule );
+        $store     = new ActionScheduler_wpPostStore();
+        $action_id = $store->save_action( $action );
+
+        $this->assertEquals( $store->get_date( $action_id )->getTimestamp(), $time->getTimestamp() );
+
+        $action = $store->fetch_action( $action_id );
+        $action->execute();
+        $now = as_get_datetime_object();
+        $store->mark_complete( $action_id );
+
+        $this->assertEquals( $store->get_date( $action_id )->getTimestamp(), $now->getTimestamp(), '', 1 ); // allow timestamp to be 1 second off for older versions of PHP
+
+        $next          = $action->get_schedule()->get_next( $now );
+        $new_action_id = $store->save_action( $action, $next );
+
+        $this->assertEquals( (int) ( $now->getTimestamp() ) + HOUR_IN_SECONDS, $store->get_date( $new_action_id )->getTimestamp() );
+    }
+
+    public function test_claim_actions_by_hooks() {
+        $hook1    = __FUNCTION__ . '_hook_1';
+        $hook2    = __FUNCTION__ . '_hook_2';
+        $store    = new ActionScheduler_wpPostStore();
+        $schedule = new ActionScheduler_SimpleSchedule( as_get_datetime_object( '-1 hour' ) );
+
+        $action1 = $store->save_action( new ActionScheduler_Action( $hook1, array(), $schedule ) );
+        $action2 = $store->save_action( new ActionScheduler_Action( $hook2, array(), $schedule ) );
+
+        // Claiming no hooks should include all actions.
+        $claim = $store->stake_claim( 10 );
+        $this->assertCount( 2, $claim->get_actions() );
+        $this->assertContains( $action1, $claim->get_actions() );
+        $this->assertContains( $action2, $claim->get_actions() );
+        $store->release_claim( $claim );
+
+        // Claiming a hook should claim only actions with that hook
+        $claim = $store->stake_claim( 10, null, array( $hook1 ) );
+        $this->assertCount( 1, $claim->get_actions() );
+        $this->assertContains( $action1, $claim->get_actions() );
+        $store->release_claim( $claim );
+
+        // Claiming two hooks should claim actions with either of those hooks
+        $claim = $store->stake_claim( 10, null, array( $hook1, $hook2 ) );
+        $this->assertCount( 2, $claim->get_actions() );
+        $this->assertContains( $action1, $claim->get_actions() );
+        $this->assertContains( $action2, $claim->get_actions() );
+        $store->release_claim( $claim );
+
+        // Claiming two hooks should claim actions with either of those hooks
+        $claim = $store->stake_claim( 10, null, array( __METHOD__ . '_hook_3' ) );
+        $this->assertCount( 0, $claim->get_actions() );
+        $this->assertNotContains( $action1, $claim->get_actions() );
+        $this->assertNotContains( $action2, $claim->get_actions() );
+        $store->release_claim( $claim );
+    }
+
+    /**
+     * @issue 121
+     */
+    public function test_claim_actions_by_group() {
+        $group1   = md5( rand() );
+        $store    = new ActionScheduler_wpPostStore();
+        $schedule = new ActionScheduler_SimpleSchedule( as_get_datetime_object( '-1 hour' ) );
+
+        $action1 = $store->save_action( new ActionScheduler_Action( __METHOD__, array(), $schedule, $group1 ) );
+        $action2 = $store->save_action( new ActionScheduler_Action( __METHOD__, array(), $schedule ) );
+
+        // Claiming no group should include all actions.
+        $claim = $store->stake_claim( 10 );
+        $this->assertCount( 2, $claim->get_actions() );
+        $this->assertContains( $action1, $claim->get_actions() );
+        $this->assertContains( $action2, $claim->get_actions() );
+        $store->release_claim( $claim );
+
+        // Claiming a group should claim only actions in that group.
+        $claim = $store->stake_claim( 10, null, array(), $group1 );
+        $this->assertCount( 1, $claim->get_actions() );
+        $this->assertContains( $action1, $claim->get_actions() );
+        $store->release_claim( $claim );
+    }
+
+    public function test_claim_actions_by_hook_and_group() {
+        $hook1    = __FUNCTION__ . '_hook_1';
+        $hook2    = __FUNCTION__ . '_hook_2';
+        $hook3    = __FUNCTION__ . '_hook_3';
+        $group1   = 'group_' . md5( rand() );
+        $group2   = 'group_' . md5( rand() );
+        $store    = new ActionScheduler_wpPostStore();
+        $schedule = new ActionScheduler_SimpleSchedule( as_get_datetime_object( '-1 hour' ) );
+
+        $action1 = $store->save_action( new ActionScheduler_Action( $hook1, array(), $schedule, $group1 ) );
+        $action2 = $store->save_action( new ActionScheduler_Action( $hook2, array(), $schedule ) );
+        $action3 = $store->save_action( new ActionScheduler_Action( $hook3, array(), $schedule, $group2 ) );
+
+        // Claiming no hooks or group should include all actions.
+        $claim = $store->stake_claim( 10 );
+        $this->assertCount( 3, $claim->get_actions() );
+        $this->assertContains( $action1, $claim->get_actions() );
+        $this->assertContains( $action2, $claim->get_actions() );
+        $store->release_claim( $claim );
+
+        // Claiming a group and hook should claim only actions in that group.
+        $claim = $store->stake_claim( 10, null, array( $hook1 ), $group1 );
+        $this->assertCount( 1, $claim->get_actions() );
+        $this->assertContains( $action1, $claim->get_actions() );
+        $store->release_claim( $claim );
+
+        // Claiming a group and hook should claim only actions with that hook in that group.
+        $claim = $store->stake_claim( 10, null, array( $hook2 ), $group1 );
+        $this->assertCount( 0, $claim->get_actions() );
+        $this->assertNotContains( $action1, $claim->get_actions() );
+        $this->assertNotContains( $action2, $claim->get_actions() );
+        $store->release_claim( $claim );
+
+        // Claiming a group and hook should claim only actions with that hook in that group.
+        $claim = $store->stake_claim( 10, null, array( $hook1, $hook2 ), $group2 );
+        $this->assertCount( 0, $claim->get_actions() );
+        $this->assertNotContains( $action1, $claim->get_actions() );
+        $this->assertNotContains( $action2, $claim->get_actions() );
+        $store->release_claim( $claim );
+    }
+
+    /**
+     * The query used to claim actions explicitly ignores future pending actions, but it
+     * is still possible under unusual conditions (such as if MySQL runs out of temporary
+     * storage space) for such actions to be returned.
+     *
+     * When this happens, we still expect the store to filter them out, otherwise there is
+     * a risk that actions will be unexpectedly processed ahead of time.
+     *
+     * @see https://github.com/woocommerce/action-scheduler/issues/634
+     */
+    public function test_claim_filters_out_unexpected_future_actions() {
+        $group = __METHOD__;
+        $store = new ActionScheduler_wpPostStore();
+
+        // Create 4 actions: 2 that are already due (-3hrs and -1hrs) and 2 that are not yet due (+1hr and +3hrs).
+        for ( $i = -3; $i <= 3; $i += 2 ) {
+            $schedule     = new ActionScheduler_SimpleSchedule( as_get_datetime_object( $i . ' hours' ) );
+            $action_ids[] = $store->save_action( new ActionScheduler_Action( 'test_' . $i, array(), $schedule, $group ) );
+        }
+
+        // This callback is used to simulate the unusual conditions whereby MySQL might unexpectedly return future
+        // actions, contrary to the conditions used by the store object when staking its claim.
+        $simulate_unexpected_db_behavior = function ( $sql ) use ( $action_ids ) {
+            global $wpdb;
+
+            $post_type = ActionScheduler_wpPostStore::POST_TYPE;
+            $pending   = ActionScheduler_wpPostStore::STATUS_PENDING;
+
+            // Look out for the claim update query, ignore all others.
+            if (
+                0 !== strpos( $sql, "UPDATE $wpdb->posts" )
+                || 0 !== strpos( $sql, "WHERE post_type = '$post_type' AND post_status = '$pending' AND post_password = ''" )
+                || ! preg_match( "/AND post_date_gmt <= '([0-9:\-\s]{19})'/", $sql, $matches )
+                || count( $matches ) !== 2
+            ) {
+                return $sql;
+            }
+
+            // Now modify the query, forcing it to also return the future actions we created.
+            return str_replace( $matches[1], as_get_datetime_object( '+4 hours' )->format( 'Y-m-d H:i:s' ), $sql );
+        };
+
+        add_filter( 'query', $simulate_unexpected_db_behavior );
+        $claim           = $store->stake_claim( 10, null, array(), $group );
+        $claimed_actions = $claim->get_actions();
+        $this->assertCount( 2, $claimed_actions );
+
+        // Cleanup.
+        remove_filter( 'query', $simulate_unexpected_db_behavior );
+        $store->release_claim( $claim );
+    }
 }

Spacing +210 added lines, -210 removed lines

@@ -20,37 +20,37 @@ 
 
 	public function test_create_action() {
 		$time      = as_get_datetime_object();
-		$schedule  = new ActionScheduler_SimpleSchedule( $time );
-		$action    = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule );
+		$schedule  = new ActionScheduler_SimpleSchedule($time);
+		$action    = new ActionScheduler_Action(ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule);
 		$store     = new ActionScheduler_wpPostStore();
-		$action_id = $store->save_action( $action );
+		$action_id = $store->save_action($action);
 
-		$this->assertNotEmpty( $action_id );
+		$this->assertNotEmpty($action_id);
 	}
 
 	public function test_create_action_with_scheduled_date() {
-		$time   = as_get_datetime_object( strtotime( '-1 week' ) );
-		$action = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), new ActionScheduler_SimpleSchedule( $time ) );
+		$time   = as_get_datetime_object(strtotime('-1 week'));
+		$action = new ActionScheduler_Action(ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), new ActionScheduler_SimpleSchedule($time));
 		$store  = new ActionScheduler_wpPostStore();
 
-		$action_id   = $store->save_action( $action, $time );
-		$action_date = $store->get_date( $action_id );
+		$action_id   = $store->save_action($action, $time);
+		$action_date = $store->get_date($action_id);
 
-		$this->assertEquals( $time->getTimestamp(), $action_date->getTimestamp() );
+		$this->assertEquals($time->getTimestamp(), $action_date->getTimestamp());
 	}
 
 	public function test_retrieve_action() {
 		$time      = as_get_datetime_object();
-		$schedule  = new ActionScheduler_SimpleSchedule( $time );
-		$action    = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule, 'my_group' );
+		$schedule  = new ActionScheduler_SimpleSchedule($time);
+		$action    = new ActionScheduler_Action(ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule, 'my_group');
 		$store     = new ActionScheduler_wpPostStore();
-		$action_id = $store->save_action( $action );
+		$action_id = $store->save_action($action);
 
-		$retrieved = $store->fetch_action( $action_id );
-		$this->assertEquals( $action->get_hook(), $retrieved->get_hook() );
-		$this->assertEqualSets( $action->get_args(), $retrieved->get_args() );
-		$this->assertEquals( $action->get_schedule()->get_date()->getTimestamp(), $retrieved->get_schedule()->get_date()->getTimestamp() );
-		$this->assertEquals( $action->get_group(), $retrieved->get_group() );
+		$retrieved = $store->fetch_action($action_id);
+		$this->assertEquals($action->get_hook(), $retrieved->get_hook());
+		$this->assertEqualSets($action->get_args(), $retrieved->get_args());
+		$this->assertEquals($action->get_schedule()->get_date()->getTimestamp(), $retrieved->get_schedule()->get_date()->getTimestamp());
+		$this->assertEquals($action->get_group(), $retrieved->get_group());
 	}
 
 	/**
@@ -58,7 +58,7 @@ 
 	 *
 	 * @param string $content
 	 */
-	public function test_action_bad_args( $content ) {
+	public function test_action_bad_args($content) {
 		$store   = new ActionScheduler_wpPostStore();
 		$post_id = wp_insert_post(
 			array(
@@ -68,44 +68,44 @@ 
 			)
 		);
 
-		$fetched = $store->fetch_action( $post_id );
-		$this->assertInstanceOf( 'ActionScheduler_NullSchedule', $fetched->get_schedule() );
+		$fetched = $store->fetch_action($post_id);
+		$this->assertInstanceOf('ActionScheduler_NullSchedule', $fetched->get_schedule());
 	}
 
 	public function provide_bad_args() {
 		return array(
-			array( '{"bad_json":true}}' ),
+			array('{"bad_json":true}}'),
 		);
 	}
 
 	public function test_cancel_action() {
 		$time      = as_get_datetime_object();
-		$schedule  = new ActionScheduler_SimpleSchedule( $time );
-		$action    = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule, 'my_group' );
+		$schedule  = new ActionScheduler_SimpleSchedule($time);
+		$action    = new ActionScheduler_Action(ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule, 'my_group');
 		$store     = new ActionScheduler_wpPostStore();
-		$action_id = $store->save_action( $action );
-		$store->cancel_action( $action_id );
+		$action_id = $store->save_action($action);
+		$store->cancel_action($action_id);
 
-		$fetched = $store->fetch_action( $action_id );
-		$this->assertInstanceOf( 'ActionScheduler_CanceledAction', $fetched );
+		$fetched = $store->fetch_action($action_id);
+		$this->assertInstanceOf('ActionScheduler_CanceledAction', $fetched);
 	}
 
 	public function test_cancel_actions_by_hook() {
 		$store   = new ActionScheduler_wpPostStore();
 		$actions = array();
 		$hook    = 'by_hook_test';
-		for ( $day = 1; $day <= 3; $day++ ) {
-			$delta     = sprintf( '+%d day', $day );
-			$time      = as_get_datetime_object( $delta );
-			$schedule  = new ActionScheduler_SimpleSchedule( $time );
-			$action    = new ActionScheduler_Action( $hook, array(), $schedule, 'my_group' );
-			$actions[] = $store->save_action( $action );
+		for ($day = 1; $day <= 3; $day++) {
+			$delta     = sprintf('+%d day', $day);
+			$time      = as_get_datetime_object($delta);
+			$schedule  = new ActionScheduler_SimpleSchedule($time);
+			$action    = new ActionScheduler_Action($hook, array(), $schedule, 'my_group');
+			$actions[] = $store->save_action($action);
 		}
-		$store->cancel_actions_by_hook( $hook );
+		$store->cancel_actions_by_hook($hook);
 
-		foreach ( $actions as $action_id ) {
-			$fetched = $store->fetch_action( $action_id );
-			$this->assertInstanceOf( 'ActionScheduler_CanceledAction', $fetched );
+		foreach ($actions as $action_id) {
+			$fetched = $store->fetch_action($action_id);
+			$this->assertInstanceOf('ActionScheduler_CanceledAction', $fetched);
 		}
 	}
 
@@ -114,301 +114,301 @@ 
 		$actions = array();
 		$group   = 'by_group_test';
 
-		for ( $day = 1; $day <= 3; $day++ ) {
-			$delta     = sprintf( '+%d day', $day );
-			$time      = as_get_datetime_object( $delta );
-			$schedule  = new ActionScheduler_SimpleSchedule( $time );
-			$action    = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule, $group );
-			$actions[] = $store->save_action( $action );
+		for ($day = 1; $day <= 3; $day++) {
+			$delta     = sprintf('+%d day', $day);
+			$time      = as_get_datetime_object($delta);
+			$schedule  = new ActionScheduler_SimpleSchedule($time);
+			$action    = new ActionScheduler_Action(ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule, $group);
+			$actions[] = $store->save_action($action);
 		}
-		$store->cancel_actions_by_group( $group );
+		$store->cancel_actions_by_group($group);
 
-		foreach ( $actions as $action_id ) {
-			$fetched = $store->fetch_action( $action_id );
-			$this->assertInstanceOf( 'ActionScheduler_CanceledAction', $fetched );
+		foreach ($actions as $action_id) {
+			$fetched = $store->fetch_action($action_id);
+			$this->assertInstanceOf('ActionScheduler_CanceledAction', $fetched);
 		}
 	}
 
 	public function test_claim_actions() {
 		$created_actions = array();
 		$store           = new ActionScheduler_wpPostStore();
-		for ( $i = 3; $i > -3; $i-- ) {
-			$time              = as_get_datetime_object( $i . ' hours' );
-			$schedule          = new ActionScheduler_SimpleSchedule( $time );
-			$action            = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( $i ), $schedule, 'my_group' );
-			$created_actions[] = $store->save_action( $action );
+		for ($i = 3; $i > -3; $i--) {
+			$time              = as_get_datetime_object($i.' hours');
+			$schedule          = new ActionScheduler_SimpleSchedule($time);
+			$action            = new ActionScheduler_Action(ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array($i), $schedule, 'my_group');
+			$created_actions[] = $store->save_action($action);
 		}
 
 		$claim = $store->stake_claim();
-		$this->assertInstanceof( 'ActionScheduler_ActionClaim', $claim );
+		$this->assertInstanceof('ActionScheduler_ActionClaim', $claim);
 
-		$this->assertCount( 3, $claim->get_actions() );
-		$this->assertEqualSets( array_slice( $created_actions, 3, 3 ), $claim->get_actions() );
+		$this->assertCount(3, $claim->get_actions());
+		$this->assertEqualSets(array_slice($created_actions, 3, 3), $claim->get_actions());
 	}
 
 	public function test_claim_actions_order() {
 		$store           = new ActionScheduler_wpPostStore();
-		$schedule        = new ActionScheduler_SimpleSchedule( as_get_datetime_object( '-1 hour' ) );
+		$schedule        = new ActionScheduler_SimpleSchedule(as_get_datetime_object('-1 hour'));
 		$created_actions = array(
-			$store->save_action( new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( 1 ), $schedule, 'my_group' ) ),
-			$store->save_action( new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( 1 ), $schedule, 'my_group' ) ),
+			$store->save_action(new ActionScheduler_Action(ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(1), $schedule, 'my_group')),
+			$store->save_action(new ActionScheduler_Action(ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(1), $schedule, 'my_group')),
 		);
 
 		$claim = $store->stake_claim();
-		$this->assertInstanceof( 'ActionScheduler_ActionClaim', $claim );
+		$this->assertInstanceof('ActionScheduler_ActionClaim', $claim);
 
 		// Verify uniqueness of action IDs.
-		$this->assertCount( 2, array_unique( $created_actions ) );
+		$this->assertCount(2, array_unique($created_actions));
 
 		// Verify the count and order of the actions.
 		$claimed_actions = $claim->get_actions();
-		$this->assertCount( 2, $claimed_actions );
-		$this->assertEquals( $created_actions, $claimed_actions );
+		$this->assertCount(2, $claimed_actions);
+		$this->assertEquals($created_actions, $claimed_actions);
 
 		// Verify the reversed order doesn't pass.
-		$reversed_actions = array_reverse( $created_actions );
-		$this->assertNotEquals( $reversed_actions, $claimed_actions );
+		$reversed_actions = array_reverse($created_actions);
+		$this->assertNotEquals($reversed_actions, $claimed_actions);
 	}
 
 	public function test_duplicate_claim() {
 		$created_actions = array();
 		$store           = new ActionScheduler_wpPostStore();
-		for ( $i = 0; $i > -3; $i-- ) {
-			$time              = as_get_datetime_object( $i . ' hours' );
-			$schedule          = new ActionScheduler_SimpleSchedule( $time );
-			$action            = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( $i ), $schedule, 'my_group' );
-			$created_actions[] = $store->save_action( $action );
+		for ($i = 0; $i > -3; $i--) {
+			$time              = as_get_datetime_object($i.' hours');
+			$schedule          = new ActionScheduler_SimpleSchedule($time);
+			$action            = new ActionScheduler_Action(ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array($i), $schedule, 'my_group');
+			$created_actions[] = $store->save_action($action);
 		}
 
 		$claim1 = $store->stake_claim();
 		$claim2 = $store->stake_claim();
-		$this->assertCount( 3, $claim1->get_actions() );
-		$this->assertCount( 0, $claim2->get_actions() );
+		$this->assertCount(3, $claim1->get_actions());
+		$this->assertCount(0, $claim2->get_actions());
 	}
 
 	public function test_release_claim() {
 		$created_actions = array();
 		$store           = new ActionScheduler_wpPostStore();
-		for ( $i = 0; $i > -3; $i-- ) {
-			$time              = as_get_datetime_object( $i . ' hours' );
-			$schedule          = new ActionScheduler_SimpleSchedule( $time );
-			$action            = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( $i ), $schedule, 'my_group' );
-			$created_actions[] = $store->save_action( $action );
+		for ($i = 0; $i > -3; $i--) {
+			$time              = as_get_datetime_object($i.' hours');
+			$schedule          = new ActionScheduler_SimpleSchedule($time);
+			$action            = new ActionScheduler_Action(ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array($i), $schedule, 'my_group');
+			$created_actions[] = $store->save_action($action);
 		}
 
 		$claim1 = $store->stake_claim();
 
-		$store->release_claim( $claim1 );
+		$store->release_claim($claim1);
 
 		$claim2 = $store->stake_claim();
-		$this->assertCount( 3, $claim2->get_actions() );
+		$this->assertCount(3, $claim2->get_actions());
 	}
 
 	public function test_search() {
 		$created_actions = array();
 		$store           = new ActionScheduler_wpPostStore();
-		for ( $i = -3; $i <= 3; $i++ ) {
-			$time              = as_get_datetime_object( $i . ' hours' );
-			$schedule          = new ActionScheduler_SimpleSchedule( $time );
-			$action            = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( $i ), $schedule, 'my_group' );
-			$created_actions[] = $store->save_action( $action );
+		for ($i = -3; $i <= 3; $i++) {
+			$time              = as_get_datetime_object($i.' hours');
+			$schedule          = new ActionScheduler_SimpleSchedule($time);
+			$action            = new ActionScheduler_Action(ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array($i), $schedule, 'my_group');
+			$created_actions[] = $store->save_action($action);
 		}
 
-		$next_no_args = $store->find_action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK );
-		$this->assertEquals( $created_actions[0], $next_no_args );
+		$next_no_args = $store->find_action(ActionScheduler_Callbacks::HOOK_WITH_CALLBACK);
+		$this->assertEquals($created_actions[0], $next_no_args);
 
-		$next_with_args = $store->find_action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( 'args' => array( 1 ) ) );
-		$this->assertEquals( $created_actions[4], $next_with_args );
+		$next_with_args = $store->find_action(ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array('args' => array(1)));
+		$this->assertEquals($created_actions[4], $next_with_args);
 
-		$non_existent = $store->find_action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( 'args' => array( 17 ) ) );
-		$this->assertNull( $non_existent );
+		$non_existent = $store->find_action(ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array('args' => array(17)));
+		$this->assertNull($non_existent);
 	}
 
 	public function test_search_by_group() {
 		$store    = new ActionScheduler_wpPostStore();
-		$schedule = new ActionScheduler_SimpleSchedule( as_get_datetime_object( 'tomorrow' ) );
-		$abc      = $store->save_action( new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( 1 ), $schedule, 'abc' ) );
-		$def      = $store->save_action( new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( 1 ), $schedule, 'def' ) );
-		$ghi      = $store->save_action( new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( 1 ), $schedule, 'ghi' ) );
-
-		$this->assertEquals( $abc, $store->find_action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( 'group' => 'abc' ) ) );
-		$this->assertEquals( $def, $store->find_action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( 'group' => 'def' ) ) );
-		$this->assertEquals( $ghi, $store->find_action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( 'group' => 'ghi' ) ) );
+		$schedule = new ActionScheduler_SimpleSchedule(as_get_datetime_object('tomorrow'));
+		$abc      = $store->save_action(new ActionScheduler_Action(ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(1), $schedule, 'abc'));
+		$def      = $store->save_action(new ActionScheduler_Action(ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(1), $schedule, 'def'));
+		$ghi      = $store->save_action(new ActionScheduler_Action(ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(1), $schedule, 'ghi'));
+
+		$this->assertEquals($abc, $store->find_action(ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array('group' => 'abc')));
+		$this->assertEquals($def, $store->find_action(ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array('group' => 'def')));
+		$this->assertEquals($ghi, $store->find_action(ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array('group' => 'ghi')));
 	}
 
 	public function test_post_author() {
 		$current_user = get_current_user_id();
 
 		$time      = as_get_datetime_object();
-		$schedule  = new ActionScheduler_SimpleSchedule( $time );
-		$action    = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule );
+		$schedule  = new ActionScheduler_SimpleSchedule($time);
+		$action    = new ActionScheduler_Action(ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule);
 		$store     = new ActionScheduler_wpPostStore();
-		$action_id = $store->save_action( $action );
+		$action_id = $store->save_action($action);
 
-		$post = get_post( $action_id );
-		$this->assertSame( 0, $post->post_author );
+		$post = get_post($action_id);
+		$this->assertSame(0, $post->post_author);
 
 		$new_user = $this->factory->user->create_object(
 			array(
 				'user_login' => __FUNCTION__,
-				'user_pass'  => md5( rand() ),
+				'user_pass'  => md5(rand()),
 			)
 		);
-		wp_set_current_user( $new_user );
+		wp_set_current_user($new_user);
 
-		$schedule  = new ActionScheduler_SimpleSchedule( $time );
-		$action    = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule );
-		$action_id = $store->save_action( $action );
-		$post      = get_post( $action_id );
-		$this->assertSame( 0, $post->post_author );
+		$schedule  = new ActionScheduler_SimpleSchedule($time);
+		$action    = new ActionScheduler_Action(ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule);
+		$action_id = $store->save_action($action);
+		$post      = get_post($action_id);
+		$this->assertSame(0, $post->post_author);
 
-		wp_set_current_user( $current_user );
+		wp_set_current_user($current_user);
 	}
 
 	/**
 	 * @issue 13
 	 */
 	public function test_post_status_for_recurring_action() {
-		$time      = as_get_datetime_object( '10 minutes' );
-		$schedule  = new ActionScheduler_IntervalSchedule( $time, HOUR_IN_SECONDS );
-		$action    = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule );
+		$time      = as_get_datetime_object('10 minutes');
+		$schedule  = new ActionScheduler_IntervalSchedule($time, HOUR_IN_SECONDS);
+		$action    = new ActionScheduler_Action(ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule);
 		$store     = new ActionScheduler_wpPostStore();
-		$action_id = $store->save_action( $action );
+		$action_id = $store->save_action($action);
 
-		$action = $store->fetch_action( $action_id );
+		$action = $store->fetch_action($action_id);
 		$action->execute();
-		$store->mark_complete( $action_id );
+		$store->mark_complete($action_id);
 
-		$next          = $action->get_schedule()->get_next( as_get_datetime_object() );
-		$new_action_id = $store->save_action( $action, $next );
+		$next          = $action->get_schedule()->get_next(as_get_datetime_object());
+		$new_action_id = $store->save_action($action, $next);
 
-		$this->assertEquals( 'publish', get_post_status( $action_id ) );
-		$this->assertEquals( 'pending', get_post_status( $new_action_id ) );
+		$this->assertEquals('publish', get_post_status($action_id));
+		$this->assertEquals('pending', get_post_status($new_action_id));
 	}
 
 	public function test_get_run_date() {
-		$time      = as_get_datetime_object( '-10 minutes' );
-		$schedule  = new ActionScheduler_IntervalSchedule( $time, HOUR_IN_SECONDS );
-		$action    = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule );
+		$time      = as_get_datetime_object('-10 minutes');
+		$schedule  = new ActionScheduler_IntervalSchedule($time, HOUR_IN_SECONDS);
+		$action    = new ActionScheduler_Action(ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule);
 		$store     = new ActionScheduler_wpPostStore();
-		$action_id = $store->save_action( $action );
+		$action_id = $store->save_action($action);
 
-		$this->assertEquals( $store->get_date( $action_id )->getTimestamp(), $time->getTimestamp() );
+		$this->assertEquals($store->get_date($action_id)->getTimestamp(), $time->getTimestamp());
 
-		$action = $store->fetch_action( $action_id );
+		$action = $store->fetch_action($action_id);
 		$action->execute();
 		$now = as_get_datetime_object();
-		$store->mark_complete( $action_id );
+		$store->mark_complete($action_id);
 
-		$this->assertEquals( $store->get_date( $action_id )->getTimestamp(), $now->getTimestamp(), '', 1 ); // allow timestamp to be 1 second off for older versions of PHP
+		$this->assertEquals($store->get_date($action_id)->getTimestamp(), $now->getTimestamp(), '', 1); // allow timestamp to be 1 second off for older versions of PHP
 
-		$next          = $action->get_schedule()->get_next( $now );
-		$new_action_id = $store->save_action( $action, $next );
+		$next          = $action->get_schedule()->get_next($now);
+		$new_action_id = $store->save_action($action, $next);
 
-		$this->assertEquals( (int) ( $now->getTimestamp() ) + HOUR_IN_SECONDS, $store->get_date( $new_action_id )->getTimestamp() );
+		$this->assertEquals((int) ($now->getTimestamp()) + HOUR_IN_SECONDS, $store->get_date($new_action_id)->getTimestamp());
 	}
 
 	public function test_claim_actions_by_hooks() {
-		$hook1    = __FUNCTION__ . '_hook_1';
-		$hook2    = __FUNCTION__ . '_hook_2';
+		$hook1    = __FUNCTION__.'_hook_1';
+		$hook2    = __FUNCTION__.'_hook_2';
 		$store    = new ActionScheduler_wpPostStore();
-		$schedule = new ActionScheduler_SimpleSchedule( as_get_datetime_object( '-1 hour' ) );
+		$schedule = new ActionScheduler_SimpleSchedule(as_get_datetime_object('-1 hour'));
 
-		$action1 = $store->save_action( new ActionScheduler_Action( $hook1, array(), $schedule ) );
-		$action2 = $store->save_action( new ActionScheduler_Action( $hook2, array(), $schedule ) );
+		$action1 = $store->save_action(new ActionScheduler_Action($hook1, array(), $schedule));
+		$action2 = $store->save_action(new ActionScheduler_Action($hook2, array(), $schedule));
 
 		// Claiming no hooks should include all actions.
-		$claim = $store->stake_claim( 10 );
-		$this->assertCount( 2, $claim->get_actions() );
-		$this->assertContains( $action1, $claim->get_actions() );
-		$this->assertContains( $action2, $claim->get_actions() );
-		$store->release_claim( $claim );
+		$claim = $store->stake_claim(10);
+		$this->assertCount(2, $claim->get_actions());
+		$this->assertContains($action1, $claim->get_actions());
+		$this->assertContains($action2, $claim->get_actions());
+		$store->release_claim($claim);
 
 		// Claiming a hook should claim only actions with that hook
-		$claim = $store->stake_claim( 10, null, array( $hook1 ) );
-		$this->assertCount( 1, $claim->get_actions() );
-		$this->assertContains( $action1, $claim->get_actions() );
-		$store->release_claim( $claim );
+		$claim = $store->stake_claim(10, null, array($hook1));
+		$this->assertCount(1, $claim->get_actions());
+		$this->assertContains($action1, $claim->get_actions());
+		$store->release_claim($claim);
 
 		// Claiming two hooks should claim actions with either of those hooks
-		$claim = $store->stake_claim( 10, null, array( $hook1, $hook2 ) );
-		$this->assertCount( 2, $claim->get_actions() );
-		$this->assertContains( $action1, $claim->get_actions() );
-		$this->assertContains( $action2, $claim->get_actions() );
-		$store->release_claim( $claim );
+		$claim = $store->stake_claim(10, null, array($hook1, $hook2));
+		$this->assertCount(2, $claim->get_actions());
+		$this->assertContains($action1, $claim->get_actions());
+		$this->assertContains($action2, $claim->get_actions());
+		$store->release_claim($claim);
 
 		// Claiming two hooks should claim actions with either of those hooks
-		$claim = $store->stake_claim( 10, null, array( __METHOD__ . '_hook_3' ) );
-		$this->assertCount( 0, $claim->get_actions() );
-		$this->assertNotContains( $action1, $claim->get_actions() );
-		$this->assertNotContains( $action2, $claim->get_actions() );
-		$store->release_claim( $claim );
+		$claim = $store->stake_claim(10, null, array(__METHOD__.'_hook_3'));
+		$this->assertCount(0, $claim->get_actions());
+		$this->assertNotContains($action1, $claim->get_actions());
+		$this->assertNotContains($action2, $claim->get_actions());
+		$store->release_claim($claim);
 	}
 
 	/**
 	 * @issue 121
 	 */
 	public function test_claim_actions_by_group() {
-		$group1   = md5( rand() );
+		$group1   = md5(rand());
 		$store    = new ActionScheduler_wpPostStore();
-		$schedule = new ActionScheduler_SimpleSchedule( as_get_datetime_object( '-1 hour' ) );
+		$schedule = new ActionScheduler_SimpleSchedule(as_get_datetime_object('-1 hour'));
 
-		$action1 = $store->save_action( new ActionScheduler_Action( __METHOD__, array(), $schedule, $group1 ) );
-		$action2 = $store->save_action( new ActionScheduler_Action( __METHOD__, array(), $schedule ) );
+		$action1 = $store->save_action(new ActionScheduler_Action(__METHOD__, array(), $schedule, $group1));
+		$action2 = $store->save_action(new ActionScheduler_Action(__METHOD__, array(), $schedule));
 
 		// Claiming no group should include all actions.
-		$claim = $store->stake_claim( 10 );
-		$this->assertCount( 2, $claim->get_actions() );
-		$this->assertContains( $action1, $claim->get_actions() );
-		$this->assertContains( $action2, $claim->get_actions() );
-		$store->release_claim( $claim );
+		$claim = $store->stake_claim(10);
+		$this->assertCount(2, $claim->get_actions());
+		$this->assertContains($action1, $claim->get_actions());
+		$this->assertContains($action2, $claim->get_actions());
+		$store->release_claim($claim);
 
 		// Claiming a group should claim only actions in that group.
-		$claim = $store->stake_claim( 10, null, array(), $group1 );
-		$this->assertCount( 1, $claim->get_actions() );
-		$this->assertContains( $action1, $claim->get_actions() );
-		$store->release_claim( $claim );
+		$claim = $store->stake_claim(10, null, array(), $group1);
+		$this->assertCount(1, $claim->get_actions());
+		$this->assertContains($action1, $claim->get_actions());
+		$store->release_claim($claim);
 	}
 
 	public function test_claim_actions_by_hook_and_group() {
-		$hook1    = __FUNCTION__ . '_hook_1';
-		$hook2    = __FUNCTION__ . '_hook_2';
-		$hook3    = __FUNCTION__ . '_hook_3';
-		$group1   = 'group_' . md5( rand() );
-		$group2   = 'group_' . md5( rand() );
+		$hook1    = __FUNCTION__.'_hook_1';
+		$hook2    = __FUNCTION__.'_hook_2';
+		$hook3    = __FUNCTION__.'_hook_3';
+		$group1   = 'group_'.md5(rand());
+		$group2   = 'group_'.md5(rand());
 		$store    = new ActionScheduler_wpPostStore();
-		$schedule = new ActionScheduler_SimpleSchedule( as_get_datetime_object( '-1 hour' ) );
+		$schedule = new ActionScheduler_SimpleSchedule(as_get_datetime_object('-1 hour'));
 
-		$action1 = $store->save_action( new ActionScheduler_Action( $hook1, array(), $schedule, $group1 ) );
-		$action2 = $store->save_action( new ActionScheduler_Action( $hook2, array(), $schedule ) );
-		$action3 = $store->save_action( new ActionScheduler_Action( $hook3, array(), $schedule, $group2 ) );
+		$action1 = $store->save_action(new ActionScheduler_Action($hook1, array(), $schedule, $group1));
+		$action2 = $store->save_action(new ActionScheduler_Action($hook2, array(), $schedule));
+		$action3 = $store->save_action(new ActionScheduler_Action($hook3, array(), $schedule, $group2));
 
 		// Claiming no hooks or group should include all actions.
-		$claim = $store->stake_claim( 10 );
-		$this->assertCount( 3, $claim->get_actions() );
-		$this->assertContains( $action1, $claim->get_actions() );
-		$this->assertContains( $action2, $claim->get_actions() );
-		$store->release_claim( $claim );
+		$claim = $store->stake_claim(10);
+		$this->assertCount(3, $claim->get_actions());
+		$this->assertContains($action1, $claim->get_actions());
+		$this->assertContains($action2, $claim->get_actions());
+		$store->release_claim($claim);
 
 		// Claiming a group and hook should claim only actions in that group.
-		$claim = $store->stake_claim( 10, null, array( $hook1 ), $group1 );
-		$this->assertCount( 1, $claim->get_actions() );
-		$this->assertContains( $action1, $claim->get_actions() );
-		$store->release_claim( $claim );
+		$claim = $store->stake_claim(10, null, array($hook1), $group1);
+		$this->assertCount(1, $claim->get_actions());
+		$this->assertContains($action1, $claim->get_actions());
+		$store->release_claim($claim);
 
 		// Claiming a group and hook should claim only actions with that hook in that group.
-		$claim = $store->stake_claim( 10, null, array( $hook2 ), $group1 );
-		$this->assertCount( 0, $claim->get_actions() );
-		$this->assertNotContains( $action1, $claim->get_actions() );
-		$this->assertNotContains( $action2, $claim->get_actions() );
-		$store->release_claim( $claim );
+		$claim = $store->stake_claim(10, null, array($hook2), $group1);
+		$this->assertCount(0, $claim->get_actions());
+		$this->assertNotContains($action1, $claim->get_actions());
+		$this->assertNotContains($action2, $claim->get_actions());
+		$store->release_claim($claim);
 
 		// Claiming a group and hook should claim only actions with that hook in that group.
-		$claim = $store->stake_claim( 10, null, array( $hook1, $hook2 ), $group2 );
-		$this->assertCount( 0, $claim->get_actions() );
-		$this->assertNotContains( $action1, $claim->get_actions() );
-		$this->assertNotContains( $action2, $claim->get_actions() );
-		$store->release_claim( $claim );
+		$claim = $store->stake_claim(10, null, array($hook1, $hook2), $group2);
+		$this->assertCount(0, $claim->get_actions());
+		$this->assertNotContains($action1, $claim->get_actions());
+		$this->assertNotContains($action2, $claim->get_actions());
+		$store->release_claim($claim);
 	}
 
 	/**
@@ -426,14 +426,14 @@ 
 		$store = new ActionScheduler_wpPostStore();
 
 		// Create 4 actions: 2 that are already due (-3hrs and -1hrs) and 2 that are not yet due (+1hr and +3hrs).
-		for ( $i = -3; $i <= 3; $i += 2 ) {
-			$schedule     = new ActionScheduler_SimpleSchedule( as_get_datetime_object( $i . ' hours' ) );
-			$action_ids[] = $store->save_action( new ActionScheduler_Action( 'test_' . $i, array(), $schedule, $group ) );
+		for ($i = -3; $i <= 3; $i += 2) {
+			$schedule     = new ActionScheduler_SimpleSchedule(as_get_datetime_object($i.' hours'));
+			$action_ids[] = $store->save_action(new ActionScheduler_Action('test_'.$i, array(), $schedule, $group));
 		}
 
 		// This callback is used to simulate the unusual conditions whereby MySQL might unexpectedly return future
 		// actions, contrary to the conditions used by the store object when staking its claim.
-		$simulate_unexpected_db_behavior = function ( $sql ) use ( $action_ids ) {
+		$simulate_unexpected_db_behavior = function($sql) use ($action_ids) {
 			global $wpdb;
 
 			$post_type = ActionScheduler_wpPostStore::POST_TYPE;
@@ -441,25 +441,25 @@ 
 
 			// Look out for the claim update query, ignore all others.
 			if (
-				0 !== strpos( $sql, "UPDATE $wpdb->posts" )
-				|| 0 !== strpos( $sql, "WHERE post_type = '$post_type' AND post_status = '$pending' AND post_password = ''" )
-				|| ! preg_match( "/AND post_date_gmt <= '([0-9:\-\s]{19})'/", $sql, $matches )
-				|| count( $matches ) !== 2
+				0 !== strpos($sql, "UPDATE $wpdb->posts")
+				|| 0 !== strpos($sql, "WHERE post_type = '$post_type' AND post_status = '$pending' AND post_password = ''")
+				|| ! preg_match("/AND post_date_gmt <= '([0-9:\-\s]{19})'/", $sql, $matches)
+				|| count($matches) !== 2
 			) {
 				return $sql;
 			}
 
 			// Now modify the query, forcing it to also return the future actions we created.
-			return str_replace( $matches[1], as_get_datetime_object( '+4 hours' )->format( 'Y-m-d H:i:s' ), $sql );
+			return str_replace($matches[1], as_get_datetime_object('+4 hours')->format('Y-m-d H:i:s'), $sql);
 		};
 
-		add_filter( 'query', $simulate_unexpected_db_behavior );
-		$claim           = $store->stake_claim( 10, null, array(), $group );
+		add_filter('query', $simulate_unexpected_db_behavior);
+		$claim           = $store->stake_claim(10, null, array(), $group);
 		$claimed_actions = $claim->get_actions();
-		$this->assertCount( 2, $claimed_actions );
+		$this->assertCount(2, $claimed_actions);
 
 		// Cleanup.
-		remove_filter( 'query', $simulate_unexpected_db_behavior );
-		$store->release_claim( $claim );
+		remove_filter('query', $simulate_unexpected_db_behavior);
+		$store->release_claim($claim);
 	}
 }

src/libraries/action-scheduler/tests/phpunit/jobstore/AbstractStoreTest.php

Indentation +96 added lines, -96 removed lines

@@ -18,101 +18,101 @@
  */
 abstract class AbstractStoreTest extends ActionScheduler_UnitTestCase {
 
-	/**
-	 * Get data store for tests.
-	 *
-	 * @return ActionScheduler_Store
-	 */
-	abstract protected function get_store();
-
-	public function test_get_status() {
-		$time      = as_get_datetime_object( '-10 minutes' );
-		$schedule  = new ActionScheduler_IntervalSchedule( $time, HOUR_IN_SECONDS );
-		$action    = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule );
-		$store     = $this->get_store();
-		$action_id = $store->save_action( $action );
-
-		$this->assertEquals( ActionScheduler_Store::STATUS_PENDING, $store->get_status( $action_id ) );
-
-		$store->mark_complete( $action_id );
-		$this->assertEquals( ActionScheduler_Store::STATUS_COMPLETE, $store->get_status( $action_id ) );
-
-		$store->mark_failure( $action_id );
-		$this->assertEquals( ActionScheduler_Store::STATUS_FAILED, $store->get_status( $action_id ) );
-	}
-
-	/* Start tests for \ActionScheduler_Store::query_actions() */
-
-	public function test_query_actions_query_type_arg_invalid_option() {
-		$this->expectException( InvalidArgumentException::class );
-		$this->get_store()->query_actions( array( 'hook' => ActionScheduler_Callbacks::HOOK_WITH_CALLBACK ), 'invalid' );
-	}
-
-	public function test_query_actions_query_type_arg_valid_options() {
-		$store    = $this->get_store();
-		$schedule = new ActionScheduler_SimpleSchedule( as_get_datetime_object( 'tomorrow' ) );
-
-		$action_id_1 = $store->save_action( new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( 1 ), $schedule ) );
-		$action_id_2 = $store->save_action( new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( 1 ), $schedule ) );
-
-		$this->assertEquals( array( $action_id_1, $action_id_2 ), $store->query_actions( array( 'hook' => ActionScheduler_Callbacks::HOOK_WITH_CALLBACK ) ) );
-		$this->assertEquals( 2, $store->query_actions( array( 'hook' => ActionScheduler_Callbacks::HOOK_WITH_CALLBACK ), 'count' ) );
-	}
-
-	public function test_query_actions_by_single_status() {
-		$store    = $this->get_store();
-		$schedule = new ActionScheduler_SimpleSchedule( as_get_datetime_object( 'tomorrow' ) );
-
-		$this->assertSame( 0, $store->query_actions( array( 'status' => ActionScheduler_Store::STATUS_PENDING ), 'count' ) );
-
-		$action_id_1 = $store->save_action( new ActionScheduler_Action( 'my_hook_1', array( 1 ), $schedule ) );
-		$action_id_2 = $store->save_action( new ActionScheduler_Action( 'my_hook_2', array( 1 ), $schedule ) );
-		$action_id_3 = $store->save_action( new ActionScheduler_Action( 'my_hook_3', array( 1 ), $schedule ) );
-		$store->mark_complete( $action_id_3 );
-
-		$this->assertEquals( 2, $store->query_actions( array( 'status' => ActionScheduler_Store::STATUS_PENDING ), 'count' ) );
-		$this->assertSame( 1, $store->query_actions( array( 'status' => ActionScheduler_Store::STATUS_COMPLETE ), 'count' ) );
-	}
-
-	public function test_query_actions_by_array_status() {
-		$store    = $this->get_store();
-		$schedule = new ActionScheduler_SimpleSchedule( as_get_datetime_object( 'tomorrow' ) );
-
-		$this->assertSame(
-			0,
-			$store->query_actions(
-				array(
-					'status' => array( ActionScheduler_Store::STATUS_PENDING, ActionScheduler_Store::STATUS_RUNNING ),
-				),
-				'count'
-			)
-		);
-
-		$action_id_1 = $store->save_action( new ActionScheduler_Action( 'my_hook_1', array( 1 ), $schedule ) );
-		$action_id_2 = $store->save_action( new ActionScheduler_Action( 'my_hook_2', array( 1 ), $schedule ) );
-		$action_id_3 = $store->save_action( new ActionScheduler_Action( 'my_hook_3', array( 1 ), $schedule ) );
-		$store->mark_failure( $action_id_3 );
-
-		$this->assertEquals(
-			3,
-			$store->query_actions(
-				array(
-					'status' => array( ActionScheduler_Store::STATUS_PENDING, ActionScheduler_Store::STATUS_FAILED ),
-				),
-				'count'
-			)
-		);
-		$this->assertEquals(
-			2,
-			$store->query_actions(
-				array(
-					'status' => array( ActionScheduler_Store::STATUS_PENDING, ActionScheduler_Store::STATUS_COMPLETE ),
-				),
-				'count'
-			)
-		);
-	}
-
-	/* End tests for \ActionScheduler_Store::query_actions() */
+    /**
+     * Get data store for tests.
+     *
+     * @return ActionScheduler_Store
+     */
+    abstract protected function get_store();
+
+    public function test_get_status() {
+        $time      = as_get_datetime_object( '-10 minutes' );
+        $schedule  = new ActionScheduler_IntervalSchedule( $time, HOUR_IN_SECONDS );
+        $action    = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule );
+        $store     = $this->get_store();
+        $action_id = $store->save_action( $action );
+
+        $this->assertEquals( ActionScheduler_Store::STATUS_PENDING, $store->get_status( $action_id ) );
+
+        $store->mark_complete( $action_id );
+        $this->assertEquals( ActionScheduler_Store::STATUS_COMPLETE, $store->get_status( $action_id ) );
+
+        $store->mark_failure( $action_id );
+        $this->assertEquals( ActionScheduler_Store::STATUS_FAILED, $store->get_status( $action_id ) );
+    }
+
+    /* Start tests for \ActionScheduler_Store::query_actions() */
+
+    public function test_query_actions_query_type_arg_invalid_option() {
+        $this->expectException( InvalidArgumentException::class );
+        $this->get_store()->query_actions( array( 'hook' => ActionScheduler_Callbacks::HOOK_WITH_CALLBACK ), 'invalid' );
+    }
+
+    public function test_query_actions_query_type_arg_valid_options() {
+        $store    = $this->get_store();
+        $schedule = new ActionScheduler_SimpleSchedule( as_get_datetime_object( 'tomorrow' ) );
+
+        $action_id_1 = $store->save_action( new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( 1 ), $schedule ) );
+        $action_id_2 = $store->save_action( new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( 1 ), $schedule ) );
+
+        $this->assertEquals( array( $action_id_1, $action_id_2 ), $store->query_actions( array( 'hook' => ActionScheduler_Callbacks::HOOK_WITH_CALLBACK ) ) );
+        $this->assertEquals( 2, $store->query_actions( array( 'hook' => ActionScheduler_Callbacks::HOOK_WITH_CALLBACK ), 'count' ) );
+    }
+
+    public function test_query_actions_by_single_status() {
+        $store    = $this->get_store();
+        $schedule = new ActionScheduler_SimpleSchedule( as_get_datetime_object( 'tomorrow' ) );
+
+        $this->assertSame( 0, $store->query_actions( array( 'status' => ActionScheduler_Store::STATUS_PENDING ), 'count' ) );
+
+        $action_id_1 = $store->save_action( new ActionScheduler_Action( 'my_hook_1', array( 1 ), $schedule ) );
+        $action_id_2 = $store->save_action( new ActionScheduler_Action( 'my_hook_2', array( 1 ), $schedule ) );
+        $action_id_3 = $store->save_action( new ActionScheduler_Action( 'my_hook_3', array( 1 ), $schedule ) );
+        $store->mark_complete( $action_id_3 );
+
+        $this->assertEquals( 2, $store->query_actions( array( 'status' => ActionScheduler_Store::STATUS_PENDING ), 'count' ) );
+        $this->assertSame( 1, $store->query_actions( array( 'status' => ActionScheduler_Store::STATUS_COMPLETE ), 'count' ) );
+    }
+
+    public function test_query_actions_by_array_status() {
+        $store    = $this->get_store();
+        $schedule = new ActionScheduler_SimpleSchedule( as_get_datetime_object( 'tomorrow' ) );
+
+        $this->assertSame(
+            0,
+            $store->query_actions(
+                array(
+                    'status' => array( ActionScheduler_Store::STATUS_PENDING, ActionScheduler_Store::STATUS_RUNNING ),
+                ),
+                'count'
+            )
+        );
+
+        $action_id_1 = $store->save_action( new ActionScheduler_Action( 'my_hook_1', array( 1 ), $schedule ) );
+        $action_id_2 = $store->save_action( new ActionScheduler_Action( 'my_hook_2', array( 1 ), $schedule ) );
+        $action_id_3 = $store->save_action( new ActionScheduler_Action( 'my_hook_3', array( 1 ), $schedule ) );
+        $store->mark_failure( $action_id_3 );
+
+        $this->assertEquals(
+            3,
+            $store->query_actions(
+                array(
+                    'status' => array( ActionScheduler_Store::STATUS_PENDING, ActionScheduler_Store::STATUS_FAILED ),
+                ),
+                'count'
+            )
+        );
+        $this->assertEquals(
+            2,
+            $store->query_actions(
+                array(
+                    'status' => array( ActionScheduler_Store::STATUS_PENDING, ActionScheduler_Store::STATUS_COMPLETE ),
+                ),
+                'count'
+            )
+        );
+    }
+
+    /* End tests for \ActionScheduler_Store::query_actions() */
 
 }

Spacing +32 added lines, -32 removed lines

@@ -26,78 +26,78 @@ 
 	abstract protected function get_store();
 
 	public function test_get_status() {
-		$time      = as_get_datetime_object( '-10 minutes' );
-		$schedule  = new ActionScheduler_IntervalSchedule( $time, HOUR_IN_SECONDS );
-		$action    = new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule );
+		$time      = as_get_datetime_object('-10 minutes');
+		$schedule  = new ActionScheduler_IntervalSchedule($time, HOUR_IN_SECONDS);
+		$action    = new ActionScheduler_Action(ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(), $schedule);
 		$store     = $this->get_store();
-		$action_id = $store->save_action( $action );
+		$action_id = $store->save_action($action);
 
-		$this->assertEquals( ActionScheduler_Store::STATUS_PENDING, $store->get_status( $action_id ) );
+		$this->assertEquals(ActionScheduler_Store::STATUS_PENDING, $store->get_status($action_id));
 
-		$store->mark_complete( $action_id );
-		$this->assertEquals( ActionScheduler_Store::STATUS_COMPLETE, $store->get_status( $action_id ) );
+		$store->mark_complete($action_id);
+		$this->assertEquals(ActionScheduler_Store::STATUS_COMPLETE, $store->get_status($action_id));
 
-		$store->mark_failure( $action_id );
-		$this->assertEquals( ActionScheduler_Store::STATUS_FAILED, $store->get_status( $action_id ) );
+		$store->mark_failure($action_id);
+		$this->assertEquals(ActionScheduler_Store::STATUS_FAILED, $store->get_status($action_id));
 	}
 
 	/* Start tests for \ActionScheduler_Store::query_actions() */
 
 	public function test_query_actions_query_type_arg_invalid_option() {
-		$this->expectException( InvalidArgumentException::class );
-		$this->get_store()->query_actions( array( 'hook' => ActionScheduler_Callbacks::HOOK_WITH_CALLBACK ), 'invalid' );
+		$this->expectException(InvalidArgumentException::class);
+		$this->get_store()->query_actions(array('hook' => ActionScheduler_Callbacks::HOOK_WITH_CALLBACK), 'invalid');
 	}
 
 	public function test_query_actions_query_type_arg_valid_options() {
 		$store    = $this->get_store();
-		$schedule = new ActionScheduler_SimpleSchedule( as_get_datetime_object( 'tomorrow' ) );
+		$schedule = new ActionScheduler_SimpleSchedule(as_get_datetime_object('tomorrow'));
 
-		$action_id_1 = $store->save_action( new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( 1 ), $schedule ) );
-		$action_id_2 = $store->save_action( new ActionScheduler_Action( ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array( 1 ), $schedule ) );
+		$action_id_1 = $store->save_action(new ActionScheduler_Action(ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(1), $schedule));
+		$action_id_2 = $store->save_action(new ActionScheduler_Action(ActionScheduler_Callbacks::HOOK_WITH_CALLBACK, array(1), $schedule));
 
-		$this->assertEquals( array( $action_id_1, $action_id_2 ), $store->query_actions( array( 'hook' => ActionScheduler_Callbacks::HOOK_WITH_CALLBACK ) ) );
-		$this->assertEquals( 2, $store->query_actions( array( 'hook' => ActionScheduler_Callbacks::HOOK_WITH_CALLBACK ), 'count' ) );
+		$this->assertEquals(array($action_id_1, $action_id_2), $store->query_actions(array('hook' => ActionScheduler_Callbacks::HOOK_WITH_CALLBACK)));
+		$this->assertEquals(2, $store->query_actions(array('hook' => ActionScheduler_Callbacks::HOOK_WITH_CALLBACK), 'count'));
 	}
 
 	public function test_query_actions_by_single_status() {
 		$store    = $this->get_store();
-		$schedule = new ActionScheduler_SimpleSchedule( as_get_datetime_object( 'tomorrow' ) );
+		$schedule = new ActionScheduler_SimpleSchedule(as_get_datetime_object('tomorrow'));
 
-		$this->assertSame( 0, $store->query_actions( array( 'status' => ActionScheduler_Store::STATUS_PENDING ), 'count' ) );
+		$this->assertSame(0, $store->query_actions(array('status' => ActionScheduler_Store::STATUS_PENDING), 'count'));
 
-		$action_id_1 = $store->save_action( new ActionScheduler_Action( 'my_hook_1', array( 1 ), $schedule ) );
-		$action_id_2 = $store->save_action( new ActionScheduler_Action( 'my_hook_2', array( 1 ), $schedule ) );
-		$action_id_3 = $store->save_action( new ActionScheduler_Action( 'my_hook_3', array( 1 ), $schedule ) );
-		$store->mark_complete( $action_id_3 );
+		$action_id_1 = $store->save_action(new ActionScheduler_Action('my_hook_1', array(1), $schedule));
+		$action_id_2 = $store->save_action(new ActionScheduler_Action('my_hook_2', array(1), $schedule));
+		$action_id_3 = $store->save_action(new ActionScheduler_Action('my_hook_3', array(1), $schedule));
+		$store->mark_complete($action_id_3);
 
-		$this->assertEquals( 2, $store->query_actions( array( 'status' => ActionScheduler_Store::STATUS_PENDING ), 'count' ) );
-		$this->assertSame( 1, $store->query_actions( array( 'status' => ActionScheduler_Store::STATUS_COMPLETE ), 'count' ) );
+		$this->assertEquals(2, $store->query_actions(array('status' => ActionScheduler_Store::STATUS_PENDING), 'count'));
+		$this->assertSame(1, $store->query_actions(array('status' => ActionScheduler_Store::STATUS_COMPLETE), 'count'));
 	}
 
 	public function test_query_actions_by_array_status() {
 		$store    = $this->get_store();
-		$schedule = new ActionScheduler_SimpleSchedule( as_get_datetime_object( 'tomorrow' ) );
+		$schedule = new ActionScheduler_SimpleSchedule(as_get_datetime_object('tomorrow'));
 
 		$this->assertSame(
 			0,
 			$store->query_actions(
 				array(
-					'status' => array( ActionScheduler_Store::STATUS_PENDING, ActionScheduler_Store::STATUS_RUNNING ),
+					'status' => array(ActionScheduler_Store::STATUS_PENDING, ActionScheduler_Store::STATUS_RUNNING),
 				),
 				'count'
 			)
 		);
 
-		$action_id_1 = $store->save_action( new ActionScheduler_Action( 'my_hook_1', array( 1 ), $schedule ) );
-		$action_id_2 = $store->save_action( new ActionScheduler_Action( 'my_hook_2', array( 1 ), $schedule ) );
-		$action_id_3 = $store->save_action( new ActionScheduler_Action( 'my_hook_3', array( 1 ), $schedule ) );
-		$store->mark_failure( $action_id_3 );
+		$action_id_1 = $store->save_action(new ActionScheduler_Action('my_hook_1', array(1), $schedule));
+		$action_id_2 = $store->save_action(new ActionScheduler_Action('my_hook_2', array(1), $schedule));
+		$action_id_3 = $store->save_action(new ActionScheduler_Action('my_hook_3', array(1), $schedule));
+		$store->mark_failure($action_id_3);
 
 		$this->assertEquals(
 			3,
 			$store->query_actions(
 				array(
-					'status' => array( ActionScheduler_Store::STATUS_PENDING, ActionScheduler_Store::STATUS_FAILED ),
+					'status' => array(ActionScheduler_Store::STATUS_PENDING, ActionScheduler_Store::STATUS_FAILED),
 				),
 				'count'
 			)
@@ -106,7 +106,7 @@ 
 			2,
 			$store->query_actions(
 				array(
-					'status' => array( ActionScheduler_Store::STATUS_PENDING, ActionScheduler_Store::STATUS_COMPLETE ),
+					'status' => array(ActionScheduler_Store::STATUS_PENDING, ActionScheduler_Store::STATUS_COMPLETE),
 				),
 				'count'
 			)