Wordlift_ShareThis_Service::__construct() - Code Metrics - Inspection of "see #184: add a ShareThis compatibility layer" - insideout10/wordlift-plugin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( e22e79...744247 )

by David

created 2015-11-22 21:31 UTC

Wordlift_ShareThis_Service::__construct() A

↳ Parent: Wordlift_ShareThis_Service

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Metric	Value
dl	0
loc	5
rs	9.4286
cc	1
eloc	2
nc	1
nop	0

<?php

/**
 * A service to maintain a compatibilty layer with the ShareThis plugin (which only displays itself on pages and posts).
 *
 * @since 3.2.0
 */
class Wordlift_ShareThis_Service {

	/**
	 * The ShareThis function which prints the buttons.
	 *
	 * @since 3.2.0
	 */
	const ADD_WIDGET_FUNCTION_NAME = 'st_add_widget';

	/**
	 * The Log service.
	 *
	 * @since 3.2.0
	 * @access private
	 * @var \Wordlift_Log_Service $log_service The Log service.
	 */
	private $log_service;

	/**
	 * Create an instance of the ShareThis service.
	 *
	 * @since 3.2.0
	 */
	public function __construct() {

		$this->log_service = Wordlift_Log_Service::get_logger( 'Wordlift_ShareThis_Service' );

	}

	/**
	 * Receive <em>the_content</em> filter calls from WordPress.
	 *
	 * @since 3.2.0
	 *
	 * @param string $content The post content.
	 *
	 * @return string The updated post content.
	 */
	public function the_content( $content ) {

		return $this->call_sharethis( 'the_content', $content );
	}

	/**
	 * Receive <em>the_excerpt</em> filter calls from WordPress.
	 *
	 * @since 3.2.0
	 *
	 * @param string $content The post excerpt.
	 *
	 * @return string The updated post excerpt.
	 */
	public function the_excerpt( $content ) {

		return $this->call_sharethis( 'the_excerpt', $content );
	}

	/**
	 * Call the ShareThis function.
	 *
	 * @since 3.2.0
	 *
	 * @param string $tag The filter tag.
	 * @param string $content The post content.
	 *
	 * @return string The updated post content.
	 */
	private function call_sharethis( $tag, $content ) {

		// Get the current post.
		global $post;
function myFunction($a, $b) {
    // Do something
}

		// If it's not the entity type, return.
		if ( Wordlift_Entity_Service::TYPE_NAME !== $post->post_type ) {
			return $content;
		}

		// If the ShareThis function doesn't exist, return.
		if ( ! function_exists( self::ADD_WIDGET_FUNCTION_NAME ) ) {
			return $content;
		}

		// If ShareThis hasn't been added as a filter, return.
		if ( ! has_filter( $tag, self::ADD_WIDGET_FUNCTION_NAME ) ) {
			return $content;
		}

		// Temporary pop the post type and replace it with post.
		$post_type       = $post->post_type;
		$post->post_type = 'post';

		// Call ShareThis (disguised as a post).
		$content = call_user_func_array( self::ADD_WIDGET_FUNCTION_NAME, array( $content ) );

		// Restore our post type.
		$post->post_type = $post_type;

		// Finally return the content.
		return $content;
	}

}


Push — develop ( e22e79...744247 )

Wordlift_ShareThis_Service::__construct() A

Complexity

Size

Duplication

1. Pass all data via parameters

2. Create a class that maintains your state

1			<?php
2
3			/**
4			* A service to maintain a compatibilty layer with the ShareThis plugin (which only displays itself on pages and posts).
5			*
6			* @since 3.2.0
7			*/
8			class Wordlift_ShareThis_Service {
9
10			/**
11			* The ShareThis function which prints the buttons.
12			*
13			* @since 3.2.0
14			*/
15			const ADD_WIDGET_FUNCTION_NAME = 'st_add_widget';
16
17			/**
18			* The Log service.
19			*
20			* @since 3.2.0
21			* @access private
22			* @var \Wordlift_Log_Service $log_service The Log service.
23			*/
24			private $log_service;
25
26			/**
27			* Create an instance of the ShareThis service.
28			*
29			* @since 3.2.0
30			*/
31			public function __construct() {
32
33			$this->log_service = Wordlift_Log_Service::get_logger( 'Wordlift_ShareThis_Service' );
34
35			}
36
37			/**
38			* Receive <em>the_content</em> filter calls from WordPress.
39			*
40			* @since 3.2.0
41			*
42			* @param string $content The post content.
43			*
44			* @return string The updated post content.
45			*/
46			public function the_content( $content ) {
47
48			return $this->call_sharethis( 'the_content', $content );
49			}
50
51			/**
52			* Receive <em>the_excerpt</em> filter calls from WordPress.
53			*
54			* @since 3.2.0
55			*
56			* @param string $content The post excerpt.
57			*
58			* @return string The updated post excerpt.
59			*/
60			public function the_excerpt( $content ) {
61
62			return $this->call_sharethis( 'the_excerpt', $content );
63			}
64
65			/**
66			* Call the ShareThis function.
67			*
68			* @since 3.2.0
69			*
70			* @param string $tag The filter tag.
71			* @param string $content The post content.
72			*
73			* @return string The updated post content.
74			*/
75			private function call_sharethis( $tag, $content ) {
76
77			// Get the current post.
78			global $post;
			0 ignored issues – show Compatibility Best Practice introduced 2015-11-22 21:34 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
79
80			// If it's not the entity type, return.
81			if ( Wordlift_Entity_Service::TYPE_NAME !== $post->post_type ) {
82			return $content;
83			}
84
85			// If the ShareThis function doesn't exist, return.
86			if ( ! function_exists( self::ADD_WIDGET_FUNCTION_NAME ) ) {
87			return $content;
88			}
89
90			// If ShareThis hasn't been added as a filter, return.
91			if ( ! has_filter( $tag, self::ADD_WIDGET_FUNCTION_NAME ) ) {
92			return $content;
93			}
94
95			// Temporary pop the post type and replace it with post.
96			$post_type = $post->post_type;
97			$post->post_type = 'post';
98
99			// Call ShareThis (disguised as a post).
100			$content = call_user_func_array( self::ADD_WIDGET_FUNCTION_NAME, array( $content ) );
101
102			// Restore our post type.
103			$post->post_type = $post_type;
104
105			// Finally return the content.
106			return $content;
107			}
108
109			}
110

insideout10 / wordlift-plugin

Push — develop ( e22e79...744247 )

Wordlift_ShareThis_Service::__construct() A

Complexity

Size

Duplication

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like