Passed
Push — develop ( a6f0fe...5308a3 )
by Daniel
24:47 queued 09:44
created

Attachment::__construct()   A

Complexity

Conditions 1
Paths 1

Size

Total Lines 15
Code Lines 0

Duplication

Lines 0
Ratio 0 %

Importance

Changes 1
Bugs 0 Features 0
Metric Value
cc 1
eloc 0
c 1
b 0
f 0
nc 1
nop 13
dl 0
loc 15
rs 10

How to fix   Many Parameters   

Many Parameters

Methods with many parameters are not only hard to understand, but their parameters also often become inconsistent when you need more, or different data.

There are several approaches to avoid long parameter lists:

1
<?php
2
3
declare(strict_types=1);
4
5
namespace InShore\Bookwhen\Domain;
6
7
use InShore\Bookwhen\Domain\Attachment;
8
9
final class Attachment
10
{
11
    /**
12
     *
13
     *
14
     */
15
    public function __construct(
16
        public readonly string $contentType,
17
        public readonly string $fileUrl,
18
        public readonly string $fileSizeBytes,
19
        public readonly string $fileSizeText,
20
        public readonly string $fileName,
21
        public readonly string $fileType,
22
        public readonly string $id,
23
        public readonly Location $location,
24
        public readonly int $maxTicketsPerBooking,
25
        public readonly string $startAt,
26
        public array $tickets,
27
        public readonly string $title,
28
        public readonly bool $waitingList
29
    ) {
30
    }
31
}
32