Passed
Pull Request — develop (#83)
by
unknown
12:02
created

Ticket::__construct()   A

Complexity

Conditions 1
Paths 1

Size

Total Lines 16
Code Lines 0

Duplication

Lines 0
Ratio 0 %

Importance

Changes 1
Bugs 0 Features 0
Metric Value
cc 1
eloc 0
c 1
b 0
f 0
nc 1
nop 14
dl 0
loc 16
rs 10

How to fix   Many Parameters   

Many Parameters

Methods with many parameters are not only hard to understand, but their parameters also often become inconsistent when you need more, or different data.

There are several approaches to avoid long parameter lists:

1
<?php
2
3
declare(strict_types=1);
4
5
namespace InShore\Bookwhen\Domain;
6
7
use InShore\Bookwhen\Domain\Event;
8
9
final class Ticket
10
{
11
    /**
12
     *
13
     */
14
    public function __construct(
15
        public readonly bool $available,
16
        public readonly null | string $availableFrom,
17
        public readonly null | string $availableTo,
18
        public readonly string $builtBasketUrl,
19
        public readonly string $builtBasketIframeUrl,
20
        public readonly bool $courseTicket,
21
        public readonly string $details,
22
        public readonly bool $groupTicket,
23
        public readonly int $groupMin,
24
        public readonly int $groupMax,
25
        public readonly string $id,
26
        public readonly int | null $numberIssued,
27
        public readonly int $numberTaken,
28
        public readonly string $title
29
    ) {
30
    }
31
}
32