Attachment::__construct()   A
last analyzed

Complexity

Conditions 1
Paths 1

Size

Total Lines 10
Code Lines 0

Duplication

Lines 0
Ratio 0 %

Code Coverage

Tests 1
CRAP Score 1

Importance

Changes 1
Bugs 0 Features 0
Metric Value
cc 1
eloc 0
c 1
b 0
f 0
nc 1
nop 8
dl 0
loc 10
ccs 1
cts 1
cp 1
crap 1
rs 10

How to fix   Many Parameters   

Many Parameters

Methods with many parameters are not only hard to understand, but their parameters also often become inconsistent when you need more, or different data.

There are several approaches to avoid long parameter lists:

1
<?php
2
3
declare(strict_types=1);
4
5
namespace InShore\Bookwhen\Domain;
6
7
use InShore\Bookwhen\Domain\Attachment;
8
9
final class Attachment
10
{
11
    /**
12
     *
13
     *
14
     */
15 2
    public function __construct(
16
        public readonly null | string $contentType,
17
        public readonly null | string $fileUrl,
18
        public readonly null | string $fileSizeBytes,
19
        public readonly null | string $fileSizeText,
20
        public readonly null | string $fileName,
21
        public readonly null | string $fileType,
22
        public readonly string $id,
23
        public readonly null | string $title
24
    ) {
25 2
    }
26
}
27