innoflash / larastart

src/Traits/APIResponses.php

<?php

namespace InnoFlash\LaraStart\Traits;

use Illuminate\Routing\ResponseFactory;

trait APIResponses
{
    /**
     * The json response for success responses.
     *
     * @param $message
     * @param  array  $data
     * @param  int  $statusCode
     *
     * @return mixed
     */
    public function successResponse($message, $data = [], int $statusCode = 200)
    {
        $responseData = [
            'success' => true,
            'message' => $message,
        ];

        if ($data) {

The expression $data of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            $responseData['data'] = $data;
        }

        return ResponseFactory::successResponse($message, $responseData, $statusCode);
    }
}