Inktale\Api\Structures\ProductItem

Complexity

Total Complexity

1

Size/Duplication

Total Lines	46
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	fromArray()	0	13	1

<?php


namespace Inktale\Api\Structures;


class ProductItem extends AbstractBaseItem
{
    /**
     * Unique product identifier, used to reference products (shirt, mug, etc)
     *
     * @var string
     */
    public $productType;

    /**
     * @var string
     */
    public $title;

    /**
     * Base price in USD (informative, not for calculating prices)
     *
     * @var float
     */
    public $price;

    /**
     * Suggested selling price in USD based on base price.
     *
     * @var float
     */
    public $sellingPrice;

    /**
     * @param array|mixed $raw
     * @return ProductItem
     */
    static function fromArray($raw)

It is generally recommended to explicitly declare the visibility for methods.

    {
        $item = new self;

        $item->raw = $raw;

It seems like $raw of type * is incompatible with the declared type array of property $raw.

        $item->productType = $raw['productType'];
        $item->title = $raw['title'];
        $item->price = (float)$raw['price'];
        $item->sellingPrice = (float)$raw['sellingPrice'];

        return $item;
    }
}