Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
16 | View Code Duplication | class Favorite extends \Model { |
|
17 | |||
18 | static $cols = [ |
||
|
|||
19 | 'user_id' => ['type' => 'select', 'source' => 'relation', 'relation' => 'user'], |
||
20 | 'item_id' => ['type' => 'select', 'source' => 'relation', 'relation' => 'item'], |
||
21 | 'date_create'=>['type'=>'dateTime'] |
||
22 | ]; |
||
23 | |||
24 | static function relations() { |
||
36 | } |
The PSR-2 coding standard requires that all properties in a class have their visibility explicitly declared. If you declare a property using
the property is implicitly global.
To learn more about the PSR-2, please see the PHP-FIG site on the PSR-2.