Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
12 | View Code Duplication | class DisablePayType extends \Model { |
|
13 | static $cols = [ |
||
|
|||
14 | 'delivery_id' => ['type' => 'select', 'source' => 'relation', 'relation' => 'delivery'], |
||
15 | 'paytype_id' => ['type' => 'select', 'source' => 'relation', 'relation' => 'payType'], |
||
16 | ]; |
||
17 | static $dataManagers = [ |
||
18 | 'manager' => [ |
||
19 | 'cols' => ['paytype_id'] |
||
20 | ] |
||
21 | ]; |
||
22 | static $forms = [ |
||
23 | 'manager' => [ |
||
24 | 'map' => [ |
||
25 | ['paytype_id'] |
||
26 | ] |
||
27 | ] |
||
28 | ]; |
||
29 | |||
30 | static function relations() { |
||
42 | } |
The PSR-2 coding standard requires that all properties in a class have their visibility explicitly declared. If you declare a property using
the property is implicitly global.
To learn more about the PSR-2, please see the PHP-FIG site on the PSR-2.