Param::indexes() - Code Metrics - Inspection of "formating" - injitools/cms-Inji - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — master (ebb499)

by Alexey

created 2016-11-29 15:13 UTC

Param::indexes() A

↳ Parent: Param

Complexity

Conditions	1
Paths	1

Size

Total Lines	23
Code Lines	15

Duplication

Lines	23
Ratio	100 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	15
nc	1
nop	0
dl	23
loc	23
rs	9.0856
c	1
b	0
f	0

<?php

/**
 * Item param
 *
 * @author Alexey Krupskiy <[email protected]>
 * @link http://inji.ru/
 * @copyright 2015 Alexey Krupskiy
 * @license https://github.com/injitools/cms-Inji/blob/master/LICENSE
 */

namespace Ecommerce\Item\Offer;

class Param extends \Model {

    public static $objectName = 'Параметр товара';
    public static $labels = [
        'item_offer_option_id' => 'Параметр предложения',
        'item_offer_id' => 'Предложение',
        'value' => 'Значение',
    ];
    public static $cols = [
        //Основные параметры
        'item_offer_id' => ['type' => 'select', 'source' => 'relation', 'relation' => 'offer'],
        'item_offer_option_id' => ['type' => 'select', 'source' => 'relation', 'relation' => 'option', 'onChange' => 'reloadForm'],
        'value' => ['type' => 'dynamicType', 'typeSource' => 'selfMethod', 'selfMethod' => 'realType'],
        //Системные
        'date_create' => ['type' => 'dateTime']
    ];

    public static function indexes() {
        return [
            'ecommerce_itemOfferOptionRelation' => [
                'type' => 'INDEX',
                'cols' => [
                    'item_offer_param_item_offer_id',
                    'item_offer_param_item_offer_option_id'
                ]
            ],
            'ecommerce_paramItemOfferIndex' => [
                'type' => 'INDEX',
                'cols' => [
                    'item_offer_param_item_offer_id',
                ]
            ],
            'ecommerce_paramOfferOptionIndex' => [
                'type' => 'INDEX',
                'cols' => [
                    'item_offer_param_item_offer_option_id'
                ]
            ],
        ];
    }

    public function realType() {
        if ($this->option && $this->option->type) {
            $type = $this->option->type;

            if ($type == 'select') {
                return [
                    'type' => 'select',
                    'source' => 'relation',
                    'relation' => 'option:items',
                ];
            }
            return $type;
        }
        return 'text';
    }

    public static $dataManagers = [

        'manager' => [
            'name' => 'Параметры предложения',
            'cols' => [
                'item_offer_option_id',
                'item_offer_id',
                'value',
            ],
        ],
    ];
    public static $forms = [
        'manager' => [
            'map' => [
                ['item_offer_id', 'item_offer_option_id'],
                ['value']
            ]
    ]];

    function name() {

        return $this->value;
    }

    public function value($default = '') {
        if ($this->option->type != 'select') {
            return $this->value;
        } elseif ($this->optionItem) {
            return $this->optionItem->value;
        }
        return $default;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    public static function relations() {
        return [
            'file' => [
                'model' => 'Files\File',
                'col' => 'value'
            ],
            'option' => [
                'model' => 'Ecommerce\Item\Offer\Option',
                'col' => 'item_offer_option_id'
            ],
            'offer' => [
                'model' => 'Ecommerce\Item\Offer',
                'col' => 'item_offer_id'
            ],
            'optionItem' => [
                'model' => 'Ecommerce\Item\Offer\Option\Item',
                'col' => 'value'
            ]
        ];
    }

}


1		<?php
2
3		/**
4		* Item param
5		*
6		* @author Alexey Krupskiy <[email protected]>
7		* @link http://inji.ru/
8		* @copyright 2015 Alexey Krupskiy
9		* @license https://github.com/injitools/cms-Inji/blob/master/LICENSE
10		*/
11
12		namespace Ecommerce\Item\Offer;
13
14	View Code Duplication	class Param extends \Model {
15
16		public static $objectName = 'Параметр товара';
17		public static $labels = [
18		'item_offer_option_id' => 'Параметр предложения',
19		'item_offer_id' => 'Предложение',
20		'value' => 'Значение',
21		];
22		public static $cols = [
23		//Основные параметры
24		'item_offer_id' => ['type' => 'select', 'source' => 'relation', 'relation' => 'offer'],
25		'item_offer_option_id' => ['type' => 'select', 'source' => 'relation', 'relation' => 'option', 'onChange' => 'reloadForm'],
26		'value' => ['type' => 'dynamicType', 'typeSource' => 'selfMethod', 'selfMethod' => 'realType'],
27		//Системные
28		'date_create' => ['type' => 'dateTime']
29		];
30
31		public static function indexes() {
32		return [
33		'ecommerce_itemOfferOptionRelation' => [
34		'type' => 'INDEX',
35		'cols' => [
36		'item_offer_param_item_offer_id',
37		'item_offer_param_item_offer_option_id'
38		]
39		],
40		'ecommerce_paramItemOfferIndex' => [
41		'type' => 'INDEX',
42		'cols' => [
43		'item_offer_param_item_offer_id',
44		]
45		],
46		'ecommerce_paramOfferOptionIndex' => [
47		'type' => 'INDEX',
48		'cols' => [
49		'item_offer_param_item_offer_option_id'
50		]
51		],
52		];
53		}
54
55		public function realType() {
56		if ($this->option && $this->option->type) {
57		$type = $this->option->type;
58
59		if ($type == 'select') {
60		return [
61		'type' => 'select',
62		'source' => 'relation',
63		'relation' => 'option:items',
64		];
65		}
66		return $type;
67		}
68		return 'text';
69		}
70
71		public static $dataManagers = [
72
73		'manager' => [
74		'name' => 'Параметры предложения',
75		'cols' => [
76		'item_offer_option_id',
77		'item_offer_id',
78		'value',
79		],
80		],
81		];
82		public static $forms = [
83		'manager' => [
84		'map' => [
85		['item_offer_id', 'item_offer_option_id'],
86		['value']
87		]
88		]];
89
90		function name() {
		0 ignored issues – show Best Practice introduced 2016-06-03 10:30 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
91		return $this->value;
92		}
93
94		public function value($default = '') {
95		if ($this->option->type != 'select') {
96		return $this->value;
97		} elseif ($this->optionItem) {
98		return $this->optionItem->value;
99		}
100		return $default;
		0 ignored issues – show Bug Best Practice introduced 2016-06-03 10:30 UTC by Report Bug Copy Issue Report The return type of `return $default;` (`string`) is incompatible with the return type of the parent method `Model::value` of type `Value\|null`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
101		}
102
103		public static function relations() {
104		return [
105		'file' => [
106		'model' => 'Files\File',
107		'col' => 'value'
108		],
109		'option' => [
110		'model' => 'Ecommerce\Item\Offer\Option',
111		'col' => 'item_offer_option_id'
112		],
113		'offer' => [
114		'model' => 'Ecommerce\Item\Offer',
115		'col' => 'item_offer_id'
116		],
117		'optionItem' => [
118		'model' => 'Ecommerce\Item\Offer\Option\Item',
119		'col' => 'value'
120		]
121		];
122		}
123
124		}
125

injitools / cms-Inji

Branch — master (ebb499)

Param::indexes() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like