ChatsController

Complexity

Total Complexity

23

Size/Duplication

Total Lines	136
Duplicated Lines	18.38 %

Coupling/Cohesion

Components	0
Dependencies	7

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
C	eventsAction()	5	53	9
A	deleteMsgAction()	5	18	3
B	banUserAction()	5	27	4
C	sendFormAction()	10	31	7

<?php

/**
 * Chat Controller
 *
 * @author Alexey Krupskiy <admin@inji.ru>
 * @link http://inji.ru/
 * @copyright 2015 Alexey Krupskiy
 * @license https://github.com/injitools/cms-Inji/blob/master/LICENSE
 */
class ChatsController extends Controller {

    public function eventsAction($chatId = 0) {

eventsAction uses the super-global variable $_GET which is generally not recommended.

        $chatId = (int) $chatId;
        $result = new Server\Result();
        if (!$chatId || !($chat = \Chats\Chat::get($chatId))) {

This code seems to be duplicated across your project.

            $result->success = false;
            $result->content = 'Такого чата не существует';
            $result->send();
        }
        $where = [
            ['chat_id', $chatId],
            ['delete', 0]
        ];
        if (!empty($_GET['lastEventDate'])) {
            $where[] = ['date_create', $_GET['lastEventDate'], '>'];
        }
        $result->content = [
            'members' => [],
            'messages' => []
        ];
        if (Users\User::$cur->id) {
            $member = \Chats\Chat\Member::get([['chat_id', $chatId], ['user_id', Users\User::$cur->id]]);
            if (!$member) {
                $member = new \Chats\Chat\Member();
                $member->user_id = Users\User::$cur->id;
                $member->chat_id = $chatId;
            }
            $member->date_last_active = date('Y-m-d H:i:s');
            $member->save();
        }

        $messages = \Chats\Chat\Message::getList(['where' => $where, 'limit' => 20, 'order' => ['date_create', 'DESC']]);
        if ($messages) {
            $messages = array_reverse($messages);
            foreach ($messages as $message) {
                $msg = [
                    'message' => $message->_params,
                    'fullUserName' => $message->user->name(),
                    'userFirstName' => $message->user->info->first_name,
                    'userPhoto' => $message->user->info->photo ? $message->user->info->photo->path : '/static/system/images/no-image.png'
                ];
                $result->content['messages'][] = $msg;
            }
            /* $members = $this->module->getMembers($chatId);

57% of this comment could be valid code. Did you maybe forget this after debugging?

              foreach ($members as $member) {
              $result->content['members'][$member->user_id] = [
              'fullUserName' => $member->user->name(),
              'userFirstName' => $member->user->info->first_name,
              'userPhoto' => $member->user->info->photo ? $member->user->info->photo->path : '/static/system/images/no-image.png'
              ];
              } */
        }
        $result->send();
    }

    function deleteMsgAction($messageId) {

It is generally recommended to explicitly declare the visibility for methods.

        $result = new Server\Result();
        if (!\Users\User::$cur->isAdmin()) {

This code seems to be duplicated across your project.

            $result->success = false;
            $result->content = 'Вы не админ';
            $result->send();
        }
        $msg = Chats\Chat\Message::get((int) $messageId);
        if (!$msg) {
            $result->success = false;
            $result->content = 'Сообщение не найдено';
            $result->send();
        }
        $msg->delete = 1;
        $msg->save();
        $result->successMsg = 'Сообщение удалено';
        $result->send();
    }

    function banUserAction($messageId) {

It is generally recommended to explicitly declare the visibility for methods.

        $result = new Server\Result();
        if (!\Users\User::$cur->isAdmin()) {

This code seems to be duplicated across your project.

            $result->success = false;
            $result->content = 'Вы не админ';
            $result->send();
        }
        $msg = Chats\Chat\Message::get((int) $messageId);
        if (!$msg) {
            $result->success = false;
            $result->content = 'Сообщение не найдено';
            $result->send();
        }
        $ban = new Chats\Chat\Ban();
        $ban->user_id = $msg->user_id;
        $ban->chat_id = $msg->chat_id;
        $ban->chat_message_id = $msg->id;
        $ban->save();
        $msgs = Chats\Chat\Message::getList(['where' => ['user_id', $ban->user_id]]);
        foreach ($msgs as $msg) {
            $msg->delete = 1;
            $msg->save();
        }
        $result->content = array_flip(array_keys($msgs));
        $result->successMsg = 'Сообщение удалено';
        $result->send();
    }

    public function sendFormAction($chatId = 0) {

sendFormAction uses the super-global variable $_POST which is generally not recommended.

        $chatId = (int) $chatId;
        $result = new Server\Result();
        if (!$chatId || !($chat = \Chats\Chat::get($chatId))) {

This code seems to be duplicated across your project.

            $result->success = false;
            $result->content = 'Такого чата не существует';
            $result->send();
        }
        if (!Users\User::$cur->id) {

This code seems to be duplicated across your project.

            $result->success = false;
            $result->content = 'Вы не авторизованы';
            $result->send();
        }
        if (empty($_POST['chat-message']) || !trim($_POST['chat-message'])) {
            $result->success = false;
            $result->content = 'Сообщение не может быть пустым';
            $result->send();
        }
        if (Chats\Chat\Ban::get(['user_id', \Users\User::$cur->id])) {
            $result->success = false;
            $result->content = 'Вы не можете писать в чат';
            $result->send();
        }
        $message = new \Chats\Chat\Message();
        $message->user_id = Users\User::$cur->id;
        $message->chat_id = $chatId;
        $message->text = htmlspecialchars(trim($_POST['chat-message']));
        $message->save();
        $result->successMsg = 'Ваше сообщение было отправлено';
        $result->send();
    }

}