Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 14 | class WarehouseNew extends \Migrations\Parser { |
||
| 15 | |||
| 16 | public function parse() { |
||
| 25 | |||
| 26 | View Code Duplication | function parseWarehouse($warehouseCount) { |
|
| 48 | |||
| 49 | } |
||
| 50 |
Adding explicit visibility (
private,protected, orpublic) is generally recommend to communicate to other developers how, and from where this method is intended to be used.