UserRequest::get() - Code Metrics - Inspection of "user filter, fixes" - injitools/cms-Inji - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c99a2b...4f91fd )

by Alexey

created 2016-02-01 16:26 UTC

UserRequest::get() A

↳ Parent: UserRequest

Complexity

Conditions	4
Paths	4

Size

Total Lines	10
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Metric	Value
dl	0
loc	10
rs	9.2
cc	4
eloc	6
nc	4
nop	3

<?php

/**
 * User Request parser
 *
 * @author Alexey Krupskiy <[email protected]>
 * @link http://inji.ru/
 * @copyright 2016 Alexey Krupskiy
 * @license https://github.com/injitools/cms-Inji/blob/master/LICENSE
 */
class UserRequest
{
    public static function get($key, $type, $default)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        if (!isset($_GET[$key])) {
            return $default;
        }
        if ($type == 'array') {
            return !is_array($_GET[$key]) ? [] : $_GET[$key];
        }
        return eval('return (' . $type . ') $_GET[$key];');

    }

}


1			<?php
2
3			/**
4			* User Request parser
5			*
6			* @author Alexey Krupskiy <[email protected]>
7			* @link http://inji.ru/
8			* @copyright 2016 Alexey Krupskiy
9			* @license https://github.com/injitools/cms-Inji/blob/master/LICENSE
10			*/
11			class UserRequest
12			{
13			public static function get($key, $type, $default)
			1 ignored issue – show Coding Style introduced 2016-02-01 16:32 UTC by Report Bug Copy Issue Report `get` uses the super-global variable `$_GET` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
14			{
15			if (!isset($_GET[$key])) {
16			return $default;
17			}
18			if ($type == 'array') {
19			return !is_array($_GET[$key]) ? [] : $_GET[$key];
20			}
21			return eval('return (' . $type . ') $_GET[$key];');
			1 ignored issue – show Coding Style introduced 2016-02-01 16:32 UTC by Report Bug Copy Issue Report It is generally not recommended to use `eval` unless absolutely required. On one hand, `eval` might be exploited by malicious users if they somehow manage to inject dynamic content. On the other hand, with the emergence of faster PHP runtimes like the HHVM, `eval` prevents some optimization that they perform. Loading history...
22			}
23
24			}
25

injitools / cms-Inji

Push — master ( c99a2b...4f91fd )

UserRequest::get() A

Complexity

Size

Duplication

Duplication Side-by-Side

Filter issues like